Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-06 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH] standalone-reset: use mkdir -p"): > tftptmp=`getconfig TftpTmpDir` > ensure_dir "$tftp$tftptmp" OK. I'm afraid I think if TftpTmpDir's parent does not exist, osstest should not create it automatically. > And $tftp is set to /tmp/ in my standalone config. As

Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-06 Thread Wei Liu
On Mon, Feb 06, 2017 at 03:13:17PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [OSSTEST PATCH] standalone-reset: use mkdir -p"): > > On Mon, Feb 06, 2017 at 11:49:23AM +, Ian Jackson wrote: > > > Wei Liu writes ("[OSSTEST PATCH] standalone-reset: use mkdir -p"): > > > ... > > > > ensure_d

Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-06 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH] standalone-reset: use mkdir -p"): > On Mon, Feb 06, 2017 at 11:49:23AM +, Ian Jackson wrote: > > Wei Liu writes ("[OSSTEST PATCH] standalone-reset: use mkdir -p"): > > ... > > > ensure_dir () { > > > if test -d "$1"; then return; fi > > > - mkdir "$1" > >

Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-06 Thread Wei Liu
On Mon, Feb 06, 2017 at 11:49:23AM +, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH] standalone-reset: use mkdir -p"): > ... > > ensure_dir () { > > if test -d "$1"; then return; fi > > - mkdir "$1" > > + mkdir -p "$1" > > This deliberately doesn't do this. Otherwise wrong (or

Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-06 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH] standalone-reset: use mkdir -p"): ... > ensure_dir () { > if test -d "$1"; then return; fi > - mkdir "$1" > + mkdir -p "$1" This deliberately doesn't do this. Otherwise wrong (or partially missing) configuration can create strangely-named directorie

[Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p

2017-02-05 Thread Wei Liu
Signed-off-by: Wei Liu --- standalone-reset | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/standalone-reset b/standalone-reset index 69a3226..d3a8f0d 100755 --- a/standalone-reset +++ b/standalone-reset @@ -49,7 +49,7 @@ fi ensure_dir () { if test -d "$1"; then ret