On Thu, 16 Nov 2017, Julien Grall wrote:
> On 11/16/2017 01:36 AM, Stefano Stabellini wrote:
> > On Wed, 15 Nov 2017, Julien Grall wrote:
> > > The function get_page_from_gva is used by copy_*_guest helpers to
> > > translate a guest virtual address to a machin
___
> From: Julien Grall
> Sent: Thursday, November 16, 2017 1:54:51 PM
> To: xen-devel; Edgar E. Iglesias; lars.ku...@citrix.com;
> scamp...@codeaurora.org; stewart.hildebr...@dornerworks.com; Stefano
> Stabellini; anastassios.na...@onapp.com;
> sg...@codeaurora.org;
ps://lists.xen.org/archives/html/xen-devel/2017-11/msg00942.html
>
> Signed-off-by: Julien Grall
Acked-by: Stefano Stabellini
fixed on commit
> ---
> xen/arch/arm/p2m.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/xen/arch/arm/p2m.c b/xen/arc
may be unitialized) with the new
^ uninitialized
> construction.
>
> Signed-off-by: Julien Grall
Acked-by: Stefano Stabellini
I fixed on commit
> ---
> xen/arch/arm/domain_build.c | 8
> xen/arch/arm/kernel.c
On Fri, 10 Nov 2017, Andre Przywara wrote:
> Hi,
>
> On 26/10/17 01:14, Stefano Stabellini wrote:
> > On Thu, 19 Oct 2017, Andre Przywara wrote:
> >> gic_clear_pending_irqs() was not only misnamed, but also misplaced, as
> >> a function solely dealing with the
On Wed, 15 Nov 2017, Paul Durrant wrote:
> Anthony, Stefano,
>
> Ping?
Acked-by: Stefano Stabellini
Unless Anthony or somebody else object, I'll queue it up in my "next"
branch (which I'll send upstream after 2.11 is out).
Cheers,
Stefano
> > -O
On Wed, 15 Nov 2017, Boris Ostrovsky wrote:
> On 11/15/2017 04:50 PM, Stefano Stabellini wrote:
> >
> > Sorry, code style issue: one missing space in the comment. I'll send it
> > again separately
>
>
> I've al
On Wed, 15 Nov 2017, Stefano Stabellini wrote:
> On Wed, 15 Nov 2017, Boris Ostrovsky wrote:
> > On 11/15/2017 02:09 PM, Stefano Stabellini wrote:
> > > On Wed, 15 Nov 2017, Juergen Gross wrote:
> > >>>>> while(mute
On Wed, 15 Nov 2017, Boris Ostrovsky wrote:
> On 11/15/2017 02:09 PM, Stefano Stabellini wrote:
> > On Wed, 15 Nov 2017, Juergen Gross wrote:
> >>>>> while(mutex_is_locked(&map->active.in_mutex.owner) ||
> >>>>>
map);xen/pvcalls: fix potential endless loop in pvcalls-front.c
mutex_trylock() returns 1 if you take the lock and 0 if not. Assume you
take in_mutex on the first try, but you can't take out_mutex. Next times
you call mutex_trylock() in_mutex is going to fail. It's an endless
loop.
dex b209cd4..02cd33c 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -1238,3 +1238,7 @@ static void __exit pvcalls_back_fin(void)
> }
>
> module_exit(pvcalls_back_fin);
> +
> +MODULE_DESCRIPTION("Xen PV Calls backend driver");
>
On Mon, 13 Nov 2017, Juergen Gross wrote:
> On 11/11/17 00:57, Stefano Stabellini wrote:
> > On Tue, 7 Nov 2017, Juergen Gross wrote:
> >> On 06/11/17 23:17, Stefano Stabellini wrote:
> >>> mutex_trylock() returns 1 if you take the lock and 0 if not. Assume you
> &
On Fri, 10 Nov 2017, Boris Ostrovsky wrote:
> On 11/10/2017 06:57 PM, Stefano Stabellini wrote:
> > On Tue, 7 Nov 2017, Juergen Gross wrote:
> > > On 06/11/17 23:17, Stefano Stabellini wrote:
> > > > mutex_trylock() returns 1 if you take the lock and 0 if not. Assum
On Tue, 7 Nov 2017, Juergen Gross wrote:
> On 06/11/17 23:17, Stefano Stabellini wrote:
> > mutex_trylock() returns 1 if you take the lock and 0 if not. Assume you
> > take in_mutex on the first try, but you can't take out_mutex. Next times
> > you call mutex_trylock()
On Fri, 10 Nov 2017, Andre Przywara wrote:
> Hi,
>
> ...
>
> >> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> >> index e489d0bf21..8d0ff65708 100644
> >> --- a/xen/include/asm-arm/vgic.h
> >> +++ b/xen/include/asm-arm/vgic.h
> >> @@ -204,6 +204,7 @@ extern int vcpu_vgic_i
On Tue, 7 Nov 2017, Peter Maydell wrote:
> On 6 November 2017 at 22:16, Stefano Stabellini
> wrote:
> > When QEMU emulates a GICv3, it needs to advertise the presence of the
> > system register interface, which is done via id_aa64pfr0.
> >
> > To do that,
On Mon, 6 Nov 2017, Boris Ostrovsky wrote:
> On 11/06/2017 05:17 PM, Stefano Stabellini wrote:
> > mutex_trylock() returns 1 if you take the lock and 0 if not. Assume you
> > take in_mutex on the first try, but you can't take out_mutex. Next times
> > you call mutex_tryl
rate
loops.
Reported-by: Dan Carpenter
Signed-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
ind
machvirt_init. Check on the boolean property from
register_cp_regs_for_features and set id_aa64pfr0 accordingly.
Signed-off-by: Stefano Stabellini
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 9e18b41..369d36b 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1401,6 +1401,9 @@ static void
On Sat, 4 Nov 2017, Dan Carpenter wrote:
> Hello Stefano Stabellini,
>
> The patch 235a71c53903: "xen/pvcalls: implement release command" from
> Oct 30, 2017, leads to the following static checker warning:
>
> drivers/xen/pvcalls-front.c:1051 pvcalls_front_rel
; issues, and a clean design from scratch lead to a very robust and
> >>>> capable re-implementation. Interestingly this implementation is fairly
> >>>> self-contained, so it seems feasible to copy it. Hopefully we only need
> >>>> minor adjustments, possibly we
On Wed, 1 Nov 2017, Andre Przywara wrote:
> Hi Stefano,
>
>
> On 01/11/17 01:58, Stefano Stabellini wrote:
> > On Wed, 11 Oct 2017, Andre Przywara wrote:
>
> many thanks for going through all of this!
No problems, and thanks for your work and for caring about doin
On Tue, 31 Oct 2017, Peter Maydell wrote:
> On 31 October 2017 at 18:51, Stefano Stabellini
> wrote:
> > On Tue, 31 Oct 2017, Peter Maydell wrote:
> >> On 31 October 2017 at 17:01, Stefano Stabellini
> >> wrote:
> >> > Fixing QEMU is harder than
on is fairly
> self-contained, so it seems feasible to copy it. Hopefully we only need
> minor adjustments, possibly we can even copy it verbatim with some
> additional glue layer code.
>
> Stefano asked for getting a design overview, to assess the feasibility
> of copying the K
On Tue, 31 Oct 2017, Peter Maydell wrote:
> On 31 October 2017 at 17:01, Stefano Stabellini
> wrote:
> > Fixing QEMU is harder than I expected. Would it be possible to update
> > id_aa64pfr0 at CPU reset time? Like cpu->id_aa64pfr0 |= 0x0100; ?
>
> At that
On Tue, 31 Oct 2017, Peter Maydell wrote:
> On 19 October 2017 at 15:46, Peter Maydell wrote:
> > On 18 October 2017 at 01:10, Stefano Stabellini
> > wrote:
> >> Advertise the presence of the GIC system register interface (1<<24)
> >> according to H9.2
Introduce a xenbus frontend for the pvcalls protocol, as defined by
https://xenbits.xen.org/docs/unstable/misc/pvcalls.html.
This patch only adds the stubs, the code will be added by the following
patches.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov
Also add pvcalls-front to the Makefile.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/Kconfig | 11 +++
drivers/xen/Makefile | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/xen/Kconfig
Send PVCALLS_LISTEN to the backend.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 57 +
drivers/xen/pvcalls-front.h | 1 +
2 files changed, 58
the
PVCALLS_FLAG_POLL_RET flag. We set the flag from
pvcalls_front_event_handler, if the response was for a POLL command.
In pvcalls_front_event_handler, get the struct sock_mapping from the
poll id (we previously converted struct sock_mapping* to uintptr_t and
used it as id).
Signed-off-by: Stef
cles. This small
optimization turns out to improve performance significantly.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 121
drivers/xen/pvcalls-fro
-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 98 +
drivers/xen/pvcalls-front.h | 1 +
2 files changed, 99 insertions(+)
diff --git a/drivers/xen/pvcalls
Implement recvmsg by copying data from the "in" ring. If not enough data
is available and the recvmsg call is blocking, then wait on the
inflight_conn_req waitqueue. Take the active socket in_mutex so that
only one function can access the ring at any given time.
Signed-off-by: Stefano
ned-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 145
drivers/xen/pvcalls-front.h | 3 +
2 files changed, 148 insertions(+)
diff --git a/drivers/xen/pvcal
_iter
Stefano Stabellini (13):
xen/pvcalls: introduce the pvcalls xenbus frontend
xen/pvcalls: implement frontend disconnect
xen/pvcalls: connect to the backend
xen/pvcalls: implement socket command and handle events
xen/pvcalls: implement connect command
xen/pv
mutexes (one of reads and one for writes) will be used to protect
the active socket in and out rings from concurrent accesses.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 158
pvcalls users.
Only remove connections once the refcount is zero.
Implement pvcalls frontend removal function. Go through the list of
active and passive sockets and free them all, one at a time.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr
Send PVCALLS_BIND to the backend. Introduce a new structure, part of
struct sock_mapping, to store information specific to passive sockets.
Introduce a status field to keep track of the status of the passive
socket.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC
a stub functions for the event handler.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 132
1 file changed, 132 insertions(+)
diff --git a/drivers/xen/p
sily get the struct sock_mapping from the struct
socket.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 131
drivers/xen/pvcalls-front.h | 8 +++
2 f
On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> On 10/30/2017 05:42 PM, Stefano Stabellini wrote:
> > On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> >> On 10/30/2017 03:48 PM, Stefano Stabellini wrote:
> >>> On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> >>>
On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> On 10/30/2017 03:48 PM, Stefano Stabellini wrote:
> > On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> >>
> >> Build warnings (gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1))
> > Hi Boris, I am trying to repro the warnings be
Check the return value of copy_from_iter in __write_ring and
copy_to_iter in __read_ring. Update "len" accordingly.
In the cases where we issue two consecutive copy_from_iter, or two
consecutive copy_to_iter, first check return, then goto out if it is not
what we expect.
Signed-off-b
the poll
request.
Signed-off-by: Stefano Stabellini
---
drivers/xen/pvcalls-front.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index f2dcac88..0c1ec68 100644
--- a/drivers/xen/pvcalls-front.c
On Mon, 30 Oct 2017, Boris Ostrovsky wrote:
> On 10/26/2017 04:45 PM, Boris Ostrovsky wrote:
> > On 10/26/2017 04:16 PM, Stefano Stabellini wrote:
> >> On Thu, 26 Oct 2017, Boris Ostrovsky wrote:
> >>> On 10/26/2017 03:11 PM, Stefano Stabellini wrote:
> >>&g
3543a4c439c0ba7d7f3a2
> > Author: Roger Pau Monne
> > Date: Thu Aug 24 16:07:03 2017 +0100
> >
> > xen/pt: allow QEMU to request MSI unmasking at bind time
> >
> > The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it
> > pos
On Fri, 27 Oct 2017, Julien Grall wrote:
> Hi,
>
> Just answering to dom0 been 1:1 domain.
>
> On 24/10/17 22:33, Stefano Stabellini wrote:
> > On Tue, 24 Oct 2017, Volodymyr Babchuk wrote:
> > > > For this series, I think we need a way to specify which domains
On Fri, 27 Oct 2017, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH v5.1 2/8] xen: restrict: use
> xentoolcore_restrict_all"):
> > On Fri, 20 Oct 2017, Ian Jackson wrote:
> ...
> > > Drop individual use of xendevicemodel_restrict and
> > >
boot it.
So instead of letting the generic backend code open the gnttab device
do it in blk_connect() and close it again in blk_disconnect.
Signed-off-by: Juergen Gross
Acked-by: Anthony PERARD
Signed-off-by: Stefano Stabellini
---
hw/block/xen_disk.c | 16
1 file changed, 12
The following changes since commit 325a084c1ebccb265a3c8f1dd092ffbbfb448a00:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2017-10-24-1' into staging (2017-10-26
09:20:11 +0100)
are available in the git repository at:
git://xenbits.xen.org/people/sstabellini/qemu-dm.git
From: Ross Lagerwall
xen_modified_memory() sets errno to communicate what went wrong so log
this rather than the return value which is not interesting.
Signed-off-by: Ross Lagerwall
Acked-by: Anthony PERARD
Signed-off-by: Stefano Stabellini
---
hw/i386/xen/xen-hvm.c | 2 +-
1 file changed
: Stefano Stabellini
---
hw/block/xen_disk.c | 18 ++
hw/xen/xen_backend.c | 11 +++
include/hw/xen/xen_backend.h | 1 +
3 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
index 536e2ee..62506e3
> Signed-off-by: Ian Jackson
> Acked-by: Anthony PERARD
Acked-by: Stefano Stabellini
> ---
> v2: New patch in v2 of the series
> ---
> include/hw/xen/xen_common.h | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/include/hw/xen
restrict_all(0);
>
>return 0;
> }
> EOF
> -compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs"
> +compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs
> -lxentoolcore"
> then
> -
CC'ing the maintainers (scripts/get_maintainer.pl is your friend)
On Fri, 20 Oct 2017, Ian Jackson wrote:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> We don't support just -
CC'ing the maintainers for this.
On Fri, 20 Oct 2017, Ian Jackson wrote:
> This makes it much easier to find a particular thing in config.log.
>
> The information may be lacking in other shells, resulting in harmless
> empty output. (This is why we don't use the proper ${FUNCNAME[*]}
> array syn
On Fri, 20 Oct 2017, Ian Jackson wrote:
> xc_interface_open etc. is not going to work if we have dropped
> privilege, but xendevicemodel_shutdown will if everything is new
> enough.
>
> xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so
> provide a stub for earlier versions.
>
> S
On Fri, 20 Oct 2017, Ian Jackson wrote:
> We are going to want to reuse this.
>
> No functional change.
>
> Signed-off-by: Ian Jackson
> Reviewed-by: Anthony PERARD
Acked-by: Stefano Stabellini
> ---
> hw/i386/xen/xen-hvm.c | 5 +++--
> 1 file changed, 3
This patch affects non-Xen components. CC'ing the relevant maintainers.
On Fri, 20 Oct 2017, Ian Jackson wrote:
> We need to restrict *all* the control fds that qemu opens. Looking in
> /proc/PID/fd shows there are many; their allocation seems scattered
> throughout Xen support code in qemu.
>
>
On Fri, 20 Oct 2017, Ian Jackson wrote:
> And insist that it works.
>
> Drop individual use of xendevicemodel_restrict and
> xenforeignmemory_restrict. These are not actually effective in this
> version of qemu, because qemu has a large number of fds open onto
> various Xen control devices.
>
>
On Thu, 26 Oct 2017, Boris Ostrovsky wrote:
> On 10/26/2017 04:16 PM, Stefano Stabellini wrote:
> > On Thu, 26 Oct 2017, Boris Ostrovsky wrote:
> >> On 10/26/2017 03:11 PM, Stefano Stabellini wrote:
> >>> Also add pvcalls-front to the Makefile.
> >>&g
On Thu, 26 Oct 2017, Boris Ostrovsky wrote:
> On 10/26/2017 03:11 PM, Stefano Stabellini wrote:
> > Also add pvcalls-front to the Makefile.
> >
> > Signed-off-by: Stefano Stabellini
> > CC: boris.ostrov...@oracle.com
> > CC: jgr...@suse.com
>
> Reviewed
Send PVCALLS_BIND to the backend. Introduce a new structure, part of
struct sock_mapping, to store information specific to passive sockets.
Introduce a status field to keep track of the status of the passive
socket.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC
mutexes (one of reads and one for writes) will be used to protect
the active socket in and out rings from concurrent accesses.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 158
cles. This small
optimization turns out to improve performance significantly.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 118
drivers/xen/pvcalls-fro
Introduce a xenbus frontend for the pvcalls protocol, as defined by
https://xenbits.xen.org/docs/unstable/misc/pvcalls.html.
This patch only adds the stubs, the code will be added by the following
patches.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov
Send PVCALLS_LISTEN to the backend.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 57 +
drivers/xen/pvcalls-front.h | 1 +
2 files changed, 58
Also add pvcalls-front to the Makefile.
Signed-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/Kconfig | 11 +++
drivers/xen/Makefile | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index
pvcalls users.
Only remove connections once the refcount is zero.
Implement pvcalls frontend removal function. Go through the list of
active and passive sockets and free them all, one at a time.
Signed-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen
sily get the struct sock_mapping from the struct
socket.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 131
drivers/xen/pvcalls-front.h | 8 +++
2 f
the
PVCALLS_FLAG_POLL_RET flag. We set the flag from
pvcalls_front_event_handler, if the response was for a POLL command.
In pvcalls_front_event_handler, get the struct sock_mapping from the
poll id (we previously converted struct sock_mapping* to uint64_t and
used it as id).
Signed-off-by: Stef
hout the
socket_lock
- remove now unused bool lock parameter to pvcalls_front_free_map
- XEN_PVCALLS_FRONTEND: default n and select XEN_XENBUS_FRONTEND
Stefano Stabellini (13):
xen/pvcalls: introduce the pvcalls xenbus frontend
xen/pvcalls: implement frontend disconnect
xen
Implement recvmsg by copying data from the "in" ring. If not enough data
is available and the recvmsg call is blocking, then wait on the
inflight_conn_req waitqueue. Take the active socket in_mutex so that
only one function can access the ring at any given time.
Signed-off-by: Stefano
ned-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 145
drivers/xen/pvcalls-front.h | 3 +
2 files changed, 148 insertions(+)
diff --git a/drivers/xen/pvcalls
a stub functions for the event handler.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 132
1 file changed, 132 insertions(+)
diff --git a/drivers/xen/p
-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 98 +
drivers/xen/pvcalls-front.h | 1 +
2 files changed, 99 insertions(+)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls
On Thu, 26 Oct 2017, Boris Ostrovsky wrote:
> On 10/25/2017 07:00 PM, Stefano Stabellini wrote:
> > On Wed, 25 Oct 2017, Boris Ostrovsky wrote:
> >> On 10/24/2017 01:33 PM, Stefano Stabellini wrote:
> >>> Send PVCALLS_RELEASE to the backend and wait for a reply
rom gic-v[23].c.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/arm/gic-v2.c | 14 +++---
> xen/arch/arm/gic-v3.c | 12 ++--
> xen/arch/arm/gic-vgic.c | 3 ++-
> xen/include/asm-arm/gic.h | 4 ++--
> 4 files
abstraction.
>
> Signed-off-by: Andre Przywara
Acked-by: Stefano Stabellini
> ---
> xen/arch/arm/gic-vgic.c| 15 +++
> xen/arch/arm/irq.c | 7 ++-
> xen/include/asm-arm/vgic.h | 2 ++
> 3 files changed, 19 insertions(+), 5 deletions(-)
&
connected to a hardware IRQ (using the hw bit in the LR).
>
> This removes said accesses to VGIC data structures and improves abstraction.
>
> Signed-off-by: Andre Przywara
Acked-by: Stefano Stabellini
> ---
> xen/arch/arm/gic-vgic.c| 31 +++
&
vent channel if there are no other pending IRQs.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/arm/vgic.c | 11 +++
> xen/include/asm-arm/event.h | 13 +++--
> xen/include/asm-arm/vgic.h | 2 ++
> 3 files cha
On Thu, 19 Oct 2017, Andre Przywara wrote:
> Currently gic_dump_info() not only dumps the hardware state of the GIC,
> but also the VGIC internal virtual IRQ lists.
> Split the latter off and move it into vgic.c to observe the abstraction.
>
> Signed-off-by: Andre Przywara
Same comment on lr_pen
On Thu, 19 Oct 2017, Andre Przywara wrote:
> Currently gic.c holds code to handle hardware IRQs as well as code to
> bridge VGIC requests to the GIC virtualization hardware.
That is true, however, I don't necessarely see "the code to bridge VGIC
requests to the GIC virtualization hardware" as belo
On Thu, 19 Oct 2017, Andre Przywara wrote:
> gic_remove_from_lr_pending() was not only misnamed, it also had the wrong
> abstraction, as it should not live in gic.c.
> Move it into vgic.c and vgic.h, where it belongs, and rename it on the
> way.
>
> Signed-off-by: Andre Przywara
Like gic_clear_p
dre Przywara
Yes, gic_remove_irq_from_queues could be in the vgic.
Reviewed-by: Stefano Stabellini
One comment about cosmetics below.
> ---
> xen/arch/arm/gic.c | 9 -
> xen/arch/arm/vgic-v3-its.c | 4 ++--
> xen/arch/arm/vgic.c| 11 ++-
> xen/inc
On Thu, 19 Oct 2017, Andre Przywara wrote:
> gic_clear_pending_irqs() was not only misnamed, but also misplaced, as
> a function solely dealing with the GIC emulation should not live in gic.c.
> Move the functionality of this function into its only caller in vgic.c
>
> Signed-off-by: Andre Przywar
s if one wanted to use a rather innocent "nr_irqs" as
> a local variable name or as a function parameter.
> Drop the optimization and make nr_irqs a normal variable for ARM also.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/ar
es.
> Remove unneeded inclusions of gic.h from files where they are actually
> not needed.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/arm/domain_build.c | 1 -
> xen/arch/arm/p2m.c | 1 -
> xen/arch/arm/platf
possible: the RX and TX interrupt trigger
> when the FIFO gets half full / half empty, and the RTI interrupt signals
> new incoming characters.
>
> [Andre: reword commit message, introduce receive timeout interrupt, add
> comments]
>
> Signed-off-by: Bhupinder Th
rzywara
> Signed-off-by: Andre Przywara
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/arm/vpl011.c | 21 -
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
> index f7ddccb42a..0b
On Wed, 25 Oct 2017, Boris Ostrovsky wrote:
> On 10/24/2017 01:33 PM, Stefano Stabellini wrote:
> > +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata,
> > + struct sock_mapping *map, bool locked)
> > +{
> > +}
>
On Wed, 25 Oct 2017, Boris Ostrovsky wrote:
> On 10/24/2017 01:33 PM, Stefano Stabellini wrote:
> > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both
> > in_mutex and out_mutex to avoid concurrent accesses. Then, free the
> > socket.
> >
> > For
On Wed, 25 Oct 2017, Boris Ostrovsky wrote:
> On 10/24/2017 01:33 PM, Stefano Stabellini wrote:
> > Also add pvcalls-front to the Makefile.
> >
> > Signed-off-by: Stefano Stabellini
> > CC: boris.ostrov...@oracle.com
> > CC: jgr...@suse.com
>
On Tue, 24 Oct 2017, Volodymyr Babchuk wrote:
> > > > >Approach in this RFC is much simpler. Few hooks in arch code +
> > > > >additional
> > > > >subsystem, which can be easily turned off.
> > > >
> > > > Stefano do you hav
the
PVCALLS_FLAG_POLL_RET flag. We set the flag from
pvcalls_front_event_handler, if the response was for a POLL command.
In pvcalls_front_event_handler, get the struct sock_mapping from the
poll id (we previously converted struct sock_mapping* to uint64_t and
used it as id).
Signed-off-by: Stef
sockets and free them all, one at a time.
Signed-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 65 +
1 file changed, 65 insertions(+)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen
Send PVCALLS_LISTEN to the backend.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/pvcalls-front.c | 57 +
drivers/xen/pvcalls-front.h | 1 +
2 files changed, 58
Send PVCALLS_BIND to the backend. Introduce a new structure, part of
struct sock_mapping, to store information specific to passive sockets.
Introduce a status field to keep track of the status of the passive
socket.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC
Also add pvcalls-front to the Makefile.
Signed-off-by: Stefano Stabellini
CC: boris.ostrov...@oracle.com
CC: jgr...@suse.com
---
drivers/xen/Kconfig | 9 +
drivers/xen/Makefile | 1 +
2 files changed, 10 insertions(+)
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index
Introduce a xenbus frontend for the pvcalls protocol, as defined by
https://xenbits.xen.org/docs/unstable/misc/pvcalls.html.
This patch only adds the stubs, the code will be added by the following
patches.
Signed-off-by: Stefano Stabellini
Reviewed-by: Boris Ostrovsky
CC: boris.ostrov
1 - 100 of 4860 matches
Mail list logo
