Re: [Xen-devel] [PATCH v3 2/5] libxl: make GC_FREE reachable in libxl_get_scheduler()

2016-02-01 Thread czylin
Quoting Ian Campbell : On Mon, 2016-01-25 at 11:59 +, Ian Campbell wrote: On Sun, 2016-01-24 at 19:45 -0500, Chester Lin wrote: > Coverity CID 1343309 > > Make GC_FREE reachable in all cases in libxl_get_scheduler() by > eliminating the error-path return and instead storing the error code i

Re: [Xen-devel] [PATCH v2 3/5] n16550: add sanity check for reg_shift

2016-01-24 Thread czylin
Quoting Jan Beulich : On 19.01.16 at 06:57, wrote: Fix CID 1343302 by adding checking a check on the value of reg_shift. This patch also rolls the multiplication by 8 into the shift. No functional changes. Suggested-by: Jan Beulich I don't think so. Signed-off-by: Chester Lin --- xen/d