Re: [Xen-devel] [RFC PATCH] tools: remove blktap2 related code and documentation

2016-08-16 Thread Yang Hongyang
t; > Ross, do you have any objection for this? I haven't seen update from the > joint blktap2 maintenance for a few months. > > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > C

[Xen-devel] [PATCH] Remus: update email address in MAINTAINERS file

2016-03-01 Thread Yang Hongyang
From: Yang Hongyang Signed-off-by: Yang Hongyang Cc: Shriram Rajagopalan Cc: Wei Liu Cc: Ian Jackson Cc: Ian Campbell --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index db14cfe..27280a4 100644 --- a/MAINTAINERS +++ b

Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

2016-01-25 Thread Yang Hongyang
On 01/26/2016 02:48 PM, Wen Congyang wrote: On 01/26/2016 02:45 PM, Yang Hongyang wrote: ditto Reviewed-by: Yang Hongyang The newest version is v5, and this series is in the staging now. Sorry for the noise...I saw the series too late, please ignore my comments... Thanks for your

Re: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback

2016-01-25 Thread Yang Hongyang
ditto Reviewed-by: Yang Hongyang On 01/08/2016 02:38 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper --- tools/libxc/xc_sr_save.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c

Re: [Xen-devel] [PATCH v3 3/5] tools/libxc: don't send end record if remus fails

2016-01-25 Thread Yang Hongyang
some commit message would be better. Reviewed-by: Yang Hongyang On 01/08/2016 02:38 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper --- tools/libxc/xc_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_save.c b

Re: [Xen-devel] [PATCH v3 2/5] remus: resume immediately if libxl__xc_domain_save_done() completes

2016-01-25 Thread Yang Hongyang
On 01/08/2016 02:38 PM, Wen Congyang wrote: For example: if the secondary host is down, and we fail to send the data to the secondary host. xc_domain_save() returns 0. So in the function libxl__xc_domain_save_done(), rc is 0(the helper program exits normally), and retval is 0(it is xc_domain_sa

Re: [Xen-devel] [PATCH v3 1/5] remus: don't call stream_continue() when doing failover

2016-01-25 Thread Yang Hongyang
On 01/08/2016 02:38 PM, Wen Congyang wrote: stream_continue() is used for migration to read emulator xenstore data and emulator context. For remus, if we do failover, we have read it in the checkpoint cycle, and we only need to complete the stream. Reviewed-by: Yang Hongyang Signed-off

Re: [Xen-devel] Taking on a Xen development project

2015-12-11 Thread Yang Hongyang
On 2015年12月11日 01:23, Andrew Cooper wrote: On 04/12/15 20:26, jto...@uwaterloo.ca wrote: Hi, We're a team of three fourth-year undergraduate software engineering students at the University of Waterloo in Canada. We're in the process of planning for our capstone design project, and are interest

Re: [Xen-devel] Current LibXL Status

2015-11-19 Thread Yang Hongyang
On 2015年11月19日 20:16, Ian Campbell wrote: On Thu, 2015-11-19 at 11:55 +, Ian Campbell wrote: On Thu, 2015-11-19 at 11:48 +, Ian Campbell wrote: On Thu, 2015-11-19 at 11:33 +, Andrew Cooper wrote: The majority of those are cases are not appropriate uses of exit(). AFAIIR, the *only

Re: [Xen-devel] [Xen 4.7] tmem todos

2015-10-29 Thread Yang Hongyang
On 2015年10月28日 21:29, Konrad Rzeszutek Wilk wrote: On Wed, Oct 28, 2015 at 04:18:56PM +0800, Yang Hongyang wrote: On 2015年10月28日 00:26, Konrad Rzeszutek Wilk wrote: Hey, Way back in Shenghai we had a chat about what needs to be done in tmem for the 4.6 release. Things got done, but there are

Re: [Xen-devel] [Xen 4.7] tmem todos

2015-10-28 Thread Yang Hongyang
On 2015年10月28日 00:26, Konrad Rzeszutek Wilk wrote: Hey, Way back in Shenghai we had a chat about what needs to be done in tmem for the 4.6 release. Things got done, but there are other things that need to be done: a) Migration v2 support b) Fix the toolstack (cleanup) c) tmem tze, dedup,

Re: [Xen-devel] [URGENT RFC] Branching and reopening -unstable

2015-08-17 Thread Yang Hongyang
Hi Wei, Thanks for CCing me, for me, I prefer option 2, it won't affect the normal development release cycle, if the contributor wants to contribute to -unstable, then it is his responsibility to resolve the confilicts on the main branch. but I think it depends on the maintainers who will make th

Re: [Xen-devel] [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status

2015-07-22 Thread Yang Hongyang
On 07/22/2015 08:20 PM, Wei Liu wrote: On Wed, Jul 22, 2015 at 12:57:59PM +0100, Andrew Cooper wrote: On 22/07/15 12:30, Wei Liu wrote: On Wed, Jul 22, 2015 at 12:26:19PM +0100, Andrew Cooper wrote: On 22/07/15 12:22, Wei Liu wrote: On Wed, Jul 22, 2015 at 11:33:06AM +0100, Ian Campbell wro

Re: [Xen-devel] Request a freeze exception for COLO in v4.6

2015-07-20 Thread Yang Hongyang
On 07/17/2015 06:18 PM, Ian Jackson wrote: Wei Liu writes ("Re: [Xen-devel] Request a freeze exception for COLO in v4.6"): Ian and Ian, anything to add? What are your opinions? I think COLO is an exciting and important feature. Unfortunately I agree with Wei that at this stage taking both s

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

2015-07-16 Thread Yang Hongyang
On 07/17/2015 12:10 AM, Wei Liu wrote: On Wed, Jul 15, 2015 at 03:45:39PM +0800, Yang Hongyang wrote: Pass checkpointed_stream from libxl to libxc. It won't affact legacy migration because legacy migration won't use this param. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: I

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

2015-07-16 Thread Yang Hongyang
On 07/17/2015 12:13 AM, Wei Liu wrote: On Thu, Jul 16, 2015 at 02:05:45PM +0800, Yang Hongyang wrote: On 07/15/2015 08:38 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: Pass checkpointed_stream from libxl to libxc. It won't affact legacy migration be

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests

2015-07-16 Thread Yang Hongyang
On 07/16/2015 11:40 PM, Ian Jackson wrote: Yang Hongyang writes ("Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests"): ... This is used for secondary, at a checkpoint, we do: Thanks for this explanation, which help

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 15/25] tools/libxl: check QEMU state before resume dm

2015-07-16 Thread Yang Hongyang
On 07/16/2015 10:43 PM, Wei Liu wrote: On Wed, Jul 15, 2015 at 03:45:41PM +0800, Yang Hongyang wrote: check QEMU state before resume dm on QEMU_XEN_TRADITIONAL. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu I think it was me who suggested this and this patch

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 07/25] libxl/remus: init checkpoint_callback in Remus checkpoint callback

2015-07-16 Thread Yang Hongyang
On 07/16/2015 06:32 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 20:35 +0800, Yang Hongyang wrote: On 07/15/2015 08:02 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: init stream {read/write} state checkpoint_callback in Remus checkpoint callback. Why? Is

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 16/25] tools/libxl: Update libxl_domain_unpause() to support qemu-xen

2015-07-16 Thread Yang Hongyang
On 07/16/2015 06:39 PM, Ian Campbell wrote: On Thu, 2015-07-16 at 11:49 +0800, Yang Hongyang wrote: On 07/15/2015 08:50 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: Currently, libxl__domain_unpause() only supports qemu-xen-traditional. Update it to

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream

2015-07-16 Thread Yang Hongyang
On 07/16/2015 06:34 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 21:58 +0800, Yang Hongyang wrote: On 07/15/2015 08:34 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: introduce enum type libxl_checkpointed_stream in IDL. rename the last argument of

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-16 Thread Yang Hongyang
On 07/16/2015 06:14 PM, Ian Campbell wrote: On Thu, 2015-07-16 at 17:36 +0800, Yang Hongyang wrote: On 07/16/2015 05:31 PM, Ian Campbell wrote: On Thu, 2015-07-16 at 17:23 +0800, Yang Hongyang wrote: On 07/15/2015 09:32 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 02/25] docs/libxl: Introduce COLO_CONTEXT to support migration v2 colo streams

2015-07-16 Thread Yang Hongyang
On 07/16/2015 05:45 PM, Andrew Cooper wrote: On 16/07/15 07:32, Yang Hongyang wrote: On 07/16/2015 12:52 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: From: Wen Congyang It is the negotiation record for COLO. Primary->Secondary: control_id 0x: Second

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-16 Thread Yang Hongyang
On 07/16/2015 05:31 PM, Ian Campbell wrote: On Thu, 2015-07-16 at 17:23 +0800, Yang Hongyang wrote: On 07/15/2015 09:32 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: tools/libxl/libxl_types.idl | 4 +- diff --git a/tools/libxl

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-16 Thread Yang Hongyang
On 07/16/2015 05:26 PM, Andrew Cooper wrote: On 15/07/15 14:34, Yang Hongyang wrote: On 07/15/2015 09:15 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: This patch is auto generated by the following commands: 1. git mv tools/libxl/libxl_remus_device.c

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-16 Thread Yang Hongyang
On 07/15/2015 09:32 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: tools/libxl/libxl_types.idl | 4 +- diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index e8d3647..1d676ef 100644 --- a/tools/libxl/libxl_types.idl +++ b

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 15/25] send store mfn and console mfn to xl before resuming secondary vm

2015-07-16 Thread Yang Hongyang
On 07/16/2015 02:15 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: From: Wen Congyang We will call libxl__xc_domain_restore_done() to rebuild secondary vm. But we need store mfn and console mfn when rebuilding secondary vm. So make restore_results a function pointer in

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 08/25] tools/libxl: handle colo_context records in a libxl migration v2 read stream

2015-07-16 Thread Yang Hongyang
On 07/16/2015 01:44 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: [...] + if (!stream->rc) stream->rc = rc; stream_done(egc, stream); @@ -794,6 +815,36 @@ static void check_all_finished(libxl__egc *egc, stream->completion_callback(eg

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 07/25] tools/libxl: add back channel support to read stream

2015-07-16 Thread Yang Hongyang
On 07/16/2015 01:38 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: This is used by primay to read records sent by secondary. Signed-off-by: Yang Hongyang --- tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h| 1 + tools/libxl/libxl_stream_read.c

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 06/25] tools/libxl: write colo_context records into the stream

2015-07-16 Thread Yang Hongyang
On 07/16/2015 01:35 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: write colo_context records into the stream, used by both primary and secondary to send colo context. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang --- tools/libxl/libxl_internal.h | 5

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 05/25] tools/libxl: add back channel support to write stream

2015-07-16 Thread Yang Hongyang
On 07/16/2015 01:25 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: Add back channel support to write stream. If the write stream is a back channel stream, this means the write stream is used by Secondary to send some records back. Signed-off-by: Yang Hongyang --- tools

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 03/25] libxc/migration: Specification update for DIRTY_BITMAP records

2015-07-16 Thread Yang Hongyang
On 07/16/2015 01:13 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: Used by secondary to send it's dirty bitmap to primary under COLO. Signed-off-by: Yang Hongyang --- docs/specs/libxc-migration-stream.pandoc | 24 +++- tools/libxc/xc_sr_com

Re: [Xen-devel] [PATCH v8 --for 4.6 COLO 02/25] docs/libxl: Introduce COLO_CONTEXT to support migration v2 colo streams

2015-07-15 Thread Yang Hongyang
On 07/16/2015 12:52 AM, Andrew Cooper wrote: On 15/07/15 10:18, Yang Hongyang wrote: From: Wen Congyang It is the negotiation record for COLO. Primary->Secondary: control_id 0x: Secondary VM is out of sync, start a new checkpoint Secondary->Primary: 0x00

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 20/25] tools/libx{l, c}: add back channel to libxc

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:13 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: In COLO mode, both VMs are running, and are considered in sync if the visible network traffic is identical. After some time, they fall out of sync. At this point, the two VMs have definitely

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 20/25] tools/libx{l, c}: add back channel to libxc

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:21 PM, Andrew Cooper wrote: On 15/07/15 08:45, Yang Hongyang wrote: In COLO mode, both VMs are running, and are considered in sync if the visible network traffic is identical. After some time, they fall out of sync. At this point, the two VMs have definitely diverged. Lets

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:38 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: Pass checkpointed_stream from libxl to libxc. It won't affact legacy migration because legacy migration won't use this param. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: I

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:26 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: From: Wen Congyang 1. suspend a. PVHVM and PV: we use the same way to suspend the guest (send the suspend request to the guest). If the guest doesn't support evtchn, the xen

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 05/25] libxl/remus: introduce libxl__remus_setup

2015-07-15 Thread Yang Hongyang
On 07/15/2015 07:26 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: Refactoring Remus setup by introducing libxl__remus_setup API. All Remus setup work are done in this function. Also remove the libxl__ prefix for static functions. There is a subtle

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 16/25] tools/libxl: Update libxl_domain_unpause() to support qemu-xen

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:50 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: Currently, libxl__domain_unpause() only supports qemu-xen-traditional. Update it to support qemu-xen. We use libxl__domain_resume_device_model to unpause guest dm. Signed-off-by: Yang Hongyang

Re: [Xen-devel] [PATCH] libxl: events: Do not abort remus with ERROR_TIMEOUT

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:35 PM, Ian Jackson wrote: When the timeout set for prompting the next remus iteration fires, we should not treat the ERROR_TIMEDOUT as an error. Bug in 31c836f4 "libxl: events: Permit timeouts to signal ao abort". Reported-by: Yang Hongyang Signed-off-by: Ian J

Re: [Xen-devel] [PATCH] libxl/remus: fix the return value of the checkpoint callback

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:37 PM, Ian Jackson wrote: Ian Campbell writes ("Re: [PATCH] libxl/remus: fix the return value of the checkpoint callback"): Does that mean it won't apply to current staging? Indeed it doesn't. I think we probably want this fix ASAP rather than waiting for that series? Y

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:32 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: tools/libxl/libxl_types.idl | 4 +- diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index e8d3647..1d676ef 100644 --- a/tools/libxl/libxl_types.idl +++ b

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 07/25] libxl/remus: init checkpoint_callback in Remus checkpoint callback

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:02 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: init stream {read/write} state checkpoint_callback in Remus checkpoint callback. Why? Is this earlier or later than previously? Seems later? There's no functional change, it&#

Re: [Xen-devel] [PATCH] libxl/remus: fix the return value of the checkpoint callback

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:13 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 18:32 +0800, Yang Hongyang wrote: In checkpoint callback, we wait for the interval and then start another checkpoint, so the ERROR_TIMEDOUT should be intended and should not treat as error. This patch is based on [PATCH v8

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 14/25] tools/libxl: introduce libxl__domain_restore_device_model to load qemu state

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:45 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: In normal migration, the qemu state was passed to qemu as a parameter. With COLO, Secondary vm is running. So we will do the following steps at every checkpoint: 1. suspend both primay vm and

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:28 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: @@ -2921,6 +2911,26 @@ _hidden void libxl__checkpoint_devices_preresume(libxl__egc *egc, libxl__checkpoint_devices_state *cds); _hidden void

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream

2015-07-15 Thread Yang Hongyang
On 07/15/2015 08:34 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: introduce enum type libxl_checkpointed_stream in IDL. rename the last argument of migrate_receive from "remus" to "checkpointed" since the semantics of this paramete

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-15 Thread Yang Hongyang
On 07/15/2015 09:15 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: This patch is auto generated by the following commands: 1. git mv tools/libxl/libxl_remus_device.c tools/libxl/libxl_checkpoint_device.c This patch does not appear to have been formatted

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure

2015-07-15 Thread Yang Hongyang
On 07/15/2015 11:08 PM, Ian Jackson wrote: Yang Hongyang writes ("[Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure"): Add a new structure remus state, and move concrete layer's private member to remus state. it is pure ref

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 04/25] tools/libxl: rename remus checkpoint callbacks

2015-07-15 Thread Yang Hongyang
On 07/15/2015 07:17 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: There are 2 remus checkpoint callbacks(save/restore), currently, they both called libxl__remus_domain_checkpoint_callback in diffrent file, so it is ok. But in the following patch, we will move

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 06/25] libxl/remus: introduce libxl__remus_teardown

2015-07-15 Thread Yang Hongyang
On 07/15/2015 07:59 PM, Ian Campbell wrote: On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote: introduce libxl__remus_teardown to teardown Remus devices. Signed-off-by: Yang Hongyang Acked-by: Ian Campbell If you need to respin then you might consider inverting the if remus check

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 00/25] Prerequisite patches for COLO

2015-07-15 Thread Yang Hongyang
Seems my reply emails last night are lost. they didn't appear on the list, I'm going to repost them. On 07/15/2015 03:45 PM, Yang Hongyang wrote: This patchset is Prerequisite for COLO feature. Refer to: http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping This patchse is based

[Xen-devel] [PATCH] libxl/remus: fix the return value of the checkpoint callback

2015-07-15 Thread Yang Hongyang
In checkpoint callback, we wait for the interval and then start another checkpoint, so the ERROR_TIMEDOUT should be intended and should not treat as error. This patch is based on [PATCH v8 --for 4.6 COLO 00/25] COarse-grain LOck-stepping Virtual Machines for Non-stop Service Signed-off-by: Yang

[Xen-devel] Request a freeze exception for COLO in v4.6

2015-07-15 Thread Yang Hongyang
Hello, I would like to request a freeze exception for COLO. 1.The benefits * COLO is a VM fault tolerance solution. Currently Remus provides this function, but it buffers all output packets, the latency is unacceptable. COLO addresses the problem, it can greatly improve the VM availability.

[Xen-devel] [PATCH v8 --for 4.6 COLO 25/25] cmdline switches and config vars to control colo-proxy

2015-07-15 Thread Yang Hongyang
Add cmdline switches to 'xl migrate-receive' command to specify a domain-specific hotplug script to setup COLO proxy. Add a new config var 'colo.default.agentscript' to xl.conf, that allows the user to override the default global script used to setup COLO proxy. Signed-o

[Xen-devel] [PATCH v8 --for 4.6 COLO 23/25] setup and control colo proxy on primary side

2015-07-15 Thread Yang Hongyang
setup and control colo proxy on primary side Signed-off-by: Yang Hongyang --- tools/libxl/libxl_colo_save.c | 124 +++--- tools/libxl/libxl_internal.h | 1 + 2 files changed, 117 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_colo_save.c b

[Xen-devel] [PATCH v8 --for 4.6 COLO 22/25] COLO nic: implement COLO nic subkind

2015-07-15 Thread Yang Hongyang
implement COLO nic subkind. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang --- tools/hotplug/Linux/Makefile | 1 + tools/hotplug/Linux/colo-proxy-setup | 131 ++ tools/libxl/Makefile | 1 + tools/libxl/libxl_colo_nic.c | 320

[Xen-devel] [PATCH v8 --for 4.6 COLO 19/25] COLO: use qemu block replication

2015-07-15 Thread Yang Hongyang
From: Wen Congyang Use qemu block replication as our block replication solution. Note that guest must be paused before starting COLO, otherwise, the disk won't be consistent between primary and secondary. Signed-off-by: Wen Congyang for commit message, Signed-off-by: Yang Hongyang ---

[Xen-devel] [PATCH v8 --for 4.6 COLO 11/25] secondary vm suspend/resume/checkpoint code

2015-07-15 Thread Yang Hongyang
aster. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/Makefile | 1 + tools/libxl/libxl_colo.h | 27 ++ tools/libxl/libxl_colo_restore.c | 991 +++ tools/libxl/libxl_create.c | 111 - tools/libxl/libxl_inter

[Xen-devel] [PATCH v8 --for 4.6 COLO 06/25] tools/libxl: write colo_context records into the stream

2015-07-15 Thread Yang Hongyang
write colo_context records into the stream, used by both primary and secondary to send colo context. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang --- tools/libxl/libxl_internal.h | 5 +++ tools/libxl/libxl_stream_write.c | 87 2 files

[Xen-devel] [PATCH v8 --for 4.6 COLO 17/25] implement the cmdline for COLO

2015-07-15 Thread Yang Hongyang
migrate-receive'. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- docs/man/xl.pod.1 | 12 -- tools/libxl/libxl.c | 23 -- tools/libxl/xl_cmdimpl.c | 61 --- tools/libxl/xl_cmdtable.c | 4 +++-

[Xen-devel] [PATCH v8 --for 4.6 COLO 24/25] setup and control colo proxy on secondary side

2015-07-15 Thread Yang Hongyang
setup and control colo proxy on secondary side Signed-off-by: Yang Hongyang --- tools/libxl/libxl_colo_restore.c | 28 +--- tools/libxl/libxl_internal.h | 3 +++ 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_colo_restore.c b/tools

[Xen-devel] [PATCH v8 --for 4.6 COLO 15/25] send store mfn and console mfn to xl before resuming secondary vm

2015-07-15 Thread Yang Hongyang
and console mfn to xl. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang CC: Andrew Cooper --- tools/libxc/include/xenguest.h | 8 tools/libxc/xc_sr_restore.c| 7 +-- tools/libxl/libxl_colo_restore.c | 5 - tools/libxl/libxl_create.c | 2 ++ tools

[Xen-devel] [PATCH v8 --for 4.6 COLO 21/25] COLO proxy: preresume, postresume and checkpoint

2015-07-15 Thread Yang Hongyang
preresume, postresume and checkpoint Signed-off-by: Yang Hongyang --- tools/libxl/libxl_colo.h | 3 +++ tools/libxl/libxl_colo_proxy.c | 57 ++ 2 files changed, 60 insertions(+) diff --git a/tools/libxl/libxl_colo.h b/tools/libxl/libxl_colo.h

[Xen-devel] [PATCH v8 --for 4.6 COLO 18/25] Support colo mode for qemu disk

2015-07-15 Thread Yang Hongyang
From: Wen Congyang Usage: disk = ['...,colo,colo-params=xxx,active-disk=xxx,hidden-disk=xxx...'] The format of colo-params: host:port:exportname=xx For QEMU block replication details: http://wiki.qemu.org/Features/BlockReplication Signed-off-by: Wen Congyang Signed-off-by: Yan

[Xen-devel] [PATCH v8 --for 4.6 COLO 20/25] COLO proxy: implement setup/teardown of COLO proxy module

2015-07-15 Thread Yang Hongyang
setup/teardown of COLO proxy module. we use netlink to communicate with proxy module. About colo-proxy module: https://lkml.org/lkml/2015/6/18/32 How to use: http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping Signed-off-by: Yang Hongyang --- tools/libxl/Makefile | 1 + tools

[Xen-devel] [PATCH v8 --for 4.6 COLO 01/25] docs: add colo readme

2015-07-15 Thread Yang Hongyang
add colo readme, refer to http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping Signed-off-by: Yang Hongyang Acked-by: Ian Campbell --- docs/README.colo | 9 + 1 file changed, 9 insertions(+) create mode 100644 docs/README.colo diff --git a/docs/README.colo b/docs/README.colo

[Xen-devel] [PATCH v8 --for 4.6 COLO 08/25] tools/libxl: handle colo_context records in a libxl migration v2 read stream

2015-07-15 Thread Yang Hongyang
Read a colo_context and call stream->checkpoint_callback to handle it. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang --- tools/libxl/libxl_internal.h| 3 +++ tools/libxl/libxl_stream_read.c | 51 + 2 files changed, 54 insertions(+) d

[Xen-devel] [PATCH v8 --for 4.6 COLO 05/25] tools/libxl: add back channel support to write stream

2015-07-15 Thread Yang Hongyang
Add back channel support to write stream. If the write stream is a back channel stream, this means the write stream is used by Secondary to send some records back. Signed-off-by: Yang Hongyang --- tools/libxl/libxl_dom_save.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl

[Xen-devel] [PATCH v8 --for 4.6 COLO 12/25] primary vm suspend/resume/checkpoint code

2015-07-15 Thread Yang Hongyang
d. Read LIBXL_COLO_SVM_RESUMED from slave 3. Wait a new checkpoint a. Wait a new checkpoint(not implemented) b. Send LIBXL_COLO_NEW_CHECKPOINT to slave Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.c | 6

[Xen-devel] [PATCH v8 --for 4.6 COLO 16/25] libxc/save: support COLO save

2015-07-15 Thread Yang Hongyang
After suspend primary vm, get dirty bitmap on secondary vm, and send pages both dirty on primary/secondary to secondary. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang CC: Andrew Cooper --- tools/libxc/xc_sr_common.h | 2 + tools/libxc/xc_sr_save.c | 104

[Xen-devel] [PATCH v8 --for 4.6 COLO 00/25] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

2015-07-15 Thread Yang Hongyang
O: use qemu block replication Yang Hongyang (18): A docs: add colo readme libxc/migration: Specification update for DIRTY_BITMAP records libxc/migration: export read_record for common use tools/libxl: add back channel support to write stream tools/libxl: write colo_context records into

[Xen-devel] [PATCH v8 --for 4.6 COLO 02/25] docs/libxl: Introduce COLO_CONTEXT to support migration v2 colo streams

2015-07-15 Thread Yang Hongyang
ready 0x0003: Secondary VM is resumed Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- docs/specs/libxl-migration-stream.pandoc | 22 +- tools/libxl/libxl_sr_stream_format.h | 11 +++ tools/python/xen/migration/libxl.py | 9 + 3

[Xen-devel] [PATCH v8 --for 4.6 COLO 09/25] tools/libx{l, c}: introduce should_checkpoint callback

2015-07-15 Thread Yang Hongyang
Under COLO, we are doing checkpoint on demand, if this callback returns 1, we will take another checkpoint. 0 indicates unexpected error. Signed-off-by: Yang Hongyang --- tools/libxc/include/xenguest.h | 18 ++ tools/libxl/libxl_save_msgs_gen.pl | 7 --- 2 files changed

[Xen-devel] [PATCH v8 --for 4.6 COLO 13/25] libxc/restore: support COLO restore

2015-07-15 Thread Yang Hongyang
call the callbacks resume/checkpoint/suspend while secondary vm status is consistent with primary. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang CC: Andrew Cooper --- tools/libxc/xc_sr_common.h | 16 ++-- tools/libxc/xc_sr_restore.c | 60

[Xen-devel] [PATCH v8 --for 4.6 COLO 03/25] libxc/migration: Specification update for DIRTY_BITMAP records

2015-07-15 Thread Yang Hongyang
Used by secondary to send it's dirty bitmap to primary under COLO. Signed-off-by: Yang Hongyang --- docs/specs/libxc-migration-stream.pandoc | 24 +++- tools/libxc/xc_sr_common.c | 1 + tools/libxc/xc_sr_stream_format.h| 1 + 3 files change

[Xen-devel] [PATCH v8 --for 4.6 COLO 14/25] libxc/restore: send dirty bitmap to primary when checkpoint under colo

2015-07-15 Thread Yang Hongyang
Send dirty bitmap to primary when checkpoint under colo. Signed-off-by: Yang Hongyang --- tools/libxc/xc_sr_common.h | 4 ++ tools/libxc/xc_sr_restore.c | 120 +++- 2 files changed, 123 insertions(+), 1 deletion(-) diff --git a/tools/libxc

[Xen-devel] [PATCH v8 --for 4.6 COLO 07/25] tools/libxl: add back channel support to read stream

2015-07-15 Thread Yang Hongyang
This is used by primay to read records sent by secondary. Signed-off-by: Yang Hongyang --- tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h| 1 + tools/libxl/libxl_stream_read.c | 17 + 3 files changed, 19 insertions(+) diff --git a/tools/libxl

[Xen-devel] [PATCH v8 --for 4.6 COLO 10/25] tools/libx{l, c}: add postcopy/suspend callback to restore side

2015-07-15 Thread Yang Hongyang
Secondary(restore side) is running under COLO, we also need postcopy/suspend callbacks. Signed-off-by: Yang Hongyang --- tools/libxc/include/xenguest.h | 10 ++ tools/libxl/libxl_save_msgs_gen.pl | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/libxc

[Xen-devel] [PATCH v8 --for 4.6 COLO 04/25] libxc/migration: export read_record for common use

2015-07-15 Thread Yang Hongyang
read_record() could be used by primary to read dirty bitmap record sent by secondary under COLO. When used by save side, we need to pass the backchannel fd instead of ctx->fd to read_record(), so we added a fd param to it. Signed-off-by: Yang Hongyang CC: Andrew Cooper --- tools/li

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 22/25] tools/libxl: adjust the indentation

2015-07-15 Thread Yang Hongyang
This is just tidying up after the previous automatic renaming. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang Acked-by: Ian Campbell --- tools/libxl/libxl_checkpoint_device.c | 21 +++-- tools/libxl/libxl_internal.h | 19 +++ 2 files changed

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

2015-07-15 Thread Yang Hongyang
7; tools/libxl/libxl_internal.h 16. perl -pi -e 's/\bremus abstract/checkpoint abstract/g' tools/libxl/libxl_internal.h 17. perl -pi -e 's/\bremus invocation/checkpoint invocation/g' tools/libxl/libxl_internal.h 18. perl -pi -e 's/\blibxl__remus_device_\(/libxl__checkpoint_d

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 20/25] tools/libx{l, c}: add back channel to libxc

2015-07-15 Thread Yang Hongyang
rty bitmap on libxc side, so we need to introduce back channel to libxc. Signed-off-by: Yang Hongyang commit message: Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxc/include/xenguest.h | 8 tools/libxc/xc_domain_restore.c | 4 ++-- t

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 23/25] tools/libxl: store remus_ops in checkpoint device state

2015-07-15 Thread Yang Hongyang
. Store it in checkpoint device state so that we do not aware of remus_ops in the checkpoint device layer. it is pure refactoring and no functional changes. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/libxl_checkpoint_device.c | 10 +- tools/libxl

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 25/25] tools/libxl: seperate device init/cleanup from checkpoint device layer

2015-07-15 Thread Yang Hongyang
. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/libxl_checkpoint_device.c | 42 ++- tools/libxl/libxl_remus.c | 42 +++ 2 files changed, 44 insertions(+), 40 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure

2015-07-15 Thread Yang Hongyang
Add a new structure remus state, and move concrete layer's private member to remus state. it is pure refactoring and no functional changes. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/libxl.c | 2 +- tools/libxl/libxl_dom_save.c

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 08/25] tools/libxl: move remus code into libxl_remus.c

2015-07-15 Thread Yang Hongyang
* libxl__remus_domain_restore_checkpoint_callback - setup/teardown Remus: * libxl__remus_setup * libxl__remus_teardown Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.c | 67 - tools

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 17/25] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty()

2015-07-15 Thread Yang Hongyang
k before exits. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang CC: Andrew Cooper Acked-by: Ian Campbell --- tools/libxl/libxl_dom_save.c | 93 tools/libxl/libxl_internal.h | 8 2 files changed, 59 insertions(+), 42 deletions(-) diff

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 16/25] tools/libxl: Update libxl_domain_unpause() to support qemu-xen

2015-07-15 Thread Yang Hongyang
Currently, libxl__domain_unpause() only supports qemu-xen-traditional. Update it to support qemu-xen. We use libxl__domain_resume_device_model to unpause guest dm. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl.c | 15 +-- 1 file

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 18/25] tools/libxl: export logdirty_init

2015-07-15 Thread Yang Hongyang
We need to enable logdirty on secondary, so we export logdirty_init for internal use. Rename it to libxl__logdirty_init. Signed-off-by: Yang Hongyang Acked-by: Ian Campbell --- tools/libxl/libxl_dom_save.c | 4 ++-- tools/libxl/libxl_internal.h | 2 ++ 2 files changed, 4 insertions(+), 2

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 19/25] tools/libxl: Add back channel to allow migration target send data back

2015-07-15 Thread Yang Hongyang
LIBXL_HAVE_CREATE_RESTORE_SEND_FD to indicate the API change. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxl/libxl.c | 2 +- tools/libxl/libxl.h | 30 -- tools/libxl/libxl_create.c | 9 + tools

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 10/25] libxl/save: Refactor libxl__domain_suspend_state

2015-07-15 Thread Yang Hongyang
stands for libxl__domain_save_state, dsps stands for libxl__domain_suspend_state. Also introduce libxl__domain_suspend_init to initialise the libxl__domain_suspend_state. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper --- tools/libxl/libxl.c

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

2015-07-15 Thread Yang Hongyang
Pass checkpointed_stream from libxl to libxc. It won't affact legacy migration because legacy migration won't use this param. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper --- tools/libxc/include/xenguest.h | 9 ++--- t

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 09/25] tools/libxl: move save/restore code into libxl_dom_save.c

2015-07-15 Thread Yang Hongyang
This is purely code motion. Signed-off-by: Yang Hongyang CC: Ian Jackson CC: Wei Liu Acked-by: Ian Campbell --- tools/libxl/Makefile | 2 +- tools/libxl/libxl_dom.c | 672 - tools/libxl/libxl_dom_save.c | 700

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 14/25] tools/libxl: introduce libxl__domain_restore_device_model to load qemu state

2015-07-15 Thread Yang Hongyang
e resuming secondary vm. Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang Cc: Anthony Perard --- tools/libxl/libxl_dom_save.c | 29 + tools/libxl/libxl_internal.h | 3 +++ tools/libxl/libxl_qmp.c | 10 ++ 3 files changed, 42 insertions(+) diff --g

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 15/25] tools/libxl: check QEMU state before resume dm

2015-07-15 Thread Yang Hongyang
check QEMU state before resume dm on QEMU_XEN_TRADITIONAL. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_dom_suspend.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dom_suspend.c b/tools

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests

2015-07-15 Thread Yang Hongyang
low path is not supported currently, this patch is to make the resume call do not fail. Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- tools/libxc/xc_resume.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tools/libxc/xc_resume.c b/to

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream

2015-07-15 Thread Yang Hongyang
an int. It has to change eventually and other callers will have to be updated to cope (and there should be LIBXL_HAVE_...). Signed-off-by: Yang Hongyang --- tools/libxl/libxl_types.idl | 5 + tools/libxl/xl_cmdimpl.c| 13 +++-- 2 files changed, 12 insertions(+), 6 deletions(-)

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 07/25] libxl/remus: init checkpoint_callback in Remus checkpoint callback

2015-07-15 Thread Yang Hongyang
init stream {read/write} state checkpoint_callback in Remus checkpoint callback. Signed-off-by: Yang Hongyang CC: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_dom.c| 2 +- 2 files changed, 2 insertions(+), 2

[Xen-devel] [PATCH v4 --for 4.6 COLOPre 02/25] tools/libxl: move domain suspend code into libxl_dom_suspend.c

2015-07-15 Thread Yang Hongyang
. Note that the newly added file libxl_dom_suspend.c is used for suspend/resume code. Signed-off-by: Yang Hongyang CC: Ian Jackson CC: Wei Liu Acked-by: Ian Campbell --- tools/libxl/Makefile| 3 +- tools/libxl/libxl_dom.c | 342 +--- tools

  1   2   3   4   5   >