Re: [Xen-devel] [PATCH] x86/svm: Improve segment register printing in svm_vmcb_dump()

2016-11-16 Thread Suravee Suthikulanit
On 11/16/2016 10:48 AM, Boris Ostrovsky wrote: On 11/16/2016 08:43 AM, Andrew Cooper wrote: On 31/10/16 13:48, Andrew Cooper wrote: This makes it more succinct and easier to read. Before: (XEN) H_CR3 = 0x00042a0ec000 CleanBits = 0 (XEN) CS: sel=0x0008, attr=0x029b, limit=0x, ba

Re: [Xen-devel] [PATCH] AMD IOMMU: correctly propagate errors from amd_iommu_init()

2016-06-15 Thread Suravee Suthikulanit
On 6/14/2016 4:09 AM, Andrew Cooper wrote: On 14/06/16 10:03, Jan Beulich wrote: ... instead of using -ENODEV for any kind of error. It in particular addresses Coverity ID 1362694 (introduced by commit eb48587210 ["AMD IOMMU: introduce support for IVHD block type 11h"]). Coverity ID: 1362694 S

Re: [Xen-devel] [PATCH v7 03/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU unmapping (top level ones)

2016-06-09 Thread Suravee Suthikulanit
On 6/8/2016 9:54 AM, Jan Beulich wrote: On 08.06.16 at 10:58, wrote: > From: Quan Xu > > Signed-off-by: Quan Xu > Acked-by: Kevin Tian > > CC: Stefano Stabellini > CC: Julien Grall > CC: Kevin Tian > CC: Feng Wu > CC: Jan Beulich > CC: Andrew Cooper CC: Suravee Suthikulpanit Acked

Re: [Xen-devel] [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending (top level ones)

2016-06-09 Thread Suravee Suthikulanit
On 6/8/2016 3:59 AM, Xu, Quan wrote: From: Quan Xu Signed-off-by: Quan Xu CC: Jan Beulich CC: Liu Jinsong CC: Keir Fraser CC: Andrew Cooper CC: Suravee Suthikulpanit CC: Stefano Stabellini CC: Julien Grall CC: Kevin Tian CC: Feng Wu v7: 1. return SAVED_ALL at the bottom of device_

Re: [Xen-devel] [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping (top level ones)

2016-06-09 Thread Suravee Suthikulanit
On 6/8/2016 9:43 AM, Jan Beulich wrote: On 08.06.16 at 10:58, wrote: > From: Quan Xu > > Signed-off-by: Quan Xu > Acked-by: Kevin Tian Reviewed-by: Jan Beulich Acked-by: Suravee Suthikulpanit Thanks, Suravee ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH v3 2/3] svm: iommu: Only call guest_iommu_init() after initialized HVM domain

2016-05-31 Thread Suravee Suthikulanit
On 5/26/2016 10:44 AM, Jan Beulich wrote: Suravee Suthikulanit 05/25/16 9:01 PM >>> On 5/23/2016 6:54 AM, Jan Beulich wrote: On 22.05.16 at 01:42, wrote: From: Suravee Suthikulpanit The guest_iommu_init() is currently called by the following code path: arch/x86

Re: [Xen-devel] [PATCH v3 1/3] x86/hvm: Add check when register io handler

2016-05-25 Thread Suravee Suthikulanit
On 5/23/2016 6:46 AM, Jan Beulich wrote: On 22.05.16 at 01:42, wrote: --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -258,6 +258,8 @@ struct hvm_io_handler *hvm_next_io_handler(struct domain *d) { unsigned int i = d->arch.hvm_domain.io_handler_count++; +ASSE

Re: [Xen-devel] [PATCH v3 2/3] svm: iommu: Only call guest_iommu_init() after initialized HVM domain

2016-05-25 Thread Suravee Suthikulanit
On 5/23/2016 6:54 AM, Jan Beulich wrote: On 22.05.16 at 01:42, wrote: From: Suravee Suthikulpanit The guest_iommu_init() is currently called by the following code path: arch/x86/domain.c: arch_domain_create() ]- drivers/passthrough/iommu.c: iommu_domain_init() |- drivers/pa

Re: [Xen-devel] [PATCH v3 3/3] AMD IOMMU: Check io_handler before registering mmio handler

2016-05-25 Thread Suravee Suthikulanit
On 5/23/2016 3:23 AM, Paul Durrant wrote: -Original Message- > From: suravee.suthikulpa...@amd.com > [mailto:suravee.suthikulpa...@amd.com] > Sent: 22 May 2016 00:43 > To: xen-devel@lists.xen.org; Paul Durrant; jbeul...@suse.com; George > Dunlap > Cc: Keir (Xen.org); Suravee Suthikulpanit

Re: [Xen-devel] [PATCH v2] AMD IOMMU: Introduce support for IVHD block type 11h

2016-05-25 Thread Suravee Suthikulanit
Thanks for these review comment. I'll update this patch and send out V3 Suravee ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] IOMMU/x86: avoid pages without GFN in page table creation/updating

2015-05-13 Thread Suravee Suthikulanit
Acked-by: Suravee Suthikulpanit Thanks, Suravee On 5/7/2015 7:59 AM, Jan Beulich wrote: Handing INVALID_GFN to functions like hd->platform_ops->map_page() just can't do any good, and the ioreq server code results in such pages being on the list of ones owned by a guest. While - as suggested

Re: [Xen-devel] [PATCH 5/5] AMD IOMMU: widen NUMA nodes to be allocated from

2015-03-09 Thread Suravee Suthikulanit
On 3/9/2015 12:26 PM, Andrew Cooper wrote: On 09/03/15 15:42, Suravee Suthikulanit wrote: On 3/6/2015 6:15 AM, Andrew Cooper wrote: On 06/03/2015 07:50, Jan Beulich wrote: On 05.03.15 at 18:30, wrote: On 26/02/15 13:56, Jan Beulich wrote: --- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h

Re: [Xen-devel] [PATCH 5/5] AMD IOMMU: widen NUMA nodes to be allocated from

2015-03-09 Thread Suravee Suthikulanit
On 3/6/2015 6:15 AM, Andrew Cooper wrote: On 06/03/2015 07:50, Jan Beulich wrote: On 05.03.15 at 18:30, wrote: On 26/02/15 13:56, Jan Beulich wrote: --- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h @@ -158,12 +158,12 @@ static inline unsi

Re: [Xen-devel] [PATCH for-4.6 0/5] xen: arm: Parse PCI DT nodes' ranges and interrupt-map

2015-02-18 Thread Suravee Suthikulanit
On 2/18/2015 6:48 AM, Julien Grall wrote: Hi Suravee, On 18/02/2015 05:28, Suravee Suthikulanit wrote: Actually, that seems to be more related to the PCI pass-through devices. Isn't the Cavium guys already done that work to support their PCI device pass-through? They were working on it

Re: [Xen-devel] [PATCH for-4.6 0/5] xen: arm: Parse PCI DT nodes' ranges and interrupt-map

2015-02-17 Thread Suravee Suthikulanit
On 2/17/2015 6:31 PM, Suravee Suthikulanit wrote: On 2/17/2015 4:35 PM, Suravee Suthikulanit wrote: On 2/17/2015 7:50 AM, Andrew Cooper wrote: On 17/02/15 13:43, Julien Grall wrote: (CC Jan and Andrew) Hi Suravee, On 17/02/15 03:04, Suravee Suthikulanit wrote: By the way, looking at the

Re: [Xen-devel] [PATCH for-4.6 0/5] xen: arm: Parse PCI DT nodes' ranges and interrupt-map

2015-02-17 Thread Suravee Suthikulanit
On 2/17/2015 4:35 PM, Suravee Suthikulanit wrote: On 2/17/2015 7:50 AM, Andrew Cooper wrote: On 17/02/15 13:43, Julien Grall wrote: (CC Jan and Andrew) Hi Suravee, On 17/02/15 03:04, Suravee Suthikulanit wrote: By the way, looking at the output of "xl dmesg", I saw the followi

Re: [Xen-devel] [PATCH for-4.6 0/5] xen: arm: Parse PCI DT nodes' ranges and interrupt-map

2015-02-17 Thread Suravee Suthikulanit
On 2/17/2015 7:50 AM, Andrew Cooper wrote: On 17/02/15 13:43, Julien Grall wrote: (CC Jan and Andrew) Hi Suravee, On 17/02/15 03:04, Suravee Suthikulanit wrote: By the way, looking at the output of "xl dmesg", I saw the following message: (XEN) DOM0: PCI host bridge /smb/pci