From: Markus Elfring
Date: Sun, 4 Jun 2017 21:21:20 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code place.
Signed-off-by: Markus Elfring
---
arch/arm/xen/p2m.c | 3 ++-
1 file changed,
From: Markus Elfring
Date: Sun, 4 Jun 2017 21:12:36 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signe
From: Markus Elfring
Date: Sun, 4 Jun 2017 20:50:55 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Mark
From: Markus Elfring
Date: Sun, 4 Jun 2017 22:45:54 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Improve a size determination
Delete an error message for a failed memory allocation
Adjust one function call together with a vari
From: Markus Elfring
Date: Thu, 25 Aug 2016 13:23:06 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus reuse the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle
From: Markus Elfring
Date: Wed, 20 Jul 2016 13:12:33 +0200
Pass the constant "FAILED" in a function call directly instead of
using an intialisation for a local variable.
Signed-off-by: Markus Elfring
---
v2: Rebased on source files from "Linux next-20160719"
drivers/xen/xen-scsiback.c | 4 ++-
From: Markus Elfring
Date: Wed, 20 Jul 2016 13:03:16 +0200
* Adjust jump targets according to the Linux coding style convention.
* A bit of refactoring for the control flow
Suggested-by: Jürgen Groß
Signed-off-by: Markus Elfring
---
v2: Rebased on source files from "Linux next-20160719"
C
From: Markus Elfring
Date: Tue, 19 Jul 2016 15:42:19 +0200
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
v2: Rebased
From: Markus Elfring
Date: Wed, 20 Jul 2016 13:20:04 +0200
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (3):
Delete an unnecessary check before the function call "kfree"
Rename jump labels in scsiback_device_act
@@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL);
if (!tmr) {
target_put_sess_cmd(se_cmd);
- goto err;
+ goto do_resp;
}
>>>
>> @@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend
>> *pending_req,
>> tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL);
>> if (!tmr) {
>> target_put_sess_cmd(se_cmd);
>> -goto err;
>> +goto do_resp;
>> }
>
> Hmm
From: Markus Elfring
Date: Sat, 16 Jul 2016 21:55:01 +0200
Pass the constant "FAILED" in a function call directly instead of
using an intialisation for a local variable.
Signed-off-by: Markus Elfring
---
drivers/xen/xen-scsiback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Markus Elfring
Date: Sat, 16 Jul 2016 21:42:42 +0200
The kfree() function was called in one case by the
scsiback_device_action() function during error handling
even if the passed variable "tmr" contained a null pointer.
Adjust jump targets according to the Linux coding style convention.
S
From: Markus Elfring
Date: Sat, 16 Jul 2016 21:21:05 +0200
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/xen
From: Markus Elfring
Date: Sat, 16 Jul 2016 22:06:54 +0200
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (3):
Delete an unnecessary check before the function call "kfree"
One function call less in scsiback_device
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:28:26 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:23:16 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driver
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:01:57 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/d
From: Markus Elfring
Date: Sat, 2 Jan 2016 17:32:40 +0100
Remove the assignment for a local variable because its value is not
changed compared to the one from a previous function call.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 1 -
1 file changed, 1 deletion(-)
diff
From: Markus Elfring
Date: Sat, 2 Jan 2016 17:50:21 +0100
One goto statement referred to a source code position directly behind it.
Thus omit such an unnecessary jump.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
d
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:46:45 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Delete an unnecessary assignment in connect_rings()
Delete an unnecessary goto statement in connect_rings()
Replace a variable in
21 matches
Mail list logo
