Tian, Kevin:
> > From: Rusty Bird [mailto:rustyb...@openmailbox.org]
> > +if ( !iommu_igfx )
> > +return;
>
> A message might be also helpful here so user can confirm its
> boot option takes effect...
Done, see v2 patch. Thanks for the feedb
rce_iommu=1 is set automatically
by x2apic_bsp_setup().
Move the iommu_igfx check from is_igd_vt_enabled_quirk() into its only
caller iommu_enable_translation(), and tweak the logic.
Signed-off-by: Rusty Bird
---
Notes:
Changed since v1: print info message when iommu_igfx==0
Best viewed w
ly
by x2apic_bsp_setup().
Move the iommu_igfx check from is_igd_vt_enabled_quirk() into its only
caller iommu_enable_translation(), and tweak the logic.
Signed-off-by: Rusty Bird
---
Notes:
Best viewed with "git show --ignore-space-change --function-context"
xen/drivers/passthro
ly. Systemd has no trouble figuring out the pid of devd all by
>>> itself.
>>>
>>> [0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html
>>
>> I'm not qualified to have much of an opinion this but I'm happy to see
>> it
Hello Wei,
For systemd/xendriverdomain.service.in, the hardcoded PID file could be
removed altogether -- systemd has no trouble figuring out the PID with
only one process. But I wasn't sure if maybe something outside of the
xen tree uses it?
(Sorry that you're not getting my CCs: "554-SMTP.EU.CIT
Wei Liu:
>> diff --git a/tools/configure.ac b/tools/configure.ac
>> index 8704927..e08fa8e 100644
>> --- a/tools/configure.ac
>> +++ b/tools/configure.ac
>> @@ -437,6 +437,7 @@ AS_IF([test "x$systemd" = "xy"], [
>> hotplug/Linux/systemd/xenconsoled.service
>> hotplug/Linux/systemd/xendoma
Wei Liu:
> While I understand it might be necessary to have a dedicated service
> file for xendriverdomain, I can't seem to be able to figure out the
> rationale from the commit message.
>
> After thinking a bit harder, may I suggest commit message like this (and
> please correct me if I'm wrong):
run autogen.sh after applying this patch)
Signed-off-by: Rusty Bird
Cc: Ian Jackson
Cc: Wei Liu
---
Changed since v1:
* more detailed commit message
tools/configure.ac | 1 +
tools/hotplug/Linux/systemd/Makefile | 1 +
tools/hotplug/Linux
Uses ConditionVirtualization=xen, which evaluates to false in dom0 since
systemd 214 (released 2014-06-11). An alternative would be this line:
ExecStartPre=/bin/sh -c "! grep -q control_d /proc/xen/capabilities"
(Please rerun autogen.sh)
Signed-off-by: Rusty Bird
Cc: Ian Jackson
C
