ers
and on the completion grant copy is called and buffers are freed.
For the 'write' operation grant copy is performed before invoking
write by qemu device.
A new value 'feature_grant_copy' is added to recognize when the
grant copy operation is supported by a guest.
Signed-off
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For the OSs that does not implement gnttab the
call of the grant copy operation causes abort.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: David Vrabel
--direct='1' \
--ioengine=libaio \
--filename=$DEV \
--iodepth=$IODEPTH \
--bs=$BS \
--name=$NAME \
--runtime=$RUNTIME >> $FILENAME
The test were repeated at least three
On 09/08/2016 12:00 AM, Paulina Szubarczyk wrote:
On 09/07/2016 10:56 PM, Stefano Stabellini wrote:
On Wed, 7 Sep 2016, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be
On 09/07/2016 10:56 PM, Stefano Stabellini wrote:
On Wed, 7 Sep 2016, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling ioreq_init_copy_buffers
ers
and on the completion grant copy is called and buffers are freed.
For the 'write' operation grant copy is performed before invoking
write by qemu device.
A new value 'feature_grant_copy' is added to recognize when the
grant copy operation is supported by a guest.
Sig
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For the OSs that does not implement gnttab the
call of the grant copy operation causes abort.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: David Vrabel
-runtime=$RUNTIME >> $FILENAME
The test were repeated at least three times.
[1]
https://docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9u2yy6DZxzhmDUyFf-eUuJ0c/edit?usp=sharing
[2] https://github.com/paulina-szubarczyk/xen-benchmark
- multitest_with_iodepth.sh
Thanks and regards,
Paulina
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
--ioengine=libaio \
--filename=$DEV \
--iodepth=$IODEPTH \
--bs=$BS \
--name=$NAME \
--runtime=$RUNTIME >> $FILENAME
The test were repeated at least three times.
[1]
https://docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For the OSs that does not implement gnttab the
call of the grant copy operation causes abort.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: David Vrabel
ers
and on the completion grant copy is called and buffers are freed.
For the 'write' operation grant copy is performed before invoking
write by qemu device.
A new value 'feature_grant_copy' is added to recognize when the
grant copy operation is supported by a guest.
Sig
--ioengine=libaio \
--filename=$DEV \
--iodepth=$IODEPTH \
--bs=$BS \
--name=$NAME \
--runtime=$RUNTIME >> $FILENAME
The test were repeated at least three times.
[1]
https://docs.google.com/s
On 08/09/2016 06:56 PM, Anthony PERARD wrote:
On Tue, Aug 02, 2016 at 04:06:30PM +0200, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling
On 08/02/2016 04:06 PM, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling ioreq_init_copy_buffers. For the 'read' operation,
first
On 08/08/2016 01:11 PM, Roger Pau Monné wrote:
On Tue, Aug 02, 2016 at 04:06:30PM +0200, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling
On 08/04/2016 11:38 AM, Wei Liu wrote:
The code looks ok. I have two minor suggestions below.
I would suggest changing the subject line to:
libs/gnttab: introduce grant copy interface
On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote:
In a linux part an ioctl(gntdev
ers
and on the completion grant copy is called and buffers are freed.
For the 'write' operation grant copy is performed before invoking
write by qemu device.
A new value 'feature_grant_copy' is added to recognize when the
grant copy operation is supported by a guest.
Sig
--ioengine=libaio \
--filename=$DEV \
--iodepth=$IODEPTH \
--bs=$BS \
--name=$NAME \
--runtime=$RUNTIME >> $FILENAME
The test were repeated at least three times.
[1]
https://docs.google.com/s
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For the OSs that does not implement gnttab the
call of the grant copy operation causes abort.
Signed-off-by: Paulina Szubarczyk
---
Changes since v3:
- revert to
On 07/15/2016 06:55 PM, Anthony PERARD wrote:
On Wed, Jun 22, 2016 at 10:38:53AM +0200, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling
On 07/15/2016 07:11 PM, Anthony PERARD wrote:
On Fri, Jul 15, 2016 at 12:15:45PM +0100, Wei Liu wrote:
On Fri, Jul 15, 2016 at 12:28:48PM +0200, Paulina Szubarczyk wrote:
On 07/14/2016 12:37 PM, Wei Liu wrote:
On Wed, Jun 22, 2016 at 10:38:53AM +0200, Paulina Szubarczyk wrote:
diff --git
On 07/19/2016 11:12 AM, Roger Pau Monné wrote:
On Wed, Jun 22, 2016 at 10:38:53AM +0200, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling
On 07/14/2016 12:37 PM, Wei Liu wrote:
On Wed, Jun 22, 2016 at 10:38:53AM +0200, Paulina Szubarczyk wrote:
diff --git a/configure b/configure
index e41876a..355d3fa 100755
--- a/configure
+++ b/configure
@@ -1843,7 +1843,7 @@ fi
# xen probe
if test "$xen" != "no"
On 06/22/2016 10:38 AM, Paulina Szubarczyk wrote:
Copy data operated on during request from/to local buffers to/from
the grant references.
Before grant copy operation local buffers must be allocated what is
done by calling ioreq_init_copy_buffers. For the 'read' operation,
first
On 07/13/2016 11:25 AM, Wei Liu wrote:
The implementation is taken from libxc.
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Cc: Paulina Szubarczyk
I could have put it in a header file accessible to all libraries under
libs but this construct is only relevant to xengnttab library at the
On Wed, 22 Jun 2016 12:24:16 +0100
Wei Liu wrote:
> On Wed, Jun 22, 2016 at 11:53:00AM +0200, Paulina Szubarczyk wrote:
> [...]
> > > I know Wei asked for this but you've replaced what should be a single
> > > pointer assignment with a memory allocation and two loop
On Wed, 22 Jun 2016 10:37:24 +0100
David Vrabel wrote:
> On 22/06/16 09:38, Paulina Szubarczyk wrote:
> > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
> > system call is invoked. In mini-os the operation is yet not
> > implemented. For other OSs there is a
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For other OSs there is a dummy implementation.
Signed-off-by: Paulina Szubarczyk
---
Changes since v2:
- dropped the changes in libxc/include/xenctrl_compat
uest.
The body of the function 'ioreq_runio_qemu_aio' is moved to
'ioreq_runio_qemu_aio_blk' and in the 'ioreq_runio_qemu_aio' depending
on the support for grant copy according checks, initialization, grant
operation are made, then the 'ioreq_runio_qemu_aio_blk' function is
ree times.
[1]
https://docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9u2yy6DZxzhmDUyFf-eUuJ0c/edit?usp=sharing
[2] https://github.com/paulina-szubarczyk/xen-benchmark
- multitest_with_iodepth.sh
Thanks and regards,
Paulina
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Fri, 2016-06-17 at 17:43 +0100, Wei Liu wrote:
> On Thu, Jun 16, 2016 at 01:16:54PM +0100, Wei Liu wrote:
> [...]
> [...]
> > > diff --git a/tools/libs/gnttab/private.h b/tools/libs/gnttab/private.h
> > > index d286c86..22ad53a 100644
> > > --- a/tools/libs/gnttab/private.h
> > > +++ b/tools/lib
l seg[MAX_INDIRECT_SEGMENTS] tabel placed in ioreq.
After that the ioreq_parse function proceedes withoth changes. For
direct request segments are mem-copied to the ioreq page.
Signed-off-by: Paulina Szubarczyk
---
hw/block/xen_blkif.h | 151
6 92 0
[1]
https://docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9u2yy6DZxzhmDUyFf-eUuJ0c/edit#gid=1390267663
[2] https://github.com/paulina-szubarczyk/xen-benchmark/tree/master/gprof
Thanks and regards,
Paulina
___
Xen-devel mailing list
Xen
On Mon, 2016-06-13 at 11:58 +0100, David Vrabel wrote:
> On 13/06/16 11:44, Paulina Szubarczyk wrote:
> > On Mon, 2016-06-13 at 11:15 +0100, David Vrabel wrote:
> >> On 13/06/16 10:43, Paulina Szubarczyk wrote:
> >>> Copy data operated on during request from/to lo
On Mon, 2016-06-13 at 11:15 +0100, David Vrabel wrote:
> On 13/06/16 10:43, Paulina Szubarczyk wrote:
> > Copy data operated on during request from/to local buffers to/from
> > the grant references.
> >
> > Before grant copy operation local buffers must be allocated w
Implentation of interface for grant copy operation in libs and
libxc.
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..)
system call is invoked. In mini-os the operation is yet not
implemented. For other OSs there is a dummy implementation.
Signed-off-by: Paulina Szubarczyk
--iodepth=$IODEPTH \
--bs=$BS \
--name=$NAME \
--runtime=$RUNTIME >> $FILENAME
The test were repeated at least three times.
[1]
https://docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9u2yy6DZxzhmDUyFf-eUuJ0c/edit?usp=sharing
[
est.
The body of the function 'ioreq_runio_qemu_aio' is moved to
'ioreq_runio_qemu_aio_blk' and in the 'ioreq_runio_qemu_aio' depending
on the support for grant copy according checks, initialization, grant
operation are made, then the 'ioreq_runio_qemu_aio_blk'
On Thu, 2016-06-09 at 15:44 +0100, Wei Liu wrote:
> Hi Paulina
>
> I was about to push this whole series, but I noticed the subject line
> of this patch is very long.
>
> May I make a suggestion that we update the title of this patch to
>
> xl: add return codes for various pci functions
>
> ?
On Thu, 2016-06-02 at 16:19 +0200, Roger Pau Monné wrote:
> On Tue, May 31, 2016 at 06:44:58AM +0200, Paulina Szubarczyk wrote:
> > If there are still pending requests the buffers are not free() but
> > cached in an array of a size max_request*BLKIF_MAX_SEGMENTS_PER_REQUEST
>
On Thu, 2016-06-02 at 11:41 +0200, Roger Pau Monné wrote:
> On Tue, May 31, 2016 at 06:44:56AM +0200, Paulina Szubarczyk wrote:
> > Grant mapping related functions and variables are removed
> > on behalf of grant copy operation introduced in following commits.
>
> As David
On Wed, 2016-06-01 at 12:22 +0100, David Vrabel wrote:
> On 01/06/16 08:45, Paulina Szubarczyk wrote:
> > On Tue, 2016-05-31 at 10:25 +0100, David Vrabel wrote:
> >>
> >> On 31/05/2016 05:44, Paulina Szubarczyk wrote:
> >>>
> >>> Notification
On Tue, 2016-05-31 at 10:37 +0100, David Vrabel wrote:
> On 31/05/2016 05:44, Paulina Szubarczyk wrote:
> > Grant copy operation is divided into two phases different for
> > 'read' and 'write' operation.
> >
> > For a 'read' operation the
On Tue, 2016-05-31 at 10:25 +0100, David Vrabel wrote:
>
> On 31/05/2016 05:44, Paulina Szubarczyk wrote:
> > Implentation of interface to grant copy operation called through
> > libxc. An ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is
> > invoked for l
Grant copy operation is divided into two phases different for
'read' and 'write' operation.
For a 'read' operation the flow is as follow:
1. allocate local buffers for all the segments contained in
a request.
2. fill the request io vectors with the buffers' addresses
3. invoke r
If there are still pending requests the buffers are not free() but
cached in an array of a size max_request*BLKIF_MAX_SEGMENTS_PER_REQUEST
---
hw/block/xen_disk.c | 60 +
1 file changed, 47 insertions(+), 13 deletions(-)
diff --git a/hw/block/x
Implentation of interface to grant copy operation called through
libxc. An ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is
invoked for linux. In the mini-os the operation is yet not
implemented.
* In the file "tools/include/xen-sys/Linux/gntdev.h" added
- 'struct ioctl_gntdev_grant_cop
Grant mapping related functions and variables are removed
on behalf of grant copy operation introduced in following commits.
---
hw/block/xen_disk.c | 284 ++--
1 file changed, 10 insertions(+), 274 deletions(-)
diff --git a/hw/block/xen_disk.c b/hw
/docs.google.com/spreadsheets/d/1E6AMiB8ceJpExL6jWpH9u2yy6DZxzhmDUyFf-eUuJ0c/edit?usp=sharing
- domU sheets
[2] https://github.com/paulina-szubarczyk/xen-benchmark
- multitest_with_iodepth.sh
Thanks and regards,
Paulina
___
Xen-devel mailin
Grant copy operation is divided into two phases different for
'read' and 'write' operation.
For a 'read' operation the flow is as follow:
1. allocate local buffers for all the segments contained in
a request.
2. fill the request io vectors with the buffers' addresses
3. invoke read operation by
u2yy6DZxzhmDUyFf-eUuJ0c/edit?usp=sharing
- domU sheets
[2] https://github.com/paulina-szubarczyk/xen-benchmark
- multitest_with_iodepth.sh
Thanks and regards,
Paulina
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
If there are still pending requests the buffers are not free() but
cached in an array of a size max_request*BLKIF_MAX_SEGMENTS_PER_REQUEST
---
hw/block/xen_disk.c | 59 ++---
1 file changed, 47 insertions(+), 12 deletions(-)
diff --git a/hw/block/xe
Implentation of interface to grant copy operation called through
libxc. An ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is
invoked for linux. In the mini-os the operation is yet not
implemented.
* In the file "tools/include/xen-sys/Linux/gntdev.h" added
- 'struct ioctl_gntdev_grant_cop
On Mon, 2016-05-09 at 14:06 +0100, Wei Liu wrote:
> Hi Paulina
>
> I believe this series is now all acked.
>
> We're however in code freeze at the moment -- only critical bug fixes
> and patches very of very low risk can be committed. I will apply this
> series when the tree reopens.
Hi Wei,
T
;, therfore use LOGE()
instead LOGEV() with the 'r' value.
Signed-off-by: Paulina Szubarczyk
---
Changed since v3:
- changed LOG() to LOGE()
tools/libxl/libxl.c | 89 ++---
1 file changed, 50 insertions(+), 39 deletions(-)
diff --git a/too
- Use EXIT_{SUCCESS,FAILURE} for main_cd*() function
- Use 0/1 as return values of cd_insert function
Signed-off-by: Paulina Szubarczyk
Reviewed-by: Olaf Hering
Acked-by: Roger Pau Monné
---
tools/libxl/xl_cmdimpl.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions
_memory_info), to reduce the risk of that.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarczyk
Reviewed-by: Olaf Hering
---
Changed since v3:
- changed the changelog
tools/libxl/libxl.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git
This is my bite-sized outreachy project [1][2].
The patch aims to improve coding_style and return failure for more xl commands:
- pci-*
-- tmem-*
After rebase to staging it seems that the patch {09} cleaning
libxl_set_memory_target()
to return useful error codes from [0] is not applied I resen
Various coding style compliance cleanups, such as, arranging for
using only one path out of the function, whitespaces in loops ad if-s
and r instead of rc for storing non-libxl error codes.
Signed-off-by: Paulina Szubarczyk
---
Changes since v3:
- When the opendir() returns NULL stored in
*libxl__device_from_pcidev(), pcidev_struct_fill() initialize
the values of libxl_device and libxl_device_pci structs
and can be void.
*libxl__create_pci_backend(), libxl__device_pci_destroy_all()
should propagate the success/error, rather than always returning 0.
Signed-off-by: Paulina
Returning error codes makes it easier for shell scripts to tell if a
command has failed or succeeded.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarczyk
Acked-by: Wei Liu
---
tools/libxl/xl_cmdimpl.c | 68 ++--
1 file changed, 49
functions.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Dario Faggioli
Acked-by: Roger Pau Monné
Acked-by: Wei Liu
---
tools/libxl/xl_cmdimpl.c | 51
1 file changed, 30 insertions(+), 21 deletions(-)
diff
On Wed, 2016-04-27 at 15:29 +0100, Wei Liu wrote:
> On Wed, Apr 20, 2016 at 10:04:03AM +0200, Paulina Szubarczyk wrote:
> > libxl_set_memory_target seems to have the following return values:
> >
> > * 1 on failure, if the failure happens because of a xenstore error *or*
On Wed, 2016-04-20 at 22:24 +0200, Olaf Hering wrote:
> On Wed, Apr 20, Paulina Szubarczyk wrote:
>
> > @@ -398,34 +398,34 @@ libxl_device_pci
> > *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num)
> > dir = opendir(SYSFS_PCIBACK_DRIVER);
>
>
On Fri, 2016-04-01 at 15:35 +0200, Roger Pau Monné wrote:
> Please don't top post, it breaks the flow of the conversation.
>
> I'm also adding Anthony (one of the QEMU/Xen maintainers).
> On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
>
> > Hi Roger,
> >
_setmaxmem and
xc_domain_set_pod_target)
3. Use 'lrc' for return values to local functions libxl__*
where a failure means retry, rather than fail the whole function
(libxl__fill_dom0_memory_info), to reduce the risk of that.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarcz
functions.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Dario Faggioli
Acked-by: Roger Pau Monné
---
tools/libxl/xl_cmdimpl.c | 51
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/tools/libxl
*libxl__device_from_pcidev() initialize the values of libxl__device
struct and can be void.
*libxl__create_pci_backend(), libxl__device_pci_destroy_all()
should propagate the success/error, rather than always returning 0.
Signed-off-by: Paulina Szubarczyk
---
Changes since v2:
- changed the
- Use EXIT_{SUCCESS,FAILURE} for main_cd*() function
- Use 0/1 as return values of cd_insert function
Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
---
tools/libxl/xl_cmdimpl.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tools/libxl
Various coding style compliance cleanups, such as, arranging for
using only one path out of the function, whitespaces in loops ad if-s
and r instead of rc for storing non-libxl error codes.
Signed-off-by: Paulina Szubarczyk
---
Changes since v2:
- changed the changelog
---
tools/libxl
7;, therfore use LOG() instead LOGEV()
with the 'r' value since the error code is always -1.
Signed-off-by: Paulina Szubarczyk
---
Changed since v2:
* corrected indentation
* changed LOGEV()->LOG()
---
tools/libxl/libxl.c | 89 ++---
1 f
Returning error codes makes it easier for shell scripts to tell if a
command has failed or succeeded.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarczyk
---
Changed since v2:
- Remove the change to exit code since the other pathes take care of that
---
tools/libxl/xl_cmdimpl.c
This is my bite-sized outreachy project [1][2].
The patch aims to improve coding_style and return failure for more xl commands:
- pci-*
-- tmem-*
After rebase to staging it seems that the patch {09} cleaning
libxl_set_memory_target()
to return useful error codes from [0] is not applied I resen
On Fri, 2016-04-08 at 10:26 +0200, Dario Faggioli wrote:
> On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote:
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -3391,15 +3391,15 @@ static int set_memory_max(uint32_t domid,
> > const c
On Wed, 2016-04-06 at 13:54 +0100, George Dunlap wrote:
> On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk
> wrote:
> > From: George Dunlap
> >
> > libxl_set_memory_target seems to have the following return values:
> >
> > * 1 on failure, if the failure hap
Signed-off-by: Paulina Szubarczyk
---
Changed since v1:
* Modify the libxl_device_pci_assignable_list() function to use
only one 'out' cleaning path.
---
tools/libxl/libxl_pci.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/t
e Dunlap
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/libxl.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 75f00be..057366e 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -4
In accordance with CODING_SYTLE:
- Use 'r' for return values to functions whose return values are a
different error space (like xc_tmem_control, xc_tmem_auth)
Signed-off-by: Paulina Szubarczyk
---
Changed since v1:
* Added the error cleanup path 'out'.
* Replaced retu
Return error code instead of always 0. Remove assigned-only ret variable.
Signed-off-by: Paulina Szubarczyk
---
Changed since v1:
* The function libxl__device_from_pcidev() initialize the values
of libxl__device and does not return any error code.
Make it return void instead 0
- Use EXIT_{SUCCESS,FAILURE} for main_cd*() function
- Use 0/1 as return values of cd_insert function
Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
---
tools/libxl/xl_cmdimpl.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tools/libxl
functions.
Signed-off-by: Paulina Szubarczyk
Reviewed-by: Konrad Rzeszutek Wilk
Acked-by: Roger Pau Monné
---
tools/libxl/xl_cmdimpl.c | 51
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl
er nothing but an "r = 0" seemed
a bit pointless.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarczyk
---
Changed since v1:
* Changed exit() calls to 'return 1;'
---
tools/libxl/xl_cmdimpl.c | 80 ++--
1 file changed,
- Return 0 or 1 for freemem function
- Correct the condition of checking return values of freemem
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
- Use EXIT_{SUCCESS,FAILURE} for main_mem*() function
- Use 0/1 as return values of set_memory_{max,target}
Signed-off-by: Paulina Szubarczyk
---
Changed since v1
* Changed exit() calls to 'return 1;'
---
tools/libxl/xl_cmdimpl.c | 24
1 file changed, 16
Return rc value instead of always 0.
Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
---
tools/libxl/libxl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 8549378..b667dba 100644
--- a/tools/libxl
This is my bite-sized outreachy project [1][2].
The patch aims to improve coding_style and return failure for more xl commands:
- pci-*
-- tmem-*
After rebase to staging it seems that the patch {09} cleaning
libxl_set_memory_target()
to return useful error codes from [0] is not applied I resen
On 4 April 2016 at 12:40, George Dunlap wrote:
>
> On 01/04/16 15:55, Roger Pau Monné wrote:
> > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> >> libxl_set_memory_target seems to have the following return values:
> >>
> >> * 1 on failure, if the failure
- Return 0 or 1 for freemem function
- Correct the condition of checking return values of freemem
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools
Retrun error code instead of allways 0. Remove assigned-only
ret variable.
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/libxl_pci.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index dc10cb7..3435ce2 100644
libxl_device_pci_assignable_list returns:
- list of the libxl_device_pci
- NULL in case of error
the rc variable is unused as return code.
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/libxl_pci.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/libxl
- Use EXIT_{SUCCESS,FAILURE} for main_cd*() function
- Use 0/1 as return values of cd_insert function
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl
those functions.
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 51 ++--
1 file changed, 32 insertions(+), 19 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 38129f4..52c3b9b 100644
--- a/tools/libxl
In accordance with CODING_SYTLE:
- Use 'r' for return values to functions whose return values are a
different error space (like xc_tmem_control, xc_tmem_auth)
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/libxl.c | 58 ++---
1 fi
libxl_set_memory_target seems to have the following return values:
* 1 on failure, if the failure happens because of a xenstore error *or*
* invalid
target
* -1 if the setmaxmem hypercall
* -errno if the set_pod_target hypercall target fails
* 0 on success
Make it consistently return ERROR_FAI
t;r = 0" seemed
a bit pointless.
Signed-off-by: George Dunlap
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 78 ++--
1 file changed, 56 insertions(+), 22 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmd
Return rc value instead of allways 0.
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/libxl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 6051ee4..e4a2c2c 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl
This is my bite-sized outreachy project [1][2]. I resend it due to the mistake
I made in the first try.
The patch aims to improve coding_style and return failure for more xl commands:
- pci-*
-- tmem-*
After rebase to staging it seems that the patch {09} cleaning
libxl_set_memory_target()
to r
- Use EXIT_{SUCCESS,FAILURE} for main_mem*() function
- Use 0/1 as return values of set_memory_{max,target}
Signed-off-by: Paulina Szubarczyk
---
tools/libxl/xl_cmdimpl.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b
t use HTML for emails to this list.
>
> On Wed, 2016-03-23 at 17:38 +0100, Paulina Szubarczyk wrote:
>> Hi,
>>
>> Thank you for the proposed tasks. I would like to work on the second
>> one,
>> fixing the return codes in xl.
>>
> I just wanted to say that, si
.
Paulina
On 31 March 2016 at 17:06, Wei Liu wrote:
> On Wed, Mar 30, 2016 at 07:19:41PM +0200, Paulina Szubarczyk wrote:
>> Yes, I was looking at wrong branch, I am sorry. The patches
>>
>> * {01-04,08,11} were not attached in the previous patch [0].
>>
>> * {05,06
1 - 100 of 118 matches
Mail list logo
