Re: [Xen-devel] [PATCH 2/2] x86/vmx: conditionally disable LBR support due to TSX format quirk

2016-08-10 Thread Matt Wilson
On Wed, Aug 10, 2016 at 06:34:10AM -0600, Jan Beulich wrote: > >>> On 10.08.16 at 08:59, wrote: > > Systems that support LBR formats that include TSX information but do > > not support TSX require special handling when saving and restoring MSR > > values. For example, see the Linux kernel quirks[1

Re: [Xen-devel] [PATCH 1/2] x86/vmx: dump MSR load area

2016-08-10 Thread Matt Wilson
On Wed, Aug 10, 2016 at 04:44:21AM -0600, Jan Beulich wrote: > >>> On 10.08.16 at 08:59, wrote: > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > > @@ -1740,6 +1740,20 @@ static void vmx_dump_sel2(char *name, uint32_t lim) > > printk("%s:%08x %016"PRIx6

[Xen-devel] [PATCH 2/2] x86/vmx: conditionally disable LBR support due to TSX format quirk

2016-08-10 Thread Matt Wilson
From: Matt Wilson Systems that support LBR formats that include TSX information but do not support TSX require special handling when saving and restoring MSR values. For example, see the Linux kernel quirks[1, 2] in the MSR context switching code. As a wrmsr with certain values under these

[Xen-devel] [PATCH 1/2] x86/vmx: dump MSR load area

2016-08-10 Thread Matt Wilson
From: Matt Wilson ... as it is very helpful to diagnose VM entry failures due to MSR loading. Signed-off-by: Matt Wilson --- xen/arch/x86/hvm/vmx/vmcs.c | 21 + 1 file changed, 21 insertions(+) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index

Re: [Xen-devel] [PATCH v2] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-11 Thread Matt Wilson
On Thu, Nov 06, 2014 at 03:26:24PM +, Paul Durrant wrote: > To perform certain hypercalls HVM guests need to use Xen's idea of > vcpu id, which may well not match the guest OS idea of CPU id. > This patch adds vcpu id to the HVM cpuid leaf allowing the guest > to build a mapping. One more tang

Re: [Xen-devel] [PATCH] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-11 Thread Matt Wilson
On Thu, Dec 11, 2014 at 07:00:55PM +, Andrew Cooper wrote: > On 11/12/14 18:19, Matt Wilson wrote: > > On Wed, Dec 10, 2014 at 10:36:18AM +, Andrew Cooper wrote: > >> On 10/12/14 06:00, Matt Wilson wrote: > >>> That's not strictly true. You can use th

Re: [Xen-devel] [PATCH] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-11 Thread Matt Wilson
On Wed, Dec 10, 2014 at 10:36:18AM +, Andrew Cooper wrote: > On 10/12/14 06:00, Matt Wilson wrote: > > > > That's not strictly true. You can use the processor index in ACPI. > > The LAPIC objects in the MADT/APIC table? That is still constructed > with the broke

Re: [Xen-devel] [PATCH] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-11 Thread Matt Wilson
On Wed, Dec 10, 2014 at 10:29:46AM +, Jan Beulich wrote: > >>> On 10.12.14 at 07:00, wrote: > > On Thu, Nov 06, 2014 at 09:27:59PM +, Andrew Cooper wrote: > >> On 06/11/2014 19:32, Konrad Rzeszutek Wilk wrote: > >> > On Thu, Nov 06, 2014 at 03:07:10PM +, Paul Durrant wrote: > >> >> To

Re: [Xen-devel] [PATCH] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-09 Thread Matt Wilson
On Thu, Nov 06, 2014 at 09:27:59PM +, Andrew Cooper wrote: > On 06/11/2014 19:32, Konrad Rzeszutek Wilk wrote: > > On Thu, Nov 06, 2014 at 03:07:10PM +, Paul Durrant wrote: > >> To perform certain hypercalls HVM guests need to use Xen's idea of > > What are those 'certain'? > > Some HVM hy