Re: [Xen-devel] [PATCH 14/16] SUPPORT.md: Add statement on PCI passthrough

2017-11-14 Thread Marek Marczykowski-Górecki
On Mon, Nov 13, 2017 at 03:41:24PM +, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Ian Jackson > CC: Wei Liu > CC: Andrew Cooper > CC: Jan Beulich > CC: Stefano Stabellini > CC: Konrad Wilk > CC: Tim Deegan > CC: Rich Persaud > CC:

Re: [Xen-devel] [PATCH 5/5] docs: add PV sound device config

2017-10-30 Thread Marek Marczykowski-Górecki
On Mon, Oct 02, 2017 at 12:49:24PM +0300, Oleksandr Grytsov wrote: > +=item B > + > +Short name of the virtual sound card. > + > +=item B > + > +Long name of the virtual sound card. > + > +=back Duplicate short-name=, should be name= ? -- Best Regards, Marek Mar

Re: [Xen-devel] [PATCH 2/2] python/libxc: extend the call to get/set cap for credit2

2017-09-27 Thread Marek Marczykowski-Górecki
On Wed, Sep 27, 2017 at 12:46:22PM +0100, Wei Liu wrote: > Commit 68817024 ("xen: credit2: allow to set and get utilization cap") > added a new parameter. Implement it for the python binding as well. > > Coverity-ID: 1418532 > > Signed-off-by: Wei Liu Acked-by

Re: [Xen-devel] [PATCH v3 1/3] python: Add binding for xs_fileno()

2017-09-22 Thread Marek Marczykowski-Górecki
by: Euan Harris > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Wei Liu Acked-by: Marek Marczykowski-Górecki > --- > Changed since v2: > * Use PyLong_FromLong instead of PyInt_FromLong > --- > tools/python/xen/lowlevel/xs/xs.c | 20 > 1 file changed, 2

Re: [Xen-devel] [PATCH v2 3/3] python: Add binding for non-blocking xs_check_watch()

2017-09-21 Thread Marek Marczykowski-Górecki
viewed-by: Wei Liu Acked-by: Marek Marczykowski-Górecki > --- > tools/python/xen/lowlevel/xs/xs.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/tools/python/xen/lowlevel/xs/xs.c > b/tools/python/xen/lowlevel/xs/xs.c > index 2af5e07..

Re: [Xen-devel] [PATCH v2 2/3] python: Extract registered watch search logic from xspy_read_watch()

2017-09-21 Thread Marek Marczykowski-Górecki
do the same, so this patch extracts the search code into a > separate function. > > Signed-off-by: Euan Harris > Reviewed-by: Wei Liu Acked-by: Marek Marczykowski-Górecki > --- > Changed since v1: > * Remove stray newline > * Fix indentation > &g

Re: [Xen-devel] [PATCH v2 1/3] python: Add binding for xs_fileno()

2017-09-21 Thread Marek Marczykowski-Górecki
hodDef xshandle_methods[] = { > XSPY_METH(release_domain,METH_VARARGS), > XSPY_METH(close, METH_NOARGS), > XSPY_METH(get_domain_path, METH_VARARGS), > +XSPY_METH(fileno,METH_NOARGS), > { NULL /* Sentinel. */ }, > };

Re: [Xen-devel] Xen 4.8.2 released

2017-09-11 Thread Marek Marczykowski-Górecki
at you're referring to? Yes, this one: https://blog.xenproject.org/2017/09/06/xen-project-4-8-2-is-available/ > Lars, > could you correct that? > > Jan > -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which pe

Re: [Xen-devel] Xen 4.8.2 released

2017-09-09 Thread Marek Marczykowski-Górecki
cement on the website has wrong link (to 4.8.1 instead of 4.8.2). -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? signature.asc Description: PGP signature ___

Re: [Xen-devel] [PATCH 5/5] tools/libxenctrl: use new xenforeignmemory API to seed grant table

2017-08-04 Thread Marek Marczykowski-Górecki
unnecessary, as the grant table has already been seeded > > by a prior call to xc_dom_gnttab_init() made by libxl__build_dom(). > > > > Signed-off-by: Paul Durrant > > --- > > Cc: Ian Jackson > > Cc: Wei Liu > > BTW Marek needs to be CC on changes

Re: [Xen-devel] [PATCH v2 1/2] libxl: use xen-blkback for 'vbd' disk types by default

2017-08-01 Thread Marek Marczykowski-Górecki
On Mon, Jul 31, 2017 at 05:01:08PM +0100, Wei Liu wrote: > On Mon, Jul 31, 2017 at 04:56:04PM +0100, Wei Liu wrote: > > On Fri, Jul 28, 2017 at 06:42:13PM +0200, Marek Marczykowski-Górecki wrote: > > > This will allow later to make HVM domain without qemu in dom0 (in > >

[Xen-devel] [PATCH v2 2/2] libxl: do not start dom0 qemu for stubdomain when not needed

2017-07-28 Thread Marek Marczykowski-Górecki
: Marek Marczykowski-Górecki --- tools/libxl/libxl_dm.c | 54 -- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 44ebd70..e0e6a99 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl

[Xen-devel] [PATCH v2 1/2] libxl: use xen-blkback for 'vbd' disk types by default

2017-07-28 Thread Marek Marczykowski-Górecki
This will allow later to make HVM domain without qemu in dom0 (in addition to the one in stubdomain). Signed-off-by: Marek Marczykowski-Górecki --- This is extracted from v1 of "libxl: do not start dom0 qemu for stubdomain when not needed". Signed-off-by: Marek Marczykowski-Górecki

Re: [Xen-devel] [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed

2017-07-28 Thread Marek Marczykowski-Górecki
On Fri, Jul 28, 2017 at 05:17:12PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] libxl: do not start dom0 qemu for stubdomain > when not needed"): > > On Fri, Jul 28, 2017 at 06:05:13PM +0200, Marek Marczykowski-Górecki wrote: > > > On Fri, Jul 28, 20

Re: [Xen-devel] [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed

2017-07-28 Thread Marek Marczykowski-Górecki
On Fri, Jul 28, 2017 at 04:17:51PM +0100, Wei Liu wrote: > On Thu, Jul 27, 2017 at 12:44:25AM +0200, Marek Marczykowski-Górecki wrote: > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > index 44ebd70..c9aefe15 100644 > > --- a/tools/libxl/libxl_dm.c

Re: [Xen-devel] [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed

2017-07-28 Thread Marek Marczykowski-Górecki
On Fri, Jul 28, 2017 at 04:17:51PM +0100, Wei Liu wrote: > On Thu, Jul 27, 2017 at 12:44:25AM +0200, Marek Marczykowski-Górecki wrote: > > Use xen-blkback for 'vbd' disk types by default and do not setup vfb+vkb > > when no access method was configured. Then check if

[Xen-devel] [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed

2017-07-26 Thread Marek Marczykowski-Górecki
, there is much smaller part of qemu exposed. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_disk.c | 4 +++- tools/libxl/libxl_dm.c | 52 ++-- 2 files changed, 40 insertions(+), 16 deletions(-) diff --git a/tools/libxl/libxl_disk.c b/t

[Xen-devel] [PATCH] libvchan: Fix cleanup when xc_gntshr_open failed

2017-07-26 Thread Marek Marczykowski-Górecki
If xc_gntshr_open failed the only thing to cleanup is free allocated memory. So instead of calling libxenvchan_close (which assume valid calculated buffers being mmaped already) free memory and return. Signed-off-by: Marek Marczykowski-Górecki --- tools/libvchan/init.c | 6 -- 1 file

Re: [Xen-devel] [PATCH RFC] tools: Drop xc_cpuid_check() and bindings

2017-07-18 Thread Marek Marczykowski-Górecki
val of the OCaml bindings and the patch for the OCaml > code. If the code is fundamentally broken it should be removed in any case > but like you already said, we are not aware of any clients. Same for python bindings. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A:

Re: [Xen-devel] offtopic: handling patches

2017-07-02 Thread Marek Marczykowski-Górecki
On Fri, Jun 30, 2017 at 06:18:11PM +0100, Andrew Cooper wrote: > On 30/06/17 17:57, Marek Marczykowski-Górecki wrote: > > Hi, > > > > How you guys handle patches with emails? I know git am and git > > format-patch/send-email, but those tools are quite limited, especia

[Xen-devel] offtopic: handling patches

2017-06-30 Thread Marek Marczykowski-Górecki
ipts? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? signature.asc Description: PGP signature ___ Xen-devel mailing

[Xen-devel] [PATCH v3 2/4] libxl: fix osvm cpuid flag

2017-06-30 Thread Marek Marczykowski-Górecki
It's bit 9 not 10 (which is ibs). Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c index fda8bf6..98c7c54 100644 --- a/tools/libxl/libxl_cpuid.c

[Xen-devel] [PATCH v3 1/4] libxl: add more cpuid flags handling

2017-06-30 Thread Marek Marczykowski-Górecki
This is result of parsing cpu_map.xml from libvirt. The most important part is handling leaf 0x0007, but while at it add other bits too. Signed-off-by: Marek Marczykowski-Górecki --- docs/man/xl.cfg.pod.5.in | 21 + tools/libxl/libxl_cpuid.c | 40

[Xen-devel] [PATCH v3 3/4] libxl: make cpuid_flags array static const

2017-06-30 Thread Marek Marczykowski-Górecki
To have it in .rodata, instead of reconstructing each time on stack. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c index 98c7c54..3726aa4

[Xen-devel] [PATCH v3 0/4] libxl: cpuid bits

2017-06-30 Thread Marek Marczykowski-Górecki
ted the first patch to v1 version Marek Marczykowski-Górecki (4): libxl: add more cpuid flags handling libxl: fix osvm cpuid flag libxl: make cpuid_flags array static const libxl: reformat cpuid_flags docs/man/xl.cfg.pod.5.in | 21 ++-- tools/libxl/libxl_cpuid.c | 234 +

[Xen-devel] [PATCH v3 4/4] libxl: reformat cpuid_flags

2017-06-30 Thread Marek Marczykowski-Górecki
Reverse sorting order, add blank lines at register change. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 260 --- 1 file changed, 137 insertions(+), 123 deletions(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl

Re: [Xen-devel] [PATCH v2 0/2] libxl: cpuid bits

2017-06-29 Thread Marek Marczykowski-Górecki
On Wed, Jun 28, 2017 at 06:55:58PM +0100, Wei Liu wrote: > On Wed, Jun 28, 2017 at 12:10:20PM +0200, Marek Marczykowski-Górecki wrote: > > This adds handling more cpuid bits by name. Mostly based on cpu_map.xml from > > libvirt. > > > > Marek Marczykowski-Górecki (2):

Re: [Xen-devel] [PATCH v2 1/2] libxl: add more cpuid flags handling

2017-06-28 Thread Marek Marczykowski-Górecki
On Wed, Jun 28, 2017 at 07:16:18PM +0100, Andrew Cooper wrote: > On 28/06/17 11:10, Marek Marczykowski-Górecki wrote: > > This is result of parsing cpu_map.xml from libvirt. > > The most important part is handling leaf 0x0007, but while at it add > > other bits too.

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Marek Marczykowski-Górecki
On Wed, Jun 28, 2017 at 11:16:33AM +0100, Andrew Cooper wrote: > On 28/06/17 07:09, Jan Beulich wrote: > >>>> Marek Marczykowski-Górecki 06/28/17 > >>>> 3:09 AM >>> > >> It's bit 9 not 10 (which is ibs). > > Indeed, but shouldn'

[Xen-devel] [PATCH v2 1/2] libxl: add more cpuid flags handling

2017-06-28 Thread Marek Marczykowski-Górecki
This is result of parsing cpu_map.xml from libvirt. The most important part is handling leaf 0x0007, but while at it add other bits too. Signed-off-by: Marek Marczykowski-Górecki --- docs/man/xl.cfg.pod.5.in | 20 tools/libxl/libxl_cpuid.c | 37

[Xen-devel] [PATCH v2 0/2] libxl: cpuid bits

2017-06-28 Thread Marek Marczykowski-Górecki
This adds handling more cpuid bits by name. Mostly based on cpu_map.xml from libvirt. Marek Marczykowski-Górecki (2): libxl: add more cpuid flags handling libxl: drop osvw cpuid flag docs/man/xl.cfg.pod.5.in | 20 tools/libxl/libxl_cpuid.c | 38

[Xen-devel] [PATCH v2 2/2] libxl: drop osvw cpuid flag

2017-06-28 Thread Marek Marczykowski-Górecki
It was wrong (should be bit 9), but instead of fixing, simply remove it because it isn't exposed by hypervisor at all. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 1 - 1 file changed, 1 deletion(-) Changes since v1: - drop it instead of fixing it diff --

[Xen-devel] [PATCH 0/2] libxl: cpuid bits

2017-06-27 Thread Marek Marczykowski-Górecki
oo? There is already such case for "sse4.1" / "sse4_1". Marek Marczykowski-Górecki (2): libxl: add more cpuid flags handling libxl: fix osvm cpuid flag docs/man/xl.cfg.pod.5.in | 20 tools/libxl/libxl_cpuid.c | 39 +

[Xen-devel] [PATCH 1/2] libxl: add more cpuid flags handling

2017-06-27 Thread Marek Marczykowski-Górecki
This is result of parsing cpu_map.xml from libvirt. The most important part is handling leaf 0x0007, but while at it add other bits too. Signed-off-by: Marek Marczykowski-Górecki --- docs/man/xl.cfg.pod.5.in | 20 tools/libxl/libxl_cpuid.c | 37

[Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-27 Thread Marek Marczykowski-Górecki
It's bit 9 not 10 (which is ibs). Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c index 1cf7973..a4a69af 100644 --- a/tools/libxl/libxl_cpuid.c

[Xen-devel] Building Xen 4.8 with GCC 7

2017-06-27 Thread Marek Marczykowski-Górecki
'/home/user/rpmbuild/BUILD/xen-4.8.1/extras/mini-os' make[1]: *** [Makefile:576: vtpmmgr-stubdom] Error 2 make[1]: Leaving directory '/home/user/rpmbuild/BUILD/xen-4.8.1/stubdom' make: *** [Makefile:105: install-stubdom] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.uyh

[Xen-devel] [PATCH 1/3] stubdom: fix vtpm compilation on GCC-7

2017-06-27 Thread Marek Marczykowski-Górecki
GCC-7 have -Wimplicit-fallthrough enabled with -Wextra. Add appropriate comment which both mute the warning and improve readibility. Signed-off-by: Marek Marczykowski-Górecki --- stubdom/Makefile| 1 + stubdom/vtpm-implicit-fallthrough.patch | 10 ++ 2 files

[Xen-devel] [PATCH 3/3] Disable -Wint-in-bool-context

2017-06-27 Thread Marek Marczykowski-Górecki
GCC 7 is too sensitive here. See https://bugs.debian.org/853710 Signed-off-by: Marek Marczykowski-Górecki --- Config.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Config.mk b/Config.mk index 1ddcd58..7af5af9 100644 --- a/Config.mk +++ b/Config.mk @@ -216,6 +216,7 @@ $(call cc-option

[Xen-devel] [PATCH 0/3] Compilation fixes for GCC 7

2017-06-27 Thread Marek Marczykowski-Górecki
backported: 796dea3 tools: include sys/sysmacros.h on Linux f49fa65 tools:misc:xenlockprof: fix possible format string overflow Marek Marczykowski-Górecki (3): stubdom: fix vtpm compilation on GCC-7 tools/xenpmd: fix potential string truncation Disable -Wint-in-bool-context

[Xen-devel] [PATCH 2/3] tools/xenpmd: fix potential string truncation

2017-06-27 Thread Marek Marczykowski-Górecki
GCC 7 warns (and thanks to -Werror, fails) about potential string truncation by snprintf in get_next_battery_file. Since the code already check if string is no longer than 4 chars, tell gcc about it. Signed-off-by: Marek Marczykowski-Górecki --- tools/xenpmd/xenpmd.c | 8 1 file

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread 'Marek Marczykowski-Górecki'
On Mon, Jun 26, 2017 at 01:09:58PM +, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > > Marek Marczykowski-Górecki > > Sent: 26 June 2017 13:45 > > To: Juergen Groß > > Cc: An

[Xen-devel] [PATCH v2] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Marek Marczykowski-Górecki
ivcmd driver carefully verify buffer addresses. Cc: sta...@vger.kernel.org Signed-off-by: Marek Marczykowski-Górecki --- arch/x86/include/asm/xen/hypercall.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Changes since v1: - add HYPERVISOR_dm_op diff --git a/arch/x86/include/as

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Marek Marczykowski-Górecki
On Mon, Jun 26, 2017 at 02:05:48PM +0200, Juergen Groß wrote: > On 06/23/2017 02:47 PM, Marek Marczykowski-Górecki wrote: > > Userspace application can do a hypercall through /dev/xen/privcmd, and > > some for some hypercalls argument is a pointers to user-provided > > st

[Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-23 Thread Marek Marczykowski-Górecki
Userspace application can do a hypercall through /dev/xen/privcmd, and some for some hypercalls argument is a pointers to user-provided structure. When SMAP is supported and enabled, hypervisor can't access. So, lets allow it. Cc: sta...@vger.kernel.org Signed-off-by: Marek Marczykowski-Gó

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-06-22 Thread Marek Marczykowski-Górecki
[resurrecting old thread...] On Mon, Jan 16, 2017 at 11:41:55PM +, Andrew Cooper wrote: > On 16/01/2017 23:06, Marek Marczykowski-Górecki wrote: > > On Mon, Jan 16, 2017 at 05:17:59AM -0700, Jan Beulich wrote: > >> 2) When the guest issues stac()/clac(), it indicate

Re: [Xen-devel] PCI passthrough of USB controllers on Xen 4.8.1, Linux 4.9.29, stubdomain

2017-06-06 Thread Marek Marczykowski-Górecki
o xen-devel Linux in domU: [ 51.679188] xhci_hcd :00:05.0: Error while assigning device slot ID [ 51.679264] xhci_hcd :00:05.0: Max number of devices this xHCI host supports is 32. [ 51.679359] usb usb1-port2: couldn't allocate usb_device (and nothing about ehci,

Re: [Xen-devel] PCI passthrough of USB controllers on Xen 4.8.1, Linux 4.9.29, stubdomain

2017-06-06 Thread Marek Marczykowski-Górecki
On Tue, Jun 06, 2017 at 02:37:01AM -0600, Jan Beulich wrote: > >>> On 02.06.17 at 12:57, wrote: > > And in this case, dom0 also prints: > > > > [ 49.155606] pciback :00:14.0: Driver tried to write to a > > read-only configuration space field at offset 0x82, size 2. This may be > > har

Re: [Xen-devel] (pv)?grub and PVHv2

2017-06-05 Thread Marek Marczykowski-Górecki
On Mon, Jun 05, 2017 at 11:55:24AM +0100, George Dunlap wrote: > On Fri, Jun 2, 2017 at 10:58 AM, Roger Pau Monné wrote: > > On Fri, Jun 02, 2017 at 11:33:50AM +0200, Marek Marczykowski-Górecki wrote: > >> Hi, > >> > >> Is there any method to boot PVHv

Re: [Xen-devel] (pv)?grub and PVHv2

2017-06-02 Thread Marek Marczykowski-Górecki
On Fri, Jun 02, 2017 at 12:16:06PM +0100, Anthony PERARD wrote: > On Fri, Jun 02, 2017 at 10:58:54AM +0100, Roger Pau Monné wrote: > > On Fri, Jun 02, 2017 at 11:33:50AM +0200, Marek Marczykowski-Górecki wrote: > > > Hi, > > > > > > Is there any method to boot

[Xen-devel] PCI passthrough of USB controllers on Xen 4.8.1, Linux 4.9.29, stubdomain

2017-06-02 Thread Marek Marczykowski-Górecki
your device obtained from lspci. [ 66.247644] pciback :00:14.0: cache line size of 64 is not supported [ 66.247646] xen_pciback: :00:14.0: cannot enable memory-write-invalidate (-22) Enabling permissive mode doesn't change anything. Any idea what's wrong? -- Bes

[Xen-devel] (pv)?grub and PVHv2

2017-06-02 Thread Marek Marczykowski-Górecki
Hi, Is there any method to boot PVHv2 domain using a kernel fetched from that domain's disk image, _without_ mounting it in dom0? Something like pvgrub was for PV. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally

Re: [Xen-devel] [PATCH] MAINTAINERS: add Marek as maintainer of python bindings

2017-03-01 Thread Marek Marczykowski-Górecki
On Wed, Mar 01, 2017 at 12:32:26PM +, Wei Liu wrote: > Marek has kindly agreed to step up and co-maintain the python bindings. > > Signed-off-by: Wei Liu Acked-by: Marek Marczykowski-Górecki > --- > Cc: Marek Marczykowski-Górecki > Cc: Ian Jackson > > $ get

[Xen-devel] [PATCH 8/8] python: handle long type in scripts

2017-02-23 Thread Marek Marczykowski-Górecki
In Python3 'long' type have been merged into 'int', '1L' syntax is no longer valid. Assign 'int' type to a 'long' variable in python3, so 'long(1)' will give correct result in both python2 and python3. Signed-off-by: Marek Marczyk

[Xen-devel] [PATCH 0/8] Python 3 bindings

2017-02-23 Thread Marek Marczykowski-Górecki
twice. In most cases it will be packaging scripts responsibility. Patches 1-4 are cleanups not really specific to python3, but making it easier. Marek Marczykowski-Górecki (8): python: check return value of PyErr_NewException python: drop tp_getattr implementation python: use Py_TYPE instead of

[Xen-devel] [PATCH 5/8] python: use PyBytes/PyUnicode instead of PyString

2017-02-23 Thread Marek Marczykowski-Górecki
which have well defined format, use PyUnicode - to ease API usage - no need to prefix all xenstore paths with 'b' when migrating scripts to Python3. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 6 +++--- tools/python/xen/lowlevel/xs/xs.c | 20 +++

[Xen-devel] [PATCH 2/8] python: drop tp_getattr implementation

2017-02-23 Thread Marek Marczykowski-Górecki
tp_getattr method of type object is deprecated already in Python2 and gone in Python3. Default implementation does the same as this custom one. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 7 +-- tools/python/xen/lowlevel/xs/xs.c | 7 +-- 2 files

[Xen-devel] [PATCH 7/8] python: adjust module initalization for Python3

2017-02-23 Thread Marek Marczykowski-Górecki
should be named PyInit_, instead of init. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 35 --- tools/python/xen/lowlevel/xs/xs.c | 34 +++--- 2 files changed, 63 insertions(+), 6 deletions(-) diff --git

[Xen-devel] [PATCH 3/8] python: use Py_TYPE instead of looking directly into PyObject_HEAD

2017-02-23 Thread Marek Marczykowski-Górecki
Py_TYPE works on both Python2 and Python3, while internals of PyObject_HEAD have changed. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 2 +- tools/python/xen/lowlevel/xs/xs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/python

[Xen-devel] [PATCH 4/8] python: initialize specific fields of PyTypeObject

2017-02-23 Thread Marek Marczykowski-Górecki
Fields not named here will be zero-initialized anyway, but using this way will be much easier to support both Python2 and Python3. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 47 --- tools/python/xen/lowlevel/xs/xs.c | 47

[Xen-devel] [PATCH 1/8] python: check return value of PyErr_NewException

2017-02-23 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 4 tools/python/xen/lowlevel/xs/xs.c | 4 2 files changed, 8 insertions(+) diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c index 39be1d5..7fbead5 100644 --- a/tools

[Xen-devel] [PATCH 6/8] python: use PyLong_* for constructing 'int' type in Python3

2017-02-23 Thread Marek Marczykowski-Górecki
In Python3 'int' and 'long' types are the same, there are no longer separate PyInt_* functions. Provide convenient #defines to limit #if in code. Signed-off-by: Marek Marczykowski-Górecki --- tools/python/xen/lowlevel/xc/xc.c | 51 -

Re: [Xen-devel] Python 3 bindings

2017-02-22 Thread Marek Marczykowski-Górecki
On Wed, Feb 22, 2017 at 11:34:16AM +, Wei Liu wrote: > On Tue, Feb 21, 2017 at 02:03:00PM +0100, Marek Marczykowski-Górecki wrote: > > On Mon, Feb 20, 2017 at 05:18:44PM +, Wei Liu wrote: > > > On Fri, Feb 17, 2017 at 01:36:01PM +0100, Marek Marczykowski-Górecki >

Re: [Xen-devel] Python 3 bindings

2017-02-21 Thread Marek Marczykowski-Górecki
On Mon, Feb 20, 2017 at 05:18:44PM +, Wei Liu wrote: > On Fri, Feb 17, 2017 at 01:36:01PM +0100, Marek Marczykowski-Górecki wrote: > > Hi, > > > > I'm adjusting python bindings to work on python3 too. This will require > > few #if in the code (to compile for b

[Xen-devel] Python 3 bindings

2017-02-17 Thread Marek Marczykowski-Górecki
ta you need to write b'some string'. As for python2, it should definitely be still 'str'/'bytes' type. There is one more little detail - build process. Here I'm going to follow popular standard - use $(PYTHON) variable - if that points to python3, build for

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-16 Thread Marek Marczykowski-Górecki
> So the driver adjustment suggested by Andrew has an effect on only > page walks done by Xen during copy_{to,from}_guest(), but not on > actual memory accesses. Ok, so indeed the kernel patch makes the most sense here. Is the change in thi

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Sat, Jan 14, 2017 at 01:47:49AM +, Andrew Cooper wrote: > On 13/01/2017 20:32, Marek Marczykowski-Górecki wrote: > > On Fri, Jan 13, 2017 at 07:54:01PM +, Andrew Cooper wrote: > >> This is a guest kernel bug. The guest kernel has used SMAP to say > >> &qu

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Fri, Jan 13, 2017 at 07:54:01PM +, Andrew Cooper wrote: > On 13/01/17 19:40, Marek Marczykowski-Górecki wrote: > > On Fri, Jan 13, 2017 at 07:27:20PM +, Andrew Cooper wrote: > >> On 13/01/17 18:59, Marek Marczykowski-Górecki wrote: > >>> On Fri, Jan 13, 20

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Fri, Jan 13, 2017 at 07:27:20PM +, Andrew Cooper wrote: > On 13/01/17 18:59, Marek Marczykowski-Górecki wrote: > > On Fri, Jan 13, 2017 at 06:37:06PM +, Andrew Cooper wrote: > >> On 13/01/17 18:32, Marek Marczykowski-Górecki wrote: > >>> On Fri, Jan 13, 20

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Fri, Jan 13, 2017 at 06:37:06PM +, Andrew Cooper wrote: > On 13/01/17 18:32, Marek Marczykowski-Górecki wrote: > > On Fri, Jan 13, 2017 at 06:15:35PM +, Andrew Cooper wrote: > >> Can you get the result of this piece of debugging in the failure case? > > I've

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Fri, Jan 13, 2017 at 06:15:35PM +, Andrew Cooper wrote: > On 13/01/17 18:03, Marek Marczykowski-Górecki wrote: > > On Fri, Jan 13, 2017 at 05:38:42PM +, Andrew Cooper wrote: > >> On 13/01/17 17:31, Marek Marczykowski-Górecki wrote: > >>> Hi, > &

Re: [Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
On Fri, Jan 13, 2017 at 05:38:42PM +, Andrew Cooper wrote: > On 13/01/17 17:31, Marek Marczykowski-Górecki wrote: > > Hi, > > > > I have a strange problem - xc_evtchn_status fails when running in HVM, > > while exactly the same code (same kernel, same applicatio

[Xen-devel] xc_evtchn_status fails with EFAULT on HVM, the same on PV works

2017-01-13 Thread Marek Marczykowski-Górecki
el is kernel-4.8.13-100.fc23. Any idea? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? signature.asc Description: PGP sign

Re: [Xen-devel] [PATCH 1/3] libxl: attach xen-pciback only to PV domains

2016-10-25 Thread Marek Marczykowski-Górecki
On Tue, Oct 25, 2016 at 09:10:02AM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Oct 20, 2016 at 12:42:33AM +0200, Marek Marczykowski-Górecki wrote: > > On Wed, Oct 19, 2016 at 04:46:26PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Wed, Oct 19, 2016 at 10:37:52AM +0100, Wei Liu

Re: [Xen-devel] [PATCH 1/3] libxl: attach xen-pciback only to PV domains

2016-10-19 Thread Marek Marczykowski-Górecki
On Wed, Oct 19, 2016 at 04:46:26PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Oct 19, 2016 at 10:37:52AM +0100, Wei Liu wrote: > > On Tue, Oct 18, 2016 at 03:53:31AM +0200, Marek Marczykowski-Górecki wrote: > > > HVM domains use IOMMU and device model assistance for communicat

Re: [Xen-devel] [PATCH 3/3] libxl: don't try to manipulate json config for stubdomain

2016-10-19 Thread Marek Marczykowski-Górecki
On Wed, Oct 19, 2016 at 10:38:04AM +0100, Wei Liu wrote: > On Tue, Oct 18, 2016 at 03:53:33AM +0200, Marek Marczykowski-Górecki wrote: > > Stubdomain do not have it's own config file - its configuration is > > derived from target domains. Do not try to manipulate it when atta

Re: [Xen-devel] [PATCH 1/3] libxl: attach xen-pciback only to PV domains

2016-10-18 Thread Marek Marczykowski-Górecki
On Tue, Oct 18, 2016 at 04:52:29PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 18, 2016 at 03:53:31AM +0200, Marek Marczykowski-Górecki wrote: > > HVM domains use IOMMU and device model assistance for communicating with > > PCI devices, xen-pcifront/pciback is used onl

[Xen-devel] [PATCH 2/3] libxl: attach PCI device to qemu only after setting pciback/pcifront

2016-10-17 Thread Marek Marczykowski-Górecki
quot; handling until pcifront_thread finishes devices discovery. But the same problem most likely will apply to any other stubdomain implementations when they come (Rumprun, Linux) - so better handle this at libxl level. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_pci.c | 9

[Xen-devel] [PATCH 1/3] libxl: attach xen-pciback only to PV domains

2016-10-17 Thread Marek Marczykowski-Górecki
to the stubdomain, effectively breaking PCI passthrough. Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 6f8f49c..2ae1bc4 100644 --- a/tools/libxl

[Xen-devel] [PATCH 0/3] Fix PCI passthrough for HVM with stubdomain

2016-10-17 Thread Marek Marczykowski-Górecki
This series is follow up to previous attempts to fix this. Related threads: - http://markmail.org/thread/dwjcdfk3y7s5c5kl "PCI passthrough with stubdomain" - http://xen.markmail.org/thread/l7tvqcxbiyc2grvr "Json config and stubdomain" With those patches applied, HVM finally have PCI devices work

[Xen-devel] [PATCH 3/3] libxl: don't try to manipulate json config for stubdomain

2016-10-17 Thread Marek Marczykowski-Górecki
Stubdomain do not have it's own config file - its configuration is derived from target domains. Do not try to manipulate it when attaching PCI device. This bug prevented starting HVM with stubdomain and PCI passthrough device attached. Signed-off-by: Marek Marczykowski-Górecki --- tools/

Re: [Xen-devel] Json config and stubdomain

2016-09-26 Thread Marek Marczykowski-Górecki
On Mon, Sep 26, 2016 at 12:01:01PM +0100, Wei Liu wrote: > On Sat, Sep 24, 2016 at 12:42:45PM +0200, Marek Marczykowski-Górecki wrote: > > So, the question is, whether json config should be created and properly > > maintained for stubdomain, or not created at all (a

[Xen-devel] Json config and stubdomain

2016-09-24 Thread Marek Marczykowski-Górecki
maintained for stubdomain, or not created at all (assuming all the configuration is already handled in the target domain json config)? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such

Re: [Xen-devel] PCI passthrough with stubdomain

2016-09-23 Thread Marek Marczykowski-Górecki
On Fri, Sep 23, 2016 at 11:00:42PM +0200, Samuel Thibault wrote: > Marek Marczykowski-Górecki, on Fri 23 Sep 2016 20:56:43 +0200, wrote: > > 1. How to do this? ;) I.e. what synchronization primitives are available > > in mini-os? Just pthread_mutex_lock/unlock? > > pthread_m

Re: [Xen-devel] PCI passthrough with stubdomain

2016-09-23 Thread Marek Marczykowski-Górecki
On Fri, Sep 23, 2016 at 04:51:33PM +0200, Samuel Thibault wrote: > Marek Marczykowski-Górecki, on Fri 23 Sep 2016 16:25:41 +0200, wrote: > > Toolstack during (stub)domain startup setup two things, mostly > > asynchronously: > > 1. pciback/pcifront (through standard xe

Re: [Xen-devel] PCI passthrough with stubdomain

2016-09-23 Thread Marek Marczykowski-Górecki
On Fri, Sep 23, 2016 at 11:35:27AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 23, 2016 at 04:25:41PM +0200, Marek Marczykowski-Górecki wrote: > > On Fri, Sep 23, 2016 at 03:27:07PM +0200, Samuel Thibault wrote: > > > Marek Marczykowski-Górecki, on Fri 23 Sep 2016 10:

Re: [Xen-devel] PCI passthrough with stubdomain

2016-09-23 Thread Marek Marczykowski-Górecki
On Fri, Sep 23, 2016 at 03:27:07PM +0200, Samuel Thibault wrote: > Marek Marczykowski-Górecki, on Fri 23 Sep 2016 10:48:14 +0200, wrote: > > I'm still trying to get PCI passthrough working with stubdomain and > > without qemu in dom0 (even for just vfb/vkbd backends). How is

[Xen-devel] PCI passthrough with stubdomain

2016-09-23 Thread Marek Marczykowski-Górecki
inux-based stubdomain with xen-pcifront driver)? PS If anyone interested, here are more details: https://github.com/QubesOS/qubes-issues/issues/1659 -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-post

[Xen-devel] [PATCH for-4.7, 4.6] libxl: do not assume Dom0 backend while getting nic info

2016-09-05 Thread Marek Marczykowski-Górecki
Fill backend_domid field based on backend path. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl.c | 12 1 file changed, 12 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index e1ab6ec..9a888a1 100644 --- a/tools

Re: [Xen-devel] [PATCH] libxl: do not assume Dom0 backend while getting nic info

2016-09-05 Thread Marek Marczykowski-Górecki
On Mon, Sep 05, 2016 at 10:39:16AM +0100, Wei Liu wrote: > On Mon, Sep 05, 2016 at 11:26:04AM +0200, Marek Marczykowski-Górecki wrote: > > Fill backend_domid field based on backend path. > > > > Cc: Ian Jackson > > Cc: Wei Liu > > Signed-off-by: Marek Marczyk

[Xen-devel] [PATCH] libxl: do not assume Dom0 backend while getting nic info

2016-09-05 Thread Marek Marczykowski-Górecki
Fill backend_domid field based on backend path. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_nic.c | 12 1 file changed, 12 insertions(+) diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c index c34b7ba..d1caa90 100644

[Xen-devel] [PATCH] libxl: do not assume Dom0 backend while getting nic info

2016-09-05 Thread Marek Marczykowski-Górecki
Fill backend_domid field based on backend path. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] PVH guess crash with memory < maxmem

2016-08-08 Thread Marek Marczykowski-Górecki
On Mon, Aug 08, 2016 at 05:38:56AM -0600, Jan Beulich wrote: > Indeed iirc PVHv1 and PoD are incompatible with one another, > and I don't know any possible workaround. And then I'm not > sure it's worth your time playing with PVHv1 in the first place. Thanks. -- Best Reg

Re: [Xen-devel] PVH hypercall interface

2016-08-08 Thread Marek Marczykowski-Górecki
On Mon, Aug 08, 2016 at 01:19:43PM +0200, Roger Pau Monne wrote: > On Mon, Aug 08, 2016 at 11:42:03AM +0100, Andrew Cooper wrote: > > On 08/08/16 11:21, Marek Marczykowski-Górecki wrote: > > > Hi, > > > > > > What hypercalls are available for PVH guests? > &

[Xen-devel] PVH guess crash with memory < maxmem

2016-08-08 Thread Marek Marczykowski-Górecki
ng some trick (memory hotplug or something)? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? name = "pvhtest" uuid = "ac823572-853b-4c8c-ba77-47aa515ccd63&quo

[Xen-devel] PVH hypercall interface

2016-08-08 Thread Marek Marczykowski-Górecki
me obscure conditions deep in execution path doesn't count). -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? signature.asc Description

Re: [Xen-devel] [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service

2016-07-25 Thread Marek Marczykowski-Górecki
On Mon, Jul 25, 2016 at 10:34:21AM +0100, Wei Liu wrote: > On Mon, Jul 25, 2016 at 11:30:32AM +0200, Marek Marczykowski-Górecki wrote: > > On Mon, Jul 25, 2016 at 10:27:47AM +0100, Wei Liu wrote: > > > On Sun, Jul 24, 2016 at 09:27:13PM +0200, Marek Marczykowski-Górecki > >

Re: [Xen-devel] [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service

2016-07-25 Thread Marek Marczykowski-Górecki
On Mon, Jul 25, 2016 at 10:27:47AM +0100, Wei Liu wrote: > On Sun, Jul 24, 2016 at 09:27:13PM +0200, Marek Marczykowski-Górecki wrote: > > It is no longer required since xl devd use /dev/xen interface. > > > > How would this unit work when there is no /dev/xen interfac

[Xen-devel] [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service

2016-07-24 Thread Marek Marczykowski-Górecki
s possible, because it will process devices created before its startup. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Marek Marczykowski-Górecki --- tools/hotplug/Linux/systemd/xendriverdomain.service.in | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/hotplug/Lin

[Xen-devel] [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service

2016-07-24 Thread Marek Marczykowski-Górecki
It is no longer required since xl devd use /dev/xen interface. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Marek Marczykowski-Górecki --- tools/hotplug/Linux/systemd/xendriverdomain.service.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/hotplug/Linux/systemd

[Xen-devel] "X86_PV_VCPU_MSRS record truncated" during domain restore (was: Re: [qubes-users] DispVM Doesn't work)

2016-07-20 Thread Marek Marczykowski-Górecki
-daemon-dvm", line 103, in do_get_dvm > dispvm.start() > File > "/usr/lib64/python2.7/site-packages/qubes/modules/01QubesDisposableVm.py", > line 193, in start > domain_config, libvirt.VIR_DOMAIN_SAVE_PAUSED) > File "/usr/lib64/python2.7/site-packages

  1   2   >