Re: [Xen-devel] [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Wed, Apr 05, 2017 at 10:21:13AM +0200, Julia Lawall wrote: > > > > > > On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > > > > > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > &g

Re: [Xen-devel] [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > > >> Eric Blake writes: > > >> > > >>> Quite a few users of qdict_put() were manuall

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread Julia Lawall
On Thu, 21 Jan 2016, Rasmus Villemoes wrote: > On Wed, Jan 20 2016, Konrad Rzeszutek Wilk wrote: > > > On Wed, Dec 23, 2015 at 10:06:24PM +0100, Julia Lawall wrote: > >> The cleancache_ops structure is never modified, so declare it as const. > >> > >&

[Xen-devel] [PATCH v2] cleancache: constify cleancache_ops structure

2016-01-21 Thread Julia Lawall
The cleancache_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: put back the read mostly drivers/xen/tmem.c |2 +- include/linux/cleancache.h |2 +- mm/cleancache.c|4 ++-- 3 files

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread Julia Lawall
On Thu, 21 Jan 2016, David Vrabel wrote: > On 23/12/15 21:06, Julia Lawall wrote: > > The cleancache_ops structure is never modified, so declare it as const. > > > > This also removes the __read_mostly declaration on the cleancache_ops > > variable declaration, si

[Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2015-12-23 Thread Julia Lawall
The cleancache_ops structure is never modified, so declare it as const. This also removes the __read_mostly declaration on the cleancache_ops variable declaration, since it seems redundant with const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- Not sure that the

[Xen-devel] [PATCH 0/3] constify mmu_notifier_ops structures

2015-11-29 Thread Julia Lawall
mmu_notifier_ops structures are never modified, so declare them all as const. --- drivers/infiniband/core/umem_odp.c |2 +- drivers/iommu/amd_iommu_v2.c |2 +- drivers/xen/gntdev.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) __

[Xen-devel] [PATCH 1/3] xen/gntdev: constify mmu_notifier_ops structures

2015-11-29 Thread Julia Lawall
This mmu_notifier_ops structure is never modified, so declare it as const, like the other mmu_notifier_ops structures. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- The patches in this series are independent of each other. drivers/xen/gntdev.c |2 +- 1 file changed, 1

[Xen-devel] [PATCH] xen/grant-table: constify gnttab_ops structure

2015-11-28 Thread Julia Lawall
The gnttab_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/xen/grant-table.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c