Looks good for me.
Reviewed-by: Joe Jin
On 10/09/2017 02:00 PM, Zhenzhong Duan wrote:
> Same code is already in allocate_and_map_msi_pirq()
>
> Signed-off-by: Zhenzhong Duan
> ---
> xen/arch/x86/physdev.c |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
Should not allocate vnic queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Jan Beulich
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netfront.c | 28 ++--
1 files changed, 22 insertions(+), 6 deletions
Should not allocate xen vif queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Jan Beulich
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netback/netback.c | 28 ++--
1 files changed, 22 insertions(+), 6
.
Joe Jin (2):
xen-netback: limit xen vif max queues number to online cpus
xen-netfront: limit vnic max_queues number to online cpus
---
Changes in v3:
- Corrected the range info [1-CPUs].
Changes in v2:
- Replace param_get_int to param_get_uint.
- Use '%u' for unsigned int
es %u is out of range [0 - %u]!\n",
>
> I suppose you mean "...[1 - %u]!\n" here?
Yes you are right, you catch my fault again :)
Thanks so much, will resend new later.
Regards,
Joe
> Jan
>
--
Oracle <http://www.oracle.com>
Joe Jin | Software Development Dire
Should not allocate vnic queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Jan Beulich
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netfront.c | 28 ++--
1 files changed, 22 insertions(+), 6 deletions
Should not allocate xen vif queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Jan Beulich
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netback/netback.c | 28 ++--
1 files changed, 22 insertions(+), 6
.
Joe Jin (2):
xen-netback: limit xen vif max queues number to online cpus
xen-netfront: limit vnic max_queues number to online cpus
---
Changes in v2:
- Replace param_get_int to param_get_uint.
- Use '%u' for unsigned int when print.
- Replace EINVAL to ERANGE when out of ran
On 10/23/2015 04:47 PM, Paul Durrant wrote:
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-
>> ow...@vger.kernel.org] On Behalf Of Joe Jin
>> Sent: 23 October 2015 08:54
>> To: Wei Liu; Ian Campbell; Boris Ostrovsky; Konrad Rzes
as many queues as there are CPUs if user has not
>> - * specified a value.
>> - */
>> -if (xenvif_max_queues == 0)
>> -xenvif_max_queues = num_online_cpus();
>> +/* Allow at most as many queues as CPUs. */
>> +if (xenvif_max_queues ==
Should not allocate vnic queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netfront.c | 27 +--
1 files changed, 21 insertions(+), 6 deletions(-)
diff --git a
Should not allocate xen vif queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Wei Liu
Cc: Ian Campbell
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
---
drivers/net/xen-netback/netback.c | 28 ++--
1 files changed, 22 insertions(+), 6 deletions
Currently xen vnic allowed to create lots of queues by set module param
max_queues(both netback and netfront), when queues number larger than
cpu number, it does not help for performance but need more cpu time.
This patchset limit netback and netfront max queues number to online
cpus number.
Joe
We need to take care sysfs too, please ignore this patch, I'll create
new one later for review and comment.
Thanks,
Joe
On 10/23/2015 08:50 AM, Joe Jin wrote:
> Should not allocate queues number more than online cpus.
>
> Signed-off-by: Joe Jin
> Cc: Boris Ostrovsky
> Cc: K
Should not allocate queues number more than online cpus.
Signed-off-by: Joe Jin
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
Cc: David S. Miller
---
drivers/net/xen-netfront.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net
Sometimes xennet_create_queues() may failed to created all requested
queues, we need to update num_queues to real created to avoid NULL
pointer dereference.
Signed-off-by: Joe Jin
Cc: Boris Ostrovsky
Cc: Konrad Rzeszutek Wilk
Cc: Wei Liu
Cc: Ian Campbell
Cc: David S. Miller
---
drivers/net
Sometimes xennet_create_queues() may failed to created all requested
queues, we need to update num_queues to real created to avoid NULL
pointer dereference.
Signed-off-by: Joe Jin
Cc: Wei Liu
Cc: Ian Campbell
Cc: David S. Miller
---
drivers/net/xen-netfront.c |9 ++---
1 files
17 matches
Mail list logo
