On 26/09/17 12:02, Andrew Cooper wrote:
On 25/09/17 19:55, Jennifer Herbert wrote:
@@ -46,7 +60,22 @@ struct save_callbacks {
*/
int (*suspend)(void* data);
-/* Called after the guest's dirty pages have been
+/*
+ * Called before and after every batch of page
On 26/09/17 11:58, Andrew Cooper wrote:
On 25/09/17 19:55, Jennifer Herbert wrote:
+/*
+ * A precopy_policy callback may not be running in the same address
+ * space as libxc an so precopy_stats is passed by value.
+ */
Please take a step back and thing about what is written here...
As I&#x
On 26/09/17 09:48, Wei Liu wrote:
On Mon, Sep 25, 2017 at 07:55:35PM +0100, Jennifer Herbert wrote:
Provide an implementation of the old policy as a callback in
libxl and plumb it through the IPC machinery to libxc.
This serves as an example for defining a libxl policy,
and provides no
itted and take the dictated action, which
may be to a) abort the migration entirely, b) continue with the
precopy, or c) proceed to the stop-and-copy phase.
- provide an implementation of the old policy, used when
precopy_policy callback is not provided.
Signed-off-by: Jennifer Herbert
Signe
Provide an implementation of the old policy as a callback in
libxl and plumb it through the IPC machinery to libxc.
This serves as an example for defining a libxl policy,
and provides no advantage over the default policy in libxc.
Signed-off-by: Joshua Otto
Reviewed-by: Roger Pau Monné
---
too
igration should end.
If none is provided, a default policy of the current behaviour
is used.
Jennifer Herbert (3):
Tidy libxc xc_domain_save
Introduce migration precopy policy
RFC: migration: defer precopy policy to libxl
tools/libxc/include/xenguest.h | 41 --
tools/libxc
Tidy up libxc's xc_domain_save, removing unused paramaters
max_iters and max_factor, making matching changes to libxl.
Signed-off-by: Joshua Otto
Signed-off-by: Jennifer Herbert
Reviewed-by: Paul Durrant
Acked-by: Wei Liu
---
tools/libxc/include/xenguest.h | 4 ++--
tools/
On 20/09/17 11:20, Roger Pau Monné wrote:
On Tue, Sep 19, 2017 at 07:06:26PM +0100, Jennifer Herbert wrote:
This Patch allows a migration precopy policy to be specified.
The precopy phase of the xc_domain_save() live migration algorithm has
historically been implemented to run until either a
Provide an implementation of the old policy as a callback in
libxl and plumb it through the IPC machinery to libxc.
This serves as an example for defining a libxl policy,
and provides no advantage over the default policy in libxc.
Signed-off-by: Joshua Otto
---
I have included this patch, as rf
itted and take the dictated action, which
may be to a) abort the migration entirely, b) continue with the
precopy, or c) proceed to the stop-and-copy phase.
- provide an implementation of the old policy, used when
precopy_policy callback is not provided.
Signed-off-by: Jennifer Herbert
Signe
Tidy up libxc's xc_domain_save, removing unused paramaters
max_iters and max_factor, making matching changes to libxl.
Signed-off-by: Joshua Otto
Signed-off-by: Jennifer Herbert
Reviewed-by: Paul Durrant
Acked-by: Wei Liu
---
tools/libxc/include/xenguest.h | 4 ++--
tools/
pful paramaters to xc_domain_save(), and the second
which allows a precopy callback to be specified, providing the
test for when to end the live phase of migration should end.
If none is provided, a default policy of the current behaviour
is used.
Jennifer Herbert (3):
Tidy libxc xc_domain_s
On 18/09/17 14:30, Ian Jackson wrote:
Jennifer Herbert writes ("[PATCH 2/2] Introduce migration precopy policy"):
This Patch allows a migration precopy policy to be specified.
But only for direct libxc users. How do you think this should be
exposed via libxl ?
The original p
Tidy up libxc's xc_domain_save, removing unused paramaters
max_iters and max_factor, making matching changes to libxl.
Signed-off-by: Jennifer Herbert
---
tools/libxc/include/xenguest.h | 4 ++--
tools/libxc/xc_nomigrate.c | 3 +--
tools/libxc/xc_sr_save.c | 8 +++-
Tidy up libxc's xc_domain_save, removing unused paramaters
max_iters and max_factor, making matching changes to libxl.
Signed-off-by: Jennifer Herbert
---
tools/libxc/include/xenguest.h | 4 ++--
tools/libxc/xc_nomigrate.c | 3 +--
tools/libxc/xc_sr_save.c | 8 +++-
itted and take the dictated action, which
may be to a) abort the migration entirely, b) continue with the
precopy, or c) proceed to the stop-and-copy phase.
- provide an implementation of the old policy, used when
precopy_policy callback is not provided.
Signed-off-by: Jennifer Herbert
---
ng the
test for when to end the live phase of migration should end.
If none is provided, a default policy of the current behaviour
is used.
Cheers,
Jennifer Herbert (2):
Tidy libxc xc_domain_save
Introduce migration precopy policy
tools/libxc/include/xenguest.h | 23 +++-
tools/libxc
ng the
test for when to end the live phase of migration should end.
If none is provided, a default policy of the current behaviour
is used.
Cheers,
Jennifer Herbert (2):
Tidy libxc xc_domain_save
Introduce migration precopy policy
tools/libxc/include/xenguest.h | 23 +++-
tools/libxc
itted and take the dictated action, which
may be to a) abort the migration entirely, b) continue with the
precopy, or c) proceed to the stop-and-copy phase.
- provide an implementation of the old policy, used when
precopy_policy callback is not provided.
Signed-off-by: Jennifer Herbert
---
QEMU XenServer/XenProject Working group meeting 5th May 2017
=
Attendees:
* Paul Durrant
* Andrew Cooper
* Ian Jackson
* Jenny Herbert
* Igor Druzhinin
* Simon Crow
* Marcus Granado
Reviewed previous action points
* Paul to carry on wi
opinion of the x86 maintainers about getting
this code in Xen 4.9.
Cheers,
On 21/04/17 15:05, jennifer.herb...@citrix.com wrote:
From: Jennifer Herbert
No functional change.
Signed-off-by: Jennifer Herbert
Signed-off-by: Andrew Cooper
Reviewed-by: Jan Beulich
Reviewed-by: Paul Durrant
-
On 21/04/17 11:38, Jan Beulich wrote:
On 21.04.17 at 12:11, wrote:
On 21/04/17 10:46, Jan Beulich wrote:
On 21.04.17 at 11:11, wrote:
On 21/04/2017 09:54, Andrew Cooper wrote:
On 21/04/2017 08:27, Jan Beulich wrote:
On 20.04.17 at 19:59, wrote:
From: Jennifer Herbert
Is this correct
On 21/04/17 10:46, Jan Beulich wrote:
On 21.04.17 at 11:11, wrote:
On 21/04/2017 09:54, Andrew Cooper wrote:
On 21/04/2017 08:27, Jan Beulich wrote:
On 20.04.17 at 19:59, wrote:
From: Jennifer Herbert
Is this correct, considering that iirc the patch was new in v5 and ...
This also
On 10/04/17 10:40, Paul Durrant wrote:
-Original Message-
From: Andrew Cooper
Sent: 10 April 2017 10:29
To: Paul Durrant ; Xen-devel
Cc: Jennifer Herbert ; Jan Beulich
; Julien Grall
Subject: Re: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than
passing two parameters around
Hi,
I would like to encourage this patch - as I have use for it outside
of your postcopy work.
Some things people will comment on:
You've used 'unsigned' without the int keyword, which people don't like.
Also on line 324, your missing space between 'if (' and
'ctx->save.policy_decision'.
Also
From: Jennifer Herbert
This new lib devicemodel call allows multiple extents of pages to be
marked as modified in a single call. This is something needed for a
usecase I'm working on.
The xen side of the modified_memory call has been modified to accept
an array of extents. The device
On 29/03/17 15:54, Jan Beulich wrote:
On 28.03.17 at 15:18, wrote:
@@ -441,13 +481,8 @@ static int dm_op(domid_t domid,
struct xen_dm_op_modified_memory *data =
&op.u.modified_memory;
-const_op = false;
-
-rc = -EINVAL;
-if ( data->pad )
-
On 29/03/17 11:38, Jan Beulich wrote:
On 28.03.17 at 15:18, wrote:
Perhaps drop "already"? Personally I also wouldn't mind you dropping
the variable altogether and using header->opaque directly, but I
guess that's too "opaque" for your taste?
It would make the code too opaque for my taste
From: Jennifer Herbert
This new lib devicemodel call allows multiple extents of pages to be
marked as modified in a single call. This is something needed for a
usecase I'm working on.
The xen side of the modified_memory call has been modified to accept
an array of extents. The device
On 23/03/17 15:58, Jan Beulich wrote:
On 22.03.17 at 20:55, wrote:
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -119,56 +119,89 @@ static int set_isa_irq_level(struct domain *d, uint8_t
--- a/xen/include/public/hvm/dm_op.h
+++ b/xen/include/public/hvm/dm_op.h
@@ -237,13 +237,2
On 23/03/17 08:35, Jan Beulich wrote:
On 22.03.17 at 20:55, wrote:
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -119,56 +119,89 @@ static int set_isa_irq_level(struct domain *d, uint8_t
isa_irq,
}
static int modified_memory(struct domain *d,
-
On 22/03/17 10:33, Jan Beulich wrote:
On 21.03.17 at 14:59, wrote:
This version of this patch removes the need for the 'offset' parameter,
by instead reducing nr_extents, and working backwards from the end of
the array.
This patch also removes the need to ever write back the passed array of
ex
From: Jennifer Herbert
This new lib devicemodel call allows multiple extents of pages to be
marked as modified in a single call. This is something needed for a
usecase I'm working on.
The xen side of the modified_memory call has been modified to accept
an array of extents. The device
From: Jennifer Herbert
This new lib devicemodel call allows multiple extents of pages to be
marked as modified in a single call. This is something needed for a
usecase I'm working on.
The xen side of the modified_memory call has been modified to accept
an array of extents. The device
QEMU XenServer/XenProject Working group meeting 10th February 2017
==
Attendance
--
Andrew Cooper
Ian Jackson
Paul Durrent
Jennifer Herbert
George Dunlap
Igor Druzhinin
Sergey Dyasli
First topic: DMop
QEMU XenServer/XenProject Working group meeting 29th September 2016
===
Attendees
-
David Vrabel
Jennifer Herbert
Ian Jackson
Andrew Cooper
Paul Durrant
Lars Kurth
QEMU depriv
===
DMOP
There has been
QEMU XenServer/XenProject Working group meeting 30th August 2016
Attendance
--
Andrew Cooper
Ian Jackson
Paul Durrant
David Vrabel
Jennifer Herbert
Introduction
Introduced Paul Durrant to the working group
On 01/08/16 12:32, Ian Jackson wrote:
I think we need to introduce a new hypercall (which I will call DMOP
for now) which may augment or replace some of HVMCTL. Let me explain:
I believe the new 'DMOP' hypercall is a good idea, but following on
from discussions, I propose a revised design, w
[ring0]
Jennifer Herbert [ring0]
Purpose of meeting
==
Both XenServer (currently using qemu-trad with de-priv) and XenProject
(using QEMU (upstream) without dep-priv), would like to move to using
QEMU (upstream) de-privelaged.
This meeting was intended to restart XenServer/ring0 and
On 18/12/15 16:58, Jan Beulich wrote:
On 18.12.15 at 15:09, wrote:
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -16,7 +16,7 @@ static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0);
static void check_lock(struct lock_debug *debug)
{
-int irq_safe = !local_irq_is_e
Hi Jan,
Thank you for your comments. Sorry for the slow response - xmas and all...
Responses below...
On 22/12/15 13:54, Jan Beulich wrote:
+/**
+ * rspin_until_writer_unlock - inc reader count & spin until writer is gone
Stale comment - the function doesn't increment anything.
Also through
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference. In this case, it shoud log the errno, (instead of
the date/time), and and continue its logging, as this is still useful.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xtl_logger_stdio.c | 11
On 07/07/15 17:05, Ian Jackson wrote:
Andrew Cooper writes ("Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer
dereference in stdiostream_vmessage()"):
On 07/07/15 16:48, Jennifer Herbert wrote:
+else
+fprintf(lg-f, "[localtime_r failed: %d] ",
I guess I didn't build what I thought I built.
V3 coming up
On 07/07/15 16:51, Andrew Cooper wrote:
On 07/07/15 16:48, Jennifer Herbert wrote:
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference. In this case, it shoud log the errno, (inste
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference. In this case, it shoud log the errno, (instead of
the date/time), and and continue its logging, as this is still useful.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xtl_logger_stdio.c | 11
On 03/07/15 16:27, Ian Jackson wrote:
Jennifer Herbert writes ("[Xen-devel] [PATCH 2/7] libxc: Use const pointer in
local_file_dump()"):
By adding the const keyword, it is clearer to people and static analysis
tools that no changes to the data are to be made.
Would it be wrong fo
If xc_domain_get_guest_width were to fail, guest_width is not set, and
hence guest_64bit becomes undefined.
Fix is to initialise to 0, and report error if call fails.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_cpuid_x86.c |8 +---
1 file changed, 5 insertions(+), 3 deletions
If xc_hvm_param_get fails, is_pae and/or is_nestedhvm are left undefined.
This patch Indicates error and defaults to false.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_cpuid_x86.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tools/libxc
lly cropping of the null termination.
Also, since we wish to initialise all of hvm_info->signature, and
certainly no more, the use of sizeof is safer.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_hvm_build_x86.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools
The return from xc_dom_allocate is not checked for a NULL value.
This patch fixes this, causing it to return from the function with an error.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_dom_compat_linux.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxc
The only place that jumps to 'err:' does so because !dom, which is
rechecked in 'err:'. This patch simplifies, giving the same result.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_dom_core.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference. In this case, one can simply just skip logging the
date/time, and logging anything is more useful then nothing.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xtl_logger_stdio.c |9
By adding the const keyword, it is clearer to people and static analysis
tools that no changes to the data are to be made.
Signed-off-by: Jennifer Herbert
---
tools/libxc/xc_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_core.c b/tools/libxc
Fix a number of coverity issues in libxc.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On 21/04/15 11:22, Jan Beulich wrote:
Despite both pictures saying micro-seconds at the respective axis (and
hence the problem not being _as bad_) - did the data collection reveal
where these IRQ disable regions are, so we could look into eliminating
them? (ISTR there being some open coded IRQ
55 matches
Mail list logo
