Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Jürgen Groß
On 06/16/2015 06:51 PM, Ross Philipson wrote: On 06/16/2015 12:39 PM, George Dunlap wrote: On 06/16/2015 05:32 PM, Ian Jackson wrote: I have just discovered that the value used in /dev/disk/by-path is not from sysfs, or at least, not directly. udev cobbles it together with a bunch of string ma

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-16 Thread Jürgen Groß
On 06/16/2015 12:41 PM, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): Ian / Ian / Wei / Jim: Hi. 3. Have the libxl layer accept both busid and bus:addr. Translate as necessary and store in the libxl_device_usb struct. ... The advantage of

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-15 Thread Jürgen Groß
On 06/15/2015 04:17 PM, George Dunlap wrote: On Wed, Jun 10, 2015 at 4:20 AM, Chunyan Liu wrote: diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 23f27d4..4561e1b 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -541,6 +541,29 @@ libxl_de

Re: [Xen-devel] [PATCH V3 3/6] libxl: add pvusb API

2015-05-19 Thread Jürgen Groß
On 05/19/2015 12:20 PM, George Dunlap wrote: On Tue, May 19, 2015 at 4:20 AM, Chun Yan Liu wrote: +static int libxl__device_usbctrl_setdefault(libxl__gc *gc, uint32_t domid, +libxl_device_usbctrl *usbctrl) +{ +int rc; + +if (!usbctrl->versio

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-14 Thread Jürgen Groß
On 05/13/2015 07:31 PM, Olaf Hering wrote: On Wed, May 13, Ian Campbell wrote: Is it important/useful that the user be able to configure/control the number (and addresses) of the buses themselves and which devices are on which, or can we get away with the pvpci model where the libxl user just gi

Re: [Xen-devel] [PATCH RFC v2 1/3] xen/pvh: enable mmu_update hypercall

2015-04-02 Thread Jürgen Groß
On 04/02/2015 01:50 PM, Andrew Cooper wrote: On 02/04/15 11:42, Ian Campbell wrote: On Thu, 2015-04-02 at 12:26 +0200, Roger Pau Monne wrote: This is needed for performing save/restore of PV guests. It's quite a big interface though, isn't it? Could we restrict it to a subset of the operation

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Jürgen Groß
On 03/02/2015 11:50 AM, Andrew Cooper wrote: On 02/03/15 10:46, Jan Beulich wrote: On 02.03.15 at 11:15, wrote: The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. Remove incorrect reference to WWN because it was never supported. And its not clear how it could be supported.

Re: [Xen-devel] how to assign resources exclusive to a single domU

2015-02-26 Thread Jürgen Groß
On 02/26/2015 09:57 AM, Olaf Hering wrote: While working on pvscsi support for libxl I noticed that assigning a resource exclusivly to just a single domU via libxl will be a major effort. Up to now libxl could rely on the fact that a resource can be either shared or the backend deals with the att

Re: [Xen-devel] [PATCH 4/5] libxc: minios: Introduce abstraction for files[]

2015-02-26 Thread Jürgen Groß
On 02/26/2015 12:56 PM, Wei Liu wrote: From: Ian Jackson We are going to want to reuse this code for NetBSD rump kernels, where there is no gntmap device and we just want to call the MiniOS gntmap code directly. As part of this we want to abstract away the use of files[] inside the actual func

Re: [Xen-devel] [PATCH DOCDAY] netif.h: describe request/response structures in terms of binary layout

2015-02-25 Thread Jürgen Groß
On 02/25/2015 01:16 PM, Ian Campbell wrote: In RFC style, rather than relying on the implicit assumptions of a particular C ABI. I have also confirmed, using the Python gdb extension technique in [0], that the struct offsets (in a Linux binary at least) are the same as described here. I took th

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-02-10 Thread Jürgen Groß
Just found other issues: On 01/19/2015 09:28 AM, Chunyan Liu wrote: Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list assignable usb devices in host - some other helper functions Signed-off-by: Chunyan Liu Signed-off-b

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-02-10 Thread Jürgen Groß
On 01/19/2015 09:28 AM, Chunyan Liu wrote: Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list assignable usb devices in host - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao --- tools/

Re: [Xen-devel] [PATCH RFC V2 4/5] xl: add pvusb commands

2015-02-09 Thread Jürgen Groß
On 01/19/2015 09:28 AM, Chunyan Liu wrote: Add pvusb commands. To attach a usb device to guest through pvusb, one could follow following example: #xl usb-ctrl-attach test_vm version=1 num_ports=8 #xl usb-list test_vm will show the usb controllers and port usage under the domain. #xl u

Re: [Xen-devel] PV USB

2015-02-02 Thread Jürgen Groß
On 02/02/2015 05:59 PM, Vitaly Chernooky wrote: Hi All! What is the current state of PV USB drivers and where can I get actual info about it? I'm working on them. I hope to be able to release them soon, but up to now I haven't been able to identify the cause of a failure I'm hitting occasional

Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Jürgen Groß
On 01/15/2015 09:58 AM, Christian Borntraeger wrote: ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145) Cha

Re: [Xen-devel] [Xen-changelog] [linux-2.6.18-xen] scsifront: avoid acquiring same lock twice if ring is full

2015-01-14 Thread Jürgen Groß
On 01/14/2015 11:22 AM, Xen patchbot-linux-2.6.18-xen wrote: # HG changeset patch # User Juergen Gross # Date 1421228828 -3600 # Node ID 3015a92b2b53825d00dc81c2dd131fc77ce8ab00 # Parent 078f1bb69ea5e3772f3df4b4ee21f3c52e381e51 scsifront: avoid acquiring same lock twice if ring is full The loc

Re: [Xen-devel] [PATCH] x86: xen: mmu: Remove unused function

2015-01-12 Thread Jürgen Groß
On 01/11/2015 11:35 PM, Rickard Strandqvist wrote: Remove the function set_pte_mfn() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Sorry, you seem not to have checked the newest kernel. Used by: xen_do_set_identity_and_remap_chu

Re: [Xen-devel] Question about arch/x86/xen/mmu.c

2014-12-04 Thread Jürgen Groß
On 12/04/2014 10:30 PM, Jan-Simon Moeller wrote: Hi ! My name is Jan-Simon Moeller and I'm looking into compiling the kernel with LLVM/Clang (see llvm.linuxfoundation.org) . Right now we face this issue when compiling with clang: CC arch/x86/xen/mmu.o arch/x86/xen/mmu.c:1343:18: error:

Re: [Xen-devel] [Patch V2] expand x86 arch_shared_info to support linear p2m list

2014-12-01 Thread Jürgen Groß
On 12/01/2014 05:28 PM, Jan Beulich wrote: On 01.12.14 at 15:33, wrote: On 12/01/2014 02:37 PM, Jan Beulich wrote: On 01.12.14 at 14:11, wrote: On 12/01/2014 12:29 PM, Jan Beulich wrote: On 01.12.14 at 12:19, wrote: On 01/12/14 10:15, Jan Beulich wrote: On 01.12.14 at 10:29, wrote: The

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-21 Thread Jürgen Groß
On 11/21/2014 02:26 PM, Andrew Cooper wrote: On 21/11/14 12:57, Juergen Gross wrote: On 11/21/2014 01:23 PM, Jan Beulich wrote: On 14.11.14 at 10:37, <"jgr...@suse.com".non-mime.internet> wrote: --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -224,7 +224,12 @

Re: [Xen-devel] Buggy interaction of live migration and p2m updates

2014-11-21 Thread Jürgen Groß
On 11/21/2014 01:15 PM, Jan Beulich wrote: On 21.11.14 at 12:24, wrote: On Fri, 2014-11-21 at 12:20 +0100, Juergen Gross wrote: On 11/21/2014 12:15 PM, Ian Campbell wrote: On Fri, 2014-11-21 at 11:07 +, Andrew Cooper wrote: On 21/11/14 10:46, Ian Campbell wrote: On Fri, 2014-11-21 at 10

Re: [Xen-devel] [PATCH V6 00/18] x86: Full support of PAT

2014-11-16 Thread Jürgen Groß
On 11/16/2014 02:08 PM, Ingo Molnar wrote: * Juergen Gross wrote: arch/x86/include/asm/cacheflush.h | 38 --- FYI, this series breaks the UML build: In file included from /home/mingo/tip/include/linux/highmem.h:11:0, from /home/mingo/tip/include/linux/pagema

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Jürgen Groß
On 11/14/2014 02:56 PM, Andrew Cooper wrote: On 14/11/14 12:53, Juergen Gross wrote: On 11/14/2014 12:41 PM, Andrew Cooper wrote: On 14/11/14 09:37, Juergen Gross wrote: The x86 struct arch_shared_info field pfn_to_mfn_frame_list_list currently contains the mfn of the top level page frame of t

Re: [Xen-devel] [PATCH] Adjust number of domains in cpupools when destroying domain

2014-11-12 Thread Jürgen Groß
On 11/12/2014 11:46 AM, Andrew Cooper wrote: On 12/11/14 10:40, Juergen Gross wrote: Commit bac6334b51d9bcfe57ecf4a4cb5288348fcf044a (move domain to cpupool0 before destroying it) introduced an error in the accounting of cpupools regarding the number of domains. The number of domains is nor adju

Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

2014-11-11 Thread Jürgen Groß
On 11/11/2014 11:50 AM, David Vrabel wrote: On 11/11/14 10:36, Juergen Gross wrote: On 11/11/2014 11:21 AM, David Vrabel wrote: On 11/11/14 05:43, Juergen Gross wrote: Some functions in arch/x86/xen/p2m.c are used locally only. Make them static. Rearrange the functions in p2m.c to avoid forwar