Re: [Xen-devel] [PATCH for 4.7] libxenvchan: Change license of header from Lesser GPL v2.1 to BSD

2016-06-10 Thread Ian Campbell
On Fri, 2016-06-10 at 09:31 -0400, Konrad Rzeszutek Wilk wrote: > > > So, I guess I don't really undertstand the case for / desire to > > > relicense tools/libvchan/libxenvchan.h, especially given that the > > > other > > > tools/libvchan/*.[ch] files don't appear to be being relicensed > > > in [0

Re: [Xen-devel] [PATCH for 4.7] libxenvchan: Change license of header from Lesser GPL v2.1 to BSD

2016-06-10 Thread Ian Campbell
On Thu, 2016-06-09 at 16:43 +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH for 4.7] libxenvchan: Change > license of header from Lesser GPL v2.1 to BSD"): > > > > As the xen/COPYING file says: > > "A few files are licensed under both GPL and a weaker BSD-style > > license. This

Re: [Xen-devel] Running Xen on Nvidia Jetson-TK1

2016-04-08 Thread Ian Campbell
On Fri, 2016-04-08 at 11:10 +0100, Julien Grall wrote: > > In your patch for *Hacky* support for Jetsok-TK1 you said that you > > were able to run guests on > > Jetson-tk1 board with Xen. Can I know which kernel version you used as > > dom0 (and possibly domU guests)? I'm afraid I don't remember.

Re: [Xen-devel] [SeaBIOS] Xen PV block device support in Seabios

2016-03-19 Thread Ian Campbell
On Wed, 2016-03-16 at 07:33 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 16.03.16 at 14:15, wrote: > > On Wed, Mar 16, 2016 at 12:22:32PM +, Ian Campbell wrote: > > > > > > On Wed, 2016-03-16 at 20:13 +0800, Shanno

Re: [Xen-devel] [SeaBIOS] Xen PV block device support in Seabios

2016-03-19 Thread Ian Campbell
On Wed, 2016-03-16 at 20:13 +0800, Shannon Zhao wrote: > > On 2016/3/16 19:20, Ian Campbell wrote: > > > > (nb, my citrix.com email is no longer valid) > > On Wed, 2016-03-16 at 11:33 +0800, Shannon Zhao wrote: > > > > > > > > > > > Hi,

Re: [Xen-devel] [SeaBIOS] Xen PV block device support in Seabios

2016-03-19 Thread Ian Campbell
(nb, my citrix.com email is no longer valid) On Wed, 2016-03-16 at 11:33 +0800, Shannon Zhao wrote: > Hi, > > I noticed there are some efforts to add Xen PV block device support in > Seabios in a GSoC project and there is a wiki page [1] for it. I found > some patches [2] to add Xenstore R/W suppo

Re: [Xen-devel] [PATCH 4/8] tools/xenalyze: Mark unreachable code as unreachable

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 15:43 +, George Dunlap wrote: > On 25/02/16 15:28, Ian Campbell wrote: > > On Thu, 2016-02-25 at 15:09 +, George Dunlap wrote: > > > On 25/02/16 15:03, Ian Campbell wrote: > > > > On Thu, 2016-02-25 at 14:48 +, George Dunlap wrote:

Re: [Xen-devel] [PATCH 4/8] tools/xenalyze: Mark unreachable code as unreachable

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 15:09 +, George Dunlap wrote: > On 25/02/16 15:03, Ian Campbell wrote: > > On Thu, 2016-02-25 at 14:48 +, George Dunlap wrote: > > > ...so that coverity knows it's unreachable. > > > > I would not be surprised if Coverity starts

Re: [Xen-devel] [PATCH 4/8] tools/xenalyze: Mark unreachable code as unreachable

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 14:48 +, George Dunlap wrote: > ...so that coverity knows it's unreachable. I would not be surprised if Coverity starts complaining about the dead code once this is in place. fprintf + abort is probably what would be wanted to placate it in this case. Ian. > > Signed-o

Re: [Xen-devel] [PATCH] Fix MAINTAINERS: remove any use of {a,b}

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 05:31 -0700, Jan Beulich wrote: > > > > On 25.02.16 at 13:21, wrote: > > This is the complain from perl: > > Unescaped left brace in regex is deprecated, passed through in regex; > > marked > > by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at > > scripts/g

Re: [Xen-devel] Pygrub on ARM64

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 11:12 +, Ian Campbell wrote: > On Thu, 2016-02-25 at 10:53 +0000, Ian Campbell wrote: > > On Thu, 2016-02-25 at 10:47 +0000, Ian Campbell wrote: > > > > > > > > > > > CentOS's first partition is fat to boot on efi sys

Re: [Xen-devel] Pygrub on ARM64

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 10:53 +, Ian Campbell wrote: > On Thu, 2016-02-25 at 10:47 +0000, Ian Campbell wrote: > > > > > > > > CentOS's first partition is fat to boot on efi systems, but it only > > > contains the grub efi binary. All the other partiti

Re: [Xen-devel] Pygrub on ARM64

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 10:47 +, Ian Campbell wrote: > > > > > CentOS's first partition is fat to boot on efi systems, but it only > > contains the grub efi binary. All the other partitions are xfs. Does > > pygrub support it? > > I don't know, b

Re: [Xen-devel] Pygrub on ARM64

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 10:35 +, Stefano Stabellini wrote: > On Thu, 25 Feb 2016, Ian Campbell wrote: > > On Thu, 2016-02-25 at 13:20 +0530, Sanjeev Pandita wrote: > > >   > > > Terminal 3: (manually running the pygrub command) > > > [root@dhcp-194 x

Re: [Xen-devel] Patching error while setting up COLO

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 16:49 +0800, Changlong Xie wrote: > Sorry for this. Since we have no privilege to update the Wiki for a long > time so most contents of this page are dated : ( Anyone can be granted access, it is only a manual process because of spammers. Please create an account and then fi

Re: [Xen-devel] [PATCH] tools: libxl: Simplify logic in libxl__realloc

2016-02-25 Thread Ian Campbell
stack of a specific thread, or they belong to > an ao and are covered by the ctx lock.) > > Signed-off-by: Ian Jackson > Acked-by: Ian Campbell > --- >  tools/libxl/libxl_internal.c |7 ++- >  1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/tool

Re: [Xen-devel] [COVERITY ACCESS] Request for access to Coverity

2016-02-25 Thread Ian Campbell
On Fri, 2016-02-12 at 14:53 +, Stefano Stabellini wrote: > I agree to the conditions in the XenProject Coverity contribution > guidelines [0]. > > I'm a developer working for Citrix Systems UK, Ltd.  I've been active > in the Xen community since 2008; I currently maintain Xen on ARM, Xen > sup

Re: [Xen-devel] New Defects reported by Coverity Scan for XenProject

2016-02-25 Thread Ian Campbell
On Wed, 2016-02-24 at 21:02 -0800, scan-ad...@coverity.com wrote: > Hi, > > Please find the latest report on new defect(s) introduced to XenProject found > with Coverity Scan. > > 2 new defect(s) introduced to XenProject found with Coverity Scan. > 12 defect(s), reported by Coverity Scan earlie

Re: [Xen-devel] Pygrub on ARM64

2016-02-25 Thread Ian Campbell
On Thu, 2016-02-25 at 13:20 +0530, Sanjeev Pandita wrote: >  > Terminal 3: (manually running the pygrub command) > [root@dhcp-194 xen]# export LD_LIBRARY_PATH=/usr/lib > [root@dhcp-194 xen]# mkdir -p /var/run/xen/bootloader.2.d > [root@dhcp-194 xen]# touch /var/run/xen/bootloader.2.out > [root@dhcp

Re: [Xen-devel] Pygrub on ARM64

2016-02-24 Thread Ian Campbell
On Wed, 2016-02-24 at 16:35 +0530, Sanjeev Pandita wrote: > Hi Ian/All, Please don't top post. > If I run the command manually it says OSError: no such file or directory > . > > [root@localhost ~]# /usr/local/lib/xen/bin/pygrub > --args=root=/dev/xvda4 rw console=hvc0 earlyprintk=xen > --output=

[Xen-devel] [PATCH] MAINTAINERS: Remove myself from ARM (incl DT), seabios, tools and The Rest

2016-02-24 Thread Ian Campbell
Signed-off-by: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cd4da04..b320152 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -127,7 +127,6 @@ F: xen/common/sched_arinc653

Re: [Xen-devel] Pygrub on ARM64

2016-02-24 Thread Ian Campbell
On Wed, 2016-02-24 at 15:52 +0530, Sanjeev Pandita wrote: > All, > > Does pygrub work with ARM64 ? It's not arch specific, so it should. > I am trying to boot the CentOS-7-aarch64.img (raw) using pygrub.I am > using the below config file and it is not working. Please post the full "xl -vvv crea

[Xen-devel] [PATCH OSSTEST] coverity: run tests on smoked rather than master.

2016-02-23 Thread Ian Campbell
Wednesday). Signed-off-by: Ian Campbell --- Deployment note, the existing coverity-tested/master branch should be renamed (git branch -m) to coverity-tested/smoked. --- ap-fetch-version | 2 +- ap-fetch-version-old | 2 +- ap-push | 2 +- 3 files changed, 3 insertions(+), 3

[Xen-devel] [PATCH v2 1/2] xl: network-attach: free config object after use

2016-02-23 Thread Ian Campbell
directly from the loop. Compile tested only. CID: 1055902 Signed-off-by: Ian Campbell --- v2: Move NULL assignment here from "xl: free config_data on error in domain_create" where it didn't belong. v1: Not posted. --- tools/libxl/xl_cmdimpl.c | 8 ++-- 1 file change

[Xen-devel] [PATCH v2 2/2] xl: free config_data on error in domain_create

2016-02-23 Thread Ian Campbell
CID: 1055898 Signed-off-by: Ian Campbell --- v2: Move spurious looking NULL assignment to previous patch where it belongs. --- tools/libxl/xl_cmdimpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 9f08f64..514f5a8 100644 --- a

Re: [Xen-devel] [PATCH] loadpolicy: only close polFd if it is valid

2016-02-23 Thread Ian Campbell
On Thu, 2016-02-11 at 11:20 +, Wei Liu wrote: > On Wed, Feb 10, 2016 at 04:32:39PM +0000, Ian Campbell wrote: > > It can be -1 at this point. > > > > CID 1055562 > > Signed-off-by: Ian Campbell > > Acked-by: Wei Li

Re: [Xen-devel] [PATCH] libxl: qmp: ensure qmp read buffer is NULL terminated

2016-02-23 Thread Ian Campbell
On Wed, 2016-02-17 at 11:02 +, Ian Campbell wrote: > Coverity rightly points out that qmp->buffer may not be NULL > terminated when passed to strncat. > > Make the actual buffer a byte bigger than QMP_RECEIVE_BUFFER_SIZE and > always append a NULL byte. > > I suspect

Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-02-23 Thread Ian Campbell
On Wed, 2016-02-17 at 10:39 +, Ian Campbell wrote: > We assert that nullfd if not std{in,out,err} since that would result > in closing one of the just dup2'd fds. For this to happen > std{in,out,err} would have needed to be closed, at which point all > sorts of other thin

Re: [Xen-devel] [PATCH 1/2] xl: uptime: skip dom0 when calling print_domU_uptime

2016-02-23 Thread Ian Campbell
On Wed, 2016-02-17 at 10:34 +, Ian Campbell wrote: > Dom0 is handled separately (via print_dom0_uptime) and the domU > variant doesn't work for dom0 since libxl_vm_get_start_time() doesn't. > > Signed-off-by: Ian Campbell Ping? (and for 2/2 "xl: NULL terminate

Re: [Xen-devel] [OSSTEST PATCH] mg-list-all-branches: avoid mistakenly generating `.' in the output

2016-02-23 Thread Ian Campbell
ce in output right now is just > to remove the erroneous `.' entry. > > Reported-by: Ian Campbell > Signed-off-by: Ian Campbell > Signed-off-by: Ian Jackson LGTM, Acked-by: Ian Campbell > --- >  mg-list-all-branches |9 +++-- >  1 file changed, 7 insert

Re: [Xen-devel] [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-02-23 Thread Ian Campbell
On Mon, 2016-02-22 at 17:29 +0800, Fu Wei wrote: > Hi Julien, > > On 20 February 2016 at 00:28, Julien Grall > wrote: > > Xen is currently crashing because of malformed compatible property for > > the boot module. This is because the property string is not > > null-terminated as requested by the

Re: [Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

2016-02-23 Thread Ian Campbell
On Fri, 2016-02-19 at 12:06 -0700, Jim Fehlig wrote: > On 02/19/2016 10:23 AM, Ian Jackson wrote: > > Jim Fehlig writes ("[PATCH 3/3] docs: add more info about target= in > > disk config"): > > > target= in disk config can be used to convey arbitrary > > > configuration information to backends. Add

[Xen-devel] [PATCH OSSTEST] sg-report-flight: move "started" column to the left in Step table

2016-02-19 Thread Ian Campbell
On the basis that "(stepno,testid,script) started at $time and failed" reads more (chrono)logically. Signed-off-by: Ian Campbell --- sg-report-flight | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index db0d922..99bde92 10

Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 16:08 +, Ian Campbell wrote: >              /* allocate space for the extra config plus two EOLs > > > plus > > > \0 */ > > > @@ -6525,6 +6526,7 @@ int main_networkattach(int argc, char **argv) > > >  } > > >   >

Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 16:02 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH 1/3] xl: free config_data on error in > domain_create"): > > CID: 1055898 > ... > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > index d5a397a.

Re: [Xen-devel] [PATCH v8 05/13] tools/libxc: support to resume uncooperative HVM guests

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 14:43 +, Wei Liu wrote: > On Fri, Feb 19, 2016 at 09:15:38AM -0500, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 18, 2016 at 12:13:36PM +, Wei Liu wrote: > > > On Thu, Feb 18, 2016 at 10:43:15AM +0800, Wen Congyang wrote: > > > > Before this patch: > > > > 1. suspend >

[Xen-devel] [PATCH] MAINTAINERS: Drop myself as xen netback maintainer

2016-02-19 Thread Ian Campbell
Wei has been picking this up for quite a while now. Signed-off-by: Ian Campbell Cc: Wei Liu --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 28eb61b..ef30060 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12013,7 +12013,6 @@ F: arch/arm64

Re: [Xen-devel] [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 11:09 +, Andrew Cooper wrote: > On 19/02/16 11:00, Ian Campbell wrote: > > On Fri, 2016-02-19 at 10:50 +, Andrew Cooper wrote: > > > On 19/02/16 10:40, Wei Liu wrote: > > > > On Thu, Feb 18, 2016 at 10:10:09PM +, Andrew Cooper

Re: [Xen-devel] [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 10:50 +, Andrew Cooper wrote: > On 19/02/16 10:40, Wei Liu wrote: > > On Thu, Feb 18, 2016 at 10:10:09PM +, Andrew Cooper wrote: > > > Signed-off-by: Andrew Cooper > > > --- > > > CC: Jan Beulich > > > CC: Ian Campb

Re: [Xen-devel] Is there a way to get the current PV domain's UUID?

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 12:44 +0200, Razvan Cojocaru wrote: > On 02/19/2016 12:20 PM, Ian Campbell wrote: > > On Fri, 2016-02-19 at 12:10 +0200, Razvan Cojocaru wrote: > > > Hello, > > > > > > Is there a way to get the UUID of a currently running PV d

Re: [Xen-devel] [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 10:40 +, Wei Liu wrote: > On Thu, Feb 18, 2016 at 10:10:09PM +, Andrew Cooper wrote: > > Signed-off-by: Andrew Cooper > > --- > > CC: Jan Beulich > > CC: Ian Campbell > > CC: Ian Jackson > > CC: Wei Liu > > CC

Re: [Xen-devel] libxl and malloc failure (Re: Current LibXL Status)

2016-02-19 Thread Ian Campbell
graft 51 ^ thanks On Thu, 2016-02-18 at 18:15 +, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] Current LibXL Status"): > > There really is a show-stopper, which I have stated before. > > > > Languages such as OCaml use -ENOMEM as a hint to run the garbage > > collector some more

Re: [Xen-devel] [PATCH] docs: document handling of metacharacter escape in xl disk format

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 10:14 +, Ian Campbell wrote: > On Thu, 2016-02-18 at 15:44 -0700, Jim Fehlig wrote: > > Ian Campbell wrote: > > > Signed-off-by: Ian Campbell > > > Cc: Jim Fehlig > > > --- > > >  docs/misc/xl-disk-configuration.txt | 18

Re: [Xen-devel] Is there a way to get the current PV domain's UUID?

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 12:10 +0200, Razvan Cojocaru wrote: > Hello, > > Is there a way to get the UUID of a currently running PV domain, from > within that domain? The type associated with the UUID in the xen public headers is "xen_domain_handle_t" which is presumably why grepping didn't find it f

Re: [Xen-devel] [PATCH] docs: document handling of metacharacter escape in xl disk format

2016-02-19 Thread Ian Campbell
On Thu, 2016-02-18 at 15:44 -0700, Jim Fehlig wrote: > Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > Cc: Jim Fehlig > > --- > >  docs/misc/xl-disk-configuration.txt | 18 ++ > >  1 file changed, 18 insertions(+) > > > > diff

Re: [Xen-devel] Current LibXL Status

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 17:39 +, Ian Campbell wrote: > On Thu, 2016-02-18 at 17:26 +, George Dunlap wrote: > > > According to them, the ocaml garbage collector never frees memory.  It > > grows its own internal heap as necessary, but it never reduces the > > size

Re: [Xen-devel] Current LibXL Status

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 17:26 +, George Dunlap wrote: > According to them, the ocaml garbage collector never frees memory.  It > grows its own internal heap as necessary, but it never reduces the > size of its heap. Assume that's true: Wow! Although, I presume this is a factor of the current/p

Re: [Xen-devel] Current LibXL Status

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 17:19 +, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] Current LibXL Status"): > > So what was the conclusion here?  It looks like we've confirmed that > > exit() is only called: > > > > 1. In the case of a malloc() failure > > 2. in libxl-save-helper (a sep

Re: [Xen-devel] Current LibXL Status

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 17:09 +, George Dunlap wrote: > On Thu, Nov 19, 2015 at 12:16 PM, Ian Campbell > wrote: > > On Thu, 2015-11-19 at 11:55 +, Ian Campbell wrote: > > > On Thu, 2015-11-19 at 11:48 +, Ian Campbell wrote: > > > > On Thu, 2015-11-19 at

[Xen-devel] [PATCH OSSTEST] crontab: adjust to remove "." from mg-list-all-branches output

2016-02-18 Thread Ian Campbell
: . Error! 0- n/an/a Signed-off-by: Ian Campbell --- crontab | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crontab b/crontab index 2cfad74..c8d8cac 100755 --- a/crontab +++ b/crontab @@ -8,7 +8,7 @@ MAILTO=ian.jack...@citrix.com,ian.campb

Re: [Xen-devel] Stabilising some tools only HVMOPs?

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 12:51 +, Wei Liu wrote: > On Wed, Feb 17, 2016 at 05:28:08PM +, Wei Liu wrote: > > Hi all > > > > Tools people are in the process of splitting libxenctrl into a set of > > stable libraries. One of the proposed libraries is libxendevicemodel > > which has a collection

Re: [Xen-devel] [PATCH v3] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-18 Thread Ian Campbell
On Fri, 2016-02-12 at 12:34 +, Wei Liu wrote: > On Fri, Feb 12, 2016 at 04:38:32PM +0530, Harmandeep Kaur wrote: > > Avoid leaking the memory mapping of the trace buffer > > > > Coverity ID 1351228 > > > > Signed-off-by: Harmandeep Kaur > > Reviewed-by: Dario Faggioli > > Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 11:55 +, Andrew Cooper wrote: > On 18/02/16 11:30, Ian Campbell wrote: > > On Thu, 2016-02-11 at 09:23 +0000, Ian Campbell wrote: > > > That is, if gc is not NOGC and ptr is not NULL then ptr must be > > > associated gc. > > > >

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-11 at 09:23 +, Ian Campbell wrote: > That is, if gc is not NOGC and ptr is not NULL then ptr must be > associated gc. > > Currently in this case the new_ptr would not be registered with any > gc, which Coverity rightly points out (in various different place

Re: [Xen-devel] [PATCH V2 0/4] libxl: support qemu's network-based block backends

2016-02-18 Thread Ian Campbell
xml converter. Only rbd supported > is added in this series. Support for other backends such as nbd > and iscsi can be added as a follow-up improvement. All looks good to me, so FWIW: Acked-by: Ian Campbell ___ Xen-devel mailing list

[Xen-devel] [PATCH] docs: document handling of metacharacter escape in xl disk format

2016-02-18 Thread Ian Campbell
Signed-off-by: Ian Campbell Cc: Jim Fehlig --- docs/misc/xl-disk-configuration.txt | 18 ++ 1 file changed, 18 insertions(+) diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index 6a2118d..a03ad10 100644 --- a/docs/misc/xl-disk

Re: [Xen-devel] Stabilising some tools only HVMOPs?

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 10:45 +, Wei Liu wrote: > On Thu, Feb 18, 2016 at 03:37:06AM -0700, Jan Beulich wrote: > > > > > On 18.02.16 at 11:24, wrote: > > > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > > > > The list of tools only HVMOPs used by QEMU are: > > > > > > > >   #define HVMOP_t

Re: [Xen-devel] Stabilising some tools only HVMOPs?

2016-02-18 Thread Ian Campbell
On Thu, 2016-02-18 at 03:31 -0700, Jan Beulich wrote: > > > > On 17.02.16 at 18:28, wrote: > > Hi all > > > > Tools people are in the process of splitting libxenctrl into a set of > > stable libraries. One of the proposed libraries is libxendevicemodel > > which has a collection of APIs that can

Re: [Xen-devel] [PATCH V2 3/3] docs: add more info about target= in disk config

2016-02-18 Thread Ian Campbell
> Signed-off-by: Jim Fehlig Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Stabilising some tools only HVMOPs?

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > Hi all > > Tools people are in the process of splitting libxenctrl into a set of > stable libraries. One of the proposed libraries is libxendevicemodel > which has a collection of APIs that can be used by device model. > > Currently we use QEMU

Re: [Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 10:24 -0700, Jim Fehlig wrote: > > > > > The general concept of escaping metacharaters is not mentioned in this doc > > at all, i.e. there is no mention of which characters need such escaping nor > > of the various "special" codes (\t and \n etc), nor of the octal and hex >

Re: [Xen-devel] [PATCH] tools: remove xenpmd

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 12:05 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 17, 2016 at 02:41:14PM +0000, Ian Campbell wrote: > > It has four instances of the same CID 1198719 (strncpy(..., 32) into a > > 32-byte buffer). > > > > However ever since it was checked in

Re: [Xen-devel] [PATCH] xen/arm64: Make sure we get all debug output

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 17:49 +0100, Dirk Behme wrote: > Could this be applied, then? Yes, sorry, this fell through the cracks somehow. I've applied it to #staging now (from where automated testing will push it into #master). I also added the same change to arm32/head.S and noted that I'd done so i

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 16:47 +, Wei Liu wrote: > On Wed, Feb 17, 2016 at 11:45:58AM -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Feb 17, 2016 at 09:48:28AM +0000, Ian Campbell wrote: > > > On Tue, 2016-02-16 at 17:54 +, Ian Jackson wrote: > > > > Wei Liu wri

[Xen-devel] Uninitialized variables in hvm_event_breakpoint (Re: New Defects reported by Coverity Scan for XenProject)

2016-02-18 Thread Ian Campbell
On Wed, 2016-02-17 at 16:02 -0800, scan-ad...@coverity.com wrote: > Hi, > > Please find the latest report on new defect(s) introduced to XenProject > found with Coverity Scan. > > 1 new defect(s) introduced to XenProject found with Coverity Scan. > 4 defect(s), reported by Coverity Scan earlier,

[Xen-devel] [PATCH OSSTEST] Increase priority of xen-unstable-coverity

2016-02-17 Thread Ian Campbell
e doc. Signed-off-by: Ian Campbell --- README.planner| 3 ++- branch-settings.xen-unstable-coverity | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 branch-settings.xen-unstable-coverity diff --git a/README.planner b/README.planner index d4

[Xen-devel] [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails

2016-02-17 Thread Ian Campbell
Since xch may not be valid (enough) any longer, xc_interface_close already logs anything of any use before it tears down the integrated logger so there is no need to log any further in the application via that path. CID: 1056203 Signed-off-by: Ian Campbell --- tools/xenpaging/xenpaging.c | 6

[Xen-devel] [PATCH] xenpaging: do not leak if --pagefile given twice

2016-02-17 Thread Ian Campbell
By freeing filename (which is either NULL or the previous iteration of this argument). This implements a semantic where the last --pagefile given on the command line takes precedence. This is the same semantic as the other options have. CID: 1198792 Signed-off-by: Ian Campbell --- tools

[Xen-devel] [PATCH] tools: remove xenpmd

2016-02-17 Thread Ian Campbell
well therefore be deleted. The code remains in the git history should anyone one to reanimate it. Searching online shows no references to the use of this tool. Signed-off-by: Ian Campbell --- .gitignore| 1 - .hgignore | 1 - tools/Makefile| 1 - tools

[Xen-devel] [PATCH 2/2] tools: gtracestat: make all functions and global data static

2016-02-17 Thread Ian Campbell
After "Drop unused functions do_cstate and single_cstate helper" make all the remaining functions and global data static and in the process allow the compiler to notice that cond_rec_init() is also unused, thus remove it. Signed-off-by: Ian Campbell --- tools/misc/gtracest

[Xen-devel] [PATCH 1/2] tools: gtracestat: Drop unused functions do_cstate and single_cstate helper

2016-02-17 Thread Ian Campbell
These have always been dead code since the code was added AFAICT. This eliminates the code containing CID 10567079, 10567080, 10567081 and 10567082 (all apparently some confusion between max_cx_num vs MAX_CX_NR, but given the lack of callers its hard to tell what was intended) Signed-off-by: Ian

[Xen-devel] [PATCH 3/3] xl: create: close restore_fd_to_close on error

2016-02-17 Thread Ian Campbell
: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 7ba40c0..514f5a8 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -3069,6 +3069,13 @@ error_out: } out

[Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-17 Thread Ian Campbell
CID: 1055898 Signed-off-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index d5a397a..e819ee6 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -2795,6 +2795,7

[Xen-devel] [PATCH 2/3] xl: use xrealloc in domain create

2016-02-17 Thread Ian Campbell
Using bare realloc risks leaking the old pointer if the realloc fails. Since xrealloc exits on such failures, drop the error handling. Noticed while fixing, but not related to, CID 1055898. Signed-off-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 6 +- 1 file changed, 1 insertion(+), 5

Re: [Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-17 Thread Ian Campbell
On Wed, 2016-02-17 at 12:20 +0100, Roger Pau Monné wrote: > El 16/2/16 a les 18:58, Ian Jackson ha escrit: > > Roger Pau Monne writes ("[PATCH v4 4/4] libxl: fix cd-eject"): > > > Current libxl__device_disk_set_backend implementation tried to guess > > > the > > > backend of devices with format LIB

Re: [Xen-devel] [linux-3.18 test] 82793: regressions - FAIL

2016-02-17 Thread Ian Campbell
On Wed, 2016-02-17 at 01:39 +, osstest service owner wrote: > flight 82793 linux-3.18 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/82793/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >  build-amd64-rumpuserxe

[Xen-devel] [PATCH] libxl: qmp: ensure qmp read buffer is NULL terminated

2016-02-17 Thread Ian Campbell
ile tested only. CID: 1055989 Signed-off-by: Ian Campbell --- tools/libxl/libxl_qmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 714038b..c45702e 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qm

[Xen-devel] [PATCH OSSTEST] mg-show-flight-runvars: avoid "SELECT .. AND TRUE" for sqlite

2016-02-17 Thread Ian Campbell
c5e29f93fb6e "mg-show-flight-runvars: recurse on buildjobs upon request" broke standalone mode with: Error: no such column: TRUE from sqlite. Do as is done for $syntcond and use (1=1) instead. Signed-off-by: Ian Campbell --- mg-show-flight-runvars | 2 +- 1 file changed, 1 inser

[Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-02-17 Thread Ian Campbell
ixing 1130516 would solve this too, but that appears to not have been the case. Compile tested only. [0] http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg02931.html Signed-off-by: Ian Campbell Cc: andrew.coop...@citrix.com --- v2: Assert logfile and nullfd are not stdio fds --- tools/

[Xen-devel] [PATCH 2/2] xl: NULL terminate buf when reading dom0 /proc/uptime

2016-02-17 Thread Ian Campbell
to strtok. In practice this likely doesn't actually cause issues (at least on Linux) because the string should always contain a space so we will stop parsing. CID: 105590 Signed-off-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) dif

[Xen-devel] [PATCH 1/2] xl: uptime: skip dom0 when calling print_domU_uptime

2016-02-17 Thread Ian Campbell
Dom0 is handled separately (via print_dom0_uptime) and the domU variant doesn't work for dom0 since libxl_vm_get_start_time() doesn't. Signed-off-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl

Re: [Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote: > xl/libxl already supports qemu's network-based block backends > such as nbd and rbd. libvirt has supported configuring network > disks for long time too. This series marries the two in the > libxl driver and in the xl<->xml converter. Only rbd

Re: [Xen-devel] [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'

2016-02-17 Thread Ian Campbell
On Wed, 2016-02-17 at 10:05 +, Ian Campbell wrote: > On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: > > When dequoting config strings in xlu__cfgl_dequote(), unknown > > characters following a '\', and the '\' itself, are discarded. > > E.

Re: [Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: > target= in disk config can be used to convey arbitrary > configuration information to backends. Add a bit more info > to xl-disk-configuration.txt to clarify this, including some > simple nbd and rbd qdisk configurations. Missing S-o-b. > ---

Re: [Xen-devel] [PATCH 2/3] docs: fix typo in xl-disk-configuration.txt

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: Missing S-o-b, otherwise: Acked-by: Ian Campbell > --- >  docs/misc/xl-disk-configuration.txt | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/misc/xl-disk-configuration.txt b/do

Re: [Xen-devel] [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: > When dequoting config strings in xlu__cfgl_dequote(), unknown > characters following a '\', and the '\' itself, are discarded. > E.g. a disk configuration string containing > >   rbd:pool/image:mon_host=192.168.0.100\:6789 > > would be dequot

Re: [Xen-devel] [PATCH 0/4] xl: consolidate adhoc parsers

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 23:20 +, Wei Liu wrote: > On Tue, Feb 16, 2016 at 03:09:37PM -0700, Jim Fehlig wrote: > > Wei Liu wrote: > > > This patch series consolidates adhoc parsers in xl. > > > > Hi Wei, > > > > I never tested or reviewed this series after seeing Ian's comments. Did > > you have

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

2016-02-17 Thread Ian Campbell
On Tue, 2016-02-16 at 17:54 +, Ian Jackson wrote: > Wei Liu writes ("[PATCH] MAINTAINERS: add myself as seabios maintainer"): > >  SEABIOS UPSTREAM > >  M: Ian Campbell > > +M: Wei Liu > >  S: Supported > >  T: git git://xenbits.xen.org/seabios.git

Re: [Xen-devel] [PATCH] xl: close nullfd after dup2'ing it to stdin

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 17:45 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH] xl: close nullfd after dup2'ing it to > stdin"): > > Taking care not to do so if nullfd happens (somehow) to have the > same > > fd number as stdin/out/err. > > I thin

[Xen-devel] [PATCH OSSTEST] crontab: Add a coverity run on a Wednesday

2016-02-16 Thread Ian Campbell
In addition to the current Sunday run. Projects of Xen's size are currently allowed 2 builds per week (max 1 per day), so make use of both. Signed-off-by: Ian Campbell --- This change is already live in the production colo --- crontab | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 14:17 +, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: 16 February 2016 14:13 > > To: Paul Durrant; xen-de...@lists.xenproject.org > > Cc: Ian Jackson; Jan Beulich

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 14:02 +, Paul Durrant wrote: > > -Original Message- > [snip] > > > > > > > >   * > > > > > - * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER > > > > > - * -- > > > > > + * NETIF_CTRL_TYPE_SET_HASH_MAPPING_ORDER > > > > > > > >

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 11:02 +, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: 16 February 2016 10:23 > > To: Paul Durrant; xen-de...@lists.xenproject.org > > Cc: Ian Jackson; Jan Beulich

Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 16:04 +, Andrew Cooper wrote: > andrewcoop@andrewcoop:/local/xen.git/xen$ dig -t ANY doe.com > ... > ;; AUTHORITY SECTION: > doe.com.3600INNSns52.domaincontrol.com. > doe.com.3600INNSns51.domaincontrol.com. > > ;; ADDITIONAL SECTION

Re: [Xen-devel] [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 16:13 +, Wei Liu wrote: > On Mon, Feb 15, 2016 at 08:38:02AM -0600, Doug Goldstein wrote: > > Switch from tracking a commit post 1.9.0 to the 1.9.1 release. > > > > Thanks for this patch. > > We can't apply this patch just yet. We need to wait a bit until the > change t

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 09:40 +0100, Gerd Hoffmann wrote: >   Hi, > > > 1.9-stable created now, with the patch above cherry-picked. > > 1.9.1 tagged & tarball uploaded now. Thanks for the heads up! ___ Xen-devel mailing list Xen-devel@lists.xen.org http

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 10:29 +, Wei Liu wrote: > On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote: > > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > > Previously in the three problematic libraries all public headers > were > > > linked to so

[Xen-devel] [PATCH] libxl: close fd's in parent when spawning qdisk

2016-02-16 Thread Ian Campbell
label from "error" to just "out". Compile tested only. CID: 1130518 (null) and 1130517 (logfile_w). Signed-off-by: Ian Campbell --- tools/libxl/libxl_dm.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/li

[Xen-devel] [PATCH] xl: close nullfd after dup2'ing it to stdin

2016-02-16 Thread Ian Campbell
/html/xen-devel/2013-11/msg02931.html Signed-off-by: Ian Campbell Cc: andrew.coop...@citrix.com --- tools/libxl/xl_cmdimpl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index d07ccb2..f38e3dd 100644 --- a/tools/libxl

[Xen-devel] [PATCH] tools: libxl: NULL terminate partially constructed hex string

2016-02-16 Thread Ian Campbell
to placate Coverity. We know this is safe because the allocation to hold the string includes a "+3" for the 0x and the terminating NULL. Compile tested only. CID: 1198708 Signed-off-by: Ian Campbell --- I flip-flopped on just telling Coverity this was a false +ve, but mainly landed on t

  1   2   3   4   5   6   7   8   9   10   >