Re: [Xen-devel] [PATCH 10/12] xen-blkback: Fix indentation

2017-08-18 Thread Hannes Reinecke
GNTMAP_host_map, pages[i]->handle); > pages[i]->handle = BLKBACK_INVALID_HANDLE; > invcount++; > - } > + } > > - return invcount; > + return invcount; > } > > static void xen_blkbk_unmap_and_respond_callback(int res

Re: [Xen-devel] [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-18 Thread Hannes Reinecke
hrough */ > + /* if not online */ > case XenbusStateUnknown: > /* implies xen_blkif_disconnect() via xen_blkbk_remove() */ > device_unregister(&dev->dev); > Oh well, gcc again. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Han

Re: [Xen-devel] [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data

2017-05-23 Thread Hannes Reinecke
c int scsifront_queuecommand(struct Scsi_Host *shost, > int err; > > sc->result = 0; > - memset(shadow, 0, sizeof(*shadow)); > > shadow->sc = sc; > shadow->act = VSCSIIF_ACT_SCSI_CDB; > Reviewed-by: Hannes Reinecke Cheers, Hannes --