Re: [Xen-devel] [PATCH v5 02/29] Replace all occurances of __FUNCTION__ with __func__

2017-11-14 Thread Gerd Hoffmann
avid Alan Gilbert" > Cc: qemu-...@nongnu.org > Cc: qemu-bl...@nongnu.org > Cc: xen-de...@lists.xenproject.org > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Anthony PERARD > Reviewed-by: Juan Quintela Reviewed-by: Gerd Hoffmann ___

Re: [Xen-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Gerd Hoffmann
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. Reviewed-by: Gerd Hoffmann Will this be merged via

Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Gerd Hoffmann
Hi, > It's probably OS specific though. I guess the behaviour changed > because the OS favours absolute pointing devices over relative ones > and how it has two absolute ones to choose from. How it reconciles > those, who knows? Typically hid emulation calls qemu_input_handler_activate() when t

Re: [Xen-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend

2017-09-29 Thread Gerd Hoffmann
#defines > are not pulled into xenfb, and so should remove the compiler > warnings reported. Reviewed-by: Gerd Hoffmann What is the plan with this? Merge through xen queue? I can merge it via ui queue too, but in that case I'd like to get an review from the xen guys. Note: conflic

Re: [Xen-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers

2017-06-08 Thread Gerd Hoffmann
diff --git a/ui/input-legacy.c b/ui/input-legacy.c > index 7159747..fbe1ce7 100644 > --- a/ui/input-legacy.c > +++ b/ui/input-legacy.c > @@ -142,6 +142,18 @@ QEMUPutKbdEntry > *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque) >  return entry; >  } >   > +void qemu_activate_kbd_ev

Re: [Xen-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

2016-09-29 Thread Gerd Hoffmann
Hi, > > Hmm, I think the xen core needs better QOM support ... > > > > struct XenDevice should have a DeviceState element, so it can be used as > > device object directly instead of attaching a device object like > > this ... > > Hmm, interesting idea. The device object could even be added in

Re: [Xen-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

2016-09-27 Thread Gerd Hoffmann
Hi, > struct usbback_info { > struct XenDevice xendev; /* must be first */ > +char id[24]; > +struct USBBACKDevice *dev; > USBBus bus; > void *urb_sring; > void *conn_sring; >

Re: [Xen-devel] [PATCH 1/2] xen: add an own bus for xen backend devices

2016-09-27 Thread Gerd Hoffmann
On Mo, 2016-09-26 at 14:43 +0200, Juergen Gross wrote: > Add a bus for Xen backend devices in order to be able to establish a > dedicated device path for pluggable devices. Looks sane to me. Can take this through the usb queue if I get an ack from xen. > +#define TYPE_XENSYSDEV "xensysdev" > +#d

Re: [Xen-devel] [PATCH 0/2] Xen pvUSB correction

2016-09-27 Thread Gerd Hoffmann
On Mo, 2016-09-26 at 14:43 +0200, Juergen Gross wrote: > Trying to use pvUSB in a Xen guest with a qemu emulated USB controller > will crash qemu as it tries to attach a pvUSB device to the emulated > controller. Hmm. --verbose please. While this clearly doesn't do what you intended I think it s

Re: [Xen-devel] [Qemu-devel] [RFC for 2.8 0/3] Drop support for 64 bit guests on 32 bit hosts

2016-08-10 Thread Gerd Hoffmann
On Di, 2016-08-09 at 16:55 +0100, Alex Bennée wrote: > Hi, > > I'm proposing for the 2.8 cycle we officially drop supporting 64 bit > guests on 32 bit hosts. For most of the KVM targets it doesn't make > any sense anyway and for TCG it makes things harder (e.g. supporting > 64 bit atomics on a 32

[Xen-devel] [PULL 4/6] xen: when removing a backend don't remove many of them

2016-08-03 Thread Gerd Hoffmann
40044-16492-2-git-send-email-jgr...@suse.com Signed-off-by: Gerd Hoffmann --- hw/xen/xen_backend.c | 58 +--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index bab79b1..3ceb778 100644 ---

[Xen-devel] [PULL 6/6] xen: use a common function for pv and hvm guest backend register calls

2016-08-03 Thread Gerd Hoffmann
ckend. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Message-id: 1470119552-16170-1-git-send-email-jgr...@suse.com Signed-off-by: Gerd Hoffmann --- hw/xen/xen_backend.c | 10 ++ hw/xenpv/xen_machine_pv.c| 7 +-- include/hw/xen/xen_backend.h | 1 + xen-

Re: [Xen-devel] [PATCH] xen: use a common function for pv and hvm guest backend register calls

2016-08-02 Thread Gerd Hoffmann
On Di, 2016-08-02 at 08:32 +0200, Juergen Gross wrote: > Instead of calling xen_be_register() for each supported backend type > for hvm and pv guests in their machine init functions use a common > function in order not to have to add new backends twice. > > This at once fixes the error that hvm do

Re: [Xen-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Gerd Hoffmann
On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote: > When unplugging a device in the Xen pvusb backend drain the submit > queue before deallocation of the control structures. Otherwise there > will be bogus memory accesses when I/O contracts are finished. > > Correlated to this issue is the ha

Re: [Xen-devel] Regression with commit 095497ffc66b7f031

2016-07-15 Thread Gerd Hoffmann
On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: > > On 15/07/2016 10:47, Juergen Gross wrote: > > Nothing scaring and no real difference between working and not working > > variant. > > > > Meanwhile I've been digging a little bit deeper and found the reason: > > libxenstore is setting up

[Xen-devel] [PATCH] xen: fix ram init regression

2016-06-24 Thread Gerd Hoffmann
er max-ram-below-4g is zero or not. Reported-by: Anthony PERARD Tested-by: Anthony PERARD Signed-off-by: Gerd Hoffmann --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c | 52 +--- hw/i386/pc_q35.c | 3 +++ xen-hvm.c | 3 +++ 4 files c

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Gerd Hoffmann
On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote: > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > How could xen_ram_init() find out if the value of max-ram-below-4g is > > > the default or if a user have set it?

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Gerd Hoffmann
u give it a spin on xen? thanks, Gerd From d45a95861def18a02e1c26d3717693432517107a Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Thu, 23 Jun 2016 16:49:03 +0200 Subject: [PATCH] xen: fix ram init regression Commit "8156d48 pc: allow raising low memory via max-ram-below-4g op

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-22 Thread Gerd Hoffmann
Hi, > How could xen_ram_init() find out if the value of max-ram-below-4g is > the default or if a user have set it? Is there another way we could fix > this? I guess we'll need a separate variable for that then, something along the lines of "max-ram-below-4g-default". I'll have a look tomorrow

Re: [Xen-devel] [PULL 3/4] xen: add pvUSB backend

2016-06-10 Thread Gerd Hoffmann
On Di, 2016-06-07 at 10:35 +0200, Olaf Hering wrote: > On Mon, May 23, Gerd Hoffmann wrote: > > > +++ b/hw/usb/Makefile.objs > > +common-obj-$(CONFIG_XEN_BACKEND) += xen-usb.o > > +++ b/hw/usb/xen-usb.c > > +usb_bus_new(&usbif->bus, sizeof(usbif->

[Xen-devel] [PULL 2/4] xen: write information about supported backends

2016-05-23 Thread Gerd Hoffmann
evconfig.c move the related functions to hw/xen/xen_backend.c where they fit better. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Wei Liu Message-id: 1463062421-613-3-git-send-email-jgr...@suse.com Signed-off-by: Gerd Hoffmann --- hw/xen/xen_backend.c

[Xen-devel] [PULL 1/4] xen: introduce dummy system device

2016-05-23 Thread Gerd Hoffmann
Reviewed-by: Wei Liu Message-id: 1463062421-613-2-git-send-email-jgr...@suse.com Signed-off-by: Gerd Hoffmann --- hw/xenpv/xen_machine_pv.c| 40 include/hw/xen/xen_backend.h | 1 + 2 files changed, 41 insertions(+) diff --git a/hw/xenpv

[Xen-devel] [PULL 3/4] xen: add pvUSB backend

2016-05-23 Thread Gerd Hoffmann
-send-email-jgr...@suse.com Signed-off-by: Gerd Hoffmann --- hw/usb/Makefile.objs |4 + hw/usb/xen-usb.c | 1080 ++ hw/xenpv/xen_machine_pv.c|3 + include/hw/xen/xen_backend.h |3 + include/hw/xen/xen_common.h |2 + 5

Re: [Xen-devel] [PATCH v5 0/3] usb, xen: add pvUSB backend

2016-05-13 Thread Gerd Hoffmann
On Do, 2016-05-12 at 16:13 +0200, Juergen Gross wrote: > This series adds a Xen pvUSB backend driver to qemu. USB devices > connected to the host can be passed through to a Xen guest. The > devices are specified via Xenstore. Access to the devices is done > via host-libusb.c > > I've tested the ba

Re: [Xen-devel] [PATCH v4 0/3] usb, xen: add pvUSB backend

2016-05-12 Thread Gerd Hoffmann
On Do, 2016-05-12 at 07:47 +0200, Juergen Gross wrote: > This series adds a Xen pvUSB backend driver to qemu. USB devices > connected to the host can be passed through to a Xen guest. The > devices are specified via Xenstore. Access to the devices is done > via host-libusb.c > > I've tested the ba

Re: [Xen-devel] [SeaBIOS] Xen PV block device support in Seabios

2016-03-19 Thread Gerd Hoffmann
Hi, > > Ian, thanks for your reply! It looks like the problem is how and when to > > clear PV resources in seabios before handing over to guest. But I wonder > > why virtio works in seabios. Does seabios using virtio need to clear > > things like vrings? Or seabios doesn't clear the things and g

Re: [Xen-devel] [PATCH v2 0/2] usb, xen: add pvUSB backend

2016-03-19 Thread Gerd Hoffmann
On Do, 2016-03-10 at 16:19 +0100, Juergen Gross wrote: > This series adds a Xen pvUSB backend driver to qemu. USB devices > connected to the host can be passed through to a Xen guest. The > devices are specified via Xenstore. Access to the devices is done > via host-libusb.c > I've tested the back

Re: [Xen-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-09 Thread Gerd Hoffmann
Hi, > +/* Here we just expose minimal host bridge offset subset. */ > +static const IGDHostInfo igd_host_bridge_infos[] = { > +{0x08, 2}, /* revision id */ > +{0x2c, 2}, /* sybsystem vendor id */ > +{0x2e, 2}, /* sybsystem id */ Can anyone clarify where this comes from? Setting

[Xen-devel] [PATCH v4 0/8] igd passthrough chipset tweaks

2016-03-08 Thread Gerd Hoffmann
e cleanups + bugfixes on top of that still make sense though. So here we go with a stripped down patch series ... cheers, Gerd Gerd Hoffmann (8): pc: remove has_igd_gfx_passthru global pc: move igd support code to igd.c igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to rea

[Xen-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-08 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini --- default-configs/x86_64-softmmu.mak | 1 + hw/pci-host/Makefile.objs

[Xen-devel] [PATCH v4 3/8] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2016-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini --- hw/pci-host/igd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 331e9e1..93b86ca 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -56,7 +56,7

[Xen-devel] [PATCH v4 6/8] igd: revamp host config read

2016-03-08 Thread Gerd Hoffmann
-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 65 ++- 1 file changed, 26 insertions(+), 39 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 8a8b37b..5c4a008 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -20,40

[Xen-devel] [PATCH v4 7/8] igd: move igd-passthrough-isa-bridge to igd.c too

2016-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 113 -- hw/pci-host/igd.c | 108 +++ 2 files changed, 108 insertions(+), 113 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Xen-devel] [PATCH v4 8/8] igd: handle igd-passthrough-isa-bridge setup in realize()

2016-03-08 Thread Gerd Hoffmann
code, and should be more robust as we don't have to maintain the id table to keep things going. Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c| 115 +-- hw/xen/xen_pt.c | 4 +- include/hw/i386/pc.h | 2 +- 3 files changed, 30 in

[Xen-devel] [PATCH v4 4/8] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2016-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 93b86ca..3654298 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -56,12 +56,32 @@ out

[Xen-devel] [PATCH v4 5/8] igd: use defines for standard pci config space offsets

2016-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini --- hw/pci-host/igd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 3654298..8a8b37b 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -11,9 +11,9

[Xen-devel] [PATCH v4 1/8] pc: remove has_igd_gfx_passthru global

2016-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini Reviewed-by: Eduardo Habkost --- hw/i386/pc_piix.c | 2 +- hw/xen/xen_pt.h | 5 +++-- vl.c | 10 -- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-02-15 Thread Gerd Hoffmann
Hi, > 1.9-stable created now, with the patch above cherry-picked. 1.9.1 tagged & tarball uploaded now. cheers, Gerd ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Gerd Hoffmann
Hi, > > I'd have qemu copy the data on 0xfc write then, so things continue to > > work without updating seabios. So, the firmware has to allocate space, > > reserve it etc., and programming the 0xfc register. Qemu has to make > > sure the opregion appears at the address written by the firmwar

Re: [Xen-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Gerd Hoffmann
Hi, > +realloc: > +opregion = malloc_high(size * 1024); memalign_high(PAGE_SIZE, size * 1024); > > I'd have qemu copy the data on 0xfc write then, so things continue to > > work without updating seabios. So, the firmware has to allocate space, > > reserve it etc., and programming the 0xf

Re: [Xen-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Gerd Hoffmann
Hi, > Thanks for the tip that seabios allocated pages automatically become > e820 reserved, that simplifies things a bit. It's common practice for all firmware. The e820 table from qemu is just a starting point, it is not passed on to the guest os as-is. All permanent allocations (acpi tables

Re: [Xen-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-01-28 Thread Gerd Hoffmann
Hi, > 1) The OpRegion MemoryRegion is mapped into system_memory through > programming of the 0xFC config space register. > a) vfio-pci could pick an address to do this as it is realized. > b) SeaBIOS/OVMF could program this. > > Discussion: 1.a) Avoids any BIOS dependency, but vfio-pci would

Re: [Xen-devel] [Spice-devel] Developers for virgl 3d windows guest support

2016-01-28 Thread Gerd Hoffmann
Hi, > About virtio-gpu using virgl3d project for 3d hw acceleration support > and is what I mainly watching for its large gpu choice/support, seems > any gpu that have a drm driver in host kernel is supported by virgl, or > I'm wrong? You need a mesa driver too. But, yes, pretty much any mo

Re: [Xen-devel] [Qemu-devel] [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2016-01-25 Thread Gerd Hoffmann
Hi, > > static void igd_passthrough_i440fx_class_init(ObjectClass *klass, void > > *data) > > @@ -78,7 +77,7 @@ static void igd_passthrough_i440fx_class_init(ObjectClass > > *klass, void *data) > > DeviceClass *dc = DEVICE_CLASS(klass); > > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass

Re: [Xen-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2016-01-20 Thread Gerd Hoffmann
ginal realize function. It's better than a > static variable. How does the attached patch (incremental fix, not tested yet) look like? cheers, Gerd From 3d110e297b5182107e055db3ab69092affdef5bb Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 20 Jan 2016 10:08:19 +0100 Subj

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-01-15 Thread Gerd Hoffmann
Hi, > It's been suggested (by you :)) that > 76327b9f32a009245c215f4a3c5d58a01b5310ae be cherry-picked into 1.9.1 as > well, perhaps. Yes, right. Thanks for the reminder. Picked up. cheers, Gerd ___ Xen-devel mailing list Xen-devel@lists.xen.or

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-01-14 Thread Gerd Hoffmann
On Do, 2016-01-14 at 14:50 +, Ian Campbell wrote: > Hello, > > The xen.git development branch currently points to SeaBIOS rel-1.9.0, but > Roger has tripped over a build issue which is fixed by 3b8c5378dfe2 "build: > fix typo in buildversion.py". > > Is there any plan for either a 1.9.1 or a

Re: [Xen-devel] [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Gerd Hoffmann
On Di, 2016-01-12 at 09:50 +, Hao, Xudong wrote: > With latest qemu 7b8a354d4716, RHEL7.2 (with default kernel) VM still can't > boot up with IGD. There is another bug, using pci_default_write_config() doesn't fly as this checks writes against wmask and the registers in question are not white

Re: [Xen-devel] [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Gerd Hoffmann
Hi, > I can boot up Linux VM with IGD pass-through with latest qemu (without > any additional patch), guest run 3D "nexuiz" and get 180fps. That is a pretty recent linux guest I assume? Tried older kernels too, possibly even the old userspace xorg driver? Do windows guest work as well? cheers

Re: [Xen-devel] [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Gerd Hoffmann
Hi, > > That is true. Given that the only qemu-xen codebase with igd support is > > 4.7 and 4.7 hasn't been released yet, I am OK with changing the guest > > visible PCI layout. I might ask for your help in backporting the patches > > ;-) What are the 4.7 release plans btw? > One thing that I

Re: [Xen-devel] [PATCH v3 10/11] igd: handle igd-passthrough-isa-bridge setup in realize()

2016-01-06 Thread Gerd Hoffmann
On Mi, 2016-01-06 at 15:29 +, Stefano Stabellini wrote: > On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > > That way a simple '-device igd-passthrough-isa-bridge,addr=1f' will > > do the setup. > > Is this going to change the QEMU command line arguments to use it?

Re: [Xen-devel] [PATCH v3 07/11] igd: revamp host config read

2016-01-06 Thread Gerd Hoffmann
> > +for (i = 0; i < len; i++) { > > +rc = pread(config_fd, guest->config + list[i].offset, > > + list[i].len, list[i].offset); > > +if (rc != list[i].len) { > > pread is allowed to return early, returning the number of bytes read. > This is a sysfs file tho

Re: [Xen-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2016-01-06 Thread Gerd Hoffmann
> > > > +static void (*i440fx_realize)(PCIDevice *pci_dev, Error **errp); > > static void igd_pt_i440fx_realize(PCIDevice *pci_dev, Error **errp) > > { > > +Error *err = NULL; > > uint32_t val = 0; > > int rc, i, num; > > int pos, len; > > Can't we get the parent PCIDeviceCl

[Xen-devel] [PATCH v3 08/11] igd: add q35 support

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 41 - hw/pci-host/q35.c | 6 +- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ec48875..f6e3f7a 100644 --- a/hw/pci-host/igd.c +++ b/hw

[Xen-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index d1eeafb..6f52ab1 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,12 +53,20 @@ out: return ret; } +static void

[Xen-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-05 Thread Gerd Hoffmann
ch to just turn off all igd passthru chipset tweaks. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 6 ++ hw/xen/xen_pt.c | 14 -- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f36222e..2afbbd3 100644 ---

[Xen-devel] [PATCH v3 01/11] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2016-01-05 Thread Gerd Hoffmann
reason to add that option to kvm guests in the first place. Signed-off-by: Gerd Hoffmann Reviewed-by: Eduardo Habkost Reviewed-by: Stefano Stabellini --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Xen-devel] [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ef0273b..d1eeafb 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,7 +53,7 @@ out: return ret; } -static

[Xen-devel] [PATCH v3 03/11] pc: move igd support code to igd.c

2016-01-05 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini --- hw/pci-host/Makefile.objs | 3 ++ hw/pci-host/igd.c | 96

[Xen-devel] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-01-05 Thread Gerd Hoffmann
in v2: * Added igd-passthrough-isa-bridge support form kvm. * Added patch to drop has_igd_gfx_passthru. cheers, Gerd Gerd Hoffmann (11): pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen pc: remove has_igd_gfx_passthru global pc: move igd support code to

[Xen-devel] [PATCH v3 09/11] igd: move igd-passthrough-isa-bridge to igd.c too

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 113 -- hw/pci-host/igd.c | 108 +++ 2 files changed, 108 insertions(+), 113 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Xen-devel] [PATCH v3 02/11] pc: remove has_igd_gfx_passthru global

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/xen/xen_pt.h | 5 +++-- vl.c| 10 -- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index 3749711..cdd73ff 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -4,6 +4,7 @@ #include

[Xen-devel] [PATCH v3 06/11] igd: use defines for standard pci config space offsets

2016-01-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 6f52ab1..0784128 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -10,9 +10,9 @@ typedef struct { /* Here we just

[Xen-devel] [PATCH v3 10/11] igd: handle igd-passthrough-isa-bridge setup in realize()

2016-01-05 Thread Gerd Hoffmann
code, and should be more robust as we don't have to maintain the id table to keep things going. Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c| 115 +-- hw/xen/xen_pt.c | 2 +- include/hw/i386/pc.h | 2 +- 3 files changed, 30 in

[Xen-devel] [PATCH v3 07/11] igd: revamp host config read

2016-01-05 Thread Gerd Hoffmann
still requires root priviledges because linux refuses to allow non-root users access pci config space above offset 0x50. Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 65 +++ 1 file changed, 27 insertions(+), 38 deletions(-) diff --git

Re: [Xen-devel] [PATCH v2 02/10] pc: remove has_igd_gfx_passthru global

2015-12-17 Thread Gerd Hoffmann
.h:325:29: error: request for member ‘igd_gfx_passthru’ in > something not a structure or union > return (qdev_get_machine->igd_gfx_passthru Incremental fix attached (will squash into v2). cheers, Gerd From b30226140f80202c4d2dda23acae9533aba6136b Mon Sep 17 00:00:00 2001 From: G

[Xen-devel] [PATCH v2 05/10] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index d1eeafb..6f52ab1 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,12 +53,20 @@ out: return ret; } +static void

[Xen-devel] [PATCH v2 07/10] igd: revamp host config read

2015-12-14 Thread Gerd Hoffmann
still requires root priviledges because linux refuses to allow non-root users access pci config space above offset 0x50. Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 65 +++ 1 file changed, 27 insertions(+), 38 deletions(-) diff --git

[Xen-devel] [PATCH v2 09/10] igd: move igd-passthrough-isa-bridge to igd.c too

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 113 -- hw/pci-host/igd.c | 108 +++ 2 files changed, 108 insertions(+), 113 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Xen-devel] [PATCH v2 02/10] pc: remove has_igd_gfx_passthru global

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/xen/xen_pt.h | 3 +-- vl.c| 10 -- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index c545280..6d8702b 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -320,10 +320,9 @@ extern void

[Xen-devel] [PATCH v2 08/10] igd: add q35 support

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 41 - hw/pci-host/q35.c | 6 +- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ec48875..f6e3f7a 100644 --- a/hw/pci-host/igd.c +++ b/hw

[Xen-devel] [PATCH v2 10/10] igd: handle igd-passthrough-isa-bridge setup in realize()

2015-12-14 Thread Gerd Hoffmann
it when it finds a igd device (i.e. vfio-pci for kvm). It's a bit ugly though, and it also has the problem that pc and q35 machine types have different needs here. (3) Let machine init do it in case igd-passthru=on is set. Signed-off-by: Gerd Hoffmann

[Xen-devel] [PATCH v2 06/10] igd: use defines for standard pci config space offsets

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 6f52ab1..0784128 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -10,9 +10,9 @@ typedef struct { /* Here we just

[Xen-devel] [PATCH v2 03/10] pc: move igd support code to igd.c

2015-12-14 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini --- hw/pci-host/Makefile.objs | 3 ++ hw/pci-host/igd.c | 96

[Xen-devel] [PATCH v2 04/10] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ef0273b..d1eeafb 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,7 +53,7 @@ out: return ret; } -static

[Xen-devel] [PATCH v2 00/10] igd passthrough chipset tweaks

2015-12-14 Thread Gerd Hoffmann
Added patch to drop has_igd_gfx_passthru. TODO: * Possibly handle igd-passthrough-isa-bridge automatically (see patch 10). * Figure a way to handle the opregion, probably via vfio extension. Beyond the scope of this patch series, but probably needed to make laptop panels work correctly

[Xen-devel] [PATCH v2 01/10] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-14 Thread Gerd Hoffmann
reason to add that option to kvm guests in the first place. Signed-off-by: Gerd Hoffmann Reviewed-by: Eduardo Habkost Reviewed-by: Stefano Stabellini --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Xen-devel] [PATCH] ehci: make idt processing more robust

2015-12-14 Thread Gerd Hoffmann
Make ehci_process_itd return an error in case we didn't do any actual iso transfer because we've found no active transaction. That'll avoid ehci happily run in circles forever if the guest builds a loop out of idts. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 5 +++--

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-12-04 Thread Gerd Hoffmann
Hi, > btw some questions here: > > for non-gl and gl rendering in Qemu, are they based on dma-buf already? > once we can export guest framebuffer in dma-buf, is there additional work > required or just straightforward to integrate with SPICE? Right now we are busy integrating dma-buf support

[Xen-devel] [PATCH for-2.5] vnc: fix segfault

2015-11-24 Thread Gerd Hoffmann
eported-by: Anthony PERARD Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index c9f2fed..7538405 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -931,6 +931,11 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl, int i, x, y,

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-24 Thread Gerd Hoffmann
Hi, > But there's some work to add generic mmap support to dma-bufs, and for > really simple case (where we don't have a gl driver to handle the dma-buf > specially) for untiled framebuffers that would be all we need? Not requiring gl is certainly a bonus, people might want build qemu without o

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-24 Thread Gerd Hoffmann
Hi, > > Yes, vGPU may have additional features, like a framebuffer area, that > > aren't present or optional for direct assignment. Obviously we support > > direct assignment of GPUs for some vendors already without this feature. > > For exposing framebuffers for spice/vnc I highly recommend a

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-20 Thread Gerd Hoffmann
Hi, > > iGVT-g_Setup_Guide.txt mentions a "Indirect Display Mode", but doesn't > > explain how the guest framebuffer can be accessed then. > > You can check "fb_decoder.h". One thing to clarify. Its format is > actually based on drm definition, instead of OpenGL. Sorry for > that. drm is fine.

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Gerd Hoffmann
Hi, > > Another area of extension is how to expose a framebuffer to QEMU for > > seamless integration into a SPICE/VNC channel. For this I believe we > > could use a new region, much like we've done to expose VGA access > > through a vfio device file descriptor. An area within this new > > fra

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Gerd Hoffmann
Hi, > > I'm trying to follow this discussion as best as I am able, but my lack > > of experience with Xen prevents me from really participating in a > > meaningful way. > > > > (I see that Laszlo is still discussing some CD-ROM issues with Fabio > > which may be of interest to me...) > > > > A

Re: [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

2015-09-09 Thread Gerd Hoffmann
> > Why multiple small iovecs instead of one big iovec? > > The guest buffer might span multiple physical non contiguous pages. Sure, thats why we have iovecs in the first place. > I > don't want to copy data to a new buffer due to performance reasons > (there is already at least one copy opera

Re: [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

2015-09-09 Thread Gerd Hoffmann
Hi, > > So, the signaling needs to be different. The host adapter needs to > > signal somehow that it can handle async iso packets. One way would be > > to flag this per usb bus, another one per usb packet. Also all xen > > naming and the xen inlude should go away. BTW: does this build witho

Re: [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

2015-09-04 Thread Gerd Hoffmann
On Do, 2015-09-03 at 12:45 +0200, Juergen Gross wrote: > When Xen is using the qemu usb framework for pure passthrough of I/Os > to host devices the handling of isoc jobs is rather complicated if > multiple isoc frames are transferred with one call. > > Instead of calling the framework with each f

Re: [Xen-devel] [Patch RFC 1/4] usb: support device specification via -

2015-07-17 Thread Gerd Hoffmann
Hi, > > device_add monitor command. > > Okay. I guess the USBDevice for the added device can be obtained > in USBPortOps->attach via USBPort->dev ? Yes. > Doing a quick search through the sources I couldn't find a way to > issue a monitor command from inside qemu. I assume I'd have to use > d

Re: [Xen-devel] [Patch RFC 2/4] usb: add flag to USBPacket to request complete callback after isoc transfer

2015-07-17 Thread Gerd Hoffmann
> > --- a/hw/usb/host-libusb.c > > +++ b/hw/usb/host-libusb.c > > @@ -451,6 +451,7 @@ static void usb_host_req_complete_iso(struct > > libusb_transfer *transfer) > > } > > if (xfer->ring->ep->pid == USB_TOKEN_IN) { > > QTAILQ_INSERT_TAIL(&xfer->ring->copy, xfer, next); > > +

Re: [Xen-devel] [Patch RFC 1/4] usb: support device specification via -

2015-07-17 Thread Gerd Hoffmann
On Fr, 2015-07-17 at 09:32 +0200, Juergen Gross wrote: > On 07/17/2015 08:59 AM, Gerd Hoffmann wrote: > > On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote: > >> Today a host usb device can be specified either via : > >> or via . syntax. Add the possibility to speci

Re: [Xen-devel] [Patch RFC 2/4] usb: add flag to USBPacket to request complete callback after isoc transfer

2015-07-17 Thread Gerd Hoffmann
On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote: > In order to avoid having to poll for the result of an iso transfer > add the possibility to request the "complete" callback which is being > used for bulk transfers as well. Sorry for the late notice (didn't do much usb coding recently and f

Re: [Xen-devel] [Patch RFC 1/4] usb: support device specification via -

2015-07-17 Thread Gerd Hoffmann
On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote: > Today a host usb device can be specified either via : > or via . syntax. Add the possibility to specify it via > - as this is needed for the support of xen pvusb backend. -device usb-host,hostbus=,hostport= should already do what you want.

Re: [Xen-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-21 Thread Gerd Hoffmann
On Mi, 2015-01-21 at 11:37 +, Ian Jackson wrote: > Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to > support IGD GFX passthrough"): > > When we're working to support IGD GFX passthrough with qemu > > upstream, instead of "-gfx_passthru" we'd like to make that > > a mac