Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
On Wed, 2015-04-22 at 19:37 +0200, Luis R. Rodriguez wrote: > On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote: > > On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > > > On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > > > > On

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > > On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: > > > > This: > > > + /* MTRR was used if this is non-zero */ > > > +

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
s_wc_add(pioaddr, piolen); > + if (dd->wc_cookie < 0) > + ret = -EINVAL; don't agree on what wc_cookie will be on error. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description