Hi,
This is great!
I don’t know if the protocol requires it, but if so then
Acked-by: David Scott mailto:d...@recoil.org>>
Cheers,
Dave
> On 17 Oct 2017, at 18:44, Ian Jackson wrote:
>
> oxenstored is our default implementation of xenstore, for platforms
> that have ocaml
gt;
> Reviewed-by: Wei Liu
>
Under the assumption that the generated code still compiles ;-) looks ok to me
too.
Acked-by: David Scott
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
rk correctly. So this command is useless and should be removed.
>>
>> In order to avoid problems in the future remove all support for
>> XS_RESTRICT from xenstore.
>>
>> Signed-off-by: Juergen Gross
>
> Adding Dave Scott to Cc: list.
Looks fine to me:
Acked-by:
> On 24 Jan 2017, at 11:35, Ian Jackson wrote:
>
> Ian Jackson writes ("[PATCH 0/2] ocaml: Start on fixing brokenness when no
> ocamlopt"):
>> Debian jessie arm64 has Ocaml (in the package `ocaml-nox') but the
>> package lacks ocamlopt.
> ...
>> This does not actually fix the real problem. I'm
> On 18 Jan 2017, at 15:23, Wei Liu wrote:
>
> On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote:
>> On 18/01/17 13:33, Juergen Gross wrote:
>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>> The aim is to test for correctness and performance.
This is a great
7;t unconditionally true.
>>
>> In principle, the check could be changed to 'proposed_id == 0x7fff' which
>> would still allow for 2 billion transaction in 32bit builds. However, in
>> 64bit builds, this reintroduce
after
> that, the chance is at most 20 (the default open transaction quota) in 2
> billion.
That makes sense to me. There seems little chance of the hash table filling up
when the quota is set to 20 :-)
Acked-by: David Scott
Cheers,
Dave
>
> Signed-off-by: Andrew Cooper
&
he
>> xenstore daemon by specifying the appropriate flags in the service
>> file.
>>
>> A rerun of autogen.sh is required.
>>
>> Signed-off-by: Juergen Gross
>
> Acked-by: Wei Liu
>
> The ocaml bits
> In any case we use these old Debian suites when testing old Xen
> branches, which were (when they were current) built without ocaml.
>
> This partially reverts "ts-xen-build-prep: Install Ocaml" bbe1a9b2a6c0.
>
> Signed-off-by: Ian Jackson
> CC: Andrew Cooper
enstored.ml
> @@ -81,7 +81,7 @@ let config_filename cf =
> | Some name -> name
> | None -> Define.default_config_dir ^ "/oxenstored.conf"
>
> -let default_pidfile = "/var/run/xenstored.pid"
> +let default_pidfile = Paths.xen_run_dir ^ "/xens
> On 14 Jun 2016, at 10:36, Wei Liu wrote:
>
> On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote:
>>
>>> On 13 Jun 2016, at 16:22, Wei Liu wrote:
>>>
>>> On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote:
>>>>
> On 13 Jun 2016, at 08:49, Wei Liu wrote:
>
> Generate a _paths.h for that and add proper dependency.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Ian Jackson
> Cc: David Scott
> ---
> .gitignore| 1 +
> tools/ocaml/xenstored/Makefile
> On 13 Jun 2016, at 08:49, Wei Liu wrote:
>
> Only contain changes to ocaml source code. C stub files will be handled
> separately.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Ian Jackson
> Cc: David Scott
> ---
> tools/ocaml/xenstored/define.ml| 6 +++--
+let daemon_socket = Paths.xen_run_stored ^ "/socket"
>
> (** Throws this rather than a miscellaneous Unix.connect failed *)
> exception Failed_to_connect
> --
> 2.1.4
>
This looks fine to me
Acked-by: David Scott
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
alified to review this.
>>
>
> David gave his ack to a similar path so I presume he will be fine with
> this, too.
>
> I will wait for his ack anyway.
Looks fine to me.
Acked-by: David Scott
Cheers,
Dave
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Looks fine to me:
Acked-by: David Scott
> On 10 Jun 2016, at 15:25, Wei Liu wrote:
>
> That file includes all paths generated by configure. It will be used to
> get rid of hard-coded paths in code.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Ian Jackson
> Cc: David
Hi,
Rather than
(String.concat “” [a; b])
it’s simpler to write
(a ^ b)
With that small change,
Acked-by: David Scott
Cheers,
Dave
> On 10 Jun 2016, at 19:44, Wei Liu wrote:
>
> CC Dave's correct email address.
>
> On Fri, Jun 10, 2016 at 03:25:46PM +0100,
.sh.
>>
>> Signed-off-by: Wei Liu
>> ---
>> Cc: Ian Jackson
>> Cc: David Scott
>
> You should mention that autogen.sh should be rerun.
>
> Acked-by: Ian Jackson
>
>> There are two hard-coded paths in logging.ml, but I'm not sure if
>> ge
> On 22 Apr 2016, at 16:26, Ian Jackson wrote:
>
> This will result in the Xen build system building, and then
> preferring, oxenstored.
>
> Signed-off-by: Ian Jackson
> CC: David Scott
> CC: Wei Liu
This looks good to me too.
Reviewed-by: David Scott
> ---
> On 29 Mar 2016, at 17:38, Wei Liu wrote:
>
> On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote:
>> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote:
>>> On 03/24/2016 06:49 PM, Andrew Cooper wrote:
On 24/03/2016 22:22, Boris Ostrovsky wrote:
> On 03/17/201
> On 16 Mar 2016, at 18:23, Wei Liu wrote:
>
> On Tue, Mar 15, 2016 at 03:35:17PM +, Andrew Cooper wrote:
>> And provide stubs for toolstack use.
>>
>> Signed-off-by: Andrew Cooper
>> ---
>> CC: Jan Beulich
>> CC: Tim Deegan
>> CC: Wei
>>> refactoring
>>> and addition of infrastructure that allows for transactions to be replayed.
>>> The
>>> seventh patch adds some extra logging.
>>
>> All the patches have quite the Reviewed-by list already so I would think
>> these can go in
re than one word in the future.
>
> Since the tests are pure ocaml (no C components) CFLAGS and
> LIBS_xenlight are not required.
>
> Signed-off-by: Ian Campbell
> Cc: David Scott
Looks fine to me:
Acked-by: David Scott
Cheers,
Dave
> ---
> v6: New patch
> ---
>
> On 26 Nov 2015, at 12:11, Wei Liu wrote:
>
> Dave, ping?
Sorry, completely forgot about this email.
Looks totally fine to me!
Acked-by: David Scott
Cheers,
Dave
>
> On Mon, Nov 16, 2015 at 12:43:19PM +, Wei Liu wrote:
>> According to public/sched.h, there is
gt;
>> In addition, correct the error detection. It is a hard error if the
>> producer index gets more than a ring size ahead of the consumer, or if
>> the consumer ever overtakes the producer.
>>
>> Signed-off-by: Andrew Cooper
>
> Reviewed-by: Samuel Thibault
to
‘control/shutdown’ in xenstore and legal arguments to `xc_domain_shutdown` and
`SCHEDOP_shutdown`?
Anyway you’re clearly right, `Watchdog` is the 5th value. So I think this is
fine.
Acked-by: David Scott
I happen to notice there’s a type with the same name in “xenopsd”[1], so I’ve
cc:d xen-
> On 27 Oct 2015, at 17:31, Andrew Cooper wrote:
>
> On 27/10/15 17:28, Samuel Thibault wrote:
>> Andrew Cooper, le Tue 27 Oct 2015 17:21:39 +, a écrit :
>>> as the second attempted write could return short as well.
>> That is fine. The second attempt will only return a short write if there
Hi,
> On 27 Oct 2015, at 15:37, Wei Liu wrote:
>
> Hi Dave
>
> We discovered an issue in oxenstored: when it writes to the ring, it writes
> a chunk of contiguous data. When it tries to write across ring boundary,
> it returns a short-write. That leads to stalling mini-os's xenbus ring.
>
> Sa
> On 2 Sep 2015, at 11:57, Ian Campbell wrote:
>
> On Wed, 2015-09-02 at 11:04 +0100, David Scott wrote:
>> From: David Scott
>>
>> Replace my sometimes unreliable address with
>> my reliable permanent address.
>>
>
> I'd add (assuming
From: David Scott
Replace my sometimes unreliable address with
my reliable permanent address.
Signed-off-by: David Scott
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 73a96c9..a7fad84 100644
--- a/MAINTAINERS
+++ b
Hi All,
I think you are looking for dave.sc...@citrix.com - cc'd
-Original Message-
From: Jan Beulich [mailto:jbeul...@suse.com]
Sent: 02 September 2015 09:26
To: car...@cardoe.com; David Scott (Sales UK)
Cc: xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] MAINTAINERS
31 matches
Mail list logo
