Re: [Xen-devel] [PATCH] ocaml/xs: prefer using character device

2015-09-02 Thread Dave Scott
Looks fine to me. Acked-by: David Scott > On 1 Sep 2015, at 19:34, Doug Goldstein wrote: > > Since 9c89dc95201ffed5fead17b35754bf9440fdbdc0 libxenstore prefers using > /dev/xen/xenbus over /proc/xen/xenbus. This makes the OCaml xenstore > library contain the same preference. > > Signed-off-by

Re: [Xen-devel] [PATCH for-4.6 5/5] oxenstored: move sd_notify_ready out of main loop

2015-08-06 Thread Dave Scott
Although I’m not familiar with systemd, this also looks fine: Acked-by: David Scott > On 6 Aug 2015, at 14:38, Wei Liu wrote: > > Oxenstored only needs to notify systemd its readiness state once. Move > sd_notify_ready out of main loop. > > Signed-off-by: Wei Liu >

Re: [Xen-devel] [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation

2015-08-06 Thread Dave Scott
booted_by_systemd to avoid confusion with systemd's > API. > > Signed-off-by: Wei Liu > --- > Cc: Dave Scott > > For 4.6: without this oxenstored is broken when running on a system with > systemd but not started by systemd. > --- > tools/ocaml/xenstored/syste

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Dave Scott
> On 23 Jul 2015, at 09:38, Andrew Cooper wrote: > > On 23/07/2015 08:59, Wei Liu wrote: >> Signed-off-by: Wei Liu >> --- >> Cc: dave.sc...@eu.citrix.com >> >> Please check if the use of caml_failwith is correct. > > This issue I have a different patch for, which could be 4.6 material, if > i

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Dave Scott
> On 23 Jul 2015, at 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu > --- > Cc: dave.sc...@eu.citrix.com > > Please check if the use of caml_failwith is correct. This looks fine to me. Acked-by: David Scott > --- > tools/ocaml/libs/xl/xenlight_stubs.c | 4 > 1 file changed, 4 inserti

Re: [Xen-devel] [PATCH] oxenstored: link in the systemd system library

2015-07-23 Thread Dave Scott
> On 22 Jul 2015, at 23:02, Jonathan Creekmore > wrote: > > If systemd is configured for use AND you are building oxenstored, the C > systemd library must be linked in to the oxenstored binary instead of > just into the static ocaml stub. This sounds sensible to me, Acked-by: David Scott >

Re: [Xen-devel] [PATCH XEN v2 09/15] tools/libxc: Remove osdep indirection for privcmd

2015-07-16 Thread Dave Scott
> On 16 Jul 2015, at 05:57, David Scott (Sales UK) > wrote: > > One for you I think Dave? > > Sent from my iPhone > > Begin forwarded message: > >> From: "Ian Campbell" >> To: "Ian Jackson" , "Wei Liu" , >> "xen-devel@lists.xen.org" >> Cc: "Stefano Stabellini" , "Roger Pau Monne" >> , "I

Re: [Xen-devel] [PATCH] tools: ocaml: Handle anonymous struct members of structs in libxl IDL

2015-07-09 Thread Dave Scott
on; > > As said on another thread, I’m not a fan of the __anon suffix. But I won’t > object either, because in practice it doesn’t really matter. So: > > Acked-by: Rob Hoes This is also ok by me, so Acked-by: David Scott > >> } >> val default :

Re: [Xen-devel] Hyper and Xen Project

2015-06-25 Thread Dave Scott
articular name at a time - lots of IPs can bind the same port ~=~ lots of domains can bind the same name What do you think? Thanks, Dave > > On Thu, Jun 25, 2015 at 2:29 AM Dave Scott wrote: > Hi Xu, > > > On 24 Jun 2015, at 14:44, Wang Xu wrote: > > > > Thank

Re: [Xen-devel] Hyper and Xen Project

2015-06-24 Thread Dave Scott
dd validation code to check uniqueness. Thanks, Dave > > Cheers > > Xu > > On Wed, Jun 24, 2015 at 9:03 PM Dave Scott wrote: > I don’t think the frontend driver in Linux knows about the name key. In my > testing I wrote a udev script which looks up the ‘name’ key directly i

Re: [Xen-devel] Hyper and Xen Project

2015-06-24 Thread Dave Scott
> On 24 Jun 2015, at 12:48, Stefano Stabellini > wrote: > > Hi Wang, > > I don't know the answer, so I CCed xen-devel (the Xen development list) > and a few people that I think will be able to help. > > Cheers, > > Stefano > > On Wed, 24 Jun 2015, Wang Xu wrote: >> A problem about channel,

Re: [Xen-devel] [PATCH] oxenstored: fix del_watches and del_transactions

2015-06-17 Thread Dave Scott
> On 17 Jun 2015, at 20:39, Wei Liu wrote: > > The statement to reset nb_watches should be in del_watches, not > del_transactions. > > Signed-off-by: Wei Liu > Cc: David Scott > --- > It was only until Ian applied previous patch that I discovered this > copy-n-paste error. Sorry about this.

Re: [Xen-devel] [PATCH RFC 0/4] 'reset everything' approach to PVHVM guest kexec

2015-06-09 Thread Dave Scott
> On 9 Jun 2015, at 10:38, Wei Liu wrote: > > On Tue, Jun 09, 2015 at 10:29:56AM +0100, Wei Liu wrote: > [...] + con.next_tid <- initial_next_tid >>> >>> I couldn’t spot the part in the C version where the next transaction id is >>> reset — is this a (minor) difference between the two im

Re: [Xen-devel] [PATCH RFC 0/4] 'reset everything' approach to PVHVM guest kexec

2015-06-09 Thread Dave Scott
> On 8 Jun 2015, at 18:43, Wei Liu wrote: > > On Mon, Jun 08, 2015 at 04:53:46PM +0100, Wei Liu wrote: >> On Wed, Jun 03, 2015 at 03:35:18PM +0200, Vitaly Kuznetsov wrote: >>> Jan and Tim, >>> >>> last week you expressed some concerns about if the toolstack-based >>> approach to PVHVM guest kex

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-21 Thread Dave Scott
> On 21 Apr 2015, at 12:06, George Dunlap wrote: > > On 04/21/2015 12:04 PM, Dave Scott wrote: >>> FYI I’ve been sporadically building the blktap userspace on ARM and it >>> seems to work, although last time I had to fix some format strings which >>> as

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-21 Thread Dave Scott
> On 21 Apr 2015, at 12:01, Dave Scott wrote: > >> >> On 21 Apr 2015, at 11:42, Stefano Stabellini >> wrote: >> >> On Tue, 21 Apr 2015, George Dunlap wrote: >>> On 04/21/2015 11:09 AM, Stefano Stabellini wrote: >>>> On Tue, 21 Apr 201

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-21 Thread Dave Scott
> On 21 Apr 2015, at 11:42, Stefano Stabellini > wrote: > > On Tue, 21 Apr 2015, George Dunlap wrote: >> On 04/21/2015 11:09 AM, Stefano Stabellini wrote: >>> On Tue, 21 Apr 2015, George Dunlap wrote: On 04/21/2015 10:25 AM, Ian Campbell wrote: > On Mon, 2015-04-20 at 18:05 +0100, Stef

Re: [Xen-devel] [PATCH] tools/ocaml: remove uint32 use added by 674ad2b

2015-02-08 Thread Dave Scott
> On 8 Feb 2015, at 17:11, M A Young wrote: > > From 73bab9cb1cb95f35080fadaf1193cbe45327a89c Mon Sep 17 00:00:00 2001 > From: Michael Young > Date: Sun, 8 Feb 2015 15:54:23 + > Subject: [PATCH] tools/ocaml: remove uint32 use added by 674ad2b > > In 674ad2b (xenstore: extend the xenstore r

[Xen-devel] entropy for VMs

2015-02-01 Thread Dave Scott
Hi, Mirage now has nice features like TLS[1] and therefore needs a good source of randomness to generate session keys. Mirage VMs are PV, so we can’t use virtio-rng. We've created a prototype entropy server which may be of interest to other people too: https://github.com/mirage/xentropyd This

Re: [Xen-devel] [RFC V10 0/4] domain snapshot document

2015-02-01 Thread Dave Scott
> On 29 Jan 2015, at 16:36, Ian Campbell wrote: > > On Mon, 2015-01-26 at 11:25 +0800, Chunyan Liu wrote: >> Changes to V9: > > This looks good to me, thanks. > > Ian/Wei do you have any comments? xapi folks? The API looks sensible to me. Xapi normally manages disk snapshots through it’s own

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Fix stub_xc_readconsolering()

2015-01-30 Thread Dave Scott
in C code should probably take a look. Acked-by: David Scott Dave > Signed-off-by: Andrew Cooper > CC: Dave Scott > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/ocaml/libs/xc/xenctrl_stubs.c | 59 +-- > 1 file cha

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-30 Thread Dave Scott
> On 30 Jan 2015, at 14:20, Wei Liu wrote: > > On Fri, Jan 30, 2015 at 02:19:53PM +0000, Dave Scott wrote: >> >> Looks ok to me. >> >> Signed-off-by: David Scott >> > > I think this should be an Acked-by. Sorry, you’re completely right. Mus

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-30 Thread Dave Scott
o being a stack variable. > > Also, propagate the Noreturn attribute from caml_raise_with_string(). > > Signed-off-by: Andrew Cooper > CC: Dave Scott > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/ocaml/libs/xc/xenctrl_stubs.c | 15 +++

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Check return values from hypercalls

2015-01-28 Thread Dave Scott
Looks fine to me Acked-by: David Scott > On 27 Jan 2015, at 20:38, Andrew Cooper wrote: > > rather than blindly continuing and possibly using negative values. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > CC: Dave S

[Xen-devel] Cancelling asynchronous operations in libxl

2015-01-20 Thread Dave Scott
Hi, Firstly, sorry for the extreme lateness of this reply! I’ve re-read the thread from Nov 2013: (2013!) http://lists.xen.org/archives/html/xen-devel/2013-11/msg01176.html and found it quite thought-provoking. From the Xapi/Xenopsd point of view, the main feature that we’d like is to be able

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Dave Scott
> On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk > wrote: > > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: >> >>> On 26 Nov 2014, at 15:38, Zheng Li wrote: >>> >>> On 26/11/2014 15:09, Andrew Cooper wrote: >>>> This

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Dave Scott
> On 26 Nov 2014, at 15:38, Zheng Li wrote: > > On 26/11/2014 15:09, Andrew Cooper wrote: >> This makes fields 0 and 1 true more often than they should be, resulting >> problems when handling events. > > Indeed, looks like a mistake I made when rewriting the logic terms lately. > The result is