Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-24 Thread Chris Patterson
On Fri, Jul 7, 2017 at 2:53 PM, Chris Patterson wrote: > On Fri, Jul 7, 2017 at 12:30 PM, Julien Grall wrote: >> Hi Chris, >> >> On 07/07/17 00:12, Chris Patterson wrote: >>>> >>>> >>>> So why do you want the hardware domain to interact w

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Chris Patterson
On Fri, Jul 7, 2017 at 12:30 PM, Julien Grall wrote: > Hi Chris, > > On 07/07/17 00:12, Chris Patterson wrote: >>> >>> >>> So why do you want the hardware domain to interact with the ictlr? Could >>> not >>> you hide it completely? >

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Chris Patterson
On Fri, Jul 7, 2017 at 12:25 PM, Julien Grall wrote: > Hi Chris, > > > On 06/07/17 23:00, Chris Patterson wrote: >>>> >>>> The purpose of tegra_interrupt_compat is to maintain a tegra-specific >>>> whitelist of interrupt controllers we know how

Re: [Xen-devel] [PATCH 6/6] xen/arm: platforms/tegra: Ensure the hwdom can only affect its own interrupts

2017-07-06 Thread Chris Patterson
Will fix, thanks! ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-06 Thread Chris Patterson
> > So why do you want the hardware domain to interact with the ictlr? Could not > you hide it completely? > snip > What would happen if you enable the interrupt here for the guest? Should not > you do it when the guest is requesting to enable (see vgic_enable_irqs). > > > Also, how about EOI an

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-06 Thread Chris Patterson
>> The purpose of tegra_interrupt_compat is to maintain a tegra-specific >> whitelist of interrupt controllers we know how to route. Presumably, >> there may be custom boards out there that may have additional >> interrupt routing capabilities that this patch set would not support >> as-is. I'm n

Re: [Xen-devel] [PATCH 1/6] xen/arm: platforms: Add earlyprintk and serial support for Tegra boards.

2017-04-19 Thread Chris Patterson
Will split patches & fix for v2, thanks! ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-17 Thread Chris Patterson
>> +static const char * const tegra_dt_compat[] __initconst = >> +{ >> +"nvidia,tegra120", /* Tegra K1 */ > > This is still tegra120 (not tegra124), is that intended? If so, it is > still missing from arch/arm*/boot/dts. Do you have a pointer? It was not intended; thank you for catching it. I

[Xen-devel] [PATCH 6/6] xen/arm: platforms/tegra: Ensure the hwdom can only affect its own interrupts

2017-04-06 Thread Chris Patterson
From: Chris Patterson Several Tegra hardware devices, and the Tegra device tree, expect the presence of a Tegra Legacy Interrupt Controller (LIC) in the hardware domain. Accordingly, we'll need to expose (most of) the LIC's registers to the hardware domain. As the Tegra LIC provides t

[Xen-devel] [PATCH 1/6] xen/arm: platforms: Add earlyprintk and serial support for Tegra boards.

2017-04-06 Thread Chris Patterson
From: Chris Patterson Tegra boards feature a NS16550-compatible serial mapped into the MMIO space. Add support for its use both as a full-featured serial port and as an earlyprintk driver. This patch adds a quirk for platforms, such as the Tegra, which require require the NS16550 Rx timeout

[Xen-devel] [PATCH 3/6] xen/arm: Allow platforms to hook IRQ routing

2017-04-06 Thread Chris Patterson
From: "Chris Patterson" Some common platforms (e.g. Tegra) have non-traditional IRQ controllers that must be programmed in addition to their primary GICs-- and which can come in unusual topologies. Device trees for targets that feature these controllers often deviate from the conven

[Xen-devel] [PATCH 0/6] Initial Tegra platform support

2017-04-06 Thread Chris Patterson
m the original RFC posted by Kyle Temkin. Kyle has done most of the authoring on this, but I am picking it up to address the RFC reviews and push it though. Chris Patterson (6): xen/arm: platforms: Add earlyprintk and serial support for Tegra boards. xen/arm: domain_build: Inherit GIC's

[Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-06 Thread Chris Patterson
From: "Chris Patterson" Tegra devices have a legacy interrupt controller (lic, or ictlr) that must be programmed in parallel with their primary GIC. For all intents and purposes, we treat these devices attached to this controller as connected to the primary GIC, as it will be hand

[Xen-devel] [PATCH 5/6] xen/arm: Add function to query IRQ 'ownership'

2017-04-06 Thread Chris Patterson
From: "Chris Patterson" The addition of new IRQ-related platform hooks now allow platforms to perform platform-specific interrupt logic, such as allowing virtualization of platform-specific interrupt controller hardware. This commit adds the ability for the platform to identify th

[Xen-devel] [PATCH 2/6] xen/arm: domain_build: Inherit GIC's interrupt-parent from host device tree

2017-04-06 Thread Chris Patterson
From: "Chris Patterson" Currently, the interrupt parent is left undefined during creation in make_gic_node(). In cases where a non-GIC interrupt controller is present, this can lead to incorrect assignment of interrupt parents. On the Tegra, the gic's interrupt parent i

Re: [Xen-devel] Xen ARM community call

2016-11-08 Thread Chris Patterson
> I would suggest to start with a 1 hour meeting on the Wednesday 23rd > November. I know that people are spread across different timezones, so I > would like to gather thought before choosing a time. > Sounds good! EST (GMT-5). Cheers, -Chris ___ Xen-

Re: [Xen-devel] [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread

2016-09-21 Thread Chris Patterson
On Wed, Sep 21, 2016 at 10:07 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 21, 2016 at 09:50:30AM -0400, Chris Patterson wrote: >> On Wed, Sep 21, 2016 at 9:00 AM, Wei Liu wrote: >> > On Wed, Sep 21, 2016 at 08:51:07AM -0400, Konrad Rzeszutek Wilk wrote: >> >>

Re: [Xen-devel] [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread

2016-09-21 Thread Chris Patterson
On Wed, Sep 21, 2016 at 9:00 AM, Wei Liu wrote: > On Wed, Sep 21, 2016 at 08:51:07AM -0400, Konrad Rzeszutek Wilk wrote: >> On Tue, Sep 20, 2016 at 05:29:39PM -0400, Chris Patterson wrote: >> > From: Chris Patterson >> > >> > xs_watch() creates a thread to l

[Xen-devel] [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread

2016-09-20 Thread Chris Patterson
From: Chris Patterson xs_watch() creates a thread to listen to xenstore events. Currently, the thread is created with the greater of 16K or PTHREAD_MIN_SIZE. There have been several bug reports and workarounds related to the issue where xs_watch() fails because its attempt to create the reader

[Xen-devel] stack size limit issues with xen + qemu + rbd

2016-09-16 Thread Chris Patterson
I have spent some time investigating a case where qemu is failing to register xenstore watches for a PV guest once I enable vfb (and thereby triggering the creation of a qemu instance). The qemu logs show something along the lines of: xen be core: xen be core: xen be: watching backend path (backen

[Xen-devel] [PATCH v2] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-21 Thread Chris Patterson
From: Chris Patterson The uart generates an interrupt whenever the transmit holding register is empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen's ns16550 driver does not currently mask this interrupt when transmit is stopped, unlike other platforms such as Linux [1]. T

Re: [Xen-devel] [PATCH] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-17 Thread Chris Patterson
On Wed, Aug 17, 2016 at 10:29 AM, Jan Beulich wrote: >>>> On 17.08.16 at 16:02, wrote: >> From: Chris Patterson >> >> The uart generates an interrupt whenever the transmit holding register is >> empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen&#x

[Xen-devel] [PATCH] ns16550: mask transmit holding register empty interrupt when tx is stopped

2016-08-17 Thread Chris Patterson
From: Chris Patterson The uart generates an interrupt whenever the transmit holding register is empty and UART_IER_ETHREI is set in UART_IER. Currently, Xen's ns16550 driver does not currently mask this interrupt when transmit is stopped, unlike other platforms such as Linux [1]. T

[Xen-devel] [PATCH] libxl: compilation warning fix for arm & aarch64

2016-07-27 Thread Chris Patterson
From: Chris Patterson GCC 6 will warn on unused static const variables in c modules: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00847.html When compiling with LIBXL_HAVE_NO_SUSPEND_RESUME set (arm & aarch64), the compiler emits the following errors: xl_cmdimpl.c:101:19: e

[Xen-devel] [PATCH v3 1/2] libxl: replace deprecated readdir_r() with readdir()

2016-06-03 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error under glibc due to the deprecation of readdir_r for their next release (2.24) [1, 2]. Remove code specific to usage of readdir_r which is no longer required, such as zalloc_dirent(). -- From

[Xen-devel] [PATCH v3 2/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-06-03 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error under glibc due to the deprecation of readdir_r for their next release (2.24) [1, 2]. Add new error checking on readdir(), and fail if error occurs. -- From the GNU libc manual [3]: "

Re: [Xen-devel] [[PATCH v2 2/2] libxl: replace deprecated readdir_r() with readdir()

2016-06-02 Thread Chris Patterson
On Thu, Jun 2, 2016 at 12:13 PM, Ian Jackson wrote: > Chris Patterson writes ("Re: [[PATCH v2 2/2] libxl: replace deprecated > readdir_r() with readdir()"): >> You're right, it should check for the error afterwards. >> >> How about something along the

Re: [Xen-devel] [[PATCH v2 2/2] libxl: replace deprecated readdir_r() with readdir()

2016-06-02 Thread Chris Patterson
On Thu, Jun 2, 2016 at 6:11 AM, Ian Jackson wrote: > Chris Patterson writes ("[[PATCH v2 2/2] libxl: replace deprecated > readdir_r() with readdir()"): >> -for (;;) { >> +while ((de = readdir(dir)) != NULL) { > ... >> -int r = readdir_r

[Xen-devel] [[PATCH v2 1/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-06-01 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error under glibc due to the deprecation of readdir_r for their next release (2.24) [1, 2]. -- From the GNU libc manual [3]: " It is expected that future versions of POSIX will obsolete read

[Xen-devel] [[PATCH v2 2/2] libxl: replace deprecated readdir_r() with readdir()

2016-06-01 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error under glibc due to the deprecation of readdir_r for their next release (2.24) [1, 2]. Remove code specific to usage of readdir_r which is no longer required, such as zalloc_dirent(). -- From

Re: [Xen-devel] [PATCH 1/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-06-01 Thread Chris Patterson
On Wed, Jun 1, 2016 at 8:06 AM, Ian Jackson wrote: > Ian Jackson writes ("Re: [Xen-devel] [PATCH 1/2] libfsimage: replace > deprecated readdir_r() with readdir()"): >> Ian Jackson writes ("Re: [Xen-devel] [PATCH 1/2] libfsimage: replace >> deprecated readdir_r() with readdir()"): >> > 2. There m

Re: [Xen-devel] [PATCH 1/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-05-31 Thread Chris Patterson
On Tue, May 31, 2016 at 1:53 PM, Wei Liu wrote: > On Tue, May 31, 2016 at 11:43:13AM -0400, Chris Patterson wrote: >> On Tue, May 31, 2016 at 6:42 AM, George Dunlap >> wrote: >> > On Mon, May 30, 2016 at 3:32 AM, Chris Patterson wrote: >> >> From: Chris Patt

Re: [Xen-devel] [PATCH 1/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-05-31 Thread Chris Patterson
On Tue, May 31, 2016 at 6:42 AM, George Dunlap wrote: > On Mon, May 30, 2016 at 3:32 AM, Chris Patterson wrote: >> From: Chris Patterson >> >> Replace the usage of readdir_r() with readdir() to address >> a compilation error due to the deprecation of readdir_r. >

[Xen-devel] [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args

2016-05-31 Thread Chris Patterson
From: Chris Patterson In some cross-compilation environments, the CC/CXX variables may expand out to more than one argument (to include things like --sysroot=...). Quote these to safely pass along. Signed-off-by: Chris Patterson --- xen/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3

[Xen-devel] [PATCH 2/2] libxl: replace deprecated readdir_r() with readdir()

2016-05-29 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error due to the deprecation of readdir_r. glibc has deprecated this for their next release (2.24): https://sourceware.org/bugzilla/show_bug.cgi?id=19056 This also removes the zalloc_dirent() helper

[Xen-devel] [PATCH 1/2] libfsimage: replace deprecated readdir_r() with readdir()

2016-05-29 Thread Chris Patterson
From: Chris Patterson Replace the usage of readdir_r() with readdir() to address a compilation error due to the deprecation of readdir_r. glibc has deprecated this for their next release (2.24): https://sourceware.org/bugzilla/show_bug.cgi?id=19056 Signed-off-by: Chris Patterson --- tools

Re: [Xen-devel] Question about running Xen on NVIDIA Jetson-TK1

2016-05-17 Thread Chris Patterson
On Tue, May 17, 2016 at 9:37 AM, Konrad Rzeszutek Wilk wrote: >> - The serial controller on the Tegra SoCs doesn't behave in the same >> was as most NS16550-compatibles; it actually adheres to the NS16550 >> spec a little more rigidly than most compatible controller

Re: [Xen-devel] [PATCH] kernel-parameters: document earlycon=xenboot

2016-04-05 Thread Chris Patterson
On Tue, Apr 5, 2016 at 12:42 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Apr 05, 2016 at 11:43:36AM -0400, Chris Patterson wrote: >> On Tue, Apr 5, 2016 at 9:49 AM, Konrad Rzeszutek Wilk >> wrote: >> > On Mon, Apr 04, 2016 at 10:48:11PM -0400, Chris Patterson wrote: &g

Re: [Xen-devel] [PATCH] kernel-parameters: document earlycon=xenboot

2016-04-05 Thread Chris Patterson
On Tue, Apr 5, 2016 at 9:49 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 04, 2016 at 10:48:11PM -0400, Chris Patterson wrote: >> Add earlycon=xenboot option to Documentation/kernel-parameters.txt. >> > > But it is not true. > > I tried this on x86: "earlyco

[Xen-devel] [PATCH] kernel-parameters: document earlycon=xenboot

2016-04-04 Thread Chris Patterson
Add earlycon=xenboot option to Documentation/kernel-parameters.txt. Signed-off-by: Chris Patterson --- Documentation/kernel-parameters.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index ecc74fa..e01ec39