Shuffle lines around so that the assignments in mfn_to_xen_entry()
occur in the same order as the bits are declared in lpae_pt_t.
This makes it easier to see which ones are never given a value.
No change in behaviour.
Also fix a minor comment typo.
Signed-off-by: Chris Brand
Reviewed-by: Julien
Ensure that every relevant bit is given an explicit value.
This has no effect on the generated code, but makes it
a little easier to follow.
Reported-by: Julien Grall
Signed-off-by: Chris Brand
---
v3 trims down the list of bits given explicit values
v2 adds comments on pxn and avail
xen
s the assignments to match the declaration, making it
clearer which ones are missing. Patch 2 then adds the missing bits.
Chris
Chris Brand (2):
xen: arm re-order assignments in mfn_to_xen_entry()
xen: arm: Be explicit about bit values in mfn_to_xen_entry()
xen/include/asm-arm/page.h
etting the "contig" bit in the PTEs.
Signed-off-by: Chris Brand
---
Changed in v2: merged create_32mb_mappings() and create_2mb_mappings()
into create_mappings(). A side-effect is to fix the bug in v1 for
ARM64 systems with <4GB RAM.
Changed in v3: Ensure that the granularity variabl
Ensure that every bit has a specific value.
Reported-by: Julien Grall
Signed-off-by: Chris Brand
---
v2 adds comments on pxn and avail.
xen/include/asm-arm/page.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index
Shuffle lines around so that the assignments in mfn_to_xen_entry()
occur in the same order as the bits are declared in lpae_pt_t.
This makes it easier to see which ones are never given a value.
No change in behaviour.
Also fix a minor comment typo.
Signed-off-by: Chris Brand
Reviewed-by: Julien
s the assignments to match the declaration, making it
clearer which ones are missing. Patch 2 then adds the missing bits.
Chris
Chris Brand (2):
xen: arm re-order assignments in mfn_to_xen_entry()
xen: arm: Set all bits in mfn_to_xen_entry()
xen/include/asm-arm/page.h | 19 ---
1