Re: [Xen-devel] [PATCH v9]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Chen, Tianyang
On 03/16/2016 10:25 AM, Dario Faggioli wrote: Ok, it's about time that we deal with this changelog! On Mon, 2016-03-14 at 20:04 -0400, Tianyang Chen wrote: Budget replenishment and enforcement are separated by adding a replenishment timer, which fires at the next most imminent release time of

Re: [Xen-devel] [PATCH v9]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Chen, Tianyang
On 03/16/2016 10:25 AM, Dario Faggioli wrote: +if ( curr_on_cpu(vc->processor) == vc && >+ ( !list_empty(runq) ) ) > So, this is because, since we don't keep the idle vcpus in the runqueues, we need to catch the case where v is running, but no other vcpu is waiting on the r

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Chen, Tianyang
On 03/17/2016 02:27 PM, Dario Faggioli wrote: Finally, when waking up a vcpu, it is now enough to tickle the various CPUs appropriately, like all other schedulers also do. Signed-off-by: Tianyang Chen Signed-off-by: Meng Xu Signed-off-by: Dagaen Golomb You seem to have taken care of all m

Re: [Xen-devel] [PATCH v9]xen: sched: convert RTDS from time to event driven model

2016-03-15 Thread Chen, Tianyang
On 03/15/2016 11:11 PM, Meng Xu wrote: + /* * Flags */ @@ -115,6 +118,18 @@ #define RTDS_delayed_runq_add (1<<__RTDS_delayed_runq_add) /* + * The replenishment timer handler needs to check this bit + * to know where a replenished vcpu was, when deciding which + * vcpu should tickle

Re: [Xen-devel] [PATCH v8]xen: sched: convert RTDS from time to event driven model

2016-03-12 Thread Chen, Tianyang
On 03/12/2016 05:36 PM, Andrew Cooper wrote: On 12/03/2016 22:21, Chen, Tianyang wrote: On 03/11/2016 11:54 PM, Meng Xu wrote: I'm focusing on the style and the logic in the replenish handler: /* @@ -160,6 +180,7 @@ struct rt_private { */ struct rt_vcpu { s

Re: [Xen-devel] [PATCH v8]xen: sched: convert RTDS from time to event driven model

2016-03-12 Thread Chen, Tianyang
On 03/11/2016 11:54 PM, Meng Xu wrote: I'm focusing on the style and the logic in the replenish handler: /* @@ -160,6 +180,7 @@ struct rt_private { */ struct rt_vcpu { struct list_head q_elem;/* on the runq/depletedq list */ +struct list_head replq_elem;/* on the repl eve

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-26 Thread Chen, Tianyang
Attached. Tianyang On 2016-02-26 13:09, Dario Faggioli wrote: On Fri, 2016-02-26 at 12:28 -0500, Tianyang Chen wrote: > So, have you made other changes wrt v6 when trying this? The v6 doesn't have the if statement commented out when I submitted it.  But I tried commenting it out, the assertion