[Xen-devel] [Patch] Fix broken package config file xenlight.pc.in

2017-05-11 Thread Charles Arnold
The Requires line in this config file uses the wrong names for two dependencies. The package config file for xenctrl is called 'xencontrol' and for blktapctl is called 'xenblktapctl'. Running a command like 'pkg-config --exists xenlight' will fail without this fix.

[Xen-devel] Is there any limitation on the firmware size in Xen?

2017-05-10 Thread Charles Arnold
I was asked the following question which I am posting to the list. " My name is Gary Lin, and I am the maintainer of the OVMF package, a UEFI implementation for the virtual machines. Recently, I was testing an upstream patchset[*] and encountered some problems in Xen. Maybe you can help me or giv

[Xen-devel] [PATCH] tools: fix vif-route add|remove

2016-09-07 Thread Charles Arnold
From 2b4e942ad75f4a4546c417d8bd1116e3af368daf Mon Sep 17 00:00:00 2001 From: Charles Arnold Date: Wed, 7 Sep 2016 09:48:18 -0600 Subject: [PATCH] tools: fix vif-route add|remove vif-route is called twice. First for the vif interface and second for the vif-emu interface. vif-route takes 4

[Xen-devel] [PATCH] libxl: 'valid_devs' may be used uninitialized

2015-05-15 Thread Charles Arnold
Using gcc 4.8 to compile with -Werror. xl_cmdimpl.c:5493:8: error: 'valid_devs' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (valid_devs == 0) ^ xl_cmdimpl.c:5455:9: note: 'valid_devs' was declared here int valid_devs; Si

Re: [Xen-devel] New Defects reported by Coverity Scan for XenProject

2015-04-02 Thread Charles Arnold
>>> On 4/2/2015 at 08:32 AM, Ian Campbell wrote: > Hi Charles, > > I'm not sure if this is a real issue in the qdisk support for xenstat, > but I think it may relate to the first return 0 in qmp_read which may > not free the accumulated array. Yes. That is a leak on the failure case. > > Coul

[Xen-devel] [PATCH] xentop: fix potential memory leak

2015-04-02 Thread Charles Arnold
On a read failure the qstats buffer is not freed. Signed-off-by: Charles Arnold diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c index c217b8e..2cb99e9 100644 --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c +++ b/tools/xenstat/libxenstat/src

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-24 Thread Charles Arnold
>>> On 3/24/2015 at 09:01 AM, Ian Campbell wrote: > On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote: > >> +/* Get up to 1024 active domains */ > > What I meant last time was, is this limitation a concern? What if there > are 1025 domains? This is act

[Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-23 Thread Charles Arnold
(). Libxl is modified to create a new socket dedicated for the use of libxenstat for querying the block statistics using QMP. The current APIs remain unchanged. It works within the existing framework of libxenstat. Signed-off-by: Charles Arnold diff --git a/tools/libxl/libxl_dm.c b/tools/libxl

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-19 Thread Charles Arnold
>>> On 3/19/2015 at 12:09 PM, Anthony PERARD wrote: > On Wed, Mar 18, 2015 at 04:12:26PM +, Ian Campbell wrote: >> My second concern here is with the use of /var/run/xen/qmp-libxl-%i from >> outside of libxl. I can't remember if qemu is safe against multiple >> users of the socket. ISTR askin

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-19 Thread Charles Arnold
>>> On 3/18/2015 at 10:12 AM, Ian Campbell wrote: > On Wed, 2015-03-11 at 11:51 -0600, Charles Arnold wrote: >> Now that Xen uses qdisks by default and qemu does not write out >> statistics to sysfs this patch queries the QMP for disk statistics. >> >> This

[Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-11 Thread Charles Arnold
interfaces have been changed. It works within the existing framework of libxenstat. Signed-off-by: Charles Arnold diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile index 07d39b1..6a69f7e 100644 --- a/tools/xenstat/libxenstat/Makefile +++ b/tools/xenstat

Re: [Xen-devel] [RFC PATCH] xentop: add support for qdisks

2015-02-20 Thread Charles Arnold
>>> On 2/20/2015 at 11:10 AM, Charles Arnold wrote: > Now that Xen uses qdisks by default and qemu does not write out > statistics to sysfs this patch queries the QMP for disk statistics. Forget this patch. I assumed the name of the xenstore backend device (eg, xvda, hda, etc) wo

[Xen-devel] [RFC PATCH] xentop: add support for qdisks

2015-02-20 Thread Charles Arnold
Now that Xen uses qdisks by default and qemu does not write out statistics to sysfs this patch queries the QMP for disk statistics. Signed-off-by: Charles Arnold diff --git a/tools/xenstat/libxenstat/src/xenstat_linux.c b/tools/xenstat/libxenstat/src/xenstat_linux.c index 7fdf70a..885d089

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable

2015-01-12 Thread Charles Arnold
>>> On 1/12/2015 at 10:03 AM, Ian Jackson wrote: > Charles Arnold writes ("Re: Backport request for "tools/hotplug: set mtu from > bridge for tap interface" - for Xen 4.4, 4.5, and unstable"): >> Add quotes around $bridge and $dev to handle spaces in n

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface"

2015-01-12 Thread Charles Arnold
Forgot to put [Patch] in the subject line for the last two replies :( - Charles ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable

2015-01-12 Thread Charles Arnold
Add quotes around $bridge and $dev to handle spaces in names. This should go into 4.4, 4.5 and unstable. Signed-off-by: Charles Arnold diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index 3d72ca4..8b67b0a 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.3

2015-01-12 Thread Charles Arnold
ith the setting of the MTU for the 'online' case was there a reason for omitting the 'add'? This patch sets the MTU for both 'online' and 'add' in the vif-bridge script. Backport for Xen version 4.3 Signed-off-by: Charles Arnold diff --git a/tools/h

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface"

2014-11-18 Thread Charles Arnold
>>> On 11/18/2014 at 11:24 AM, Ian Jackson wrote: > Daniel Kiper writes ("Re: [Xen-devel] delaying 4.4.2 and 4.3.4"): >> By the way, what I should do to have commit > f3f5f1927f0d3aef9e3d2ce554dbfa0de73487d5 >> (tools/hotplug: set mtu from bridge for tap interface) in at least Xen 4.3? >> I am a