[Xen-devel] [PATCH 10/12] xen-blkback: Fix indentation

2017-08-17 Thread Bart Van Assche
Avoid that smatch reports the following warning when building with C=2 CHECK="smatch -p=kernel": drivers/block/xen-blkback/blkback.c:710 xen_blkbk_unmap_prepare() warn: inconsistent indenting Signed-off-by: Bart Van Assche Cc: Konrad Rzeszutek Wilk Cc: Roger Pau Monn303251

[Xen-devel] [PATCH 12/12] xen-blkfront: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-17 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Cc: Konrad Rzeszutek Wilk Cc: Roger Pau Monn303251 Cc: xen-de...@lists.xenproject.org --- drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index

[Xen-devel] [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-17 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Cc: Konrad Rzeszutek Wilk Cc: Roger Pau Monn303251 Cc: xen-de...@lists.xenproject.org --- drivers/block/xen-blkback/blkback.c | 1 + drivers/block/xen-blkback/xenbus.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen

Re: [Xen-devel] [PATCH] xen-blkfront: Fix handling of non-supported operations

2017-07-24 Thread Bart Van Assche
On Mon, 2017-07-24 at 08:46 -0600, Jens Axboe wrote: > On 07/21/2017 11:11 AM, Bart Van Assche wrote: > > This patch fixes the following sparse warnings: > > > > drivers/block/xen-blkfront.c:916:45: warning: incorrect type in argument 2 > > (different base types) >

[Xen-devel] [PATCH] xen-blkfront: Fix handling of non-supported operations

2017-07-21 Thread Bart Van Assche
("block: introduce new block status code type") Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Konrad Rzeszutek Wilk Cc: Roger Pau Monné Cc: Cc: --- drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-bl

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Bart Van Assche
On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > This interfaces will be removed soon, so use quiesce and > unquiesce instead, which should be more safe. > > The only one usage will be removed in the following > congestion control patches. Hello Ming, The title of this patch is misleading si

[Xen-devel] [PATCH v3 12/12] xen/scsifront: Remove code that zeroes driver-private command data

2017-06-02 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Reviewed-by: Juergen Gross Reviewed-by: Christoph Hellwig Cc: xen-de...@lists.xenproject.org Cc: Johannes Thumshirn --- drivers

[Xen-devel] [PATCH v2 12/12] xen/scsifront: Remove code that zeroes driver-private command data

2017-06-01 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Reviewed-by: Juergen Gross Cc: xen-de...@lists.xenproject.org Cc: Johannes Thumshirn --- drivers/scsi/xen-scsifront.c | 1 - 1

[Xen-devel] [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data

2017-05-23 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche Cc: Juergen Gross Cc: xen-de...@lists.xenproject.org --- drivers/scsi/xen-scsifront.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/xen

[Xen-devel] [PATCH 17/33] xen/scsiback: Make TMF processing slightly faster

2017-05-23 Thread Bart Van Assche
the struct se_cmd that corresponds to the TMF exists as long as target_tmr_work() is in progress. Hence change the second argument of transport_generic_free_cmd() from 1 into 0. Signed-off-by: Bart Van Assche Cc: Juergen Gross Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: David Disseldorp Cc

[Xen-devel] [PATCH 16/33] xen/scsiback: Replace a waitqueue and a counter by a completion

2017-05-23 Thread Bart Van Assche
This patch simplifies the implementation of the scsiback driver but does not change its behavior. Signed-off-by: Bart Van Assche Cc: Juergen Gross Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: David Disseldorp Cc: xen-de...@lists.xenproject.org --- drivers/xen/xen-scsiback.c | 11

[Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-05-23 Thread Bart Van Assche
scsiback_release_cmd() must not dereference se_cmd->se_tmr_req because that memory is freed by target_free_cmd_mem() before scsiback_release_cmd() is called. Fix this use-after-free by inlining struct scsiback_tmr into struct vscsibk_pend. Signed-off-by: Bart Van Assche Cc: Juergen Gross

[Xen-devel] [PATCH 1/9] treewide: Constify most dma_map_ops structures

2017-01-10 Thread Bart Van Assche
ops->/intel_dma_ops./' arch/ia64/kernel/pci-dma.c sed -i -e 's/static const struct dma_map_ops sn_dma_ops/static struct dma_map_ops sn_dma_ops/' arch/ia64/sn/pci/pci_dma.c Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Cc: Aurelien Jacquiot Cc: Catalin Marinas C