Re: [Xen-devel] [MULTIBOOT2 DOC PATCH v3 01/13] multiboot2: Replace u_phys with u32

2016-12-10 Thread Andrei Borzenkov
07.12.2016 01:52, Daniel Kiper пишет: > u_phys is used just in two places and sometimes it may confuse reader. > Additionally, GRUB multiboot2 implementation does not use u_phys anywhere. > So, replace it with basic well defined and used in implementation u32 type. > > Signed-off-by: Daniel Kiper

Re: [Xen-devel] [MULTIBOOT2 DOC PATCH v2 01/11] multiboot2: Rename Multiboot to Multiboot2

2016-11-28 Thread Andrei Borzenkov
24.11.2016 23:40, Daniel Kiper пишет: > Multiboot2 is proper name of the boot protocol. Multiboot is name of older > boot > protocol. So, rename Multiboot to Multiboot2 to not confuse the reader. > > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 112 > ++

Re: [Xen-devel] [MULTIBOOT2 DOC PATCH v2 06/11] multiboot2: Add description of EFI image handle tags

2016-11-28 Thread Andrei Borzenkov
24.11.2016 23:40, Daniel Kiper пишет: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 28 > doc/multiboot2.h | 16 > 2 files changed, 44 insertions(+) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index cc1edab..dca3e62

Re: [Xen-devel] [MULTIBOOT2 DOC PATCH v2 05/11] multiboot2: Add description of support for EFI boot services

2016-11-28 Thread Andrei Borzenkov
24.11.2016 23:40, Daniel Kiper пишет: > Signed-off-by: Daniel Kiper > --- > v2 - suggestions/fixes: >- clarify physical address meaning for EFI amd64 > mode with boot services enabled > (suggested by Andrew Cooper). > --- > doc/multiboot.texi | 115 > ++

Re: [Xen-devel] [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-15 Thread Andrei Borzenkov
15.03.2016 19:07, Vladimir 'phcoder' Serbinenko пишет: > Looks good. Let's give a day for others to comment. Is the second email the > version for commit? > > On Tuesday, March 15, 2016, Daniel Kiper wrote: > >> Do not pass memory maps to image if it asked for EFI boot services. >> Main reason f

Re: [Xen-devel] [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-03-08 Thread Andrei Borzenkov
08.03.2016 19:37, Fu Wei пишет: > Hi Andrei, > > On 8 March 2016 at 14:54, Andrei Borzenkov wrote: >> 07.03.2016 11:22, Fu Wei пишет: >>> Hi Andrei, >>> >>> On 28 February 2016 at 00:44, Fu Wei wrote: >>>> Hi Andrei >>&

Re: [Xen-devel] [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-03-07 Thread Andrei Borzenkov
07.03.2016 11:22, Fu Wei пишет: > Hi Andrei, > > On 28 February 2016 at 00:44, Fu Wei wrote: >> Hi Andrei >> >> On 28 February 2016 at 01:26, Andrei Borzenkov wrote: >>> 26.02.2016 14:13, fu@linaro.org пишет: >>>> From: Fu Wei >>&

Re: [Xen-devel] [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-29 Thread Andrei Borzenkov
29.02.2016 17:41, Konrad Rzeszutek Wilk пишет: > On Sun, Feb 28, 2016 at 08:10:33AM +0300, Andrei Borzenkov wrote: >> 27.02.2016 23:33, Konrad Rzeszutek Wilk пишет: >>> On Fri, Feb 26, 2016 at 07:15:52PM +0800, Fu Wei wrote: >>>> Hi Andrei, >>>> >>&

Re: [Xen-devel] [PATCH v4 10/11] xen: modify page table construction

2016-02-29 Thread Andrei Borzenkov
29.02.2016 15:19, Juergen Gross пишет: > On 29/02/16 10:13, Juergen Gross wrote: >> On 25/02/16 19:33, Andrei Borzenkov wrote: >>> 22.02.2016 16:14, Juergen Gross пишет: >>>> On 22/02/16 13:48, Daniel Kiper wrote: >>>>> On Mon, Feb 22, 2016 at 01:30:30P

Re: [Xen-devel] [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-27 Thread Andrei Borzenkov
27.02.2016 23:33, Konrad Rzeszutek Wilk пишет: > On Fri, Feb 26, 2016 at 07:15:52PM +0800, Fu Wei wrote: >> Hi Andrei, >> >> On 26 February 2016 at 18:50, Andrei Borzenkov wrote: >>> On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: >>>>>>>> +@s

Re: [Xen-devel] [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-27 Thread Andrei Borzenkov
26.02.2016 14:13, fu@linaro.org пишет: > From: Fu Wei > > delete: xen_linux, xen_initrd, xen_xsm > add: xen_module > > This update bases on > commit 0edd750e50698854068358ea53528100a9192902 > Author: Vladimir Serbinenko > Date: Fri Jan 22 10:18:47 2016 +0100 > > xen_b

Re: [Xen-devel] [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-02-27 Thread Andrei Borzenkov
23.02.2016 17:16, Fu Wei пишет: > Hi Ian > > On 23 February 2016 at 18:00, Ian Campbell wrote: >> On Mon, 2016-02-22 at 17:29 +0800, Fu Wei wrote: >>> Hi Julien, >>> >>> On 20 February 2016 at 00:28, Julien Grall >>> wrote: Xen is currently crashing because of malformed compatible property

Re: [Xen-devel] [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-26 Thread Andrei Borzenkov
On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: > +@subsection xen_module > > -@deffn Command xen_linux file [arguments] > -Load a dom0 kernel image for xen hypervisor at the booting process of > xen. > +@deffn Command xen_module [--nounzip] file [arguments] > +Load a m

Re: [Xen-devel] [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-25 Thread Andrei Borzenkov
Отправлено с iPhone > 26 февр. 2016 г., в 7:48, Fu Wei написал(а): > > Hi Andrei > >> On 26 February 2016 at 01:34, Andrei Borzenkov wrote: >> 25.02.2016 09:39, fu@linaro.org пишет: >>> From: Fu Wei >>> >>> delete: xen_linux, xe

Re: [Xen-devel] [PATCH v4 10/11] xen: modify page table construction

2016-02-25 Thread Andrei Borzenkov
22.02.2016 16:14, Juergen Gross пишет: > On 22/02/16 13:48, Daniel Kiper wrote: >> On Mon, Feb 22, 2016 at 01:30:30PM +0100, Juergen Gross wrote: >>> On 22/02/16 13:18, Daniel Kiper wrote: On Mon, Feb 22, 2016 at 10:29:04AM +0100, Juergen Gross wrote: > On 22/02/16 10:17, Daniel Kiper wrot

Re: [Xen-devel] [PATCH v4 02/11] xen: avoid memleaks on error

2016-02-25 Thread Andrei Borzenkov
22.02.2016 11:24, Daniel Kiper пишет: > > Are you sure that grub_errno is always set to GRUB_ERR_NONE > if any GRUB2 function finished successfully? grub_errno is reset by command parser before command execution (or after previous command finished actually). During command execution there is no g

Re: [Xen-devel] [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-02-25 Thread Andrei Borzenkov
25.02.2016 09:39, fu@linaro.org пишет: > From: Fu Wei > > delete: xen_linux, xen_initrd, xen_xsm > add: xen_module > > This update bases on > commit 0edd750e50698854068358ea53528100a9192902 > Author: Vladimir Serbinenko > Date: Fri Jan 22 10:18:47 2016 +0100 > > xen_b

Re: [Xen-devel] [PATCH 1/3] arm64: add grub_xen_boot env to indicate that we have xen_* commands

2016-02-24 Thread Andrei Borzenkov
24.02.2016 21:01, fu@linaro.org пишет: > From: Fu Wei > > Signed-off-by: Fu Wei > --- > grub-core/loader/arm64/xen_boot.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/grub-core/loader/arm64/xen_boot.c > b/grub-core/loader/arm64/xen_boot.c > index 8ae43d7..ef03111 10064

Re: [Xen-devel] [PATCH 2/3] * util/grub.d/20_linux_xen.in: Add support of the xen_boot command

2016-02-24 Thread Andrei Borzenkov
24.02.2016 21:01, fu@linaro.org пишет: > From: Fu Wei > > This patch adds the support of xen_boot command: > xen_hypervisor > xen_module > > Signed-off-by: Fu Wei > --- > util/grub.d/20_linux_xen.in | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > di

Re: [Xen-devel] Uniform commands for booting xen

2015-11-13 Thread Andrei Borzenkov
On Fri, Nov 13, 2015 at 10:48 AM, Jan Beulich wrote: On 12.11.15 at 18:09, wrote: >> On Thu, 2015-11-12 at 08:44 -0700, Jan Beulich wrote: >>> > > > On 12.11.15 at 14:41, wrote: >>> > Hello, all. I'd like to have set of commands that would boot xen on all >>> > platforms. I thought of follo

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Andrei Borzenkov
12.11.2015 20:08, Jan Beulich пишет: On 12.11.15 at 17:58, wrote: 12.11.2015 18:44, Jan Beulich пишет: On 12.11.15 at 14:41, wrote: Hello, all. I'd like to have set of commands that would boot xen on all platforms. I thought of following set: xen_hypervisor FILE XEN_OPTIONS xen_kernel FILE

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Andrei Borzenkov
12.11.2015 18:44, Jan Beulich пишет: On 12.11.15 at 14:41, wrote: Hello, all. I'd like to have set of commands that would boot xen on all platforms. I thought of following set: xen_hypervisor FILE XEN_OPTIONS xen_kernel FILE KERNEL_OPTIONS xen_initrd INITRD INITRD INITRD all initrds are concat

Re: [Xen-devel] [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

2015-10-30 Thread Andrei Borzenkov
On Fri, Oct 30, 2015 at 12:50 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >> But how to deal with xen_initrd ? >> Could you help me ? >> > Just another alias to module. Possibly you might want to add a code to > xen_initrd tto check that xen_linux was already run I think we need to be car

Re: [Xen-devel] [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

2015-10-29 Thread Andrei Borzenkov
29.10.2015 18:25, Vladimir 'φ-coder/phcoder' Serbinenko пишет: +if [ "x$machine" != xaarch64 ]; then + multiboot_cmd="multiboot" + module_linux_cmd="module" + module_initrd_cmd="module --nounzip" +else + multiboot_cmd="xen_hypervisor" + module_linux_cmd="xen_linux" +

Re: [Xen-devel] [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size

2015-07-20 Thread Andrei Borzenkov
On Mon, Jul 20, 2015 at 5:35 PM, Daniel Kiper wrote: > malloc_in_range() should not use memory region if its starta is smaller > than size. Otherwise target wraps around and points to region which is > usually not a RAM, e.g.: > > loader/multiboot.c:93: segment 0: paddr=0x80, memsz=0x3f80,

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-13 Thread Andrei Borzenkov
В Mon, 13 Jul 2015 16:53:59 +0800 fu@linaro.org пишет: > From: Fu Wei > > This patch adds the support of boot command on arm64 for XEN: > xen_hypervisor > xen_module > > Signed-off-by: Fu Wei > --- > util/grub.d/20_linux_xen.in | 14 +++--- > 1 file changed, 11 insertions(

Re: [Xen-devel] [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument

2015-05-29 Thread Andrei Borzenkov
В Fri, 29 May 2015 22:58:43 +0200 Daniel Kiper пишет: > Another questions is why grub_relocator_alloc_chunk_addr() does not consult > EFI > memory map if grub_relocator_alloc_chunk_align() does. Should not we fix it? My best guess is that grub_relocator_alloc_chunk_addr() gets target from elsew

Re: [Xen-devel] [Linaro-uefi] [PATCH 0/5]arm64: Add multiboot support (via fdt) for Xen boot

2015-05-03 Thread Andrei Borzenkov
В Fri, 10 Apr 2015 10:32:15 +0800 Fu Wei пишет: > Hi everybody, > any suggestion for my patchset? > Please let me know if there are some place need to be fixed or improved, if > these patches look good to you, can they be merged? > > Any feedback or suggestion is welcome! :-) > Great thanks ! >

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-14 Thread Andrei Borzenkov
В Wed, 11 Feb 2015 08:20:04 + "Jan Beulich" пишет: > >>> On 10.02.15 at 22:27, wrote: > > After some testing we have found at least one machine on which this thing > > does not work. It is Dell PowerEdge R820 with latest firmware. Machine > > crashes/stops because early 32-bit code is not re

Re: [Xen-devel] [PATCH 1/5] multiboot2: Fix information request tag size calculation

2015-02-14 Thread Andrei Borzenkov
В Fri, 30 Jan 2015 18:59:24 +0100 Daniel Kiper пишет: > Signed-off-by: Daniel Kiper > --- > grub-core/loader/multiboot_mbi2.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/loader/multiboot_mbi2.c > b/grub-core/loader/multiboot_mbi2.c > index 6f74aee..d7