Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Alistair Francis
On Wed, Nov 8, 2017 at 7:00 AM, Eric Blake wrote: > On 11/08/2017 08:51 AM, Alistair Francis wrote: > >>>>> Let me rephrase the question: do we really support compilers that don't >>>>> understand __func__? The presence of numerous unconditional use

Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Alistair Francis
On Tue, Nov 7, 2017 at 11:52 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/07/2017 04:12 AM, Markus Armbruster wrote: >>> Juan Quintela writes: >>> >>>> Alistair Francis wrote: >>>>> Replace all occurs of __FUNCTION__

Re: [Xen-devel] [Qemu-arm] [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

2017-09-28 Thread Alistair Francis
On Wed, Sep 27, 2017 at 4:47 PM, Peter Maydell wrote: > On 26 September 2017 at 06:32, Eric Blake wrote: >> On 09/25/2017 07:08 PM, Alistair Francis wrote: >>> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c >>> index 58005b6619..32687afced 100644 >>> ---

Re: [Xen-devel] [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

2017-09-27 Thread Alistair Francis
On Tue, Sep 26, 2017 at 6:32 AM, Eric Blake wrote: > On 09/25/2017 07:08 PM, Alistair Francis wrote: >> Replace all occurs of __FUNCTION__ except for the check in checkpatch >> with the non GCC specific __func__. >> >> One line in hcd-musb.c was manually tweaked to pa

Re: [Xen-devel] [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr, "*\n" with error_report()

2017-09-27 Thread Alistair Francis
On Mon, Sep 25, 2017 at 8:51 PM, Thomas Huth wrote: > On 26.09.2017 02:08, Alistair Francis wrote: >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues w

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Alistair Francis
On Thu, Apr 20, 2017 at 12:05 PM, Eric Blake wrote: > On 04/20/2017 11:18 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 04/20/2017 06:59 AM, Markus Armbruster wrote: >>> No objection to Alistair's idea to turn this into an enumeration. >>> >>> Question - should the enum b

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-19 Thread Alistair Francis
On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake wrote: > Libvirt would like to be able to distinguish between a SHUTDOWN > event triggered solely by guest request and one triggered by a > SIGTERM or other action on the host. qemu_kill_report() is > already able to tell whether a shutdown was triggere

[Xen-devel] [PATCH 1/2] tools: Use POSIX poll.h instead of sys/poll.h

2017-04-17 Thread Alistair Francis
The POSIX spec specifies to use: #include instead of: #include as seen here: http://pubs.opengroup.org/onlinepubs/009695399/functions/poll.html This removes the warning: #warning redirecting incorrect #include to when building with the musl C-library. Signed-off-by: Alistair

[Xen-devel] [PATCH 2/2] tools: Use POSIX signal.h instead of sys/signal.h

2017-04-17 Thread Alistair Francis
The POSIX spec specifies to use: #include instead of: #include as seen here: http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html This removes the warning: #warning redirecting incorrect #include to when building with the musl C-library. Signed-off-by: Alistair

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 2:11 PM, Alistair Francis wrote: > On Thu, Dec 22, 2016 at 2:00 PM, Doug Goldstein wrote: >> On 12/22/16 3:47 PM, Andrew Cooper wrote: >>> On 22/12/16 21:41, Alistair Francis wrote: >>>> On Thu, Dec 22, 2016 at 1:15 PM, Alistair Francis >

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 2:00 PM, Doug Goldstein wrote: > On 12/22/16 3:47 PM, Andrew Cooper wrote: >> On 22/12/16 21:41, Alistair Francis wrote: >>> On Thu, Dec 22, 2016 at 1:15 PM, Alistair Francis >>> wrote: >>>> On Thu, Dec 22, 2016 at 1:12 PM, Alistair

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 1:15 PM, Alistair Francis wrote: > On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis > wrote: >> On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson >> wrote: >>> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded >&g

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis wrote: > On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson > wrote: >> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded >> strict -Werror checking"): >>> On Thu, Dec 22, 2016 at

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson wrote: > Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded > strict -Werror checking"): >> On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich wrote: >>> On 20.12.16 at 20:46, wrote: >&g

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich wrote: >>>> On 20.12.16 at 20:46, wrote: >> Signed-off-by: Alistair Francis > > Without some rationale given I don't think such changes are > acceptable at all. And then, as already pointed out others, the > use o

Re: [Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 2:54 AM, Wei Liu wrote: > On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote: >> To avoid build errors related to missing file 'sys/sysctl.h' by removing >> the #include statement. >> >> Signed-off-by: Alistair Francis

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 12:16 PM, Andrew Cooper wrote: > On 20/12/2016 20:06, Doug Goldstein wrote: >> On 12/20/16 1:46 PM, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> Config.mk | 2 +- >>> tools/bl

Re: [Xen-devel] [PATCH v2 0/5] General Build Fixes

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 11:53 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 11:46:55AM -0800, Alistair Francis wrote: >> This patch series is a list of build issues that appeared when >> buildling Xen 4.8.0 in buildroot. Hopefully some of them can be > > Is t

[Xen-devel] [PATCH v2 0/5] General Build Fixes

2016-12-20 Thread Alistair Francis
it shouldn't break glibc though). Instead of renaming the #include files I have just removed the -Werror flags. - Allow people building Xen to pass in EXTRA_CFLAGS. Alistair Francis (5): Remove hardcoded strict -Werror checking config/StdGNU.mk: Allows users to pa

[Xen-devel] [PATCH v2 2/5] config/StdGNU.mk: Allows users to pass in EXTRA_CFLAGS

2016-12-20 Thread Alistair Francis
Signed-off-by: Alistair Francis --- config/StdGNU.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/StdGNU.mk b/config/StdGNU.mk index 6be8233..a6cdd82 100644 --- a/config/StdGNU.mk +++ b/config/StdGNU.mk @@ -35,6 +35,9 @@ UTIL_LIBS = -lutil SONAME_LDFLAG = -soname SHLIB_LDFLAGS

[Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include

2016-12-20 Thread Alistair Francis
To avoid build errors related to missing file 'sys/sysctl.h' by removing the #include statement. Signed-off-by: Alistair Francis --- tools/blktap2/drivers/block-remus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/blktap2/drivers/block-remus.c b/tools/blktap2/drivers/blo

[Xen-devel] [PATCH v2 3/5] tools/blktap2/vhd: Remove unused struct stat stats

2016-12-20 Thread Alistair Francis
The unsued variable 'struct stat stats' causes build errors in some situations. As it isn't used just remove it. Signed-off-by: Alistair Francis --- tools/blktap2/vhd/lib/libvhd-journal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c

[Xen-devel] [PATCH v2 4/5] tools/blktap2: Fix missing header file

2016-12-20 Thread Alistair Francis
To avoid build errors relating to missing delcarations of ssize_t add the appripriote header file to atomic.h. Signed-off-by: Alistair Francis --- tools/blktap2/include/atomicio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/blktap2/include/atomicio.h b/tools/blktap2/include

[Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
Signed-off-by: Alistair Francis --- Config.mk | 2 +- tools/blktap2/drivers/Makefile | 1 - tools/libxl/Makefile | 2 +- tools/xentrace/Makefile| 2 -- 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Config.mk b/Config.mk index 3ec7367

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Mon, Dec 19, 2016 at 7:53 PM, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >> >> >> Why? > > *adjusts his distro

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
7/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >> >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> >>>> Signed-off-by: Alistair Francis >> >>> >> >>> >> >>> Why? >> >> >> >> *adju

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-20 Thread Alistair Francis
On Mon, Dec 19, 2016 at 8:00 PM, Doug Goldstein wrote: > On 12/19/16 12:01 PM, Alistair Francis wrote: >> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk >> wrote: >>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote: >>>> To avoid this

Re: [Xen-devel] [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h

2016-12-19 Thread Alistair Francis
On Sat, Dec 17, 2016 at 7:56 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote: >> To avoid this build error with newer build systems: >> error: #warning redirecting incorrect #include to >> [-Werror=cpp

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-19 Thread Alistair Francis
On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote: >> To avoid this build error with newer build systems: > > And what is newer? GCC 5? 6? In this case it is GCC 5. Thanks, Alistair > > Thanks.

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-19 Thread Alistair Francis
On Sat, Dec 17, 2016 at 7:51 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis > > > Why? Hey Konrad, The problem that I have is that we build Xen releases in buildroot. As things change (G

[Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-16 Thread Alistair Francis
To avoid this build error with newer build systems: error: #warning redirecting incorrect #include to [-Werror=cpp] Rename sys/poll.h to poll.h Signed-off-by: Alistair Francis --- tools/libxl/libxl_internal.h | 2 +- tools/tests/xen-access/xen-access.c| 2

[Xen-devel] [PATCH 7/7] tools/blktap2: Fix missing header file

2016-12-16 Thread Alistair Francis
To avoid build errors relating to missing delcarations of ssize_t add the appripriote header file to atomic.h. Signed-off-by: Alistair Francis --- tools/blktap2/include/atomicio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/blktap2/include/atomicio.h b/tools/blktap2/include

[Xen-devel] [PATCH 0/7] General Build Fixes

2016-12-16 Thread Alistair Francis
This patch series is a list of build issues that appeared when buildling Xen 4.8.0 in buildroot. Hopefully some of them can be accepted upstream to help others who are trying to build Xen in the future. Alistair Francis (6): Remove hardcoded strict -Werror checking tools/libxl: Remove

[Xen-devel] [PATCH 2/7] tools/libxl: Remove hardcoded strict -Werror checking

2016-12-16 Thread Alistair Francis
Signed-off-by: Alistair Francis --- tools/libxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 91e2f97..e8a37ef 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -11,7 +11,7 @@ MINOR = 0 XLUMAJOR = 4.9

[Xen-devel] [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment

2016-12-16 Thread Alistair Francis
From: "Yann E. MORIN" When CFLAGS are passed from the environment, the first-level make invocation will append -D__OBJECT_FILE__ to it, then call a second make invocation, that will have those new CFLAGS in its environment, but will also append -D__OBJECT_FILE__ to those. Then, the compiler fail

[Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-16 Thread Alistair Francis
Signed-off-by: Alistair Francis --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 3ec7367..e3cda81 100644 --- a/Config.mk +++ b/Config.mk @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y SHELL ?= /bin/sh # Tools to run on system hosting

[Xen-devel] [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h

2016-12-16 Thread Alistair Francis
To avoid this build error with newer build systems: error: #warning redirecting incorrect #include to [-Werror=cpp] Rename sys/signal.h to signal.h Signed-off-by: Alistair Francis --- tools/blktap2/drivers/tapdisk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Xen-devel] [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats

2016-12-16 Thread Alistair Francis
The unsued variable 'struct stat stats' causes build errors in some situations. As it isn't used just remove it. Signed-off-by: Alistair Francis --- tools/blktap2/vhd/lib/libvhd-journal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c

Re: [Xen-devel] Xen ARM community call

2016-11-08 Thread Alistair Francis
On Tue, Nov 8, 2016 at 4:19 AM, Julien Grall wrote: > Hi all, > ... > I would suggest to start with a 1 hour meeting on the Wednesday 23rd > November. I know that people are spread across different timezones, so I > would like to gather thought before choosing a time. I can't make it that week, b

Re: [Xen-devel] [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

2016-10-07 Thread Alistair Francis
s solution looks fine to me and everything boots on ZynqMP as expected with this patch. Acked-by: Alistair Francis Thanks, Alistair > --- > xen/arch/arm/domain_build.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build