flight 110403 xen-4.7-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110403/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-xsm5 xen-buildfail REGR. vs. 109620
build-i386
On 14/06/17 02:47, Stefano Stabellini wrote:
> On Tue, 13 Jun 2017, Juergen Gross wrote:
>> On 02/06/17 21:31, Stefano Stabellini wrote:
>>> Implement the accept command by calling inet_accept. To avoid blocking
>>> in the kernel, call inet_accept(O_NONBLOCK) from a workqueue, which get
>>> schedul
flight 110401 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110401/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qcow210 guest-start fail REGR. vs. 109975
test-amd64-amd64-
Hi Julien,
+}
+
+static void vpl011_update(struct domain *d)
+{
+struct vpl011 *vpl011 = &d->arch.vpl011;
+
+/*
+ * TODO: PL011 interrupts are level triggered which means
+ * that interrupt needs to be set/clear instead of being
+
flight 110399 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110399/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 12 guest-saverestore fail REGR.
vs. 110380
Regressio
flight 110396 linux-4.9 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110396/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl-credit2 6 xen-boot fail REGR. vs. 107358
Regressions which are
This patch adds L2 CAT description in related documents.
Signed-off-by: He Chen
Signed-off-by: Yi Sun
Acked-by: Wei Liu
---
docs/man/xl.pod.1.in | 25 ++---
docs/misc/xl-psr.markdown | 18 --
2 files changed, 34 insertions(+), 9 deletions(-)
diff --git
This patch implements the xl/xc changes to support set CBM
for L2 CAT.
The new level option is introduced to original CAT setting
command in order to set CBM for specified level CAT.
- 'xl psr-cat-set' is updated to set cache capacity bitmasks(CBM)
for a domain according to input cache level.
r
This patch implements the CPU init flow for L2 CAT.
Signed-off-by: Yi Sun
---
v12:
- move 'type[]' assignment into l2_cat_props declaration to make it be
'const'.
(suggested by Jan Beulich)
- add "L2 CAT" indicator in printk.
(suggested by Jan Beulich)
- restore mask
Continue from patch:
'x86: refactor psr: L3 CAT: set value: assemble features value array'
We can try to find if there is a COS ID on which all features' COS registers
values are same as the array assembled before.
Signed-off-by: Yi Sun
---
v12:
- use 'ARRAY_SIZE' to calculate array boundary
This patch implements xl/xc changes to support get HW info
for L2 CAT.
'xl psr-hwinfo' is updated to show both L3 CAT and L2 CAT
info.
Example(on machine which only supports L2 CAT):
Cache Monitoring Technology (CMT):
Enabled : 0
Cache Allocation Technology (CAT): L2
Socket ID : 0
M
This patch implements L3 CDP set value related callback function.
With this patch, 'psr-cat-cbm-set' command can work for L3 CDP.
Signed-off-by: Yi Sun
---
v12:
- add comment to explain how to deal with the case that user set new val
for both DATA and CODE at same time.
- add param
This patch implements L2 CAT get value interface in domctl.
Signed-off-by: Yi Sun
Reviewed-by: Jan Beulich
---
v11:
- remove "get_val' assignment because it has been replaced by generic
codes.
(suggested by Jan Beulich)
v10:
- remove cast in domctl.
(suggested by Jan Be
This patch implements L2 CAT get HW info flow and interface in sysctl.
Signed-off-by: Yi Sun
---
v10:
- modify macro name according to previous patch change.
(suggested by Jan Beulich)
- modify commit message.
v9:
- reuse 'cat_get_feat_info' for L2 CAT to reduce redundant codes.
This patch implements changes in xl/xc changes to support
showing CBM of L2 CAT.
The new level option is introduced to original CAT showing
command in order to show CBM for specified level CAT.
- 'xl psr-cat-show' is updated to show CBM of a domain
according to input cache level.
Examples:
root
Continue from previous patch:
'x86: refactor psr: L3 CAT: set value: implement cos id picking flow.'
We have got the feature value and COS ID to set. Then, we write MSRs of the
designated feature.
Till now, set value process is completed.
Signed-off-by: Yi Sun
---
v12:
- declare same type v
The current cache allocation codes in psr.c do not consider
future features addition and are not friendly to extend.
To make psr.c be more flexible to add new features and fulfill
the program principle, open for extension but closed for
modification, we have to refactor the psr.c:
1. Analyze cache
To construct an extendible framework, we need analyze PSR features
and abstract the common things and feature specific things. Then,
encapsulate them into different data structures.
By analyzing PSR features, we can get below map.
+--+--+--+
->| Dom0 | Dom
As set value flow is the most complicated one in psr, it will be
divided to some patches to make things clearer. This patch
implements the set value framework to show a whole picture firstly.
It also changes domctl interface to make it more general.
To make the set value flow be general and can s
Continue from previous patch:
'x86: refactor psr: L3 CAT: set value: implement cos finding flow.'
If fail to find a COS ID, we need pick a new COS ID for domain. Only COS ID
that ref[COS_ID] is 1 or 0 can be picked to input a new set feature values.
Signed-off-by: Yi Sun
---
v12:
- use 'ASSE
This patch implements get HW info flow for CDP including L3 CDP callback
function. The flow is almost same as L3 CAT.
With this patch, 'psr-hwinfo' can work for L3 CDP.
Signed-off-by: Yi Sun
---
v12:
- remove input parameter 'info' in 'psr_cbm_type_to_feat_type'. Use
'feat_props' array
This patch moves 'cpuid_count_leaf' from cpuid.c to processor.h to
make it available to external codes.
Signed-off-by: Yi Sun
Acked-by: Jan Beulich
---
v9:
- create this patch alone to move 'cpuid_count_leaf'.
(suggested by Wei Liu)
v6:
- use 'struct cpuid_leaf' in psr.c. So we hav
This patch implements L2 CAT set value related callback function
and domctl interface.
Signed-off-by: Yi Sun
Reviewed-by: Jan Beulich
---
v11:
- remove 'domctl->u.psr_cat_op.data' check because it has been moved into
'psr_set_val'.
(suggested by Jan Beulich)
- move 'feat->cos
There is an interface in user space to show feature value of
domains.
This patch implements get value flow in hypervisor.
It also changes domctl interface to make it more general.
With this patch, 'psr-cat-show' can work for L3 CAT but not for
L3 code/data which is implemented in CDP related pat
Only can one COS ID be used by one domain at one time. That means all enabled
features' COS registers at this COS ID are valid for this domain at that time.
When user updates a feature's value, we need make sure all other features'
values are not affected. So, we firstly need gather an array which
This patch implements the CPU init flow for CDP. The flow is almost
same as L3 CAT.
Signed-off-by: Yi Sun
---
v12:
- move 'type[]' assignment into l3_cdp_props declaration to make it be
'const'.
(suggested by Jan Beulich)
- remove "L2 CAT" indication in printk.
(suggeste
Hi all,
We plan to bring a new PSR (Platform Shared Resource) feature called
Intel L2 Cache Allocation Technology (L2 CAT) to Xen. It has been enabled
in Linux Kernel.
Besides the L2 CAT implementaion, we refactor the psr.c to make it more
flexible and easily to extend to add new features. We abs
This patch implements get HW info flow including L3 CAT callback
function.
It also changes sysctl interface to make it more general.
With this patch, 'psr-hwinfo' can work for L3 CAT.
Signed-off-by: Yi Sun
Reviewed-by: Jan Beulich
---
v12:
- use 'ASSERT_UNREACHABLE()' to record bug.
This patch implements the Domain init/free and schedule flows.
- When domain init, its psr resource should be allocated.
- When domain free, its psr resource should be freed too.
- When domain is scheduled, its COS ID on the socket should be
set into ASSOC register to make corresponding COS MSR v
This patch creates CAT and CDP feature document in doc/features/. It describes
key points to implement L3 CAT/CDP and L2 CAT which is described in details in
Intel SDM "INTEL® RESOURCE DIRECTOR TECHNOLOGY (INTEL® RDT) ALLOCATION
FEATURES".
Signed-off-by: Yi Sun
Reviewed-by: Konrad Rzeszutek Wilk
GCC 7.1.1 complains that several buffers passed to snprintf() in xenpmd
and tools/ocmal/xc are too small to hold the largest possible resulting string,
which is calculated by adding up the maximum length of all the substrings.
The warnings are treated as errors by -Werror, and goes like this (abbr
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > When the other end notifies us that there is data to be written
> > (pvcalls_back_conn_event), increment the io and write counters, and
> > schedule the ioworker.
> >
> > Implement the write function calle
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > When an active socket has data available, increment the io and read
> > counters, and schedule the ioworker.
> >
> > Implement the read function by reading from the socket, writing the data
> > to the data
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > We have one ioworker per socket. Each ioworker goes through the list of
> > outstanding read/write requests. Once all requests have been dealt with,
> > it returns.
> >
> > We use one atomic counter per so
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Implement backend_disconnect. Call pvcalls_back_release_active on active
> > sockets and pvcalls_back_release_passive on passive sockets.
> >
> > Implement module_exit by calling backend_disconnect on fron
flight 110398 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110398/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-localmigrate/x10 fail REGR.
vs. 110383
Tests which
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Release both active and passive sockets. For active sockets, make sure
> > to avoid possible conflicts with the ioworker reading/writing to those
> > sockets concurrently. Set map->release to let the iowork
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Implement poll on passive sockets by requesting a delayed response with
> > mappass->reqcopy, and reply back when there is data on the passive
> > socket.
> >
> > Poll on active socket is unimplemented as
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Allocate a socket. Keep track of socket <-> ring mappings with a new data
> > structure, called sock_mapping. Implement the connect command by calling
> > inet_stream_connect, and mapping the new indexes pa
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Allocate a socket. Track the allocated passive sockets with a new data
> > structure named sockpass_mapping. It contains an unbound workqueue to
> > schedule delayed work for the accept and poll commands. I
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Implement the accept command by calling inet_accept. To avoid blocking
> > in the kernel, call inet_accept(O_NONBLOCK) from a workqueue, which get
> > scheduled on sk_data_ready (for a passive socket, it me
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Just reply with success to the other end for now. Delay the allocation
> > of the actual socket to bind and/or connect.
> >
> > Signed-off-by: Stefano Stabellini
> > CC: boris.ostrov...@oracle.com
> > CC:
This run is configured for baseline tests only.
flight 71560 ovmf real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/71560/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
build-amd64-libvirt 5 libvirt-buildfai
On Tue, 13 Jun 2017, Juergen Gross wrote:
> On 02/06/17 21:31, Stefano Stabellini wrote:
> > Also add pvcalls-back to the Makefile.
> >
> > Signed-off-by: Stefano Stabellini
> > CC: boris.ostrov...@oracle.com
> > CC: jgr...@suse.com
> > ---
> > drivers/xen/Kconfig | 12
> > drivers
flight 110416 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110416/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a
test-amd64-amd64-libvirt 12 mig
flight 110397 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110397/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 110231
test-armhf-armhf-libvirt-raw 12 saveresto
On Tue, 13 Jun 2017, Andre Przywara wrote:
> Recently there were some discussions about the nature and guarantees of
> the atomic primitives that Xen provides.
> This README.atomic file tries to document our expectations in those
> functions and macros.
>
> Signed-off-by: Andre Przywara
> ---
> H
On Tue, 13 Jun 2017, Julien Grall wrote:
> On 12/06/2017 23:34, Stefano Stabellini wrote:
> > On Mon, 12 Jun 2017, Julien Grall wrote:
> > > Hi Andre,
> > >
> > > On 09/06/17 18:41, Andre Przywara wrote:
> > > > When reading the priority value of a virtual interrupt, we were taking
> > > > the res
On Fri, 9 Jun 2017, Andre Przywara wrote:
> @@ -375,6 +390,131 @@ out_unlock:
> return ret;
> }
>
> +/* Must be called with the ITS lock held. */
> +static int its_discard_event(struct virt_its *its,
> + uint32_t vdevid, uint32_t vevid)
> +{
> +struct pending
On 06/13/2017 04:36 PM, Dario Faggioli wrote:
> On Tue, 2017-06-13 at 14:39 -0400, Boris Ostrovsky wrote:
>> On 06/13/2017 04:19 AM, Jan Beulich wrote:
>> On 12.06.17 at 23:28, wrote:
If some vcpu context work is scheduled, SCHEDULE_SOFTIRQ is
raised.
do_softirq() will call the
Hi Dario,
Besides the sockperf benchmark, I also did another test with memcached
as the I/O application. The client side I use cloudsuite 3.0 as the
request generator. The command from the client side is as follows:
$ ./loader -a ../twitter_dataset/twitter_dataset_30x -s servers.txt -g
0.8 -T 20
flight 110392 xen-4.9-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110392/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail REGR. vs. 110219
Tests which did not succ
On Tue, Jun 13, 2017 at 3:51 PM, Dario Faggioli
wrote:
> On Tue, 2017-06-13 at 14:59 -0500, T S wrote:
>> Hi all,
>>
> Hi,
>
> Nice to hear from you again... You guys always have interesting things
> to say/report/etc., about scheduling... I truly appreciate what you
> do! :-)
>
Thank you for you
On Tue, 2017-06-13 at 17:07 +0100, Anshul Makkar wrote:
> On 12/06/2017 14:19, Dario Faggioli wrote:
> > > > @@ -92,6 +92,82 @@
> > > > */
> > > >
> > > > /*
> > > > + * Utilization cap:
> > > > + *
> > > > + * Setting an pCPU utilization cap for a domain means the
> > > > following:
> > > > +
On 13/06/17 21:51, Andrew Cooper wrote:
> A symndx of STN_UNDEF is special, and means a symbol value of 0.
>
> There is no real symbol data for it, so avoid tripping over a NULL pointer
> with "elf->sym[symndx].sym->st_value".
>
> Signed-off-by: Andrew Cooper
> ---
> CC: Konrad Rzeszutek Wilk
> C
A symndx of STN_UNDEF is special, and means a symbol value of 0.
There is no real symbol data for it, so avoid tripping over a NULL pointer
with "elf->sym[symndx].sym->st_value".
Signed-off-by: Andrew Cooper
---
CC: Konrad Rzeszutek Wilk
CC: Ross Lagerwall
CC: Jan Beulich
CC: Stefano Stabelli
On Tue, 2017-06-13 at 14:59 -0500, T S wrote:
> Hi all,
>
Hi,
Nice to hear from you again... You guys always have interesting things
to say/report/etc., about scheduling... I truly appreciate what you
do! :-)
> When I was executing the latency-sensitive applications in VMs on the
> latest Xen,
>
* Reduce symbol scope and initalisation as much as possible
* Annotate a fallthrough case in arm64
* Fix switch statement style in arm32
No functional change.
Signed-off-by: Andrew Cooper
---
CC: Konrad Rzeszutek Wilk
CC: Ross Lagerwall
CC: Jan Beulich
CC: Stefano Stabellini
CC: Julien Gr
On Tue, 2017-06-13 at 14:39 -0400, Boris Ostrovsky wrote:
> On 06/13/2017 04:19 AM, Jan Beulich wrote:
> > > > > On 12.06.17 at 23:28, wrote:
> > > If some vcpu context work is scheduled, SCHEDULE_SOFTIRQ is
> > > raised.
> > > do_softirq() will call the scheduler, which will see that there
> > >
flight 110415 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110415/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-armhf 5 xen-buildfail REGR. vs. 110412
Tests which
Hi all,
When I was executing the latency-sensitive applications in VMs on the
latest Xen,
I found the rate limit will cause the long tail latency for VMs
sharing CPU with other VMs.
(1) Problem description
Description
My test environment is as follows: Hypervisor(Xen 4.8
On Tue, 2017-06-13 at 21:27 +0200, Juergen Gross wrote:
> On 13/06/17 18:31, Joe Perches wrote:
> > On Tue, 2017-06-13 at 18:13 +0200, Juergen Gross wrote:
> > > On 13/06/17 17:20, Ingo Molnar wrote:
> > > > * Juergen Gross wrote:
> > > >
> > > > > When running under Xen as dom0 /dev/mcelog is be
On 13/06/17 18:31, Joe Perches wrote:
> On Tue, 2017-06-13 at 18:13 +0200, Juergen Gross wrote:
>> On 13/06/17 17:20, Ingo Molnar wrote:
>>> * Juergen Gross wrote:
>>>
When running under Xen as dom0 /dev/mcelog is being registered by Xen
instead of the normal mcelog driver. Avoid an erro
flight 110412 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110412/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a
test-amd64-amd64-libvirt 12 mig
On 06/13/2017 04:19 AM, Jan Beulich wrote:
On 12.06.17 at 23:28, wrote:
>> On Mon, 2017-06-12 at 13:01 -0400, Boris Ostrovsky wrote:
>>> On 06/12/2017 04:08 AM, Jan Beulich wrote:
>>> On 19.05.17 at 17:50, wrote:
> Instead of scrubbing pages during guest destruction (from
> free_
On 06/13/2017 10:28 AM, Sarah Newman wrote:
> On 06/13/2017 10:08 AM, Wei Liu wrote:
>> On Tue, Jun 13, 2017 at 05:56:26PM +0100, Wei Liu wrote:
>>> On Tue, Jun 13, 2017 at 09:29:22AM -0700, Sarah Newman wrote:
Hi,
With xen 4.8.1, I got the error message:
libxl: error: libx
+if ( node_need_scrub[node] )
+{
+if ( !get_node )
+return node;
+
+dist = __node_distance(local_node, node);
+if ( dist < shortest || closest == NUMA_NO_NODE )
+{
+
flight 110393 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110393/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 983f59932db28ae37b9f9e545c1258bc59aa71ca
baseline version:
ovmf ec4910cd3336565fdb61d
On Tue, 13 Jun 2017, Ian Jackson wrote:
> Stefano Stabellini writes ("tags in backport commits"):
> > Specifically, I would like to see a tag that specifies the id of the
> > original commit, like "master commit" that Jan is using today. I would
> > prefer if the tag didn't have any spaces, thus, I
On Tue, 13 Jun 2017, Julien Grall wrote:
> > > > tools/console/daemon/io.c| 2 +-
> > > > xen/arch/arm/Kconfig | 5 +
> > > > xen/arch/arm/Makefile| 1 +
> > > > xen/arch/arm/vpl011.c| 418
> > > > +++
> > > > xe
On Tue, 13 Jun 2017, George Dunlap wrote:
> On 13/06/17 08:28, Jan Beulich wrote:
> >> Moreover, I think we should start using tags in our staging commits
> >> which specify to which trees a given commit should be backported to as
> >> soon as it passes the push gate.
> >
> > But that's already a
On 06/13/2017 10:08 AM, Wei Liu wrote:
> On Tue, Jun 13, 2017 at 05:56:26PM +0100, Wei Liu wrote:
>> On Tue, Jun 13, 2017 at 09:29:22AM -0700, Sarah Newman wrote:
>>> Hi,
>>>
>>> With xen 4.8.1, I got the error message:
>>>
>>> libxl: error: libxl_dom.c:60:libxl__domain_cpupool: got info for dom209
On Tue, Jun 13, 2017 at 05:56:26PM +0100, Wei Liu wrote:
> On Tue, Jun 13, 2017 at 09:29:22AM -0700, Sarah Newman wrote:
> > Hi,
> >
> > With xen 4.8.1, I got the error message:
> >
> > libxl: error: libxl_dom.c:60:libxl__domain_cpupool: got info for dom2098,
> > wanted dom2097
> > : No such fil
On Wed, May 31, 2017 at 06:41:12PM +, Ian Murray wrote:
> All,
> Having a very strange problem. I created a CentOS 7 PV vm but could not get
> pygrub to pick-up the grub entries. I did some fault finding and concluded
> that `fsimage` was unable to find the grub.cfg.
> I could start the vm as
On Tue, Jun 13, 2017 at 09:29:22AM -0700, Sarah Newman wrote:
> Hi,
>
> With xen 4.8.1, I got the error message:
>
> libxl: error: libxl_dom.c:60:libxl__domain_cpupool: got info for dom2098,
> wanted dom2097
> : No such file or directory
>
> This was while creating an HVM domain with a stub dom
On 01/06/17 18:33, Dario Faggioli wrote:
> Hello,
>
> While chasing and dealing with bugs, over this last period, I've found myself
> augmenting Xen with quite a few new tracing capabilities, especially focusing
> on:
> - IRQ being disabled and (re)enabled (in addition to the already existing
>
On Tue, 2017-06-13 at 18:13 +0200, Juergen Gross wrote:
> On 13/06/17 17:20, Ingo Molnar wrote:
> > * Juergen Gross wrote:
> >
> > > When running under Xen as dom0 /dev/mcelog is being registered by Xen
> > > instead of the normal mcelog driver. Avoid an error message being
> > > issued by the mc
Hi,
With xen 4.8.1, I got the error message:
libxl: error: libxl_dom.c:60:libxl__domain_cpupool: got info for dom2098,
wanted dom2097
: No such file or directory
This was while creating an HVM domain with a stub domain, probably concurrent
to creating a PV domain. The domains were created as 2
On 13/06/17 17:13, Julien Grall wrote:
> INVALID_{G,M}FN are defined using static inline helpers _{g,m}fn.
> This means, they cannot be used to initialize a build time static variable:
>
> In file included from mm.c:24:0:
> xen/xen/include/xen/mm.h:59:26: error: initializer element is not constant
flight 110408 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/110408/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a
test-amd64-amd64-libvirt 12 mig
On Tue, Jun 13, 2017 at 09:00:01AM -0700, Andy Lutomirski wrote:
> 1. Make sure that every read_cr3() instance got converted. I didn't
> want a mid-air collision with someone else's patch in which it would
> appear to apply and compile but the result would randomly fail on PCID
> systems.
Right.
The file xen/arch/arm/domain_build.c is using typesafe MFN in most of
the place. The only caller to virt_to_mfn is using prefixed with
_mfn(...).
To avoid extra _mfn(...), re-define virt_to_mfn within
arch/arm/domain_build.c to handle typesafe MFN.
Signed-off-by: Julien Grall
---
xen/arch/arm/d
Add a bit more safety when using create_xen_entries.
Also when destroying/modifying mapping, the MFN is currently not used.
Rather than passing _mfn(0) use INVALID_MFN to stay consistent with the
other usage.
Signed-off-by: Julien Grall
---
xen/arch/arm/mm.c | 19 ++-
1 file cha
Signed-off-by: Julien Grall
---
xen/arch/arm/acpi/lib.c | 4 ++--
xen/arch/arm/kernel.c | 4 +---
xen/arch/arm/mm.c | 4 ++--
xen/arch/arm/platforms/vexpress.c | 2 +-
xen/drivers/video/arm_hdlcd.c | 2 +-
xen/include/asm-arm/mm.h | 2 +-
6 files
Add a new helper clear_table to clear a page table entry and invalidate
the cache.
Signed-off-by: Julien Grall
---
xen/arch/arm/mm.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 082c872c72..b4ff777b55 100
The file xen/arch/arm/alternative.c is using typesafe MFN in most of
the place. The only caller to virt_to_mfn is using with _mfn(...).
To avoid extra _mfn(...), re-define virt_to_mfn within
xen/arch/arm/alternative.c to handle typesafe MFN.
Signed-off-by: Julien Grall
---
xen/arch/arm/alternat
Replace the following constructions:
- _gfn(paddr_to_pfn(...)) => gaddr_to_gfn(...)
- _mfn(paddr_to_pfn(...)) => maddr_to_mfn(...)
- pfn_to_paddr(mfn_x(...)) => mfn_to_maddr(...)
- pfn_to_paddr(gfn_x(...)) => gfn_to_gaddr(...)
- _mfn(... >> PAGE_SHIFT) => maddr_to_mfn(..
The file xen/arch/arm/mm.c is using the typesafe MFN in most of the
place. This requires all caller of virt_to_mfn to prefixed by _mfn(...).
To avoid the extra _mfn(...), re-defined virt_to_mfn within arch/arm/mm.c
to handle typesafe MFN.
This patch also introduce __virt_to_mfn, so virt_to_mfn ca
xenheap_mfn_end is storing an MFN and not a physical address. Thankfully
xenheap_mfn_end is not used in the arm64 code. So drop it.
Signed-off-by: Julien Grall
---
xen/arch/arm/setup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index f00f29a4
Signed-off-by: Julien Grall
---
xen/arch/arm/gic-v2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 270a1362ec..f8124e5e54 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -598,8 +598,8 @@ static int gi
INVALID_{G,M}FN are defined using static inline helpers _{g,m}fn.
This means, they cannot be used to initialize a build time static variable:
In file included from mm.c:24:0:
xen/xen/include/xen/mm.h:59:26: error: initializer element is not constant
#define INVALID_MFN _mfn(~0UL)
Signed-off
The file xen/arch/arm/p2m.c is using typesafe MFN in most of the place.
This requires caller to mfn_to_page and page_to_mfn to use _mfn/mfn_x.
To avoid extra _mfn/mfn_x, re-define mfn_to_page and page_to_mfn within
xen/arch/arm/p2m.c to handle typesafe MFN.
Signed-off-by: Julien Grall
---
xen/a
The file xen/arch/arm/livepatch.c is using typesafe MFN in most of
the place. The only caller to virt_to_mfn is using with _mfn(...).
To avoid extra _mfn(...), re-define virt_to_mfn within
xen/arch/arm/livepatch.c to handle typesafe MFN.
Signed-off-by: Julien Grall
Cc: Ross Lagerwall
Cc: Konrad
This is matching the x86 side where the __* version is used if you need
to override the helpers in source files.
At the same time, move the non-underscore version at the end of the
defintion and add a comment to explain them.
Signed-off-by: Julien Grall
---
xen/include/asm-arm/mm.h | 13 +++
The physical address is computed from the machine frame number, so
checking if the physical address is page aligned is pointless.
Furthermore, directly assigned the MFN to the corresponding field in the
entry rather than converting to a physical address and orring the value.
It will avoid to rely
gfn_to_mfn is a wrapper of p2m_lookup which does not return the
p2m_type.
Signed-off-by: Julien Grall
---
xen/arch/arm/traps.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 6cf9ee7244..ce19021f01 100644
--- a/xen/arc
Signed-off-by: Julien Grall
---
xen/arch/arm/mm.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index d164ed2eda..08116679ec 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -259,7 +259,7 @@ v
Fix the comment coding style and add a newline before the return.
Signed-off-by: Julien Grall
---
xen/arch/arm/mm.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 587a6b3975..6f63e4315a 100644
--- a/xen/arch/arm
Signed-off-by: Julien Grall
---
xen/arch/arm/mm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 8573192e3a..452c1e26c3 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -181,7 +181,7 @@ void dump_pt_walk(paddr_t ttbr, p
paddr_to_pfn(virt_to_maddr(.)) and virt_to_mfn(.) are equivalent.
Signed-off-by: Julien Grall
---
xen/arch/arm/domain_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 3abacc0d80..a04c8862db 100644
--- a/xe
1 - 100 of 187 matches
Mail list logo
