Re: [Xen-devel] [PATCH] Use non-debug build for Xen 4.9

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 17:38, wrote: > Modify Config.mk and Kconfig.debug to disable debug by default in > preparation for late RCs and eventual release. > > Signed-off-by: Julien Grall To avoid pointless code churn on the master branch, shouldn't this be done only after (or even while) branching?

Re: [Xen-devel] [PATCH 3/3] arm: fix build with gcc 7

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 20:35, wrote: > On Thu, 18 May 2017, Julien Grall wrote: >> Hi, >> >> On 18/05/17 09:41, Jan Beulich wrote: >> > The compiler dislikes duplicat "const", and the ones it complains about >> >> s/duplicat/duplicate/ >> >> > look like they we in fact meant to be placed differentl

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

2017-05-18 Thread Goel, Sameer
On 12/29/2016 7:04 AM, Julien Grall wrote: > > ### Finding the StreamID and DeviceID > > The static table IORT (see [5]) will provide information that will help to > deduce the StreamID and DeviceID from a given RID. > IORT table will also need some information on PCI seg to parse through the

Re: [Xen-devel] [PATCH v1 08/10] iommu: Split iommu_hwdom_init() into arch specific parts

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 20:06, wrote: > On Thu, May 18, 2017 at 11:53 AM, Jan Beulich wrote: > On 17.05.17 at 22:30, wrote: >>> On 05/17/2017 07:51 PM, Oleksandr Tyshchenko wrote: On Wed, May 17, 2017 at 7:01 PM, Jan Beulich wrote: > Well, if the ARM maintainers insist on baking their o

Re: [Xen-devel] [PATCH v1 06/10] iommu: Add extra use_iommu argument to iommu_domain_init()

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 19:41, wrote: > patch #6: As for the current patch, likely the "init" platform > callback should be extended with > extra "use_iommu" argument as well as the "iommu_domain_init" API. In > that case we > would just pass thought incoming flag to the IOMMU drivers followed by > upd

Re: [Xen-devel] [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 16:23, wrote: >> > --- a/xen/arch/x86/cpu/vpmu.c >> > +++ b/xen/arch/x86/cpu/vpmu.c >> > @@ -859,6 +859,7 @@ static int cpu_callback( >> > { >> > vpmu_save_force(vcpu); >> > vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >> > +per_cpu(last_vcpu, cpu) = NUL

Re: [Xen-devel] [PATCH 3/3] arm: fix build with gcc 7

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 17:12, wrote: > On 18/05/17 09:41, Jan Beulich wrote: >> The compiler dislikes duplicat "const", and the ones it complains about > > s/duplicat/duplicate/ > >> look like they we in fact meant to be placed differently. >> >> Also fix array_access_okay() (just like on x86), desp

Re: [Xen-devel] [PATCH] x86emul: MOVNTI does not allow 66/F3/F2 prefixes

2017-05-18 Thread Jan Beulich
>>> On 18.05.17 at 14:52, wrote: > On 18/05/17 13:35, Jan Beulich wrote: >> Intel SDM revision 062 finally makes this explicit. >> >> Signed-off-by: Jan Beulich > > So it does. Acked-by: Andrew Cooper I withdraw this patch as being redundant with 96a7cb37b9 ("x86emul: MOVNTI does not allow RE

[Xen-devel] [xtf test] 109589: all pass - PUSHED

2017-05-18 Thread osstest service owner
flight 109589 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/109589/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 1538388f283a3cba96c08177413eb415db78921a baseline version: xtf 88454e5ece8fc9caa23a2f

[Xen-devel] [linux-linus test] 109572: tolerable FAIL - PUSHED

2017-05-18 Thread osstest service owner
flight 109572 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/109572/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 5 xen-install fail in 109552 pass in 109572 test-armhf-armhf-libvirt 5 x

Re: [Xen-devel] [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-18 Thread Stefano Stabellini
On Wed, 17 May 2017, Juergen Gross wrote: > On 16/05/17 21:58, Stefano Stabellini wrote: > > On Tue, 16 May 2017, Juergen Gross wrote: > >> On 15/05/17 22:35, Stefano Stabellini wrote: > >>> The pvcalls backend has one ioworker per cpu: the ioworkers are > >>> implemented as a cpu bound workqueue,

Re: [Xen-devel] [PATCH v8 0/3] arm64, xen: add xen_boot support into grub-mkconfig

2017-05-18 Thread Daniel Kiper
On Mon, May 15, 2017 at 03:46:55PM +0200, Daniel Kiper wrote: > Hi Julien, > > On Mon, May 15, 2017 at 02:43:28PM +0100, Julien Grall wrote: > > Hi Daniel, > > > > On 15/05/17 14:38, Daniel Kiper wrote: > > >On Sun, May 14, 2017 at 03:43:44PM +0800, fu@linaro.org wrote: > > >>From: Fu Wei > >

Re: [Xen-devel] [PATCH 08/18] xen/pvcalls: implement connect command

2017-05-18 Thread Boris Ostrovsky
On 05/18/2017 03:10 PM, Stefano Stabellini wrote: > On Tue, 16 May 2017, Boris Ostrovsky wrote: > + ret = xenbus_map_ring_valloc(dev, &req->u.connect.ref, 1, &page); > + if (ret < 0) { > + sock_release(map->sock); > + kfree(map); > + goto out; > + } >

Re: [Xen-devel] xen/arm: Hiding SMMUs from Dom0 when using ACPI on Xen

2017-05-18 Thread Julien Grall
On 18/05/2017 21:02, Manish Jaggi wrote: In the IORT table using the PCI-RC node, SMMU node and ITS node, RID->StreamID->Device-ID mapping can be generated. As per IORT spec toady, same RID can be mapped to different StreamIDs using two ID Array elements with same RID range but different outp

Re: [Xen-devel] xen/arm: Hiding SMMUs from Dom0 when using ACPI on Xen

2017-05-18 Thread Manish Jaggi
Hi Julien, On 5/18/2017 8:27 PM, Julien Grall wrote: Hello, On 18/05/17 12:59, Manish Jaggi wrote: On 2/27/2017 11:42 PM, Julien Grall wrote: On 02/27/2017 04:58 PM, Shanker Donthineni wrote: Hi Julien, Hi Shanker, Please don't drop people in CC. In my case, any e-mail I am not CCed are s

Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

2017-05-18 Thread Konrad Rzeszutek Wilk
On Thu, May 18, 2017 at 05:47:08PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: [PATCH v2 6/9] ts-xen-build: Build the > livepatch test-cases"): > > > or something ? > > > > I ended up doing two patches - one to create an enable_livepatch > > (in mfi-common) to seed the jobs. >

Re: [Xen-devel] [PATCH 08/18] xen/pvcalls: implement connect command

2017-05-18 Thread Stefano Stabellini
On Tue, 16 May 2017, Boris Ostrovsky wrote: > >>> + ret = xenbus_map_ring_valloc(dev, &req->u.connect.ref, 1, &page); > >>> + if (ret < 0) { > >>> + sock_release(map->sock); > >>> + kfree(map); > >>> + goto out; > >>> + } > >>> + map->ring = page; > >>> + map->ring_order = m

Re: [Xen-devel] Livepatching and Xen Security

2017-05-18 Thread Andrew Cooper
On 18/05/17 17:40, George Dunlap wrote: > There are four general areas I think there may be bugs. > > ## Unprivileged access to Livepatching hypercalls > > ## Bugs in the patch creation tools which create patches with vulnerabilities > > ## Bugs in the patch-application code such that vulnerabiliti

[Xen-devel] Notes on stubdoms and latency on ARM

2017-05-18 Thread Stefano Stabellini
Hi all, Julien, Dario, George and I had a quick meeting to discuss stubdom scheduling. These are my notes. Description of the problem: need for a place to run emulators and mediators outside of Xen, with low latency. Explanation of what EL0 apps are. What should be their interface with Xen? Cou

[Xen-devel] [linux-4.9 test] 109565: regressions - trouble: broken/fail/pass

2017-05-18 Thread osstest service owner
flight 109565 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/109565/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 6 xen-boot fail REGR. vs. 107358 test-amd64-i386-xl-qe

Re: [Xen-devel] [PATCH 3/3] arm: fix build with gcc 7

2017-05-18 Thread Stefano Stabellini
On Thu, 18 May 2017, Julien Grall wrote: > Hi, > > On 18/05/17 09:41, Jan Beulich wrote: > > The compiler dislikes duplicat "const", and the ones it complains about > > s/duplicat/duplicate/ > > > look like they we in fact meant to be placed differently. > > > > Also fix array_access_okay() (ju

Re: [Xen-devel] [PATCH v3 for-4.9 0/3] libxl/devd: bugfixes

2017-05-18 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v3 for-4.9 0/3] libxl/devd: bugfixes"): > On 17/05/17 15:02, Julien Grall wrote: > > For the last patch, at this stage of the release I would prefer to defer > > it for Xen 4.10. After reviewing these, I'd like to make a case for the third patch for 4.9: I haven't

Re: [Xen-devel] Proposal to allow setting up shared memory areas between VMs from xl config file

2017-05-18 Thread Stefano Stabellini
On Mon, 15 May 2017, Wei Liu wrote: > On Sat, May 13, 2017 at 10:28:27AM +0800, Zhongze Liu wrote: > > 2017-05-13 1:51 GMT+08:00 Wei Liu : > > > Hi Zhongze > > > > > > This is a nice write-up. Some comments below. Feel free to disagree with > > > what I say below, this is more a discussion than pic

Re: [Xen-devel] [PATCH v3 for-4.9 3/3] libxl/devd: move the device allocation/removal code

2017-05-18 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 for-4.9 3/3] libxl/devd: move the device allocation/removal code"): > Move the device addition/removal code to the {add/remove}_device functions. > > Signed-off-by: Roger Pau Monné Acked-by: Ian Jackson ___ Xen-dev

Re: [Xen-devel] [PATCH v1 08/10] iommu: Split iommu_hwdom_init() into arch specific parts

2017-05-18 Thread Oleksandr Tyshchenko
Hi, all. On Thu, May 18, 2017 at 11:53 AM, Jan Beulich wrote: On 17.05.17 at 22:30, wrote: >> On 05/17/2017 07:51 PM, Oleksandr Tyshchenko wrote: >>> On Wed, May 17, 2017 at 7:01 PM, Jan Beulich wrote: Well, if the ARM maintainers insist on baking their own thing every time we'd

Re: [Xen-devel] [PATCH v3 for-4.9 1/3] libxl/devd: fix a race with concurrent device addition/removal

2017-05-18 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 for-4.9 1/3] libxl/devd: fix a race with concurrent device addition/removal"): > Current code can free the libxl__device inside of the libxl__ddomain_device > before the addition has finished if a removal happens while an addition is > still in process: Acked-by

Re: [Xen-devel] [PATCH v3 for-4.9 2/3] libxl/devd: correctly manipulate the dguest list

2017-05-18 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 for-4.9 2/3] libxl/devd: correctly manipulate the dguest list"): > Current code in backend_watch_callback has two issues when manipulating the > dguest list: Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v1 06/10] iommu: Add extra use_iommu argument to iommu_domain_init()

2017-05-18 Thread Oleksandr Tyshchenko
Hi, all. On Thu, May 18, 2017 at 11:38 AM, Jan Beulich wrote: On 17.05.17 at 21:52, wrote: >> On 05/12/2017 03:31 PM, Jan Beulich wrote: >> On 10.05.17 at 16:03, wrote: From: Oleksandr Tyshchenko The presence of this flag lets us know that the guest has devices whi

Re: [Xen-devel] [PATCH] Use non-debug build for Xen 4.9

2017-05-18 Thread Ian Jackson
Julien Grall writes ("[PATCH] Use non-debug build for Xen 4.9"): > Modify Config.mk and Kconfig.debug to disable debug by default in > preparation for late RCs and eventual release. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.o

Re: [Xen-devel] [xen-unstable-smoke test] 109547: tolerable trouble: broken/pass - PUSHED

2017-05-18 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [xen-unstable-smoke test] 109547: tolerable trouble: broken/pass - PUSHED"): > However, currently, with only two arm64 boxes, I don't think we have > enough bandwidth to add this to the smoke tests. I have put a note in > my backlog to revisit this when we hav

Re: [Xen-devel] [PATCH] xen: make xen_flush_tlb_all() static

2017-05-18 Thread Boris Ostrovsky
On 05/18/2017 11:46 AM, Juergen Gross wrote: > xen_flush_tlb_all() is used in arch/x86/xen/mmu.c only. Make it static. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen

Re: [Xen-devel] [PATCH for-next v3 01/22] x86/traps: move privilege instruction emulation code

2017-05-18 Thread Wei Liu
I forgot to move gpr_switch.S. Here is an updated version. ---8<--- From 58df816b937dc7a3598de01f053a6030e631057e Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Thu, 18 May 2017 16:18:56 +0100 Subject: [PATCH] x86/traps: move privilege instruction emulation code Move relevant code to pv/emulate.c.

Re: [Xen-devel] [PATCH 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2017-05-18 Thread Tamas K Lengyel
On Thu, May 18, 2017 at 9:07 AM, Adrian Pop wrote: > Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a > domain to change the value of the #VE suppress bit for a page. > > Signed-off-by: Adrian Pop > --- > xen/arch/x86/hvm/hvm.c | 14 > xen/arch/x86/mm/mem

Re: [Xen-devel] Livepatching and Xen Security

2017-05-18 Thread Lars Kurth
On 18/05/2017 17:53, "Ian Jackson" wrote: >George Dunlap writes ("Livepatching and Xen Security"): >> # Executive summary > >I am completely in agreement with your analysis and your conclusions. Me too. I am not sure though whether we need a vote or lazy consensus. For Credit2 (see https://l

[Xen-devel] [PATCH for-next v3 16/22] x86/traps: move callback_op code

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 148 +++ xen/arch/x86/x86_64/traps.c | 149 2 files changed, 148 insertions(+), 149 deletions(-) diff --git a/xen/arch/x86/pv/traps

[Xen-devel] [PATCH for-next v3 17/22] x86/traps: move hypercall_page_initialise_ring3_kernel

2017-05-18 Thread Wei Liu
And export it via pv/domain.h. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 36 xen/arch/x86/x86_64/traps.c | 37 + xen/include/asm-x86/pv/domain.h | 5 + 3 files changed, 42

[Xen-devel] [PATCH for-next v3 11/22] x86/traps: move guest_has_trap_callback to pv/traps.c

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 18 ++ xen/arch/x86/traps.c| 18 -- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index ff7dd1905f..6876150969 10064

[Xen-devel] [PATCH for-next v3 18/22] x86/traps: merge x86_64/compat/traps.c into pv/traps.c

2017-05-18 Thread Wei Liu
Export hypercall_page_initialise_ring1_kernel as the code is moved. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c| 405 xen/arch/x86/x86_64/compat/traps.c | 416 - xen/arch/x86/x86_64

[Xen-devel] [PATCH for-next v3 12/22] x86/traps: move send_guest_trap to pv/traps.c

2017-05-18 Thread Wei Liu
Fixed some coding style issues while moving. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 50 + xen/arch/x86/traps.c| 47 -- 2 files changed, 50 insertions(+), 47 deleti

[Xen-devel] [PATCH for-next v3 14/22] x86/traps: move do_iret to pv/traps.c

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 56 + xen/arch/x86/x86_64/traps.c | 56 - 2 files changed, 56 insertions(+), 56 deletions(-) diff --git a/xen/arch/x86/pv/traps.

[Xen-devel] [PATCH for-next v3 21/22] x86: fix coding style issues in asm-x86/traps.h

2017-05-18 Thread Wei Liu
And provide an Emacs block. Signed-off-by: Wei Liu --- xen/include/asm-x86/traps.h | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/xen/include/asm-x86/traps.h b/xen/include/asm-x86/traps.h index 7f36f6c1a7..0676e81d1a 100644 --- a/xen/include/asm-x86/tra

[Xen-devel] [PATCH for-next v3 15/22] x86/traps: move init_int80_direct_trap

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 14 ++ xen/arch/x86/x86_64/traps.c | 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index b69990c6b7..cb9b3b1425 10064

[Xen-devel] [PATCH for-next v3 20/22] x86: guest_has_trap_callback should return bool

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 4 ++-- xen/include/asm-x86/traps.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index ea5b543247..c36b650f5f 100644 --- a/xen/arch/x86/p

[Xen-devel] [PATCH for-next v3 19/22] x86: clean up pv/traps.c

2017-05-18 Thread Wei Liu
Fix coding style issues. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 62 ++--- 1 file changed, 43 insertions(+), 19 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index db92f6d520..ea5b543247

[Xen-devel] [PATCH for-next v3 13/22] x86/traps: move toggle_guest_mode

2017-05-18 Thread Wei Liu
Move from x86_64/traps.c to pv/traps.c. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 30 ++ xen/arch/x86/x86_64/traps.c | 30 -- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/xen/arch/x8

[Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

2017-05-18 Thread Wei Liu
It needs to be non-static when we split PV specific code out. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c| 2 +- xen/include/asm-x86/traps.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index e

[Xen-devel] [PATCH for-next v3 22/22] x86: clean up traps.c

2017-05-18 Thread Wei Liu
Replace bool_t with bool. Delete trailing white spaces. Fix some coding style issues. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c | 77 +++- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/xen/arch/x86/tra

[Xen-devel] [PATCH for-next v3 04/22] x86/traps: move emulate_forced_invalid_op

2017-05-18 Thread Wei Liu
And remove the now unused instruction_done in x86/traps.c. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/emulate.c | 51 ++ xen/arch/x86/traps.c | 62 -- xen/include/asm-x86/pv/traps.h | 2

[Xen-devel] [PATCH for-next v3 09/22] x86/traps: move {un, }register_guest_nmi_callback

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 36 xen/arch/x86/traps.c| 36 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.

[Xen-devel] [PATCH for-next v3 01/22] x86/traps: move privilege instruction emulation code

2017-05-18 Thread Wei Liu
Move relevant code to pv/emulate.c. Export emulate_privileged_op in pv/traps.h. Note that read_descriptor is duplicated in emulate.c. The duplication will be gone once all emulation code is moved. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile |1 + xen/arc

[Xen-devel] [PATCH for-next v3 06/22] x86/traps: move PV hypercall handlers to pv/traps.c

2017-05-18 Thread Wei Liu
The following handlers are moved: 1. do_set_trap_table 2. do_set_debugreg 3. do_get_debugreg 4. do_fpu_taskswitch No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 97 + xen/arch/x86/traps.c| 94 ---

[Xen-devel] [PATCH for-next v3 05/22] x86/pv: clean up emulate.c

2017-05-18 Thread Wei Liu
Fix coding style issues. Replace bool_t with bool. Add spaces around binary ops. Use unsigned integer for shifting. Eliminate TOGGLE_MODE. Signed-off-by: Wei Liu Signed-off-by: Andrew Cooper --- xen/arch/x86/pv/emulate.c | 123 -- 1 file changed, 63 i

[Xen-devel] [PATCH for-next v3 03/22] x86/traps: move emulate_invalid_rdtscp

2017-05-18 Thread Wei Liu
And export it in pv/traps.h. The stub function returns 0 because that represents "unsuccessful emulation" in the original code. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/emulate.c | 20 xen/arch/x86/traps.c | 20 x

[Xen-devel] [PATCH for-next v3 07/22] x86/traps: move pv_inject_event to pv/traps.c

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 73 + xen/arch/x86/traps.c| 69 -- 2 files changed, 73 insertions(+), 69 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b

[Xen-devel] [PATCH for-next v3 08/22] x86/traps: move set_guest_{machinecheck, nmi}_trapbounce

2017-05-18 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 27 +++ xen/arch/x86/traps.c| 27 --- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 79304704dd

[Xen-devel] [PATCH for-next v3 02/22] x86/traps: move gate op emulation code

2017-05-18 Thread Wei Liu
The code is moved to pv/emulate.c. Export emulate_gate_op in pv/traps.h. Delete the now unused read_descriptor in x86/traps.c. Duplicate instruction_done in pv/traps.c. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/emulate.c | 403 +

[Xen-devel] [PATCH for-next v3 00/22] x86: refactor trap handling code

2017-05-18 Thread Wei Liu
V3 of the series. Rebased on top of x86-next branch. Patches are broken down into the smallest trunk possible to ease review and future rebasing. git://xenbits.xen.org/people/liuw/xen.git wip.move-traps-v3 Wei Liu (22): x86/traps: move privilege instruction emulation code x86/traps: move

Re: [Xen-devel] Livepatching and Xen Security

2017-05-18 Thread Ian Jackson
George Dunlap writes ("Livepatching and Xen Security"): > # Executive summary I am completely in agreement with your analysis and your conclusions. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 3/9] OssTest: Add target_dir_exists

2017-05-18 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: [PATCH v2 3/9] OssTest: Add target_dir_exists"): > On Tue, Dec 13, 2016 at 04:24:56PM +, Ian Jackson wrote: > > Konrad Rzeszutek Wilk writes ("[PATCH v2 3/9] OssTest: Add > > target_dir_exists"): > > > We have target_file_exists but not an equivalant one for

Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

2017-05-18 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases"): > > or something ? > > I ended up doing two patches - one to create an enable_livepatch > (in mfi-common) to seed the jobs. > > And then another to piggyback on that. > > I am attaching them here (

[Xen-devel] Livepatching and Xen Security

2017-05-18 Thread George Dunlap
# Executive summary * It is important for the Livepatching feature to be declared "security supported". * At the moment it's not clear whether we can get osstest support in by the release or not, or if we did whether that would be considered sufficient to consider it supported * I would argue th

[Xen-devel] [xen-unstable-smoke test] 109579: tolerable trouble: broken/pass - PUSHED

2017-05-18 Thread osstest service owner
flight 109579 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/109579/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

2017-05-18 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases"): > So I feel like the only way to figure out whether the livepatch tests cases > can be built is if I check either the version of Xen (4.9 or above say) > or if an file exists (xen/xen/test/Makefile).

Re: [Xen-devel] [PATCH] livepatch/Makefile: Add 'install' stanza [and 1 more messages]

2017-05-18 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("[PATCH] livepatch/Makefile: Add 'install' stanza"): > So that you can do: > > DESTDIR=`pwd`/dist/xenlptinstall/usr/lib/debug > mkdir -p $DESTDIR > BASEDIR=`pwd`/xen XEN_ROOT=`pwd` make -C xen/test -f `pwd`/xen/Rules.mk > install Looking at our other DESTDIR settin

[Xen-devel] [PATCH] xen: make xen_flush_tlb_all() static

2017-05-18 Thread Juergen Gross
xen_flush_tlb_all() is used in arch/x86/xen/mmu.c only. Make it static. Signed-off-by: Juergen Gross --- arch/x86/xen/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index 5e375a5e815f..3be06f3caf3c 100644 --- a/arch/x86/xen/mmu.c

Re: [Xen-devel] [PATCH] Use non-debug build for Xen 4.9

2017-05-18 Thread Wei Liu
On Thu, May 18, 2017 at 04:38:29PM +0100, Julien Grall wrote: > Modify Config.mk and Kconfig.debug to disable debug by default in > preparation for late RCs and eventual release. > > Signed-off-by: Julien Grall Acked-by: Wei Liu ___ Xen-devel mailing

[Xen-devel] [PATCH] Use non-debug build for Xen 4.9

2017-05-18 Thread Julien Grall
Modify Config.mk and Kconfig.debug to disable debug by default in preparation for late RCs and eventual release. Signed-off-by: Julien Grall --- tools/Rules.mk| 2 +- xen/Kconfig.debug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk inde

[Xen-devel] [libvirt test] 109561: tolerable all pass - PUSHED

2017-05-18 Thread osstest service owner
flight 109561 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/109561/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 109516 test-armhf-armhf-libvirt 13 saveresto

[Xen-devel] [PATCH v2 0/3] xen/blkback: several fixes of resource management

2017-05-18 Thread Juergen Gross
Destroying a Xen guest domain while it was doing I/Os via xen-blkback leaked several resources, including references of the guest's memory pages. This patch series addresses those leaks by correcting usage of reference counts and the sequence when to free which resource. The series applies on top

[Xen-devel] [PATCH v2 2/3] xen/blkback: don't free be structure too early

2017-05-18 Thread Juergen Gross
The be structure must nor be freed when freeing the blkif structure isn't done. Otherwise a use-after-free of be when unmapping the ring used for communicating with the frontend will occur in case of a late call of xenblk_disconnect() (e.g. due to an I/O still active when trying to disconnect). Si

[Xen-devel] [PATCH v2 3/3] xen/blkback: don't use xen_blkif_get() in xen-blkback kthread

2017-05-18 Thread Juergen Gross
There is no need to use xen_blkif_get()/xen_blkif_put() in the kthread of xen-blkback. Thread stopping is synchronous and using the blkif reference counting in the kthread will avoid to ever let the reference count drop to zero at the end of an I/O running concurrent to disconnecting and multiple r

[Xen-devel] [PATCH v2 1/3] xen/blkback: fix disconnect while I/Os in flight

2017-05-18 Thread Juergen Gross
Today disconnecting xen-blkback is broken in case there are still I/Os in flight: xen_blkif_disconnect() will bail out early without releasing all resources in the hope it will be called again when the last request has terminated. This, however, won't happen as xen_blkif_free() won't be called on t

Re: [Xen-devel] Questions about PVHv2/HVMlite

2017-05-18 Thread Roger Pau Monné
On Thu, May 18, 2017 at 09:48:02AM -0500, Gary R Hook wrote: > On 05/18/2017 03:16 AM, Roger Pau Monné wrote: > > > > So using your example, the config file should look like: > > > > extra = "root=/dev/xvda1 console=hvc0" > > kernel = "/root/64/vmlinuz-4.11.0-pvh+" > > ramdisk = "/root/64/initrd.

Re: [Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-18 Thread Andrew Cooper
On 18/05/17 15:31, Tim Deegan wrote: > Hi, > > At 15:02 +0100 on 18 May (1495119734), Andrew Cooper wrote: >> * When fabricating gl1e's from superpages, propagate the protection key as >>well, so the protection key logic sees the real key as opposed to 0. >> >> * Experimentally, the protectio

Re: [Xen-devel] [PATCH v3 for-4.9 0/3] libxl/devd: bugfixes

2017-05-18 Thread Wei Liu
On Thu, May 18, 2017 at 04:06:33PM +0100, Julien Grall wrote: > (CC Ian and Wei) > I did see this. Ian said he wanted to review this in detail. That's why I haven't committed them. > On 17/05/17 15:02, Julien Grall wrote: > > On 16/05/17 08:59, Roger Pau Monne wrote: > > > Hello, > > > > Hi Rog

Re: [Xen-devel] [PATCH 0/3] gcc 7 build fixes (hypervisor side)

2017-05-18 Thread Julien Grall
Hi Jan, On 18/05/17 09:01, Jan Beulich wrote: I think it would be good for 4.9 to build out of the box with this recently released compiler version. 1: xmalloc: correct _xmalloc_array() indentation 2: x86: fix build with gcc 7 3: arm: fix build with gcc 7 Signed-off-by: Jan Beulich For the

Re: [Xen-devel] [PATCH 3/3] arm: fix build with gcc 7

2017-05-18 Thread Julien Grall
Hi, On 18/05/17 09:41, Jan Beulich wrote: The compiler dislikes duplicat "const", and the ones it complains about s/duplicat/duplicate/ look like they we in fact meant to be placed differently. Also fix array_access_okay() (just like on x86), despite the construct being unused on ARM: -Wint

[Xen-devel] [PATCH 3/3] libxc: Add support for the altp2m suppress #VE hvmop

2017-05-18 Thread Adrian Pop
This adds a wrapper for issuing HVMOP_altp2m_set_suppress_ve from a domain. Signed-off-by: Adrian Pop --- tools/libxc/include/xenctrl.h | 2 ++ tools/libxc/xc_altp2m.c | 24 2 files changed, 26 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools/libx

[Xen-devel] [PATCH 0/3] x86: Add a hvmop for setting the #VE suppress bit

2017-05-18 Thread Adrian Pop
As the code stands right now, after DomU has enabled #VE using HVMOP_altp2m_vcpu_enable_notify, all its pages have the #VE suppress bit cleared, generating #VEs for any EPT violation. There is currently no way to change the value of the #VE suppress bit for a page from a domain; it can only be don

[Xen-devel] [PATCH 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2017-05-18 Thread Adrian Pop
Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a domain to change the value of the #VE suppress bit for a page. Signed-off-by: Adrian Pop --- xen/arch/x86/hvm/hvm.c | 14 xen/arch/x86/mm/mem_access.c| 48 + xen/

[Xen-devel] [PATCH 1/3] x86/mm: Change default value for suppress #VE in set_mem_access()

2017-05-18 Thread Adrian Pop
From: Vlad Ioan Topan The default value for the "suppress #VE" bit set by set_mem_access() currently depends on whether the call is made from the same domain (the bit is set when called from another domain and cleared if called from the same domain). This patch changes that behavior to inherit th

Re: [Xen-devel] [PATCH v3 for-4.9 0/3] libxl/devd: bugfixes

2017-05-18 Thread Julien Grall
(CC Ian and Wei) On 17/05/17 15:02, Julien Grall wrote: On 16/05/17 08:59, Roger Pau Monne wrote: Hello, Hi Roger, The first two patches in the series fix a race with concurrent device addition/removal and two bugs related to manipulation of the list of active domains in the devd subcomman

Re: [Xen-devel] [PATCH 0/3] xen/blkback: several fixes of resource management

2017-05-18 Thread Juergen Gross
On 18/05/17 16:38, Roger Pau Monné wrote: > On Tue, May 16, 2017 at 08:23:17AM +0200, Juergen Gross wrote: >> Destroying a Xen guest domain while it was doing I/Os via xen-blkback >> leaked several resources, including references of the guest's memory >> pages. >> >> This patch series addresses tho

[Xen-devel] [ovmf baseline-only test] 71343: tolerable FAIL

2017-05-18 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 71343 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71343/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-libvirt 5 libvirt-buildfai

Re: [Xen-devel] [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu

2017-05-18 Thread Dario Faggioli
On Thu, 2017-05-18 at 07:16 -0600, Jan Beulich wrote: > > > > On 18.05.17 at 15:03, wrote: > > > > As I said last time, I'd rename cpu_callback() to something less > > generic, like vpmu_cpu_callback() (or vpmu_cpuhp_callback()). > > The vpmu_ prefix is clearly pointless for a static function. >

Re: [Xen-devel] xen/arm: Hiding SMMUs from Dom0 when using ACPI on Xen

2017-05-18 Thread Julien Grall
Hello, On 18/05/17 12:59, Manish Jaggi wrote: On 2/27/2017 11:42 PM, Julien Grall wrote: On 02/27/2017 04:58 PM, Shanker Donthineni wrote: Hi Julien, Hi Shanker, Please don't drop people in CC. In my case, any e-mail I am not CCed are skipping my inbox and I may not read them for a while.

Re: [Xen-devel] [PATCH 0/3] xen/blkback: several fixes of resource management

2017-05-18 Thread Roger Pau Monné
On Tue, May 16, 2017 at 08:23:17AM +0200, Juergen Gross wrote: > Destroying a Xen guest domain while it was doing I/Os via xen-blkback > leaked several resources, including references of the guest's memory > pages. > > This patch series addresses those leaks by correcting usage of > reference coun

Re: [Xen-devel] [xen-4.8-testing test] 109515: tolerable FAIL - PUSHED

2017-05-18 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [xen-4.8-testing test] 109515: tolerable FAIL - PUSHED"): > The arm64 jobs are blocked because of the missing ocamlopt > package. I think testing Xen 4.8 would be good so we may want to > backport the patch 4d0240e033 "tools: ocaml: In configure, check for > o

Re: [Xen-devel] Questions about PVHv2/HVMlite

2017-05-18 Thread Gary R Hook
On 05/18/2017 03:16 AM, Roger Pau Monné wrote: So using your example, the config file should look like: extra = "root=/dev/xvda1 console=hvc0" kernel = "/root/64/vmlinuz-4.11.0-pvh+" ramdisk = "/root/64/initrd.img-4.11.0-pvh+" builder="hvm" device_model_version="none" memory = 4096 name = "sosp

Re: [Xen-devel] [Xen-users] vif-bridge errors when creating and destroying dozens of VMs simultaneously

2017-05-18 Thread Antony Saba
George, Patch works as expected, no failures on create and no stale iptables rules after running under the same load that was producing the errors previously. Ubuntu 16.04 Linux 3.13.0-83-generic iptables v1.6.0 Xen 4.6 5 from distro packages Thanks! -Tony On Wed, May 17, 2017 at 7:44 AM, Geor

Re: [Xen-devel] [resend PATCH] xen: common: rbtree: ported updates from linux tree

2017-05-18 Thread Dario Faggioli
On Thu, 2017-05-18 at 07:59 -0600, Jan Beulich wrote: > > > > On 11.05.17 at 19:21, wrote: > > > > The patch contains the updated version of rbtree implementation > > from linux > > kernel tree containing the fixes so far handled. > > I suppose this isn't just fixes, but also enhancements. Furth

Re: [Xen-devel] [xen-unstable-smoke test] 109547: tolerable trouble: broken/pass - PUSHED

2017-05-18 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [xen-unstable-smoke test] 109547: tolerable trouble: broken/pass - PUSHED"): > On 05/17/2017 08:32 PM, osstest service owner wrote: > > flight 109547 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/109547/ > > > > Failures :

Re: [Xen-devel] [PATCH RFC 0/6] qemu-xen-trad: sasl: add SASL support to VNC

2017-05-18 Thread Ian Jackson
Simon Waterman writes ("Re: [PATCH RFC 0/6] qemu-xen-trad: sasl: add SASL support to VNC"): > It's not the QEMU in the stubdom that would need to be newer > but rather the one that's spawned in domain-0 to provide the > VNC backend when you use an IOEMU stubdom. As I understand > it this also nee

Re: [Xen-devel] [PATCH v9 27/28] ARM: vITS: create and initialize virtual ITSes for Dom0

2017-05-18 Thread Julien Grall
Hi Andre, On 11/05/17 18:53, Andre Przywara wrote: For each hardware ITS create and initialize a virtual ITS for Dom0. We use the same memory mapped address to keep the doorbell working. This introduces a function to initialize a virtual ITS. We maintain a list of virtual ITSes, at the moment fo

Re: [Xen-devel] [PATCH v9 26/28] ARM: vITS: increase mmio_count for each ITS

2017-05-18 Thread Julien Grall
Hi Andre, On 11/05/17 18:53, Andre Przywara wrote: Increase the count of MMIO regions needed by one for each ITS Dom0 has to emulate. We emulate the ITSes 1:1 from the hardware, so the number is the number of host ITSes. Signed-off-by: Andre Przywara Acked-by: Julien Grall Cheers, -- Juli

Re: [Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-18 Thread Tim Deegan
Hi, At 15:02 +0100 on 18 May (1495119734), Andrew Cooper wrote: > * When fabricating gl1e's from superpages, propagate the protection key as >well, so the protection key logic sees the real key as opposed to 0. > > * Experimentally, the protection key checks are performed ahead of the other

Re: [Xen-devel] [PATCH v9 23/28] ARM: vITS: handle DISCARD command

2017-05-18 Thread Julien Grall
Hi Andre, On 11/05/17 18:53, Andre Przywara wrote: The DISCARD command drops the connection between a DeviceID/EventID and an LPI/collection pair. We mark the respective structure entries as not allocated and make sure that any queued IRQs are removed. Signed-off-by: Andre Przywara --- xen/ar

Re: [Xen-devel] [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu

2017-05-18 Thread Kang, Luwei
> > --- a/xen/arch/x86/cpu/vpmu.c > > +++ b/xen/arch/x86/cpu/vpmu.c > > @@ -859,6 +859,7 @@ static int cpu_callback( > > { > > vpmu_save_force(vcpu); > > vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > > +per_cpu(last_vcpu, cpu) = NULL;// OR: this_cpu(last_vcpu) > >

[Xen-devel] [qemu-mainline test] 109560: regressions - FAIL

2017-05-18 Thread osstest service owner
flight 109560 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/109560/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 5 xen-buildfail REGR. vs. 107636 build-arm64

Re: [Xen-devel] [PATCH v9 22/28] ARM: vITS: handle MOVI command

2017-05-18 Thread Julien Grall
Hi Andre, On 11/05/17 18:53, Andre Przywara wrote: The MOVI command moves the interrupt affinity from one redistributor (read: VCPU) to another. For now migration of "live" LPIs is not yet implemented, but we store the changed affinity in the host LPI structure and in our virtual ITTE. Signed-o

  1   2   >