Re: [Xen-devel] [PATCH] vvmx: fix the wrong address width in c/s 08fac63

2016-12-18 Thread Jan Beulich
>>> On 19.12.16 at 02:14, wrote: > c/s 08fac63 misused v->domain-arch.paging.gfn_bits as the width of > guest physical address and missed adding PAGE_SHIFT to it when > checking vmxon operand. > > Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich

Re: [Xen-devel] [PATCH v4 10/14] xen/x86: populate PVHv2 Dom0 physical memory map

2016-12-18 Thread Jan Beulich
>>> On 16.12.16 at 18:38, wrote: > On Fri, Dec 09, 2016 at 09:48:32AM -0700, Jan Beulich wrote: >> >>> On 30.11.16 at 17:49, wrote: >> > @@ -545,11 +552,12 @@ static __init void pvh_map_all_iomem(struct domain >> > *d, unsigned long nr_pages) >> > ASSERT(nr_holes == 0); >> > } >> > >> >

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-18 Thread Jan Beulich
>>> On 16.12.16 at 18:57, wrote: > On Fri, Dec 16, 2016 at 09:17:01AM -0700, Jan Beulich wrote: >> >>> On 16.12.16 at 15:45, wrote: >> > On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: >> >> On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: >> >> > >>> On 30.11.16 at 1

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-18 Thread Jan Beulich
>>> On 16.12.16 at 18:42, wrote: > On Fri, Dec 16, 2016 at 09:18:13AM -0700, Jan Beulich wrote: >> >>> On 16.12.16 at 15:28, wrote: >> > On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: >> >> >>> On 30.11.16 at 17:49, wrote: >> >> > --- a/docs/misc/xen-command-line.markdown >> >> > +

[Xen-devel] [ovmf baseline-only test] 68241: regressions - FAIL

2016-12-18 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68241 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68241/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-insta

Re: [Xen-devel] [XTF PATCH 00/16] Add test cases for nested vmxon

2016-12-18 Thread Haozhong Zhang
On 12/16/16 21:26 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: This patch series starts to add a test selection "test-hvm64-vvmx" for nested VMX. This first series focuses mostly on nested vmxon. * Patch 01 - 03 test the basic environment (cpuid and MSR). * Patch 04 - 0

[Xen-devel] [ovmf test] 103742: all pass - PUSHED

2016-12-18 Thread osstest service owner
flight 103742 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/103742/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a35dc6499beb0b76c340379a06dff74a8d38095a baseline version: ovmf 04fd7859bd0185668f2cf

[Xen-devel] [linux-3.18 test] 103738: regressions - trouble: broken/fail/pass

2016-12-18 Thread osstest service owner
flight 103738 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103738/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 9 xen-boot/src_hostfail REGR. vs. 101675 test-amd64-i386-libv

Re: [Xen-devel] [XTF PATCH 14/16] vvmx: test vmxon in VMX root w/ CPL = 3 and w/o current VMCS

2016-12-18 Thread Haozhong Zhang
On 12/16/16 20:59 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: Fault #GP(0) is expected in this test. Signed-off-by: Haozhong Zhang --- tests/vvmx/vmxon.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/vvmx/vmxon.c b/tests/vvmx

Re: [Xen-devel] [XTF PATCH 08/16] vvmx: test vmxon with invalidly wide VMXON region address

2016-12-18 Thread Haozhong Zhang
On 12/16/16 20:40 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: +static uint8_t get_cpu_paddr_bits(void) +{ +uint8_t paddr_bits = 36; +uint32_t eax; + +eax = cpuid_eax(0x8000); +if ( (eax >> 16) == 0x8000 && eax >= 0x8008 ) +{ +eax = cpu

Re: [Xen-devel] [XTF PATCH 07/16] vvmx: test vmxon in CPL=3 and out of VMX operation

2016-12-18 Thread Haozhong Zhang
On 12/16/16 20:33 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c index 31f074c..ca33b3c 100644 --- a/tests/vvmx/vmxon.c +++ b/tests/vvmx/vmxon.c @@ -28,11 +28,42 @@ static bool test_vmxon_novmxe(void)

Re: [Xen-devel] [XTF PATCH 06/16] vvmx: test vmxon with CR4.VMXE cleared

2016-12-18 Thread Haozhong Zhang
On 12/16/16 20:25 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: diff --git a/tests/vvmx/util.c b/tests/vvmx/util.c index 74b4d01..f30fc26 100644 --- a/tests/vvmx/util.c +++ b/tests/vvmx/util.c @@ -1,7 +1,31 @@ #include +#include #include #include "util.h" +#define I

Re: [Xen-devel] [XTF PATCH 05/16] vvmx: add a general error handler for VMX instructions

2016-12-18 Thread Haozhong Zhang
On 12/16/16 20:16 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: handle_vmxinsn_err() is added to check and output the mismatch between errors in the execution of a VMX instruction and the expected errors. Signed-off-by: Haozhong Zhang --- tests/vvmx/util.c | 104 +++

Re: [Xen-devel] [licensing] was: [XTF PATCH 04/16] vvmx: add C wrappers of vmxon/vmread/vmptrld

2016-12-18 Thread Haozhong Zhang
On 12/16/16 19:03 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: diff --git a/include/arch/x86/hvm/vmx/vmcs.h b/include/arch/x86/hvm/vmx/vmcs.h new file mode 100644 index 000..e1a6ef8 --- /dev/null +++ b/include/arch/x86/hvm/vmx/vmcs.h @@ -0,0 +1,179 @@ +#ifndef XTF_X86

Re: [Xen-devel] [XTF PATCH 04/16] vvmx: add C wrappers of vmxon/vmread/vmptrld

2016-12-18 Thread Haozhong Zhang
On 12/16/16 19:47 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: Review of the technical side of the patch, leaving the licensing to the other thread. Reordering for better logical clarity for my suggestion. diff --git a/tests/vvmx/util.h b/tests/vvmx/util.h new file mod

[Xen-devel] [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2016-12-18 Thread Jiandi An
Ensure all reserved fields of xatp are zero before making hypervisor call to XEN in xen_map_device_mmio(). xenmem_add_to_physmap_one() in XEN fails the mapping request if extra.res reserved field in xatp is not zero for XENMAPSPACE_dev_mmio request. Signed-off-by: Jiandi An --- drivers/xen/arm-

Re: [Xen-devel] [XTF PATCH 03/16] vvmx: test whether MSR_IA32_VMX_BASIC is set correctly

2016-12-18 Thread Haozhong Zhang
On 12/16/16 17:19 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: It tests whether bit 31 and bit 48 are 0, and VMCS size is in the range (0, 4096]. Signed-off-by: Haozhong Zhang --- include/arch/x86/msr-index.h | 4 tests/vvmx/msr.c | 47 +++

Re: [Xen-devel] [XTF PATCH 02/16] vvmx: test whether MSR_IA32_FEATURE_CONTROL is set correctly

2016-12-18 Thread Haozhong Zhang
On 12/16/16 16:17 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: diff --git a/tests/vvmx/msr.c b/tests/vvmx/msr.c new file mode 100644 index 000..100491d --- /dev/null +++ b/tests/vvmx/msr.c @@ -0,0 +1,67 @@ +#include + +#include + +/* + * NB. Guest MSR_IA32_FEATURE_C

Re: [Xen-devel] [XTF PATCH 01/16] vvmx: test whether VMX feature is present in CPUID

2016-12-18 Thread Haozhong Zhang
On 12/16/16 14:40 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: diff --git a/tests/vvmx/cpuid.c b/tests/vvmx/cpuid.c new file mode 100644 index 000..9a4cdae --- /dev/null +++ b/tests/vvmx/cpuid.c @@ -0,0 +1,24 @@ +#include + +bool test_cpuid_vmx_feat(void) +{ +uin

Re: [Xen-devel] [XTF PATCH 00/16] Add test cases for nested vmxon

2016-12-18 Thread Haozhong Zhang
On 12/16/16 14:12 +, Andrew Cooper wrote: On 16/12/16 13:43, Haozhong Zhang wrote: This patch series starts to add a test selection "test-hvm64-vvmx" for nested VMX. This first series focuses mostly on nested vmxon. * Patch 01 - 03 test the basic environment (cpuid and MSR). * Patch 04 - 0

[Xen-devel] [ovmf baseline-only test] 68240: all pass

2016-12-18 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68240 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68240/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 04fd7859bd0185668f2cf9213273a5fb4bcc7123 baseline v

[Xen-devel] [PATCH] vvmx: fix the wrong address width in c/s 08fac63

2016-12-18 Thread Haozhong Zhang
c/s 08fac63 misused v->domain-arch.paging.gfn_bits as the width of guest physical address and missed adding PAGE_SHIFT to it when checking vmxon operand. Signed-off-by: Haozhong Zhang --- xen/arch/x86/hvm/vmx/vvmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x

[Xen-devel] [linux-4.1 test] 103736: regressions - FAIL

2016-12-18 Thread osstest service owner
flight 103736 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl 6 xen-boot fail REGR. vs. 101737 test-amd64-i386-xl-qe

[Xen-devel] [xen-unstable test] 103737: regressions - trouble: broken/fail/pass

2016-12-18 Thread osstest service owner
flight 103737 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-36 xen-boot fail REGR. vs. 103466 test-amd64-amd64-x

[Xen-devel] [ovmf test] 103739: all pass - PUSHED

2016-12-18 Thread osstest service owner
flight 103739 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/103739/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 04fd7859bd0185668f2cf9213273a5fb4bcc7123 baseline version: ovmf c0584d0bdd4463551db8f

[Xen-devel] [linux-3.18 test] 103688: regressions - FAIL

2016-12-18 Thread osstest service owner
flight 103688 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 9 xen-boot/src_hostfail REGR. vs. 101675 test-amd64-i386-libv

[Xen-devel] [xen-unstable test] 103659: regressions - FAIL

2016-12-18 Thread osstest service owner
flight 103659 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103659/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-pvgrub 6 xen-boot fail REGR. vs. 103466 test-xtf-amd64-amd

[Xen-devel] [linux-4.1 test] 103652: regressions - FAIL

2016-12-18 Thread osstest service owner
flight 103652 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103652/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl 6 xen-boot fail REGR. vs. 101737 test-amd64-i386-xl-qe

Re: [Xen-devel] [PATCH v2 3/4] vvmx: check the operand of L1 vmxon

2016-12-18 Thread Andrew Cooper
On 18/12/16 14:02, Haozhong Zhang wrote: > On 12/14/16 18:11 +0800, Haozhong Zhang wrote: >> Check whether the operand of L1 vmxon is a valid VMXON region address >> and whether the VMXON region at that address contains a valid revision >> ID. >> >> Signed-off-by: Haozhong Zhang >> Reviewed-by: An

Re: [Xen-devel] [PATCH v2 3/4] vvmx: check the operand of L1 vmxon

2016-12-18 Thread Haozhong Zhang
On 12/14/16 18:11 +0800, Haozhong Zhang wrote: Check whether the operand of L1 vmxon is a valid VMXON region address and whether the VMXON region at that address contains a valid revision ID. Signed-off-by: Haozhong Zhang Reviewed-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk Acked-by:

Re: [Xen-devel] [xen-unstable test] 103540: regressions - FAIL

2016-12-18 Thread Andrew Cooper
On 18/12/2016 10:38, Andrew Cooper wrote: > On 18/12/2016 05:21, osstest service owner wrote: >> flight 103540 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/103540/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which coul

Re: [Xen-devel] [xen-unstable test] 103540: regressions - FAIL

2016-12-18 Thread Andrew Cooper
On 18/12/2016 05:21, osstest service owner wrote: > flight 103540 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/103540/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-i386-pvgrub 6 xe

[Xen-devel] [xen-unstable-coverity test] 103698: all pass - PUSHED

2016-12-18 Thread osstest service owner
flight 103698 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/103698/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen fa25f10f2af877ed6bfa2ddce3d321ff61268c13 baseline version: xen fc92

Re: [Xen-devel] [PATCH] x86/head: Refactor 32-bit pgtable setup

2016-12-18 Thread Ingo Molnar
* Boris Ostrovsky wrote: > On 12/08/2016 11:33 PM, Ingo Molnar wrote: > > * Boris Ostrovsky wrote: > > > >> The new Xen PVH entry point requires page tables to be setup by the > >> kernel since it is entered with paging disabled. > >> > >> Pull the common code out of head_32.S so that mk_early_

[Xen-devel] [linux-3.18 test] 103561: regressions - FAIL

2016-12-18 Thread osstest service owner
flight 103561 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103561/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 9 xen-boot/src_hostfail REGR. vs. 101675 test-amd64-i386-libv