Re: [Xen-devel] [PATCH 1/1] xen: xenbus: set error code on failure

2016-12-04 Thread Pan Bian
From: PanBian On Mon, Dec 05, 2016 at 07:30:49AM +0100, Juergen Gross wrote: > On 03/12/16 11:49, Pan Bian wrote: > > In function xenstored_local_init(), the value of return variable err > > should be negative on errors. But the value of err keeps 0 even if the > > call to get_zeroed_page() retu

[Xen-devel] [PATCH v4 10/12] xenstore: add helper functions for wire argument parsing

2016-12-04 Thread Juergen Gross
The xenstore wire command argument parsing of the different commands is repeating some patterns multiple times. Add some helper functions to avoid the duplicated code. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/xenstore/xenstored_core.c | 66 ++-- tools/x

[Xen-devel] [PATCH v4 11/12] xenstore: add small default data buffer to internal struct

2016-12-04 Thread Juergen Gross
Instead of always allocating a data buffer for incoming or outgoing xenstore wire data add a small buffer to the buffered_data structure of xenstored. This has the advantage that especially sending simple response messages like errors or "OK" will no longer need allocating a data buffer. This requi

[Xen-devel] [PATCH v4 00/12] xenstore: support reading directory with many children

2016-12-04 Thread Juergen Gross
Reading the children list of a xenstore node with the length of that list exceeding 4096 bytes is currently not possible. This can be a problem for a large host with a huge number of domains as Xen tools will no longer by capable to scan some directories of xenstore (e.g. /local/domain). This patc

[Xen-devel] [PATCH v4 12/12] xenstore: handle memory allocation failures in xenstored

2016-12-04 Thread Juergen Gross
Check for failures when allocating new memory in xenstored. Signed-off-by: Juergen Gross --- V4: add alloc failure check in delete_node() and add_change_node() clean_store() only if no failure in check_store_() --- tools/xenstore/xenstored_core.c| 210 +---

[Xen-devel] [PATCH v4 08/12] xenstore: let command functions return error or success

2016-12-04 Thread Juergen Gross
Add a return value to all wire command functions of xenstored. If such a function returns an error send the error message in process_message(). Only code refactoring, no change in behavior expected. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/xenstore/xenstored_core.c| 213

[Xen-devel] [PATCH v4 05/12] xenstore: add support for reading directory with many children

2016-12-04 Thread Juergen Gross
As the payload size for one xenstore wire command is limited to 4096 bytes it is impossible to read the children names of a node with a large number of children (e.g. /local/domain in case of a host with more than about 2000 domains). This effectively limits the maximum number of domains a host can

[Xen-devel] [PATCH v4 01/12] xenstore: modify add_change_node() parameter types

2016-12-04 Thread Juergen Gross
In order to prepare adding a generation count to each node modify add_change_node() to take the connection pointer and a node pointer instead of the transaction pointer and node name as parameters. This requires moving the call of add_change_node() from do_rm() to delete_node_single(). While at it

[Xen-devel] [PATCH v4 07/12] xenstore: use array for xenstore wire command handling

2016-12-04 Thread Juergen Gross
Instead of switch() statements for selecting wire command actions use an array for this purpose. While doing this add the XS_RESTRICT type for diagnostic prints and correct the printed string for XS_IS_DOMAIN_INTRODUCED. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V4: add XS_TYPE_COUNT (

[Xen-devel] [PATCH v4 06/12] xenstore: support XS_DIRECTORY_PART in libxenstore

2016-12-04 Thread Juergen Gross
This will enable all users of libxenstore to handle xenstore nodes with a huge amount of children. In order to not depend completely on the XS_DIRECTORY_PART functionality use it only in case of E2BIG returned by XS_DIRECTORY. Signed-off-by: Juergen Gross Reviewed-by: Wei Liu --- tools/xenstor

[Xen-devel] [PATCH v4 02/12] xenstore: call add_change_node() directly when writing node

2016-12-04 Thread Juergen Gross
Instead of calling add_change_node() at places where write_node() is called, do that inside write_node(). Note that there is one case where add_change_node() is called now when a later failure will prohibit the changed node to be written: in case of a write_node failing due to an error in tdb_stor

[Xen-devel] [PATCH v4 03/12] xenstore: use common tdb record header in xenstore

2016-12-04 Thread Juergen Gross
The layout of the tdb record of xenstored is defined at multiple places: read_node(), write_node() and in xs_tdb_dump.c Use a common structure instead. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/xenstore/include/xenstore_lib.h | 8 tools/xenstore/xenstored_core.c

[Xen-devel] [PATCH v4 04/12] xenstore: add per-node generation counter

2016-12-04 Thread Juergen Gross
In order to be able to support reading the list of a node's children in multiple chunks (needed for list sizes > 4096 bytes) without having to allocate a temporary buffer we need some kind of generation counter for each node. This will help to recognize a node has changed between reading two chunks

Re: [Xen-devel] [PATCH v2 4/4] tools/libacpi: announce that PVHv2 has no CMOS RTC in FADT

2016-12-04 Thread Jan Beulich
>>> On 02.12.16 at 18:32, wrote: > On Fri, Dec 02, 2016 at 10:20:59AM -0700, Jan Beulich wrote: >> >>> On 02.12.16 at 14:48, wrote: >> > @@ -436,7 +439,7 @@ struct acpi_20_slit { >> > * Table revision numbers. >> > */ >> > #define ACPI_2_0_RSDP_REVISION 0x02 >> > -#define ACPI_2_0_FADT_REVIS

[Xen-devel] [PATCH v4 09/12] xenstore: make functions static

2016-12-04 Thread Juergen Gross
Move functions used in only one source to the file where they are used and make them static. Remove some prototypes from headers which are no longer in use. Signed-off-by: Juergen Gross --- V4: don't remove functions of libxenstore as requested by Andrew Cooper --- tools/xenstore/xenstored_core

Re: [Xen-devel] [PATCH] AMD IOMMU: Support IOAPIC IDs larger than 128

2016-12-04 Thread Jan Beulich
>>> On 05.12.16 at 05:30, wrote: > On 12/1/16 18:58, Jan Beulich wrote: > On 01.12.16 at 12:04, wrote: >> Or otherwise wouldn't it make >> sense to use the same array slots for a particular IO-APIC in both >> nr_ioapic_entries[] and ioapic_sbdf[], instead of allocating them via >> get_next_io

[Xen-devel] [linux-4.1 test] 102886: regressions - FAIL

2016-12-04 Thread osstest service owner
flight 102886 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/102886/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 6 xen-bootfail REGR. vs. 101737 test-amd64-amd64-xl-q

Re: [Xen-devel] [PATCH 1/1] xen: set error code on failures

2016-12-04 Thread Juergen Gross
On 04/12/16 07:24, Pan Bian wrote: > From: Pan Bian > > The return variable rc is initialized with "-ENOMEM" outside the loop. > However, it is reset in the loop, and its value is not negative during > the second or after repeat of the loop. If kzalloc() fails then, it will > return 0. This pat

Re: [Xen-devel] [PATCH 1/1] xen: xenbus: set error code on failure

2016-12-04 Thread Juergen Gross
On 03/12/16 11:49, Pan Bian wrote: > In function xenstored_local_init(), the value of return variable err > should be negative on errors. But the value of err keeps 0 even if the > call to get_zeroed_page() returns a NULL pointer. This patch assigns > "-ENOMEM" to err on the error branch. > > Bu

Re: [Xen-devel] Xen Solaris support still required? Illumos/Dilos Xen

2016-12-04 Thread Juergen Gross
On 04/12/16 18:11, Igor Kozhukhov wrote: > Hi Pasi, > > i’m using both addresses, but probably @gmale missed some emails with > maillist. > > About DilOS + Xen. > > i’m using xen-3.4 - old version what i backported to DilOS based on old > opensolaris varsion and upadted it to use python2.7 and s

Re: [Xen-devel] Xen Solaris support still required? Illumos/Dilos Xen

2016-12-04 Thread Igor Kozhukhov
Hi Pasi, i’m using both addresses, but probably @gmale missed some emails with maillist. About DilOS + Xen. i’m using xen-3.4 - old version what i backported to DilOS based on old opensolaris varsion and upadted it to use python2.7 and some others zfs updates - more updates :) i tried to port

Re: [Xen-devel] [PATCH] AMD IOMMU: Support IOAPIC IDs larger than 128

2016-12-04 Thread Suravee Suthikulpanit
Hi Jan, On 12/1/16 18:58, Jan Beulich wrote: On 01.12.16 at 12:04, wrote: @@ -1028,15 +1036,15 @@ static int __init parse_ivrs_table(struct acpi_table_header *table) if ( !nr_ioapic_entries[apic] ) continue; -if ( !ioapic_sbdf[IO_APIC_ID(apic)].seg && +i

[Xen-devel] [linux-3.18 test] 102875: regressions - trouble: blocked/broken/fail/pass

2016-12-04 Thread osstest service owner
flight 102875 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/102875/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 101675 test-amd64-amd

[Xen-devel] [xen-unstable baseline-only test] 68157: regressions - FAIL

2016-12-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68157 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 10 xen-boot/dst_h

[Xen-devel] [xen-4.4-testing test] 102863: regressions - FAIL

2016-12-04 Thread osstest service owner
flight 102863 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/102863/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt3 host-install(3) broken in 102751 REGR. vs. 102521 test-armhf-armh

[Xen-devel] [qemu-mainline baseline-only test] 68156: regressions - FAIL

2016-12-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68156 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-amd64-pvgrub 10 guest-start

Re: [Xen-devel] mpt3sas bug with Debian jessie kernel only under Xen - "swiotlb buffer is full"

2016-12-04 Thread Andy Smith
Hi Andrew, On Sun, Dec 04, 2016 at 03:59:20PM +, Andrew Cooper wrote: > Can you try these two patches from the XenServer Patch queue? > https://github.com/xenserver/linux-3.x.pg/blob/master/master/series#L613-L614 Thanks for getting back to me. I will try this in the next day or two and get b

[Xen-devel] [seabios test] 102858: tolerable FAIL - PUSHED

2016-12-04 Thread osstest service owner
flight 102858 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/102858/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 102484 test-amd64-amd64-xl-qemuu-win7-a

[Xen-devel] [xen-4.5-testing test] 102855: regressions - FAIL

2016-12-04 Thread osstest service owner
flight 102855 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/102855/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-4 52 leak-check/check fail REGR. vs. 102721 test-xtf-amd64-

Re: [Xen-devel] Xen Solaris support still required? Illumos/Dilos Xen

2016-12-04 Thread Pasi Kärkkäinen
Hello Igor, I noticed you're using @dilos.org email address these days, so i'm sending this email again.. see below for more info and a question for you.. On Thu, Nov 03, 2016 at 03:56:32PM +0200, Pasi Kärkkäinen wrote: > On Thu, Nov 03, 2016 at 01:49:07PM +0100, Juergen Gross wrote: > > Xen t

Re: [Xen-devel] mpt3sas bug with Debian jessie kernel only under Xen - "swiotlb buffer is full"

2016-12-04 Thread Andrew Cooper
On 04/12/16 08:32, Andy Smith wrote: > Hi, > > I have a Debian jessie server with an LSI SAS controller using the > mpt3sas driver. > > Under the Debian jessie amd64 kernel (linux-image-3.16.0-4-amd64 > 3.16.36-1+deb8u2) running under Xen, I cannot put the system's > storage under heavy load withou

[Xen-devel] [xen-unstable test] 102843: tolerable FAIL - PUSHED

2016-12-04 Thread osstest service owner
flight 102843 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/102843/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 102758 test-amd64-i386-xl-qemuu-wi

[Xen-devel] [PATCH 1/1] xen: set error code on failures

2016-12-04 Thread Pan Bian
From: Pan Bian The return variable rc is initialized with "-ENOMEM" outside the loop. However, it is reset in the loop, and its value is not negative during the second or after repeat of the loop. If kzalloc() fails then, it will return 0. This patch fixes the bug, assigning "-ENOMEM" to rc whe

[Xen-devel] [xen-unstable-coverity test] 102883: all pass - PUSHED

2016-12-04 Thread osstest service owner
flight 102883 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/102883/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 8e4b2676685f50bc26f03b5f62d8b7aea8e69dbf baseline version: xen a7a5

[Xen-devel] [linux-4.1 test] 102829: regressions - FAIL

2016-12-04 Thread osstest service owner
flight 102829 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/102829/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 6 xen-bootfail REGR. vs. 101737 test-amd64-amd64-xl-q

[Xen-devel] [xen-4.6-testing baseline-only test] 68153: regressions - FAIL

2016-12-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68153 xen-4.6-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68153/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-420 xtf/test-hvm32-

[Xen-devel] [qemu-mainline test] 102835: tolerable FAIL - PUSHED

2016-12-04 Thread osstest service owner
flight 102835 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/102835/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 22 guest-migrate/dst_host/src_host fail in 102789 pass in 102835 test-armhf-armhf-xl-rtd

[Xen-devel] mpt3sas bug with Debian jessie kernel only under Xen - "swiotlb buffer is full"

2016-12-04 Thread Andy Smith
Hi, I have a Debian jessie server with an LSI SAS controller using the mpt3sas driver. Under the Debian jessie amd64 kernel (linux-image-3.16.0-4-amd64 3.16.36-1+deb8u2) running under Xen, I cannot put the system's storage under heavy load without receiving a bunch of "swiotlb buffer is full" ker