[Xen-devel] [PATCH v3] xen: arm: Update arm64 image header

2016-06-22 Thread Dirk Behme
With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=a2c1d73b94ed49

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Corneliu ZUZU
On 6/23/2016 8:31 AM, Corneliu ZUZU wrote: On 6/22/2016 10:41 PM, Julien Grall wrote: On 22/06/2016 20:37, Corneliu ZUZU wrote: I've also realized that it's a bit complicated to avoid writing HCR from 2 places. That's because: - p2m_restore_state is part of the process of switching to anothe

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Corneliu ZUZU
On 6/22/2016 10:41 PM, Julien Grall wrote: On 22/06/2016 20:37, Corneliu ZUZU wrote: I've also realized that it's a bit complicated to avoid writing HCR from 2 places. That's because: - p2m_restore_state is part of the process of switching to another vCPU and the HCR write _must be committed_

[Xen-devel] [PATCH] xen: fix upper bound of pmd loop in xen_cleanhighmap()

2016-06-22 Thread Juergen Gross
xen_cleanhighmap() is operating on level2_kernel_pgt only. The upper bound of the loop setting non-kernel-image entries to zero should not exceed the size of level2_kernel_pgt. Reported-by: Linus Torvalds Signed-off-by: Juergen Gross --- arch/x86/xen/mmu.c | 2 +- 1 file changed, 1 insertion(+)

[Xen-devel] [PATCH v2 13/17] libxl/arm: Link all ACPI tables into one buffer

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Link all ACPI tables into one buffer, fill in the addresses of tables and update checksum of each table. Reserve a memory map space for ACPI tables. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 58 +++ xen/include/p

[Xen-devel] [PATCH v2 14/17] libxl/arm: Factor finalise_one_memory_node as a gerneric function

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Rename finalise_one_memory_node to finalise_one_node and pass the node name via function parameter. This is useful for adding ACPI module which will be added by a later patch. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 8 1 file changed, 4 insertions

[Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao It uses static DSDT table like the way x86 uses. Currently the DSDT table only contains processor device objects and it generates the maximal objects which so far is 128. Signed-off-by: Shannon Zhao --- tools/libxl/Makefile | 24 - tools/libxl/libxl_a

[Xen-devel] [PATCH v2 15/17] libxl/arm: Add ACPI module

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Add the ARM Multiboot module for ACPI, so UEFI or DomU can get the base address of ACPI tables from it. Signed-off-by: Shannon Zhao --- docs/misc/arm/device-tree/acpi.txt | 23 +++ tools/libxl/libxl_arm.c| 24 2 files

[Xen-devel] [PATCH v2 10/17] libxl/arm: Construct ACPI FADT table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 24 1 file changed, 24 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 659dbfa..353d774 100644 --- a/tools/libxl/libxl_arm_acpi.c +++ b/tools/

[Xen-devel] [PATCH v2 09/17] libxl/arm: Construct ACPI MADT table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao According to the GIC version, construct the MADT table. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 100 +++ 1 file changed, 100 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c

[Xen-devel] [PATCH v2 17/17] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao If Xen guest boots with ACPI, the guest kernel will get the event channel interrupt information via domain param HVM_PARAM_CALLBACK_IRQ. Initialize that domain param. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 8 +++- 1 file changed, 7 insertions(+),

[Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Copy all the ACPI tables to guest space so that UEFI or guest could access them. Signed-off-by: Shannon Zhao --- tools/libxc/xc_dom_arm.c | 51 1 file changed, 51 insertions(+) diff --git a/tools/libxc/xc_dom_arm.c b/tools/li

[Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Add a configuration option for ARM DomU so that user can deicde to use ACPI or not. This option is defaultly false. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 3 +++ tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c | 4 xen/include

[Xen-devel] [PATCH v2 02/17] libxc: Add placeholders for ACPI tables blob and size

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Add placeholders for ACPI tables blob and size here so that ACPI blob can be accessed from libxl and libxc. Signed-off-by: Shannon Zhao --- tools/libxc/include/xc_dom.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/x

[Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 28 1 file changed, 28 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index d5f

[Xen-devel] [PATCH v2 06/17] libxl/arm: Construct ACPI XSDT table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 40 1 file changed, 40 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 5f332fa..d5ffedf 100644 --- a/tools/libxl/libxl_arm_acp

[Xen-devel] [PATCH v2 12/17] libxl/arm: Add a helper to calculate the ACPI table checksum

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 45fc354..d8779af 100644 --- a/tools/libxl/libxl_arm_acpi.c +++ b/tools/libxl/lib

[Xen-devel] [PATCH v2 00/17] Xen ARM DomU ACPI support

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao The design of this feature is described as below. Firstly, the toolstack (libxl) generates the ACPI tables according the number of vcpus and gic controller. Then, it copies these ACPI tables to DomU non-RAM memory map space and passes them to UEFI firmware through the "ARM mul

[Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao It only constructs the ACPI tables for 64-bit ARM DomU when user enables acpi because 32-bit DomU doesn't support ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/Makefile | 4 +++ tools/libxl/libxl_arm.c | 19 +- tools/libxl/libxl_arm_acpi.c | 85

[Xen-devel] [PATCH v2 08/17] libxl/arm: Factor MPIDR computing codes out as a helper

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Factor MPIDR computing codes out as a helper, so it could be shared between DT and ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 8 +--- tools/libxl/libxl_arm_acpi.h | 12 2 files changed, 13 insertions(+), 7 deletions(-) diff --git

[Xen-devel] [PATCH v2 01/17] libxl/arm: Factor out codes for generating DTB

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Factor out codes for generating DTB to prepare for adding ACPI tables generation codes. Signed-off-by: Shannon Zhao Acked-by: Wei Liu --- tools/libxl/libxl_arm.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_arm.c

[Xen-devel] [PATCH v2 05/17] libxl/arm: Construct ACPI RSDP table

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 20 1 file changed, 20 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 60c31f9..5f332fa 100644 --- a/tools/libxl/libxl_arm_acpi.c +++ b/tools/libx

Re: [Xen-devel] [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-22 Thread Xu, Quan
On June 23, 2016 12:18 AM, Jan Beulich wrote: > >>> On 22.06.16 at 17:54, wrote: > > On June 17, 2016 3:01 PM, Jan Beulich wrote: > >> And again I don't understand: ASSERT()s are to verify assumed state. > >> If > > static > >> code analysis resulted in understanding a function is unreachable >

[Xen-devel] [qemu-upstream-4.3-testing test] 96127: regressions - FAIL

2016-06-22 Thread osstest service owner
flight 96127 qemu-upstream-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 80927 build-i

[Xen-devel] [xen-unstable test] 96125: tolerable FAIL - PUSHED

2016-06-22 Thread osstest service owner
flight 96125 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/96125/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 15 guest-start/debian.repeat fail REGR. vs. 96049 build-amd64-rumpuserxen

[Xen-devel] [xen-4.3-testing test] 96118: regressions - FAIL

2016-06-22 Thread osstest service owner
flight 96118 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96118/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 87893 build-amd64-libvi

Re: [Xen-devel] [PATCH v2 0/4] VMX: Properly handle pi descriptor and per-cpu blocking list

2016-06-22 Thread Dario Faggioli
On Tue, 2016-05-31 at 10:19 +, Wu, Feng wrote: > > -Original Message- > > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > >  > > So, if you want try argumenting a bit on what was your line of > > reasoning when doing things this way, that would be helpful (at > > least > > to

Re: [Xen-devel] [GIT PULL] xen: bug fixes for 4.7-rc0

2016-06-22 Thread Linus Torvalds
Having upgraded one of my machines to F24, I get a few new warnings during the kernel compile due to a new compiler. Some of them are just annoying and wrong, but one of them points to a real Xen bug: arch/x86/xen/mmu.c:1116:57: warning: array subscript is above array bounds [-Warray-bounds]

[Xen-devel] [ovmf test] 96126: regressions - FAIL

2016-06-22 Thread osstest service owner
flight 96126 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/96126/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-

[Xen-devel] [qemu-mainline test] 96109: regressions - FAIL

2016-06-22 Thread osstest service owner
flight 96109 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/96109/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 94856 test-amd64-i3

[Xen-devel] pcie error containment: kill domain and dm without xend

2016-06-22 Thread Elena Ufimtseva
Hello I am working on PCIe errors containment and XSA-124 relevant problem. This is only small part of the problem and I can provide more details later if that is of someone's interest. As the temporary solution, guest domain with passthrough device without SRIOV gets killed when certain AER erro

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Julien Grall
On 22/06/2016 20:37, Corneliu ZUZU wrote: I've also realized that it's a bit complicated to avoid writing HCR from 2 places. That's because: - p2m_restore_state is part of the process of switching to another vCPU and the HCR write _must be committed_ here because other components depend on that

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Corneliu ZUZU
On 6/22/2016 9:39 PM, Corneliu ZUZU wrote: On 6/22/2016 8:17 PM, Julien Grall wrote: On 22/06/16 17:35, Corneliu ZUZU wrote: Julien, Hello Corneliu, I was trying to implement having HCR stored in arch_domain or arch_vcpu as suggested above and I'm a bit confused about the code in p2m_resto

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Corneliu ZUZU
On 6/22/2016 8:17 PM, Julien Grall wrote: On 22/06/16 17:35, Corneliu ZUZU wrote: Julien, Hello Corneliu, I was trying to implement having HCR stored in arch_domain or arch_vcpu as suggested above and I'm a bit confused about the code in p2m_restore_state. I'm hoping you can provide some fe

Re: [Xen-devel] [PATCH v2 4/4] VMX: fixup PI descritpor when cpu is offline

2016-06-22 Thread George Dunlap
On Tue, May 31, 2016 at 11:31 AM, Wu, Feng wrote: > > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Friday, May 27, 2016 10:57 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin ; xen

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-22 Thread Daniel De Graaf
On 06/22/2016 11:23 AM, Jan Beulich wrote: On 22.06.16 at 16:13, wrote: On Wed, Jun 22, 2016 at 07:50:09AM -0600, Jan Beulich wrote: On 22.06.16 at 15:03, wrote: I've finally found what was causing long standing issue of not working PCI passthrough for HVM domains with qemu in stubdomain (on

Re: [Xen-devel] [PATCH v2 3/4] VMX: Assign the right value to 'NDST' field in a concern case

2016-06-22 Thread George Dunlap
On Thu, May 26, 2016 at 2:39 PM, Feng Wu wrote: > Normally, in vmx_cpu_block() 'NDST' filed should have the same > value with 'dest' or 'MASK_INSR(dest, PI_xAPIC_NDST_MASK)' depending > on whether x2apic is enabled. However, in the following scenario, > 'NDST' has different value: > > 'vcpu_block'

[Xen-devel] [PATCH v5 10/14] hvmloader: Load SeaBIOS from hvm_start_info modules

2016-06-22 Thread Anthony PERARD
... and do not include the SeaBIOS ROM into hvmloader anymore. This also fix the dependency on roms.inc, hvmloader.o does not include it. Signed-off-by: Anthony PERARD --- Change in V5: - update BUG_ON in seabios_setup_e820(). Change in V4: - check that seabios_config.bios_address have a probab

[Xen-devel] [PATCH v5 13/14] hvmloader: Always build-in SeaBIOS and OVMF loader

2016-06-22 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- tools/firmware/hvmloader/Makefile| 11 +-- tools/firmware/hvmloader/hvmloader.c | 4 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile ind

[Xen-devel] [PATCH v5 12/14] hvmloader: bios->bios_load() now needs to be defined

2016-06-22 Thread Anthony PERARD
All BIOSes but ROMBIOS needs to be loaded via modules. ROMBIOS is handled as a special case. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Change in V5: - rename patch, was: "hvmloader: Specific bios_load function required" No change in V4. Change in V3: - reprint Main BIOS in bio

[Xen-devel] [PATCH v5 11/14] hvmloader: Load OVMF from modules

2016-06-22 Thread Anthony PERARD
... and do not include the OVMF ROM into hvmloader anymore. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Change in V5: - define OVMF_END macro - fix some cast coding style Change in V4: - check if source and dest of ovmf binary does not overlaps Change in V3: - change makefile to no

[Xen-devel] [PATCH v5 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH ...

2016-06-22 Thread Anthony PERARD
... to compile SeaBIOS and OVMF. Only depend on CONFIG_*. If --with-system-* configure option is used, then set *_CONFIG=n to not compile SEABIOS and OVMF. Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Please, run ./autogen.sh on this patch. No change

[Xen-devel] [PATCH] get_maintainer.pl: Teach brace expansion

2016-06-22 Thread Anthony PERARD
This only implement a simpler non-nested brace expansion. This will convert brace expansion style use in MAINTAINER into a regex that get_maintainer.pl can use to match a path again a maintainer section. It is done by using two different regex, the first one will take care of converting ',' insid

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Julien Grall
On 22/06/16 17:35, Corneliu ZUZU wrote: Julien, Hello Corneliu, I was trying to implement having HCR stored in arch_domain or arch_vcpu as suggested above and I'm a bit confused about the code in p2m_restore_state. I'm hoping you can provide some feedback on this matter. Here's the current i

[Xen-devel] [PATCH v5 02/14] libxc: Prepare a start info structure for hvmloader

2016-06-22 Thread Anthony PERARD
... and load BIOS/UEFI firmware into guest memory. This adds a new firmware module, system_firmware_module. It is loaded in the guest memory and final location is provided to hvmloader via the hvm_start_info struct. This patch create the hvm_start_info struct for HVM guest that have a device mode

[Xen-devel] [PATCH v5 05/14] libxl: Load guest BIOS from file

2016-06-22 Thread Anthony PERARD
The path to the BIOS blob can be overriden by the xl's bios_path_override option, or provided by u.hvm.bios_firmware in the domain_build_info struct by other libxl user. Signed-off-by: Anthony PERARD --- Changes in V5: - man page, use B<> to highlight config option in description. - rename confi

[Xen-devel] [PATCH v5 09/14] hvmloader: Check modules whereabouts in perform_tests

2016-06-22 Thread Anthony PERARD
As perform_tests() is going to clear memory past 4MB, we check that the memory can be use or we skip the tests. Signed-off-by: Anthony PERARD --- Changes in V5: - also account for the pages table - fix coding style - also check modules cmdline and main cmdline and modlist_paddr - make use of ch

[Xen-devel] [PATCH v5 03/14] configure: #define SEABIOS_PATH and OVMF_PATH

2016-06-22 Thread Anthony PERARD
Those paths are to be used by libxl, in order to load the firmware in memory. If a system path is not defined via --with-system-seabios or --with-system-ovmf, then default to the Xen firmware directory. Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Plea

[Xen-devel] [PATCH v5 01/14] libxc: Rework extra module initialisation

2016-06-22 Thread Anthony PERARD
This patch use xc_dom_alloc_segment() to allocate the memory space for the ACPI modules and the SMBIOS modules. This is to replace the arbitrary placement of 1MB (+ extra for MB alignement) after the hvmloader image. This patch can help if one add extra ACPI table and hvmloader contain OVMF (OVMF

[Xen-devel] [PATCH v5 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h

2016-06-22 Thread Anthony PERARD
Instead of having several representation of hvm_start_info in C, define it in public/xen.h so both libxc and hvmloader can use it. Signed-off-by: Anthony PERARD --- Change in V5: - remove packed attribute. New in V4. --- tools/libxc/include/xc_dom.h | 31 --- xen/inc

[Xen-devel] [PATCH v5 04/14] firmware/makefile: install BIOS blob ...

2016-06-22 Thread Anthony PERARD
... into the firmware directory, along with hvmloader. Signed-off-by: Anthony PERARD --- Change in V5: - remove use of "variable" for SEABIOS_ROM and OVMF_ROM location there are static location - install seabios as bios.bin instead of seabios.bin Change in V4: - remove install of acpi dsdt tabl

[Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-22 Thread Anthony PERARD
The BIOS blob can be found an entry called "firmware" of the modlist of the hvm_start_info struct. The found BIOS blob is not loaded by this patch, but only passed as argument to bios_load() function. Signed-off-by: Anthony PERARD --- Changes in V5: - don't BUG() on module's paddr having value

[Xen-devel] [PATCH v5 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-06-22 Thread Anthony PERARD
Hi all, Changes in V5: quite a few rework it as been suggest that "bios" was not quite right to name SeaBIOS/OVMF, so when I introduce a new name/variable instead of bios, I tried to use system_firmware which is more appropriate, I think, with regards to OVMF. Details of the changes in

[Xen-devel] [PATCH v5 07/14] hvmloader: Grab the hvm_start_info pointer

2016-06-22 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Jan Beulich --- Change in V4: - remove struct hvm_info_start redefinition, as it's moved to public/xen.h in a previous patch. Change in V3: - remove cmdline parser - load hvm_start_info pointer earlier, before calling

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 03:52:43PM +0100, Wei Liu wrote: > On Wed, Jun 22, 2016 at 02:52:47PM +0100, David Vrabel wrote: > > On 22/06/16 14:29, Wei Liu wrote: > > > On Wed, Jun 22, 2016 at 01:37:50PM +0100, David Vrabel wrote: > > >> On 22/06/16 12:21, Wei Liu wrote: > > >>> On Wed, Jun 22, 2016 at

Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

2016-06-22 Thread Corneliu ZUZU
On 6/17/2016 1:36 PM, Corneliu ZUZU wrote: On 6/16/2016 7:49 PM, Julien Grall wrote: Hello Corneliu, On 16/06/16 15:13, Corneliu ZUZU wrote: +case MWS_TTBCR: +MWS_EMUL(TTBCR); +break; +default: +break; +} + +w->status = MWS_NOWRITE; +} + +static inline

Re: [Xen-devel] [PATCH v1 Altp2m cleanup 0/3] Cleaning up altp2m code

2016-06-22 Thread Lai, Paul C
Jan: Ok... adding back xen-devel. Thanks for the pointer to the thread. I'm looking at the existing Xen code and the changes mentioned by George (and supported by Tim) are already in. The patch suggested by George is http://lists.xenproject.org/archives/html/xen-devel/2015-07/txtEYYYL6ATei.t

Re: [Xen-devel] [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-22 Thread Jan Beulich
>>> On 22.06.16 at 17:54, wrote: > On June 17, 2016 3:01 PM, Jan Beulich wrote: >> And again I don't understand: ASSERT()s are to verify assumed state. If > static >> code analysis resulted in understanding a function is unreachable when >> qi_ctrl->qinval_maddr is zero (because qinval ought to

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-22 Thread Meng Xu
On Wed, Jun 22, 2016 at 11:51 AM, George Dunlap wrote: > On Mon, May 16, 2016 at 12:54 AM, Tianyang Chen wrote: >> No functional change: >> -Various coding style fix >> -Added comments for UPDATE_LIMIT_SHIFT. >> >> Signed-off-by: Tianyang Chen > > Hey Tianyang, > > The changes here for the mos

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-22 Thread George Dunlap
On Mon, May 16, 2016 at 12:54 AM, Tianyang Chen wrote: > No functional change: > -Various coding style fix > -Added comments for UPDATE_LIMIT_SHIFT. > > Signed-off-by: Tianyang Chen Hey Tianyang, The changes here for the most part look good (with a few comments -- see below), but the title an

[Xen-devel] [xen-4.3-testing bisection] complete build-amd64-libvirt

2016-06-22 Thread osstest service owner
branch xen-4.3-testing xenbranch xen-4.3-testing job build-amd64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.gi

Re: [Xen-devel] [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node

2016-06-22 Thread Julien Grall
Hello Dirk, On 21/06/16 11:15, Dirk Behme wrote: Some clocks might be used by Xen (drivers) and not by the Linux kernel. If these are not registered by the Linux kernel, they might be disabled by the Linux kernel's clk_disable_unused() as the kernel doesn't know that they are used (by Xen driver

Re: [Xen-devel] [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-22 Thread Xu, Quan
On June 17, 2016 3:01 PM, Jan Beulich wrote: > And again I don't understand: ASSERT()s are to verify assumed state. If static > code analysis resulted in understanding a function is unreachable when > qi_ctrl->qinval_maddr is zero (because qinval ought to have got disabled if > any > of the table

[Xen-devel] [PATCH 05/17] block: Convert BB interface to byte-based discards

2016-06-22 Thread Eric Blake
Change sector-based blk_discard(), blk_co_discard(), and blk_aio_discard() to instead be byte-based *_pdiscard() functions. NBD gets a lot simpler now that ignoring the unaligned portion of a byte-based discard request is handled under the hood by the block layer. Signed-off-by: Eric Blake ---

Re: [Xen-devel] [PATCH 0/3] xen: add full support for CONFIG_PARAVIRT_TIME_ACCOUNTING

2016-06-22 Thread Boris Ostrovsky
On 06/22/2016 03:03 AM, Juergen Gross wrote: > With most recent Xen hypervisor (4.8) it is now possible to add full > support of CONFIG_PARAVIRT_TIME_ACCOUNTING. > > To be applied on top of commit ed2f61fdd2356c2a1d1239aa1507ce4e2e059306 > "xen: add steal_clock support on x86" of kernel/git/xen/tip

Re: [Xen-devel] [PATCH] xen/arm: register clocks used by the hypervisor

2016-06-22 Thread Mark Rutland
On Wed, Jun 22, 2016 at 04:26:46PM +0100, Julien Grall wrote: > Hello Dirk, > > On 21/06/16 11:16, Dirk Behme wrote: > >Some clocks might be used by the Xen hypervisor and not by the Linux > >kernel. If these are not registered by the Linux kernel, they might be > >disabled by clk_disable_unused()

Re: [Xen-devel] [PATCH v3 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-22 Thread Jan Beulich
>>> On 20.06.16 at 18:30, wrote: > @@ -97,9 +98,17 @@ boolean_param("hap", opt_hap_enabled); > > #ifndef opt_hvm_fep > /* Permit use of the Forced Emulation Prefix in HVM guests */ > -bool_t opt_hvm_fep; > +bool_t __read_mostly opt_hvm_fep; > boolean_param("hvm_fep", opt_hvm_fep); > #endif >

Re: [Xen-devel] [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

2016-06-22 Thread George Dunlap
On Sun, Jun 12, 2016 at 12:24 AM, Tamas K Lengyel wrote: > Currently mem-sharing can be performed on a page-by-page base from the control > domain. However, when completely deduplicating (cloning) a VM, this requires > at least 3 hypercalls per page. As the user has to loop through all pages up >

Re: [Xen-devel] [PATCH v3 2/3] console: use warning infrastructure for sync console warning

2016-06-22 Thread Jan Beulich
>>> On 20.06.16 at 18:30, wrote: > @@ -44,6 +44,14 @@ string_param("conswitch", opt_conswitch); > /* sync_console: force synchronous console output (useful for debugging). */ > static bool_t __initdata opt_sync_console; > boolean_param("sync_console", opt_sync_console); > +static const char __i

Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-22 Thread Jan Beulich
>>> On 20.06.16 at 18:30, wrote: > @@ -1582,6 +1583,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > init_constructors(); > > +warning_print(); > + > console_endboot(); What about an ARM equivalent? Perhaps put this in console_endboot()? > --- a/xen/common/Makefil

Re: [Xen-devel] [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 09:20:57AM -0600, Jan Beulich wrote: > >>> On 22.06.16 at 15:59, wrote: > > On Wed, Jun 22, 2016 at 07:53:56AM -0600, Jan Beulich wrote: > >> >>> On 22.06.16 at 15:47, wrote: > >> > On Wed, Jun 22, 2016 at 06:58:28AM -0600, Jan Beulich wrote: > >> >> >>> On 12.06.16 at 16:

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-22 Thread Gerd Hoffmann
Hi, > How could xen_ram_init() find out if the value of max-ram-below-4g is > the default or if a user have set it? Is there another way we could fix > this? I guess we'll need a separate variable for that then, something along the lines of "max-ram-below-4g-default". I'll have a look tomorrow

Re: [Xen-devel] [PATCH] xen/arm: register clocks used by the hypervisor

2016-06-22 Thread Julien Grall
Hello Dirk, On 21/06/16 11:16, Dirk Behme wrote: Some clocks might be used by the Xen hypervisor and not by the Linux kernel. If these are not registered by the Linux kernel, they might be disabled by clk_disable_unused() as the kernel doesn't know that they are used. The clock of the serial con

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-22 Thread Jan Beulich
>>> On 22.06.16 at 16:13, wrote: > On Wed, Jun 22, 2016 at 07:50:09AM -0600, Jan Beulich wrote: >> >>> On 22.06.16 at 15:03, wrote: >> > I've finally found what was causing long standing issue of not working >> > PCI passthrough for HVM domains with qemu in stubdomain (only - without >> > the oth

Re: [Xen-devel] [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target

2016-06-22 Thread Jan Beulich
>>> On 22.06.16 at 15:59, wrote: > On Wed, Jun 22, 2016 at 07:53:56AM -0600, Jan Beulich wrote: >> >>> On 22.06.16 at 15:47, wrote: >> > On Wed, Jun 22, 2016 at 06:58:28AM -0600, Jan Beulich wrote: >> >> >>> On 12.06.16 at 16:09, wrote: >> >> > --- a/tools/libxl/libxl.c >> >> > +++ b/tools/libxl

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Stefano Stabellini
On Wed, 22 Jun 2016, Julien Grall wrote: > Hi Konrad, > > On 22/06/16 15:29, Konrad Rzeszutek Wilk wrote: > > > > Oh, indeed! > > > > > > > > > > > > > > > My patch doesn't change anything regarding the fact that if the magics > > > > > are > > > > > not valid (due to quite old kernel version) t

[Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-22 Thread Anthony PERARD
Hi, following commit 8156d48 (pc: allow raising low memory via max-ram-below-4g option), guest under Xen fail to boot. This is due to the initial value of max-ram-below-4g been change from 4G to 3.5G. Unfortunately, a Xen guest have a higher default split, at 3.75G, but can be change via the -mach

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Julien Grall
Hi Konrad, On 22/06/16 15:29, Konrad Rzeszutek Wilk wrote: Oh, indeed! My patch doesn't change anything regarding the fact that if the magics are not valid (due to quite old kernel version) the code does exit with an error. /me nods While the review of v1 of this patch, Julien asked for a

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 02:52:47PM +0100, David Vrabel wrote: > On 22/06/16 14:29, Wei Liu wrote: > > On Wed, Jun 22, 2016 at 01:37:50PM +0100, David Vrabel wrote: > >> On 22/06/16 12:21, Wei Liu wrote: > >>> On Wed, Jun 22, 2016 at 10:37:24AM +0100, David Vrabel wrote: > On 22/06/16 09:38, Pa

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Konrad Rzeszutek Wilk
> >>Please check the _existing_ code: It's > >> > >> > >>if ( zimage.magic0 != ZIMAGE64_MAGIC_V0 && > >> zimage.magic1 != ZIMAGE64_MAGIC_V1 ) > >> return -EINVAL; > > It is an "&&" not "||". So it will fail only if none of the 2 magics are > present. > Argh. Brainfart! > >Oh, indeed! > >

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-06-22 Thread Paulina Szubarczyk
On Wed, 22 Jun 2016 12:24:16 +0100 Wei Liu wrote: > On Wed, Jun 22, 2016 at 11:53:00AM +0200, Paulina Szubarczyk wrote: > [...] > > > I know Wei asked for this but you've replaced what should be a single > > > pointer assignment with a memory allocation and two loops over all the > > > segments.

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-22 Thread Marek Marczykowski-Górecki
On Wed, Jun 22, 2016 at 07:50:09AM -0600, Jan Beulich wrote: > >>> On 22.06.16 at 15:03, wrote: > > I've finally found what was causing long standing issue of not working > > PCI passthrough for HVM domains with qemu in stubdomain (only - without > > the other one in dom0). It looks to be this pat

Re: [Xen-devel] [PATCHv2] x86/xen: avoid m2p lookup when setting early page table entries

2016-06-22 Thread Boris Ostrovsky
On 06/22/2016 07:19 AM, David Vrabel wrote: > On 22/06/16 11:54, David Vrabel wrote: >> On 21/06/16 20:31, Boris Ostrovsky wrote: >>> On 06/21/2016 12:09 PM, David Vrabel wrote: When page tables entries are set using xen_set_pte_init() during early boot there is no page fault handler that

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Dirk Behme
On 22.06.2016 15:44, Julien Grall wrote: Hi Konrad, On 22/06/16 14:30, Konrad Rzeszutek Wilk wrote: On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?

Re: [Xen-devel] [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 07:53:56AM -0600, Jan Beulich wrote: > >>> On 22.06.16 at 15:47, wrote: > > On Wed, Jun 22, 2016 at 06:58:28AM -0600, Jan Beulich wrote: > >> >>> On 12.06.16 at 16:09, wrote: > >> > --- a/tools/libxl/libxl.c > >> > +++ b/tools/libxl/libxl.c > >> > @@ -4927,10 +4927,12 @@ r

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Julien Grall
Hello, On 22/06/16 14:51, Konrad Rzeszutek Wilk wrote: On Wed, Jun 22, 2016 at 03:44:44PM +0200, Dirk Behme wrote: On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote: On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: With the Linux kernel commits https://git.kernel.org/cgit/linux/ker

Re: [Xen-devel] [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target

2016-06-22 Thread Jan Beulich
>>> On 22.06.16 at 15:47, wrote: > On Wed, Jun 22, 2016 at 06:58:28AM -0600, Jan Beulich wrote: >> >>> On 12.06.16 at 16:09, wrote: >> > --- a/tools/libxl/libxl.c >> > +++ b/tools/libxl/libxl.c >> > @@ -4927,10 +4927,12 @@ retry_transaction: >> > >> > target = libxl__xs_read(gc, t, GCSPRIN

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-06-22 Thread David Vrabel
On 22/06/16 14:29, Wei Liu wrote: > On Wed, Jun 22, 2016 at 01:37:50PM +0100, David Vrabel wrote: >> On 22/06/16 12:21, Wei Liu wrote: >>> On Wed, Jun 22, 2016 at 10:37:24AM +0100, David Vrabel wrote: On 22/06/16 09:38, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNT

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Konrad Rzeszutek Wilk
On Wed, Jun 22, 2016 at 03:44:44PM +0200, Dirk Behme wrote: > On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote: > >On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: > >>With the Linux kernel commits > >> > >>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentat

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-22 Thread Jan Beulich
>>> On 22.06.16 at 15:03, wrote: > I've finally found what was causing long standing issue of not working > PCI passthrough for HVM domains with qemu in stubdomain (only - without > the other one in dom0). It looks to be this patch: > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=c428c9f

Re: [Xen-devel] [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 06:58:28AM -0600, Jan Beulich wrote: > >>> On 12.06.16 at 16:09, wrote: > > --- a/tools/libxl/libxl.c > > +++ b/tools/libxl/libxl.c > > @@ -4927,10 +4927,12 @@ retry_transaction: > > > > target = libxl__xs_read(gc, t, GCSPRINTF("%s/memory/target", dompath)); > >

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Dirk Behme
On 22.06.2016 15:30, Konrad Rzeszutek Wilk wrote: On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0 https:/

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Julien Grall
Hi Konrad, On 22/06/16 14:30, Konrad Rzeszutek Wilk wrote: On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

2016-06-22 Thread Konrad Rzeszutek Wilk
On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote: > With the Linux kernel commits > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0 > > https://git.kernel.org/cgit/linux/kernel/git/torva

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-06-22 Thread Wei Liu
On Wed, Jun 22, 2016 at 01:37:50PM +0100, David Vrabel wrote: > On 22/06/16 12:21, Wei Liu wrote: > > On Wed, Jun 22, 2016 at 10:37:24AM +0100, David Vrabel wrote: > >> On 22/06/16 09:38, Paulina Szubarczyk wrote: > >>> In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > >>> system call

[Xen-devel] [PATCH 5/9] xen/arm: Provide macros to help creating workaround helpers

2016-06-22 Thread Julien Grall
Workarounds may require to execute a different path when the platform is affected by the associated erratum. Furthermore, this may need to be called in the common code. To avoid too much intrusion/overhead, the workaround helpers need to be a nop on architecture which will never have the workaroun

[Xen-devel] [PATCH 9/9] xen/arm: arm64: Add Cortex-A57 erratum 834220 workaround

2016-06-22 Thread Julien Grall
The ARM erratum applies to certain revisions of Cortex-A57. The processor may report a Stage 2 translation fault as the result of Stage 1 fault for load crossing a page boundary when there is a permission fault or device memory fault at stage 1 and a translation fault at Stage 2. So Xen needs to c

[Xen-devel] [PATCH 8/9] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers

2016-06-22 Thread Julien Grall
Translating a VA to a IPA is expensive. Currently, Xen is assuming that HPFAR_EL2 is only valid when the stage-2 data/instruction abort happened during a translation table walk of a first stage translation (i.e S1PTW is set). However, based on the ARM ARM (D7.2.34 in DDI 0487A.j), the register is

[Xen-devel] [xen-unstable-smoke test] 96116: tolerable all pass - PUSHED

2016-06-22 Thread osstest service owner
flight 96116 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [PATCH 4/9] xen/arm: traps: Simplify the switch in do_trap_*_abort_guest

2016-06-22 Thread Julien Grall
The fault status we care are all the form xx where xx is the lookup level that gave the fault. We can simply the code by masking the 2 least significant bits. Signed-off-by: Julien Grall --- xen/arch/arm/traps.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/

  1   2   3   >