[Xen-devel] [seabios baseline-only test] 38319: tolerable FAIL

2015-11-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38319 seabios real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38319/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-winxpsp3 9 windows-install

[Xen-devel] patch for restricted vPMU modes

2015-11-20 Thread Brendan Gregg
G'Day, The vpmu feature of Xen is incredibly useful for performance analysis, however, it's currently all counters or nothing. In secure environments, there can be hesitation to enable access to all PMCs (there are hundreds of them). I've included a prototype patch that introduces two new restrict

Re: [Xen-devel] [PATCH 3/3] libxl: implement virDomainInterfaceStats

2015-11-20 Thread Joao Martins
On 11/20/2015 07:25 PM, Jim Fehlig wrote: > On 11/19/2015 04:45 PM, Joao Martins wrote: >> Introduce support for domainInterfaceStats API call for querying >> network interface statistics. Consequently it also enables the >> use of `virsh domifstat ` command plus >> seeing the interfaces names i

Re: [Xen-devel] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

2015-11-20 Thread Joao Martins
On 11/20/2015 07:05 PM, Jim Fehlig wrote: > On 11/19/2015 04:45 PM, Joao Martins wrote: > > You're not going to be happy with me... > >> This new field in libxlDomainObjPrivate is named "config" >> and is kept while the domain is active. > > While this sounded like a good idea when I mentioned

[Xen-devel] [seabios test] 64846: tolerable FAIL - PUSHED

2015-11-20 Thread osstest service owner
flight 64846 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/64846/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 64584 Tests which did not succeed, but a

[Xen-devel] [ovmf baseline-only test] 38318: all pass

2015-11-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38318 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38318/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf 55df704dd24928b60b10bbb9dec5bfa7682910de baseline version: ovm

[Xen-devel] [xen-4.4-testing baseline-only test] 38317: regressions - FAIL

2015-11-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38317 xen-4.4-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38317/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-prev 5 xen-build

[Xen-devel] [linux-3.16 test] 64841: regressions - FAIL

2015-11-20 Thread osstest service owner
flight 64841 linux-3.16 real [real] http://logs.test-lab.xenproject.org/osstest/logs/64841/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-localmigrate fail REGR. vs. 63429 Regr

Re: [Xen-devel] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

2015-11-20 Thread Jim Fehlig
On 11/20/2015 08:31 AM, Ian Campbell wrote: > On Fri, 2015-11-13 at 14:36 -0700, Jim Fehlig wrote: >> Prior to this patch, libxl events were delivered to libvirt via >> the libxlDomainEventHandler callback registered with libxl. >> Documenation in $xensrc/tools/libxl/libxl_event.h states that the >

Re: [Xen-devel] [PATCH 3/3] libxl: implement virDomainInterfaceStats

2015-11-20 Thread Jim Fehlig
On 11/19/2015 04:45 PM, Joao Martins wrote: > Introduce support for domainInterfaceStats API call for querying > network interface statistics. Consequently it also enables the > use of `virsh domifstat ` command plus > seeing the interfaces names instead of "-" when doing > `virsh domiflist `. > >

[Xen-devel] [PATCHv5] 12/28] build: convert HAS_CPUFREQ use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_CPUFREQ defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Liu Jinsong Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig| 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/Kconfig | 2 ++ xen/drivers/Mak

[Xen-devel] [PATCHv5] 15/28] build: convert HAS_KEXEC use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_KEXEC defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/common/Kconfig| 4 4 files changed, 6 i

[Xen-devel] [PATCHv5] 17/28] build: convert HAS_CADENCE_UART use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_CADENCE_UART defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- config/arm64.mk | 1 - xen/arch/arm/configs/arm64_defconfig | 1 + xen/drivers/c

[Xen-devel] [PATCHv5] 13/28] build: convert HAS_GDBSX use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_GDBSX defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Rules.mk | 1 - xen/common/Kconfig| 4 xen/common/domain.c | 2 +- 4 files changed, 5 i

[Xen-devel] [PATCHv5] 05/28] build: convert HAS_DEVICE_TREE use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_DEVICE_TREE defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Jan Beulich CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk | 1 - xen/arch/arm/Kconfig | 1 +

[Xen-devel] [PATCHv5] 02/28] build: build Kconfig and config rules

2015-11-20 Thread Doug Goldstein
Wire in the Kconfig build and makefile rules to be able to generate valid configuration files to be used by the build process but don't actually use the output for affecting the Xen build. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by:

[Xen-devel] [PATCHv5] 00/28] Kconfig conversion

2015-11-20 Thread Doug Goldstein
The following series is a follow on to the Kconfig conversion patch series. There are still more components to convert however this is the bare minimal to get everything working and get the options out of the existing makefiles. The CONFIG_HAS_ variables are there to match the behavior of the Linu

[Xen-devel] [PATCHv5] 09/28] build: convert HAS_ACPI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_ACPI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk| 1 - xen/common/sysctl.c | 2 +- xen/drivers/

[Xen-devel] [PATCHv5] 22/28] build: convert HAS_EHCI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_UART_EHCI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/char/Kconfig | 7 +++ xen/drivers/char/Makefile | 2 +- 4

[Xen-devel] [PATCHv5] 24/28] build: convert HAS_MEM_PAGING use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_PAGING defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by: Daniel De Graaf --- config/x86_32.mk

[Xen-devel] [PATCHv5] 23/28] build: convert HAS_MEM_ACCESS use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_ACCESS defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by

[Xen-devel] [PATCHv5] 08/28] build: convert HAS_IOPORTS use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_IOPORTS defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/char/Kconfig | 5 +

[Xen-devel] [PATCHv5] 26/28] build: convert HAS_GICV3 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_GICV3 defines in the code base. CC: Ian Campbell CC: Stefano Stabellini Signed-off-by: Doug Goldstein --- config/arm64.mk | 1 - xen/arch/arm/Kconfig | 5 + xen/arch/arm/Makefile| 2 +- xen/arch/arm/Rules.mk| 2 -- x

[Xen-devel] [PATCHv5] 19/28] build: convert HAS_EXYNOS4210 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_UART_EXYNOS4210 defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- config/arm32.mk | 1 - xen/arch/arm/configs/arm32_defconfig | 1 + xen/drivers/ch

[Xen-devel] [PATCHv5] 20/28] build: convert HAS_OMAP use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_UART_OMAP defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- config/arm32.mk | 1 - xen/arch/arm/configs/arm32_defconfig | 1 + xen/drivers/char/Kco

[Xen-devel] [PATCHv5] 28/28] build: convert kexec options to CONFIG_KEXEC

2015-11-20 Thread Doug Goldstein
Replace kexec := y in Rules.mk with a Kconfig option called CONFIG_KEXEC CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/Rules.mk | 6 -- xen/common/Kconfig | 12 2 files changed, 12 insertions(+),

[Xen-devel] [PATCHv5] 21/28] build: convert HAS_SCIF use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_UART_SCIF defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- config/arm32.mk | 1 - xen/drivers/char/Kconfig | 7 +++ xen/drivers/char/Makefile | 2 +- 3

[Xen-devel] [PATCHv5] 27/28] build: convert CONFIG_COMPAT to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_COMPAT defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 3842018..7d92

[Xen-devel] [PATCHv5] 06/28] build: convert HAS_PCI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_PCI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86

[Xen-devel] [PATCHv5] 16/28] build: convert HAS_ARM_HDLCD use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_ARM_HDLCD defines in the code base. CC: Ian Campbell CC: Stefano Stabellini Signed-off-by: Doug Goldstein --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 2 -- xen/drivers/video/Makefile | 2 +- 3 files changed, 2 insertions(+), 3 deletio

[Xen-devel] [PATCHv5] 18/28] build: convert HAS_PL011 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_UART_PL011 defines in the code base. The prefix HAS_ does not make sense in this case because these are intended to be user selected options while HAS_ just states that the hardware has this support and is controlled by Xen maintainers. CC: Ian Campbell CC: Ian Ja

[Xen-devel] [PATCHv5] 25/28] build: convert HAS_MEM_SHARING use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_SHARING defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by: Daniel De Graaf --- config/x86_32.mk

[Xen-devel] [PATCHv5] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated HAS_PASSTHROUGH defines for the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk| 1 - xen/arch/a

[Xen-devel] [PATCHv5] 14/28] build: convert HAS_PDX use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_PDX defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 1 - xen/arch/x86/

[Xen-devel] [PATCHv5] 07/28] build: convert HAS_NS16550 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_NS16550 defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- config/arm32.mk | 1 - config/arm64.mk | 1 - xen/arch/arm/configs/arm32_defconfig | 1 + xen/ar

[Xen-devel] [PATCHv5] 11/28] build: convert HAS_VGA use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_VGA defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/video/Makefile | 4 ++-- 3 files changed, 3 insertions(+), 3 d

[Xen-devel] [PATCHv5] 03/28] build: use generated Kconfig options for Xen

2015-11-20 Thread Doug Goldstein
Switches the build system to rely on the options and flags generated by Kconfig to control what gets built and how. Follow on patches will convert items to be prefixed with CONFIG_. Additionally remove a #define that resulted in a redefined variable when building for arm. CC: Ian Campbell CC: Ste

[Xen-devel] [PATCHv5] 10/28] build: convert HAS_VIDEO use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_VIDEO defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 1 - xen/arch/x86/Kconfig |

Re: [Xen-devel] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

2015-11-20 Thread Jim Fehlig
On 11/19/2015 04:45 PM, Joao Martins wrote: You're not going to be happy with me... > This new field in libxlDomainObjPrivate is named "config" > and is kept while the domain is active. While this sounded like a good idea when I mentioned it, I'm now worried that the config will quickly become s

Re: [Xen-devel] Crash in set_cpu_sibling_map() booting Xen 4.6.0 on Fusion

2015-11-20 Thread Ed Swierk
I instrumented set_nr_sockets() and smp_store_cpu_info(), and re-ran with varying numbers of CPUs. With 4 CPUs, nr_sockets=4, so smp_store_cpu_info() exceeds the bounds of the socket_cpumask array when socket=4 or 6. Loading xen-4.6-amd64.gz... ok Loading vmlinuz-3.14.51-grsec-dock... ok Loading

Re: [Xen-devel] [PATCH v3] minios: don't rely on specific page table allocation scheme

2015-11-20 Thread Samuel Thibault
Juergen Gross, on Fri 20 Nov 2015 19:32:42 +0100, wrote: > Today mini-os is making assumptions how the page tables it is started > with are being allocated. Especially it is using the number of page > table frames to calculate which is the first unmapped pfn. > > Instead of relying on page table n

[Xen-devel] [PATCHv4] 28/28] build: convert kexec options to CONFIG_KEXEC

2015-11-20 Thread Doug Goldstein
Replace kexec := y in Rules.mk with a Kconfig option called CONFIG_KEXEC CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/Rules.mk | 6 -- xen/common/Kconfig | 12 2 files changed, 12 insertions(+),

[Xen-devel] [PATCHv4] 25/28] build: convert HAS_MEM_SHARING use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_SHARING defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by: Daniel De Graaf --- config/x86_32.mk

[Xen-devel] [PATCHv4] 23/28] build: convert HAS_MEM_ACCESS use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_ACCESS defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by

[Xen-devel] [PATCHv4] 17/28] build: convert HAS_CADENCE_UART use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_CADENCE_UART defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 2 files changed, 5 insertions(+

[Xen-devel] [PATCHv4] 19/28] build: convert HAS_EXYNOS4210 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_EXYNOS4210 defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 2 files changed, 5 insertions(+),

[Xen-devel] [PATCHv4] 20/28] build: convert HAS_OMAP use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_OMAP defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 2 files changed, 5 insertions(+), 1 del

[Xen-devel] [PATCHv4] 16/28] build: convert HAS_ARM_HDLCD use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_ARM_HDLCD defines in the code base. CC: Ian Campbell CC: Stefano Stabellini Signed-off-by: Doug Goldstein --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 2 -- xen/drivers/video/Makefile | 2 +- 3 files changed, 2 insertions(+), 3 deletio

[Xen-devel] [PATCHv4] 22/28] build: convert HAS_EHCI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_EHCI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 4 fil

[Xen-devel] [PATCHv4] 26/28] build: convert HAS_GICV3 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_GICV3 defines in the code base. CC: Ian Campbell CC: Stefano Stabellini Signed-off-by: Doug Goldstein --- xen/arch/arm/Kconfig | 5 + xen/arch/arm/Makefile| 2 +- xen/arch/arm/Rules.mk| 2 -- xen/arch/arm/vgic.c | 2 +-

[Xen-devel] [PATCHv4] 24/28] build: convert HAS_MEM_PAGING use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_MEM_PAGING defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Razvan Cojocaru Acked-by: Daniel De Graaf --- config/x86_32.mk

[Xen-devel] [PATCHv4] 21/28] build: convert HAS_SCIF use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_SCIF defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 2 files changed, 5 insertions(+), 1 del

[Xen-devel] [PATCHv4] 27/28] build: convert CONFIG_COMPAT to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_COMPAT defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 7a90fb7..1a62

[Xen-devel] [PATCHv4] 18/28] build: convert HAS_PL011 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_PL011 defines in the code base. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 4 xen/drivers/char/Makefile | 2 +- 2 files changed, 5 insertions(+), 1 de

[Xen-devel] [PATCHv4] 12/28] build: convert HAS_CPUFREQ use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_CPUFREQ defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Liu Jinsong Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig| 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/Kconfig | 2 ++ xen/drivers/Mak

[Xen-devel] [PATCHv4] 09/28] build: convert HAS_ACPI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_ACPI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk| 1 - xen/common/sysctl.c | 2 +- xen/drivers/

[Xen-devel] [PATCHv4] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated HAS_PASSTHROUGH defines for the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk| 1 - xen/arch/a

[Xen-devel] [PATCHv4] 03/28] arm: drop now redefined CONFIG_64BIT

2015-11-20 Thread Doug Goldstein
The switch to Kconfig provides variables prefixed with CONFIG_ with results in a redefinition of this variable. CC: Ian Campbell CC: Stefano Stabellini Signed-off-by: Doug Goldstein --- xen/drivers/passthrough/arm/smmu.c | 4 1 file changed, 4 deletions(-) diff --git a/xen/drivers/passth

[Xen-devel] [PATCHv4] 05/28] build: convert HAS_DEVICE_TREE use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_DEVICE_TREE defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Jan Beulich CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk | 1 - xen/arch/arm/Kconfig | 1 +

[Xen-devel] [PATCHv4] 11/28] build: convert HAS_VGA use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_VGA defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/video/Makefile | 4 ++-- 3 files changed, 3 insertions(+), 3 d

[Xen-devel] [PATCHv4] 00/28] Kconfig conversion

2015-11-20 Thread Doug Goldstein
The following series is a follow on to the Kconfig conversion patch series. There are still more components to convert however this is the bare minimal to get everything working and get the options out of the existing makefiles. The CONFIG_HAS_ variables are there to match the behavior of the Linu

[Xen-devel] [PATCHv4] 13/28] build: convert HAS_GDBSX use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_GDBSX defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Rules.mk | 1 - xen/common/Kconfig| 4 xen/common/domain.c | 2 +- 4 files changed, 5 i

[Xen-devel] [PATCHv4] 15/28] build: convert HAS_KEXEC use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_KEXEC defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/common/Kconfig| 4 4 files changed, 6 i

[Xen-devel] [PATCHv4] 10/28] build: convert HAS_VIDEO use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_VIDEO defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 1 - xen/arch/x86/Kconfig |

[Xen-devel] [PATCHv4] 07/28] build: convert HAS_NS16550 use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_NS16550 defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/Kconfig | 2 ++ xen/drivers/char/Kconfig | 4 xe

[Xen-devel] [PATCHv4] 02/28] build: hookup Kconfig build and usage

2015-11-20 Thread Doug Goldstein
Wire in the Kconfig build and makefile rules to be able to generate valid configuration files to be used by the build process. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- .gitignore|

[Xen-devel] [PATCHv4] 06/28] build: convert HAS_PCI use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_PCI defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86

[Xen-devel] [PATCHv4] 08/28] build: convert HAS_IOPORTS use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_IOPORTS defines in the code base. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/x86/Kconfig | 1 + xen/arch/x86/Rules.mk | 1 - xen/drivers/char/Kconfig | 5 +

[Xen-devel] [PATCHv4] 14/28] build: convert HAS_PDX use to Kconfig

2015-11-20 Thread Doug Goldstein
Use the Kconfig generated CONFIG_HAS_PDX defines in the code base. CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/Rules.mk | 1 - xen/arch/arm/Kconfig | 1 + xen/arch/arm/Rules.mk | 1 - xen/arch/x86/

[Xen-devel] [PATCH v3] minios: don't rely on specific page table allocation scheme

2015-11-20 Thread Juergen Gross
Today mini-os is making assumptions how the page tables it is started with are being allocated. Especially it is using the number of page table frames to calculate which is the first unmapped pfn. Instead of relying on page table number assumptions just look into the page tables to find the first

[Xen-devel] [PATCH] public/hvm: Export the HVM_PARAM_CALLBACK_VIA ABI in the API

2015-11-20 Thread Andrew Cooper
Signed-off-by: Andrew Cooper CC: Keir Fraser CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell CC: Ian Jackson CC: Stefano Stabellini CC: Shannon Zhao --- This ABI is utterly mad. Despite appearing to be wrong, it is compatible with its implementation of enum { HVMIRQ_callback_

[Xen-devel] [xen-unstable-smoke test] 64959: tolerable all pass - PUSHED

2015-11-20 Thread osstest service owner
flight 64959 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/64959/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [PATCH 9/9] vtpm: guard against redefining TPM_VENDOR_COMMAND

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" vtpm.c already includes tpm/tpm_marshalling.h, this in turn includes tpm_structures.h which already has defined TPM_VENDOR_COMMAND. Guard against its redefinition to avoid a compilation warning on vtpmc: cc -I../tpm_emulator-x86_64 -c -o vtpm.o vtpm.c In file included

[Xen-devel] [PATCH 8/9] vtpm: fix vtpmblk.c compilation warning

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Using gcc5 we get the following warning: vtpmblk.c:322:7: warning: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration] vtpmblk.c:322:7: warning: incompatible implicit declaration of built-in function ‘printf’ Fix this by including stdio.h Cc:

[Xen-devel] [PATCH 7/9] stubdom: fix unfound libgmp library issues

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" With binutils 2.25.0 libgmp is not found. When building studom's we build our own libgmp for each minios. On x86-64 all libraries are put on the directory: stubdom/cross-root-x86_64/x86_64-xen-elf/lib/ The exception is libgmp, it gets tosse don lib64. It doesn't seem t

[Xen-devel] [PATCH 6/9] mini-os: fix linker warning with app.lds

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We toss around the linker script app.lds without specifying -T, this works but causes the following warning. Let's split this the required objects and use -T for the linker script. This fixes this linker warning: mcgrof@ergon ~/devel/xen/stubdom (git::stable-4.6)$ make

[Xen-devel] [PATCH 5/9] qemu-xen-dir: virtio-rng: fix check for period_ms validity

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Upstream fix a3a292c420d2 ("virtio-rng: fix check for period_ms validity") On this upstream commit Amit fixed the compilation warning: hw/virtio/virtio-rng.c: In function ‘virtio_rng_device_realize’: hw/virtio/virtio-rng.c:152:31: error: logical not is only applied to

[Xen-devel] [PATCH 4/9] qemu-xen-dir: spice: remove spice-experimental.h include

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Upstream qemu commit e0883e2de0ef36f254acc274e80ddeac13a2a8f6 ("spice: remove spice-experimental.h include") commit e0883e2de0ef36f254acc274e80ddeac13a2a8f6 Author: Marc-André Lureau Date: Mon Nov 17 16:52:49 2014 +0100 spice: remove spice-experimental.h include

[Xen-devel] [PATCH 3/9] hw/usb-net.c: fix state check

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The existing check is incorrect, currently it will actually allow the code path to move on regardless of the state, fix this. This is fixed upstream on qemu by the following commit: commit 98d23704138e0be17a3ed9eb2631077bf92cc028 Author: Peter Maydell Date: Wed Nov

[Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set()

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Using deprecate gnutls_*_set() triggers a failure to compile with gnutls30-3.4.4, used on OpenSUSE factory: ../libqemu_common.a(vnc.o): In function `vnc_start_tls': ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2164: undefined reference to `gnutls_kx_set_priority' ~

[Xen-devel] [PATCH 1/9] Revert "Use the extra stack for 16bit USB and PS2 keyboard/mouse commands."

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Upstream commit 12085439561f44107c7d3bea5a333a90ea987643 Kevin made this change upstream to seabios, this is needed for gcc5. Mark Pryor reported the issue with gcc5 a while ago [0], he however failed to follow up with an explanation as to what this does and why this is

[Xen-devel] [PATCH 0/9] xen: build fixes with gcc5 and binutils 2.25.0

2015-11-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Here's a slew of build fixes as well as build warning fixes required when using the latest build tools, at least gcc 5 and binutils 2.25.0. I ran into this while doing development on OpenSUSE factory. Other rolling distros seem to be having similar issues based on inspec

[Xen-devel] [qemu-mainline test] 64797: regressions - FAIL

2015-11-20 Thread osstest service owner
flight 64797 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/64797/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-winxpsp3 9 windows-install fail REGR. vs. 64579 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2015-11-20 Thread Stefano Stabellini
On Fri, 20 Nov 2015, Andrew Cooper wrote: > On 20/11/15 17:07, Stefano Stabellini wrote: > > On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > >> From: Shannon Zhao > >> > >> Add a new dilivery type: > > delivery > > > >> val[63:56] == 3: val[15:8] is flag: val[7:0] is a PPI. > >> To the flag,

Re: [Xen-devel] [PATCH 13/13] ARM: XEN: Move xen_early_init() before efi_init()

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Move xen_early_init() before efi_init(), then when calling efi_init() > could initialize Xen specific UEFI. > > Check if it runs on Xen hypervisor through the flat dts. > > Signed-off-by: Shannon Zhao > --- > arch/ar

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-20 Thread Alex Williamson
On Fri, 2015-11-20 at 08:10 +, Tian, Kevin wrote: > > From: Tian, Kevin > > Sent: Friday, November 20, 2015 3:10 PM > > > > > > > > > > > The proposal is therefore that GPU vendors can expose vGPUs to > > > > > userspace, and thus to QEMU, using the VFIO API. For instance, vfio > > > > > supp

Re: [Xen-devel] [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2015-11-20 Thread Andrew Cooper
On 20/11/15 17:07, Stefano Stabellini wrote: > On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: >> From: Shannon Zhao >> >> Add a new dilivery type: > delivery > >> val[63:56] == 3: val[15:8] is flag: val[7:0] is a PPI. >> To the flag, bit 0 stands the interrupt mode is edge(1) or level(0) and

Re: [Xen-devel] [PATCH 10/13] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > When it's a Xen domain0 booting with ACPI, it will supply a /chosen and > a /hypervisor node in DT. So check if it needs to enable ACPI. > > Signed-off-by: Shannon Zhao > --- > arch/arm64/kernel/acpi.c | 12 --

Re: [Xen-devel] [PATCH v11 3/5] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2015-11-20 Thread Stefano Stabellini
On Fri, 20 Nov 2015, Russell King - ARM Linux wrote: > On Fri, Nov 20, 2015 at 02:40:31PM +, Stefano Stabellini wrote: > > On Fri, 20 Nov 2015, Christopher Covington wrote: > > > Hi Stefano, > > > > > > On 11/20/2015 09:31 AM, Stefano Stabellini wrote: > > > > On Tue, 10 Nov 2015, Stefano Stab

Re: [Xen-devel] [PATCH 12/13] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > When booting with ACPI, it could get the event-channel irq through > HVM_PARAM_CALLBACK_IRQ. > > Signed-off-by: Shannon Zhao > --- > arch/arm/xen/enlighten.c | 23 +++ > 1 file changed, 19 insertio

Re: [Xen-devel] [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Add a new dilivery type: delivery > val[63:56] == 3: val[15:8] is flag: val[7:0] is a PPI. > To the flag, bit 0 stands the interrupt mode is edge(1) or level(0) and > bit 1 stands the interrupt polarity is active low(1

Re: [Xen-devel] Fwd: Xen-4.1.6.1 backport for XSA156

2015-11-20 Thread Stefan Bader
On 20.11.2015 17:54, Jan Beulich wrote: On 20.11.15 at 17:15, wrote: >> So this is a quick hack I just tried and that keeps the HVM alive: >> >> @@ -1294,7 +1288,6 @@ void vmx_inject_hw_exception(int trap, i >> switch ( trap ) >> { >> case TRAP_debug: >> -type = X86_EVE

Re: [Xen-devel] [PATCH 08/13] Xen: EFI: Parse DT parameters for Xen specific UEFI

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Add a new function to parse DT parameters for Xen specific UEFI just > like the way for normal UEFI. Then it could reuse the existing codes. > > Signed-off-by: Shannon Zhao > --- > drivers/firmware/efi/efi.c | 67 > +

Re: [Xen-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-20 Thread Alex Williamson
On Fri, 2015-11-20 at 07:09 +, Tian, Kevin wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, November 20, 2015 4:03 AM > > > > > > > > > > The proposal is therefore that GPU vendors can expose vGPUs to > > > > userspace, and thus to QEMU, using the VFIO API

[Xen-devel] [ovmf test] 64803: all pass - PUSHED

2015-11-20 Thread osstest service owner
flight 64803 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/64803/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf 55df704dd24928b60b10bbb9dec5bfa7682910de baseline version: ovmf 386cdfbecbbacb600ffc8e2ffa8c7af1b38

Re: [Xen-devel] [PATCH 09/13] ARM: Xen: Initialize Xen specific UEFI runtime services

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > When running on Xen hypervisor, runtime services are supported through > hypercall. So call Xen specific function to initialize runtime services. > > Signed-off-by: Shannon Zhao You can drop the dom0_op part of the pa

Re: [Xen-devel] Fwd: Xen-4.1.6.1 backport for XSA156

2015-11-20 Thread Jan Beulich
>>> On 20.11.15 at 17:15, wrote: > So this is a quick hack I just tried and that keeps the HVM alive: > > @@ -1294,7 +1288,6 @@ void vmx_inject_hw_exception(int trap, i > switch ( trap ) > { > case TRAP_debug: > -type = X86_EVENTTYPE_SW_EXCEPTION; > if ( guest_cpu_

Re: [Xen-devel] [PATCH v2] xen/events: Always allocate legacy interrupts on PV guests

2015-11-20 Thread Boris Ostrovsky
On 11/20/2015 11:33 AM, Stefano Stabellini wrote: BTW, I got this build error: STUBCPY drivers/firmware/efi/libstub/lib-sort.stub.o R_AARCH64_ABS64 __efistub_sort 0008 R_AARCH64_ABS64 .init__ksymtab_strings drivers/firmware/efi/libstub/lib-sort.stub.o: abso

Re: [Xen-devel] [PATCH v11 3/5] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2015-11-20 Thread Russell King - ARM Linux
On Fri, Nov 20, 2015 at 02:40:31PM +, Stefano Stabellini wrote: > On Fri, 20 Nov 2015, Christopher Covington wrote: > > Hi Stefano, > > > > On 11/20/2015 09:31 AM, Stefano Stabellini wrote: > > > On Tue, 10 Nov 2015, Stefano Stabellini wrote: > > >> On Thu, 5 Nov 2015, Stefano Stabellini wrote

Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2015-11-20 Thread Stefano Stabellini
On Tue, 17 Nov 2015, David Vrabel wrote: > On 17/11/15 09:57, shannon.z...@linaro.org wrote: > > From: Shannon Zhao > > > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > > scan this to get the UEFI information. > [...] > > --- a/Documentation/devicetree/bindings/arm/x

  1   2   3   >