Re: [Xen-devel] [PATCH v8 4/7] xen: Add vmware_port support

2015-02-10 Thread Jan Beulich
>>> On 10.02.15 at 20:30, wrote: > While coding this is up I have hit issues that I need input on: > > As a HVM_PARAM_ item, I would assume I should be following > what HVM_PARAM_VIRIDIAN does. It has this comment: > > case HVM_PARAM_VIRIDIAN: > /* This should only e

[Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-10 Thread Jan Beulich
All, I'd like to propose to honor the 'd' in these functions' names (which I understand to mean "debug") in that such functions should be no-ops in non-debug builds. I'd then be inclined to introduce a gprintk() automatically adding XENLOG_GUEST and the printing of current using the %pv format. Qu

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> On 10.02.15 at 19:03, wrote: > On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich wrote: > Tamas K Lengyel 02/10/15 5:38 PM >>> >>>On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: >>> Tamas K Lengyel 02/10/15 2:51 PM >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >>

Re: [Xen-devel] [PATCH v3 27/27] ArmVirtualizationPkg: add platform description for Xen guests

2015-02-10 Thread Olivier Martin
Reviewed-By: Olivier Martin On 03/02/15 19:20, Ard Biesheuvel wrote: This adds the .dsc and .fdf descriptions to build a UEFI image that is bootable by a Xen guest on 64-bit ARM (AArch64) Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Bieshe

Re: [Xen-devel] [PATCH RFC 25/35] arm: acpi add helper functions to map memory regions

2015-02-10 Thread Julien Grall
Hi Stefano, On 06/02/2015 22:12, Stefano Stabellini wrote: On Fri, 6 Feb 2015, Julien Grall wrote: On 06/02/2015 00:21, Stefano Stabellini wrote: On Thu, 5 Feb 2015, Julien Grall wrote: Hi parth, Title: this is not acpi specific. On 04/02/2015 14:02, parth.di...@linaro.org wrote: From: Par

Re: [Xen-devel] [PATCH v3 26/27] ArmVirtualizationPkg/VirtFdtDxe: wire up XenBusDxe to "xen, xen" DT node

2015-02-10 Thread Olivier Martin
Reviewed-By: Olivier Martin On 03/02/15 19:20, Ard Biesheuvel wrote: This patchs adds support to VirtFdtDxe for the Xen DT node which contains the base address of the Grant Table. This data is communicated to XenBusDxe using a XENIO_PROTOCOL instance. Contributed-under: TianoCore Contribution

Re: [Xen-devel] [PATCH v3 23/27] Ovmf/Xen: implement dummy RealTimeClockLib for Xen

2015-02-10 Thread Olivier Martin
Reviewed-By: Olivier Martin On 03/02/15 19:20, Ard Biesheuvel wrote: This implements a dummy RealTimeClockLib for Xen, as there is no guest interface to access the time kept by Xen that can be shared between UEFI and the OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by

Re: [Xen-devel] [PATCH v3 10/27] ArmVirtualizationPkg: implement custom MemoryInitPeiLib

2015-02-10 Thread Olivier Martin
I do not know if it is a bug in the original implementation. I think I had to do this hack to prevent some code (DXE core?) to overwrite the FD file at boot time - mainly when the FD file was loaded quite high in the system memory. But I do not see what the DXE phase could need from the original F

Re: [Xen-devel] [PATCH v3 09/27] ArmVirtualizationPkg: add a relocatable version of PrePi

2015-02-10 Thread Olivier Martin
The main comments about this patch is about the ELF Relocation Table manipulation. The code looks alright but I had to guess what some magic offsets were meaning. On 03/02/15 19:19, Ard Biesheuvel wrote: This patch introduces a relocatable PrePi, which can execute from arbitrary offsets in RAM.

Re: [Xen-devel] [PATCH RFC 21/35] xen/arm: Create memory node for DOM0

2015-02-10 Thread Julien Grall
Hi Stefano, On 06/02/2015 00:01, Stefano Stabellini wrote: On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: From: Naresh Bhat Create a memory node for DOM0. Signed-off-by: Naresh Bhat --- xen/arch/arm/domain_build.c | 48 + 1 file changed, 48

Re: [Xen-devel] [PATCH RFC 18/35] arm : add helper function for setting interrupt type

2015-02-10 Thread Julien Grall
Hi Stefano, On 05/02/2015 23:33, Stefano Stabellini wrote: On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: From: Parth Dixit set edge/level type information for an interrupt Signed-off-by: Parth Dixit --- xen/arch/arm/irq.c| 19 +++ xen/include/asm-arm/irq.h |

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-10 Thread Julien Grall
Hi Ian, On 05/02/2015 22:52, Ian Campbell wrote: On Thu, 2015-02-05 at 22:29 +0800, Julien Grall wrote: On 05/02/2015 19:42, Ian Campbell wrote: On Wed, 2015-02-04 at 21:57 +, Julien Grall wrote: I believe that most of the SPCR parsing should be generic, so maybe you could extend the DEV

Re: [Xen-devel] [PATCH RFC 13/35] ACPI: Introduce acpi_parse_entries

2015-02-10 Thread Julien Grall
Hi Stefano, On 05/02/2015 18:29, Stefano Stabellini wrote: On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: From: Naresh Bhat Introduce acpi_parse_entries Signed-off-by: Naresh Bhat --- xen/drivers/acpi/tables.c | 64 +++ xen/include/xen/acpi.

Re: [Xen-devel] [PATCH RFC 12/35] ARM64: Initialization of cpu_logical_map(0)

2015-02-10 Thread Julien Grall
Hi Stefano, On 05/02/2015 18:26, Stefano Stabellini wrote: On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: From: Naresh Bhat Initialization of cpu_logical_map(0) before acpi_boot_init() Signed-off-by: Hanjun Guo Signed-off-by: Naresh Bhat --- xen/arch/arm/setup.c | 5 + 1 file cha

Re: [Xen-devel] [PATCH v3] libxl: Wait for ballooning if free memory is increasing

2015-02-10 Thread Mike Latimer
On Thursday, February 05, 2015 12:45:53 PM Ian Campbell wrote: > On Mon, 2015-02-02 at 08:17 -0700, Mike Latimer wrote: > > On Monday, February 02, 2015 02:35:39 PM Ian Campbell wrote: > > > On Fri, 2015-01-30 at 14:01 -0700, Mike Latimer wrote: > > > > During domain startup, all required memory ba

[Xen-devel] [linux-next test] 34382: regressions - FAIL

2015-02-10 Thread xen . org
flight 34382 linux-next real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34382/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 5 xen-boot fail REGR. vs. 34127 test-amd64-i386-qemut-

[Xen-devel] [Block dev] : Qemu block ide_dma_read call routine

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my gue

Re: [Xen-devel] [PATCH v3 12/27] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-02-10 Thread Olivier Martin
On 03/02/15 19:19, Ard Biesheuvel wrote: Add a ArmPlatformLib instance that can deal with the self relocation and truly dynamic discovery of system RAM base and size. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- .../AARCH64

Re: [Xen-devel] [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-10 Thread Chen, Tiejun
On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. Thanks for your time. A couple of hi

[Xen-devel] [libvirt test] 34420: tolerable all pass - PUSHED

2015-02-10 Thread xen . org
flight 34420 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34420/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 10 migrate-support-checkfail never pass test-armhf-armhf-libvirt 10 migrate-sup

Re: [Xen-devel] [PATCH 02/29] libxl: Comment cleanups

2015-02-10 Thread Hongyang Yang
在 02/11/2015 04:09 AM, Ian Jackson 写道: * Add two comments in libxl_remus_disk_drbd documenting buggy handling of the hotplug script exit status. * Add a section heading for async exec in libxl_aoutils.c * Mention the right function name (libxl__ev_child_fork, not libxl__ev_fork) in libx

Re: [Xen-devel] [PATCH v4 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2015-02-10 Thread David Rientjes
On Tue, 10 Feb 2015, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This lets you build a kernel which can support xen dom0 > or xen guests by just using: > >make xenconfig > > on both x86 and arm64 kernels. This also splits out the > options which are available currently to be b

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Jeremy Fitzhardinge
On 02/10/2015 05:26 AM, Oleg Nesterov wrote: > On 02/10, Raghavendra K T wrote: >> On 02/10/2015 06:23 AM, Linus Torvalds wrote: >> >>> add_smp(&lock->tickets.head, TICKET_LOCK_INC); >>> if (READ_ONCE(lock->tickets.tail) & TICKET_SLOWPATH_FLAG) .. >>> >>> into something like >>>

[Xen-devel] [PATCH v4 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This lets you build a kernel which can support xen dom0 or xen guests by just using: make xenconfig on both x86 and arm64 kernels. This also splits out the options which are available currently to be built with x86 and 'make ARCH=arm64' under a shared config. Techn

[Xen-devel] [PATCH v4 1/2] x86, platform, xen, kconfig: clarify kvmconfig is for kvm

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We'll be adding options for xen as well. Cc: Josh Triplett Cc: Borislav Petkov Cc: Pekka Enberg Cc: David Rientjes Cc: Michal Marek Cc: Randy Dunlap Cc: penb...@kernel.org Cc: levinsasha...@gmail.com Cc: mtosa...@redhat.com Cc: fengguang...@intel.com Cc: David Vra

[Xen-devel] [PATCH v4 0/2] x86/arm64: add xenconfig

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This v4 addresses the missing CONFIG_HYPERVISOR_GUEST and CONFIG_PARAVIRT as noted by David. Luis R. Rodriguez (2): x86, platform, xen, kconfig: clarify kvmconfig is for kvm x86, arm, platform, xen, kconfig: add xen defconfig helper arch/x86/configs/xen.config | 1

Re: [Xen-devel] [PATCH v3 RESEND] 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2015-02-10 Thread Luis R. Rodriguez
On Tue, Feb 10, 2015 at 04:49:13PM -0800, David Rientjes wrote: > On Tue, 10 Feb 2015, Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > > > This lets you build a kernel which can support xen dom0 > > or xen guests by just using: > > > >make xenconfig > > > > on both x86 and arm

Re: [Xen-devel] [PATCH 10/29] libxl: events: Make timeout and async exec setup take an ao, not a gc

2015-02-10 Thread Wen Congyang
On 02/11/2015 04:09 AM, Ian Jackson wrote: > Change the timeout setup functions to take a libxl__ao, not a > libxl__gc. This is going to be needed for ao cancellation, because > timeouts are going to be a main hook for ao cancellation - so the > timeouts need to be associated with an ao. > > This

[Xen-devel] [PATCH] virtual: Documentation: simplify and generalize paravirt_ops.txt

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The general documentation we have for pv_ops is currenty present on the IA64 docs, but since this documentation covers IA64 xen enablement and IA64 Xen support got ripped out a while ago through commit d52eefb47 present since v3.14-rc1 lets just simplify, generalize and

[Xen-devel] [PATCH v3 RESEND] 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This lets you build a kernel which can support xen dom0 or xen guests by just using: make xenconfig on both x86 and arm64 kernels. This also splits out the options which are available currently to be built with x86 and 'make ARCH=arm64' under a shared config. Techn

[Xen-devel] [PATCH v3 RESEND] 1/2] x86, platform, xen, kconfig: clarify kvmconfig is for kvm

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We'll be adding options for xen as well. Cc: Josh Triplett Cc: Borislav Petkov Cc: Pekka Enberg Cc: David Rientjes Cc: Michal Marek Cc: Randy Dunlap Cc: penb...@kernel.org Cc: levinsasha...@gmail.com Cc: mtosa...@redhat.com Cc: fengguang...@intel.com Cc: David Vra

[Xen-devel] [PATCH v3 RESEND] 0/2] x86/arm64: add xenconfig

2015-02-10 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Resending to the maintainers that it was recommended to try. Ingo, Thomas, Andrew, who should this go through? Please note that the Kconfig maintainer is not available anymore and it was recommended this go through that person first, meanwhile while that is ironed out it

[Xen-devel] [PATCH v3 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG

2015-02-10 Thread Don Slutz
Suggested-by: Paul Durrant Signed-off-by: Don Slutz --- v3: Move ASSERT() into switch and use ASSERT_UNREACHABLE(). xen/arch/x86/hvm/hvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index b03ee4e..1e722fc 100644 --- a/xen/arch/x

[Xen-devel] [PATCH v3 3/3] hvmemul_do_io: Do not retry if no ioreq server exists for this I/O.

2015-02-10 Thread Don Slutz
This saves a VMENTRY and a VMEXIT since we no longer retry the ioport read on backing DM not handling a given ioreq. There are 2 case about "no ioreq server exists for this I/O": 1) No ioreq servers (PVH case) 2) No ioreq servers for this I/O (non PVH case) The routine hvm_has_dm() used to check

[Xen-devel] [PATCH v3 0/3] Skip unneeded VMENTRY & VMEXIT

2015-02-10 Thread Don Slutz
Changes v3: George Dunlap: Acked-by for #1 "xentrace: Adjust IOPORT & MMIO format" Paul Durrant: Reviewed-by for #3 "hvmemul_do_io: Do not retry if no ioreq server exists" Did not add to commit message do to code changes. Jan Beulich: #2 "hvm_complete_assist_req: We shoul

[Xen-devel] [PATCH v3 1/3] xentrace: Adjust IOPORT & MMIO format

2015-02-10 Thread Don Slutz
The 1st item is not data, but the port (address). The 2nd item is the data. Signed-off-by: Don Slutz Acked-by: George Dunlap --- v3: Added Acked-by, George Dunlap tools/xentrace/formats | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/xentrace/formats b/tools

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Andrew Cooper
On 10/02/2015 21:27, Daniel Kiper wrote: > On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: >> Signed-off-by: Daniel Kiper >> --- >> xen/arch/x86/boot/head.S | 174 >> +++-- >> xen/arch/x86/efi/efi-boot.h | 29 +++ >> xen/arch/x8

Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-10 Thread Paul Bolle
On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote: > We need an update to the MAINTAINERS file if "Yann E. MORIN" > isn't the active Kconfig maintainer anymore. Yes, we do. Michal, what update would you suggest? Thanks, Paul Bolle ___ Xen-d

Re: [Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 04:49 PM, Andrew Cooper wrote: On 10/02/2015 21:44, Boris Ostrovsky wrote: If NULL pointer is passed for these specifiers then print '-' or 'd-v-'. Signed-off-by: Boris Ostrovsky Instead of special casing each custom format, I would be tempted just to put the switch() in an if(a

Re: [Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Andrew Cooper
On 10/02/2015 21:44, Boris Ostrovsky wrote: > If NULL pointer is passed for these specifiers then print '-' > or 'd-v-'. > > Signed-off-by: Boris Ostrovsky Instead of special casing each custom format, I would be tempted just to put the switch() in an if(arg) conditional, and fall back to the reg

[Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Boris Ostrovsky
If NULL pointer is passed for these specifiers then print '-' or 'd-v-'. Signed-off-by: Boris Ostrovsky --- xen/common/vsprintf.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c index 065cc42..84cfa85 10064

Re: [Xen-devel] freemem-slack and large memory environments

2015-02-10 Thread Mike Latimer
On Monday, February 09, 2015 06:27:54 PM Mike Latimer wrote: > While testing commit 2563bca1, I found that libxl_get_free_memory returns 0 > until there is more free memory than required for freemem-slack. This means > that during the domain creation process, freed memory is first set aside for > f

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Daniel Kiper
On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > xen/arch/x86/boot/head.S | 174 > +++-- > xen/arch/x86/efi/efi-boot.h | 29 +++ > xen/arch/x86/setup.c | 23 ++--- > xen/arch/x

Re: [Xen-devel] [RFC PATCH] xen, apic: Setup our own APIC driver and validator for APIC IDs.

2015-02-10 Thread Konrad Rzeszutek Wilk
On Thu, Jan 22, 2015 at 10:00:55AM +, David Vrabel wrote: > On 21/01/15 21:56, Konrad Rzeszutek Wilk wrote: > > +static struct apic xen_apic = { > > + .name = "Xen", > > + .probe = probe_xen, > > + /* The rest is copied from the default. */ > > Explicitly initialize all required members

Re: [Xen-devel] Xen's Linux kernel config options v3

2015-02-10 Thread Luis R. Rodriguez
On Tue, Feb 10, 2015 at 05:41:42AM +0100, Juergen Gross wrote: > On 02/09/2015 08:52 PM, Luis R. Rodriguez wrote: >> On Mon, Feb 09, 2015 at 07:17:23AM +0100, Juergen Gross wrote: >>> On 02/07/2015 12:44 AM, Luis R. Rodriguez wrote: After some feedback for the first draft I'd suggest the follo

[Xen-devel] [PATCH 29/29] libxl: cancellation: Make datacopiers cancellable

2015-02-10 Thread Ian Jackson
libxl__datacopier_* can now actually generate a callback with rc==CANCELLED. This provides cancellation during some corner cases, including (at least) copying the device model data during the end of domain save. Signed-off-by: Ian Jackson --- v2: New in this version of the series. --- tools/lib

[Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable

2015-02-10 Thread Ian Jackson
The libxl__spawn_spawn internal API permits the caller to specify .timeout_ms==-1, meaning to wait forever. Provide an explicit cancellable to allow spawns to be cancelled. I think there are not currently any internal callers which do use spawn with an infinite timeout, but this should not be lef

[Xen-devel] [PATCH 22/29] libxl: Introduce DOMAIN_DESTROYED error code

2015-02-10 Thread Ian Jackson
This is currently reported only by the bootloader code, if the domain is destroyed while the bootloader is running. In the future it would be nice to return it for other circumstances where the domain existed when the operation started but subsequently vanished. Signed-off-by: Ian Jackson --- v2

[Xen-devel] [PATCH 16/29] libxl: ao: Provide manip_refcnt

2015-02-10 Thread Ian Jackson
Previously we used in_initiator to stop the ao being freed while we were still in the initiator function (which would result in the initiator's call to lixl__ao_inprogress accessing the ao after it had been freed). We are going to introduce a new libxl entrypoint which finds, and operates on, ongo

Re: [Xen-devel] [RFC PATCH v2 00/29] libxl: Cancelling asynchronous operations

2015-02-10 Thread Ian Jackson
Ian Jackson writes ("[RFC PATCH v2 00/29] libxl: Cancelling asynchronous operations"): > This is v2 of my work-in-progress series to support cancellation of > long-running libxl operations. > > There are many improvements since v1, but the basic structure remains > the same and the external API r

[Xen-devel] [PATCH 12/29] libxl: events: Permit timeouts to signal cancellation

2015-02-10 Thread Ian Jackson
The callback functions provided by users must take an rc value. This rc value can be ERROR_TIMEDOUT or ERROR_CANCELLED. Users of xswait are now expected to deal correctly with ERROR_CANCELLED. If they experience this, it hasn't been logged. And the caller won't log it either since it's not TIMED

[Xen-devel] [PATCH 07/29] libxl: xswait/devstate: Move xswait to before devstate

2015-02-10 Thread Ian Jackson
Pure code motion. We are going to make devstate use xswait. Signed-off-by: Ian Jackson --- tools/libxl/libxl_internal.h | 109 +- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h

[Xen-devel] [PATCH 28/29] libxl: ao: datacopier callback gets an rc

2015-02-10 Thread Ian Jackson
libxl__datacopier_* now provides its caller's callback function with an rc value. This relieves the caller of the need to figure out an appropriate rc value. Arrange that the `other internal failure' cases now get a valid positive errno value (EIO). In a few places, assert that errno is nonzero

[Xen-devel] [PATCH 08/29] libxl: devstate: Use libxl__xswait*

2015-02-10 Thread Ian Jackson
Signed-off-by: Ian Jackson --- tools/libxl/libxl_device.c |4 +-- tools/libxl/libxl_event.c| 78 ++ tools/libxl/libxl_internal.h | 11 +++--- 3 files changed, 40 insertions(+), 53 deletions(-) diff --git a/tools/libxl/libxl_device.c b/tools/l

[Xen-devel] [PATCH 10/29] libxl: events: Make timeout and async exec setup take an ao, not a gc

2015-02-10 Thread Ian Jackson
Change the timeout setup functions to take a libxl__ao, not a libxl__gc. This is going to be needed for ao cancellation, because timeouts are going to be a main hook for ao cancellation - so the timeouts need to be associated with an ao. This means that timeouts can only occur as part of a long-r

[Xen-devel] [PATCH 17/29] libxl: cancellation: Provide public ao cancellation API

2015-02-10 Thread Ian Jackson
Provide libxl_ao_cancel. There is machinery to allow an ao to register an interest in its cancellation, using a libxl__ao_cancellable. This API is not currently very functional: attempting cancellation it will always return NOTIMPLEMENTED and have no effect. Signed-off-by: Ian Jackson --- v2: M

[Xen-devel] [PATCH 06/29] libxl: Use libxl__xswait* in libxl__ao_device

2015-02-10 Thread Ian Jackson
Replace the separate timeout and xenstore watch with use of libxl__xswait*. Different control flow, but no ultimate functional change apart from slight changes to the text of error messages. Signed-off-by: Ian Jackson --- tools/libxl/libxl_device.c | 64 -

[Xen-devel] [RFC PATCH v2 00/29] libxl: Cancelling asynchronous operations

2015-02-10 Thread Ian Jackson
This is v2 of my work-in-progress series to support cancellation of long-running libxl operations. There are many improvements since v1, but the basic structure remains the same and the external API remains unchanged. I have rebased this onto current staging. I have compiled it but NOT EXECUTED

[Xen-devel] [PATCH 09/29] libxl: New error codes CANCELLED etc.

2015-02-10 Thread Ian Jackson
We introduce ERROR_CANCELLED now, so that we can write code to handle it, and decreee that functions might return it, even though currently there is nowhere where this error is generated. While we're here, provide ERROR_NOTFOUND and ERROR_NOTIMPLEMENTED, which will also be used later, but only as

[Xen-devel] [PATCH 05/29] libxl: suspend: Return correct error from callbacks

2015-02-10 Thread Ian Jackson
If a suspend callback fails, it has a libxl error code in its hand. However we must return to libxc the values that libxc expects. So we stash the libxl error code in dss->rc and fish it out again after libxc returns from the suspend call. While we're here, abolish the now-redundant `ok' variable

[Xen-devel] [PATCH 27/29] libxl: cancellation: Cancel libxc save/restore

2015-02-10 Thread Ian Jackson
Register the the save/restore helper interface with the cancellation machinery. When we are informed that save/restore should be cancelled, we make a note of the that in our rc variable, and send the helper a SIGTERM. It will die in due course. Signed-off-by: Ian Jackson --- v2: New in this ver

[Xen-devel] [PATCH 25/29] libxl: cancellation: Preparations for save/restore cancellation

2015-02-10 Thread Ian Jackson
Two unrelated non-functional changes, broken out into a pre-patch for easier review: Break out a function sendsig() in libxl_save_callout.c. Move io_fd to be a global variable in libxl_save_helper.c. Signed-off-by: Ian Jackson --- v2: New in this version of the series. --- tools/libxl/libxl_sa

[Xen-devel] [PATCH 26/29] libxl: cancellation: Handle SIGTERM in save/restore helper

2015-02-10 Thread Ian Jackson
During startup of the save/restore helper, set the disposition of SIGTERM appropriately. For restore, we can simply die immediately - there is no point trying to do any kind of cleanup on what is now going to be a trashed domain. For save, we want to arrange that libxc's cleanup code (eg turning

[Xen-devel] [PATCH 24/29] libxl: Introduce FILLZERO

2015-02-10 Thread Ian Jackson
FILLZERO is a macro for memset(&foo,0,sizeof(foo)). It eliminates the possiblity to make the error memset(&foo,0,sizeof(&foo)). No callers yet, but document it in CODING_STYLE. (In accordance with existing libxl policy, I haven't gone through all existing possible call sites.) Signed-off-by: Ia

[Xen-devel] [PATCH 15/29] libxl: ao: Count the nested progeny of an ao

2015-02-10 Thread Ian Jackson
This will detect any "escaped" nested aos. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c|8 +++- tools/libxl/libxl_internal.h |1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c index 1385a94..37c3d2

[Xen-devel] [PATCH 23/29] libxl: cancellation: Support cancellation where we spot domain death

2015-02-10 Thread Ian Jackson
Make an active libxl__domaindeathcheck contain an active libxl__ao_cancellable. Consequential changes are: * domaindeath callbacks now take an rc value. * libxl__domaindeathcheck_start takes an ao, not a gc. * bootloader_domaindeath plumbs the rc through to its caller. * libxl__domaindeathchec

[Xen-devel] [PATCH 02/29] libxl: Comment cleanups

2015-02-10 Thread Ian Jackson
* Add two comments in libxl_remus_disk_drbd documenting buggy handling of the hotplug script exit status. * Add a section heading for async exec in libxl_aoutils.c * Mention the right function name (libxl__ev_child_fork, not libxl__ev_fork) in libxl_internal.h Signed-off-by: Ian Jackson CC:

[Xen-devel] [PATCH 03/29] libxl: suspend: switch_logdirty_done takes rc

2015-02-10 Thread Ian Jackson
switch_logdirty_done used to take the value to pass to libxl__xc_domain_saverestore_async_callback_done (ie, the return value from the callback). (This was mistakenly described as "ok" in the prototype, but in the definition it is "broke" and all the call sites passed 0 for success or -1 for error

[Xen-devel] [PATCH 20/29] libxl: cancellation: Note that driver domain task cannot be usefully cancelled

2015-02-10 Thread Ian Jackson
In practice, cancelling this task will cause all subsequent actual backend operations to fail, but will not actually cause the libxl_device_events_handler operation to complete. Signed-off-by: Ian Jackson CC: Roger Pau Monne --- v2: New in this version of the series. --- tools/libxl/libxl.h |

[Xen-devel] [PATCH 18/29] libxl: cancellation: Provide explicit internal cancel check API

2015-02-10 Thread Ian Jackson
Some places in libxl which can't handle cancellation via a libxl__ao_cancellable callback might nevertheless benefit from being able to explicitly check for cancellation. Provide the (fairly trivial) internal API function to do this. Signed-off-by: Ian Jackson --- v2: New in this version of the

[Xen-devel] [PATCH 14/29] libxl: ao: Record ultimate parent of a nested ao

2015-02-10 Thread Ian Jackson
This will be used by the cancellation machinery. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c| 25 +++-- tools/libxl/libxl_internal.h |3 ++- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_e

[Xen-devel] [PATCH 13/29] libxl: domain create: Do not destroy on cancellation

2015-02-10 Thread Ian Jackson
If we cancelled the domain creation, do not try to tear it down again Document this. This is a backwards-compatible API change since old libxl users will never cancel any operations. In the current code, there is no functional change, because ERROR_CANCELLED is never generated anywhere yet. Sign

[Xen-devel] [PATCH 04/29] libxl: suspend: common suspend callbacks take rc

2015-02-10 Thread Ian Jackson
Change the following functions to take a libxl error code rather than a boolean "ok" value, and translate that value to the boolean expected by libxc at the last moment: domain_suspend_callback_common_done} dss->callback_common_done remus_domain_suspend_callback_common_done } domain_

[Xen-devel] [PATCH 19/29] libxl: cancellation: Make timeouts cancellable

2015-02-10 Thread Ian Jackson
Make libxl__ev_time* register with the cancellation machinery, so that libxl_ao_cancel can cancel any operation which has a timeout. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c| 27 +++ tools/libxl/libxl_internal.h |3 ++- 2 files changed, 29 insert

[Xen-devel] [PATCH 01/29] libxl: Further fix exit paths from libxl_device_events_handler

2015-02-10 Thread Ian Jackson
On the success path, do not call GC_FREE explicitly. Instead, call AO_INPROGRESS. GC_FREE will free the gc underlying the long-term ao, which is then subsequently referenced in backend_watch_callback's call to libxl__nested_ao_create. It is a miracle that this ever works at all. Also, add an `i

[Xen-devel] [PATCH 11/29] libxl: events: Make libxl__async_exec_* pass caller an rc

2015-02-10 Thread Ian Jackson
The internal user of libxl__async_exec_start et al now gets an rc as well as the process's exit status. For now this is always either 0 or ERROR_FAIL, but with ao cancellation this will possibly be CANCELLED or TIMEDOUT too. Signed-off-by: Ian Jackson --- v2: New patch due to rebause; v1 had cha

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Lars Kurth
Wei, thanks for clarifying. I don't think you answered all the practical implications of your proposal though. A) Do we start making RC's straight after the Feature Freeze? B) Will there still be exceptions? I am assuming yes C) Do you expect a gradual decrease of what bug fixes are allowed after

Re: [Xen-devel] [PATCH v8 4/7] xen: Add vmware_port support

2015-02-10 Thread Don Slutz
On 01/26/15 10:58, Don Slutz wrote: > On 01/22/15 03:32, Jan Beulich wrote: > On 21.01.15 at 18:52, wrote: >>> On 01/16/15 05:09, Jan Beulich wrote: >>> On 03.10.14 at 00:40, wrote: > This is a new domain_create() flag, DOMCRF_vmware_port. It is > passed to domctl as XEN_DOMCTL_C

[Xen-devel] [rumpuserxen test] 34400: regressions - FAIL

2015-02-10 Thread xen . org
flight 34400 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34400/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 33866 build-amd64-rumpuserx

[Xen-devel] [rumpuserxen bisection] complete build-i386-rumpuserxen

2015-02-10 Thread xen . org
branch xen-unstable xen branch xen-unstable job build-i386-rumpuserxen test xen-build Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git Tree: rumpuserxen https://github.com/rumpkernel/rumprun-xen Tree: rumpuserxen_bu

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 06:04:10PM +, Lars Kurth wrote: > Wei, > could you explain what you mean by soft freeze and hard freeze. > Regards They correspond to feature freeze and code freeze respectively. A bit more background information for developers that are new to the community. In 4.5 and

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 6:47:46 PM, you wrote: Sander Eikelenboom 02/10/15 6:30 PM >>> >>Tuesday, February 10, 2015, 5:22:16 PM, you wrote: >> Sander Eikelenboom 02/10/15 5:01 PM >>> I haven't checked the call chain of xen_pcibk_do_op .. but that could be a side effect of l

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Lars Kurth
Wei, could you explain what you mean by soft freeze and hard freeze. Regards Lars > On 10 Feb 2015, at 15:04, Wei Liu wrote: > > Hi, all > > With Xen 4.5 released on Jan 14 and the open of Xen 4.6 (commit > 0082626f35, Jan 6), we are now one month into 4.6 development window. > > This is an e

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich wrote: Tamas K Lengyel 02/10/15 5:38 PM >>> >>On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: >> Tamas K Lengyel 02/10/15 2:51 PM >>> >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >>> On 09.02.15 at 19:53, wrote: >> @

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
>>> Sander Eikelenboom 02/10/15 6:30 PM >>> >Tuesday, February 10, 2015, 5:22:16 PM, you wrote: > Sander Eikelenboom 02/10/15 5:01 PM >>> >>>I haven't checked the call chain of xen_pcibk_do_op .. but that could be a >>>side effect of libxl not imitating pci-front good enough (since HVM guests

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> Tamas K Lengyel 02/10/15 5:38 PM >>> >On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: > Tamas K Lengyel 02/10/15 2:51 PM >>> >> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: >> On 09.02.15 at 19:53, wrote: > @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct d

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 5:22:16 PM, you wrote: Sander Eikelenboom 02/10/15 5:01 PM >>> >>Tuesday, February 10, 2015, 2:26:43 PM, you wrote: > On 10.02.15 at 14:07, wrote: >>> I don't really know how this code is supposed to work (we don't use >>> it in our kernels), but it seems th

[Xen-devel] [PATCH 2/3] x86/traps: Use write_atomic() when updating potentially-live descriptors

2015-02-10 Thread Andrew Cooper
Signed-off-by: Andrew Cooper CC: Jan Beulich CC: Tim Deegan --- atomic.h currently can't be included in either location because of dependency issues. As this is part of a bugfix series which needs backporting, I opted to opencode write_atomic() rather than something more invasive to the heade

[Xen-devel] [PATCH 3/3] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-10 Thread Andrew Cooper
c/s 7dd3b06ff "vmx: fix handling of NMI VMEXIT" fixed one issue but inadvertently introduced a regression when it came to the NMI shootdown. The shootdown code worked by patching vector 2 in each IDT, but the introduced direct call to do_nmi() bypassed this. Instead of patching each IDT, take a d

[Xen-devel] [PATCH 0/3] Fixes to NMI shootdown

2015-02-10 Thread Andrew Cooper
This series fixes an issue introduced by c/s 7dd3b06ff On my testbox I can observe the cpu which doesn't get shot down to still be executing after the crash kernel has finished running. [ 25.806178] sd 2:0:0:0: [sda] Synchronizing SCSI cache [ 25.812038] Restarting system. [ 25.815121] rebo

[Xen-devel] [PATCH 1/3] x86/traps: Export the exception_table[] function pointer table to C

2015-02-10 Thread Andrew Cooper
and use it in preference to the direct call to do_nmi() in vmx.c The value 'TRAP_last_reserved' was only used where 'TRAP_nr' would be more appropriate, so is replaced. No functional change Signed-off-by: Andrew Cooper CC: Jan Beulich CC: Tim Deegan --- Diffing the dissassembly confirms no c

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread George Dunlap
On Tue, Feb 10, 2015 at 11:47 AM, Dario Faggioli wrote: > On Tue, 2015-02-10 at 11:11 -0500, George Dunlap wrote: >> On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wrote: > >> > # Scrapping soft freeze >> > >> > I think existing model (development + freeze) works well in general, >> > but it would be

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Dario Faggioli
On Tue, 2015-02-10 at 11:11 -0500, George Dunlap wrote: > On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wrote: > > # Scrapping soft freeze > > > > I think existing model (development + freeze) works well in general, > > but it would be better if we can shorten the time frame a bit, or try > > harder

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich wrote: Tamas K Lengyel 02/10/15 2:51 PM >>> > On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: > On 09.02.15 at 19:53, wrote: @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct domain *d) { struct vcpu

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 10/02/15 16:30, Jan Beulich wrote: Boris Ostrovsky 02/10/15 4:07 PM >>> >> On 02/10/2015 09:54 AM, Andrew Cooper wrote: >>> copy_to/from_guest() is not expensive. It is a straight memcpy with an >>> extable guards for pagefaults. >> True, but still why do this inside a loop? xmalloc() of

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Jan Beulich
>>> Boris Ostrovsky 02/10/15 4:07 PM >>> >On 02/10/2015 09:54 AM, Andrew Cooper wrote: >> copy_to/from_guest() is not expensive. It is a straight memcpy with an >> extable guards for pagefaults. > >True, but still why do this inside a loop? xmalloc() of less than a page >is not that expensive, i

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
>>> Sander Eikelenboom 02/10/15 5:01 PM >>> >Tuesday, February 10, 2015, 2:26:43 PM, you wrote: On 10.02.15 at 14:07, wrote: >> I don't really know how this code is supposed to work (we don't use >> it in our kernels), but it seems the more interesting question is what >> happens when xen_pc

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
>>> Tamas K Lengyel 02/10/15 2:51 PM >>> On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich wrote: On 09.02.15 at 19:53, wrote: >>> @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct domain *d) >>> { >>> struct vcpu *v; >>> >>> +if ( rsp.version != MEM_EVENT_INTERFAC

Re: [Xen-devel] [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates

2015-02-10 Thread Jens Axboe
On 02/10/2015 09:10 AM, David Vrabel wrote: On 10/02/15 15:27, Jens Axboe wrote: On 02/10/2015 05:58 AM, Roger Pau Monné wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Jens, There are 3 fixes for Xen blk drivers. One adds myself as a maintainer (together with Konrad). There's also

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread George Dunlap
On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wrote: > Hi, all > > With Xen 4.5 released on Jan 14 and the open of Xen 4.6 (commit > 0082626f35, Jan 6), we are now one month into 4.6 development window. > > This is an email to kick off a discussion with regard to our release > process.The goal is to c

  1   2   >