[Xen-devel] [libvirt test] 31566: tolerable FAIL - PUSHED

2014-11-14 Thread xen . org
flight 31566 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31566/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 9 guest-start fail never pass test-amd64-amd64-libvirt 9 guest-start

[Xen-devel] [xen-4.2-testing test] 31525: regressions - FAIL

2014-11-14 Thread xen . org
flight 31525 xen-4.2-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31525/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair 18 guest-migrate/dst_host/src_host fail in 31451 REGR. vs. 30594 Tests whi

[Xen-devel] [rumpuserxen test] 31565: regressions - FAIL

2014-11-14 Thread xen . org
flight 31565 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31565/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 11 rumpuserxen-demo-xenstorels/xenstorels fail REGR. vs. 31437 tes

Re: [Xen-devel] [PATCH RFC] EFI: allow retry of ExitBootServices() call

2014-11-14 Thread Roy Franz
On Fri, Nov 14, 2014 at 7:37 AM, Jan Beulich wrote: > The specification is kind of vague under what conditions > ExitBootServices() may legitimately fail, requiring the OS loader to > retry: > > "If MapKey value is incorrect, ExitBootServices() returns > EFI_INVALID_PARAMETER and GetMemoryMap() w

Re: [Xen-devel] PCI and VGA Passthrough regressions on Xen 4.4.1 vs 4.3.2

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 04:08:14PM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Oct 06, 2014 at 03:55:36AM -0300, Zir Blazer wrote: > > There is a regression in both PCI and VGA Passthrough in Xen 4.4.1 when > > compared to 4.3.2. Due to the added complexity of VGA Passthrough, I was > > suggest

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 9:25:13 PM, you wrote: > On Fri, Nov 14, 2014 at 05:59:23PM +0100, Sander Eikelenboom wrote: >> >> Friday, November 14, 2014, 4:43:58 PM, you wrote: >> >> On 14.11.14 at 16:20, wrote: >> >> If it still helps i could try Andrews suggestion and try out with only

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 10:38:11 PM, you wrote: > On 11/14/2014 04:20 PM, Sander Eikelenboom wrote: >> Friday, November 14, 2014, 10:09:04 PM, you wrote: >> >> >>> I don't know about detach but I apparently can't even properly attach a >>> second device --- I get complaints about it already be

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 04:20 PM, Sander Eikelenboom wrote: Friday, November 14, 2014, 10:09:04 PM, you wrote: I don't know about detach but I apparently can't even properly attach a second device --- I get complaints about it already being in xenstore. But device does show up in the guest. And then I c

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 10:09:04 PM, you wrote: > On 11/14/2014 02:24 PM, Sander Eikelenboom wrote: >> Friday, November 14, 2014, 7:07:46 PM, you wrote: >> >>> Sander Eikelenboom writes ("Re: [Xen-devel] [PATCH 1/2] libxl: Wait until >>> QEMU removed the device before tearing it down"):

Re: [Xen-devel] PCI and VGA Passthrough regressions on Xen 4.4.1 vs 4.3.2

2014-11-14 Thread Gordan Bobic
On 11/14/2014 09:08 PM, Konrad Rzeszutek Wilk wrote: On Mon, Oct 06, 2014 at 03:55:36AM -0300, Zir Blazer wrote: There is a regression in both PCI and VGA Passthrough in Xen 4.4.1 when compared to 4.3.2. Due to the added complexity of VGA Passthrough, I was suggested to focus instead in my PCI

Re: [Xen-devel] PCI and VGA Passthrough regressions on Xen 4.4.1 vs 4.3.2

2014-11-14 Thread Konrad Rzeszutek Wilk
On Mon, Oct 06, 2014 at 03:55:36AM -0300, Zir Blazer wrote: > There is a regression in both PCI and VGA Passthrough in Xen 4.4.1 when > compared to 4.3.2. Due to the added complexity of VGA Passthrough, I was > suggested to focus instead in my PCI Passthrough issue, which involves the > integrat

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 02:24 PM, Sander Eikelenboom wrote: Friday, November 14, 2014, 7:07:46 PM, you wrote: Sander Eikelenboom writes ("Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): 1) xc_physdev_unmap_pirq does get called when destroying a HVM guest.

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 05:59:23PM +0100, Sander Eikelenboom wrote: > > Friday, November 14, 2014, 4:43:58 PM, you wrote: > > On 14.11.14 at 16:20, wrote: > >> If it still helps i could try Andrews suggestion and try out with only > >> commit aeeea485 .. > > > Yes, even if it's pretty cer

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 6:05:28 PM, you wrote: > On Fri, Nov 14, 2014 at 05:59:23PM +0100, Sander Eikelenboom wrote: >> >> Friday, November 14, 2014, 4:43:58 PM, you wrote: >> >> On 14.11.14 at 16:20, wrote: >> >> If it still helps i could try Andrews suggestion and try out with only

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 7:07:46 PM, you wrote: > Sander Eikelenboom writes ("Re: [Xen-devel] [PATCH 1/2] libxl: Wait until > QEMU removed the device before tearing it down"): >> 1) xc_physdev_unmap_pirq does get called when destroying a HVM guest. > Yes, but I think that is so only because o

Re: [Xen-devel] [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 06:52:37PM +, Ian Jackson wrote: > The structural considerations, error handling patterns, and so on, in > libxl have remained undocumented. This has been a problem during > recent code submissions and reviews. > > In this series I have attempted to document current be

[Xen-devel] [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE

2014-11-14 Thread Ian Jackson
The structural considerations, error handling patterns, and so on, in libxl have remained undocumented. This has been a problem during recent code submissions and reviews. In this series I have attempted to document current best practice. The first patch contains much new material and the others

[Xen-devel] [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems

2014-11-14 Thread Ian Jackson
Document that: - the existing code is not all confirming yet - code should conform - we will sometimes accept patches with nonconforming elements if they don't make matters worse. Signed-off-by: Ian Jackson --- v2: When not fixing up existing style problems, new code should conform to

[Xen-devel] [PATCH 1/4] libxl: CODING_STYLE: Much new material

2014-11-14 Thread Ian Jackson
Discuss: Memory allocation Conventional variable names Convenience macros Error handling Idempotent data structure construction/destruction Asynchronous/long-running operations Signed-off-by: Ian Jackson --- v2: Fix typo `codem'. Fix example to use libxl__xs_get_domp

[Xen-devel] [PATCH 3/4] libxl: CODING_STYLE: Mention function out parameters

2014-11-14 Thread Ian Jackson
We seem to use both `_r' and `_out'. Document both. Signed-off-by: Ian Jackson --- tools/libxl/CODING_STYLE |3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE index 128cfea..9a1d6e0 100644 --- a/tools/libxl/CODING_STYLE +++ b/tools/libx

[Xen-devel] [PATCH 2/4] libxl: CODING_STYLE: Deprecate `error' for out blocks

2014-11-14 Thread Ian Jackson
We should have only one name for this and `out' is more prevalent. Signed-off-by: Ian Jackson --- tools/libxl/CODING_STYLE |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE index 32d058f..128cfea 100644 --- a/tools/libxl/CO

Re: [Xen-devel] [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems

2014-11-14 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems"): > On Wed, 2014-11-05 at 14:43 +, Ian Jackson wrote: > > +If it is not feasible to conform fully to the style while patching old > > +code, without doing substantial style reengineering first, we may >

Re: [Xen-devel] [PATCH 1/4] libxl: CODING_STYLE: Much new material

2014-11-14 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 1/4] libxl: CODING_STYLE: Much new material"): > On Wed, 2014-11-05 at 14:43 +, Ian Jackson wrote: > > +The following local variable names should be used where applicable: > > + > > + int rc;/* a libxl error code - and not anything else */ > > + int r;

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Sander Eikelenboom writes ("Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > 1) xc_physdev_unmap_pirq does get called when destroying a HVM guest. Yes, but I think that is so only because of the block structure bug introduced in abfb006f. > 2) Whe

Re: [Xen-devel] vtpmmgr bug: fails to start if locality!=0

2014-11-14 Thread Daniel De Graaf
On 11/14/2014 09:22 AM, Emil Condrea wrote: I modified linux kernel tpm_tis driver to try to start with locality 2. I did some logging and after taking a look with dmesg it seems that the IO pages for other localities are full with 1. in tpm_tis_init: for(i=0;i<5;i++){ release_locality(chip,

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 5:31:03 PM, you wrote: > Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the > device before tearing it down"): >> (Now with Reply-all, sorry) > Likewise. >> On 11/14/2014 11:01 AM, Ian Jackson wrote: >> > What call to xc_physdev_unmap_pirq ?

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > On 11/14/2014 11:19 AM, Ian Jackson wrote: > > The most seriouis is this: you may not call usleep() anywhere inside > > libxl. If you want to wait, you must use the callback mechanisms.

Re: [Xen-devel] Security policy ambiguities - XSA-108 process post-mortem

2014-11-14 Thread Lars Kurth
On 14 Nov 2014, at 12:50, Ian Jackson wrote: > Lars Kurth writes ("Re: [Xen-devel] Security policy ambiguities - XSA-108 > process post-mortem"): >> I do have one question. What led us to publish an XSA number on >> http://xenbits.xen.org/xsa/ in the way we do now? As far as I can tell, >> CV

Re: [Xen-devel] RFC: Configuring rumprun-xen application stacks from Xenstore

2014-11-14 Thread Ian Jackson
Martin Lucina writes ("Re: RFC: Configuring rumprun-xen application stacks from Xenstore"): > > What about embedded platforms with no notion of block devices? The /etc should be provided as a RAM image then. I did this very successfully in a previous life in a resource-constrained embedded plat

Re: [Xen-devel] [OSSTEST PATCH 8/9] ts-hosts-allocate-Executive: Redo variation_bonus scoring

2014-11-14 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 8/9] ts-hosts-allocate-Executive: Redo variation_bonus scoring"): > On Tue, 2014-11-11 at 19:41 +, Ian Jackson wrote: > > +my $log_variation_age = log(1+$variation_age/86400); > > +my $variation_bonus = $log_variation_age * 3600*2; > > +my $

Re: [Xen-devel] [OSSTEST PATCH 7/9] ts-hosts-allocate-Executive: Score for equivalent previous failures

2014-11-14 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 7/9] ts-hosts-allocate-Executive: Score for equivalent previous failures"): > On Tue, 2014-11-11 at 19:41 +, Ian Jackson wrote: > > + if ($candrow->{restype} eq 'host') { > > + $equivstatusq->execute($job,$fi->{intended},$fi->{branch}, > > +

Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain

2014-11-14 Thread Juergen Gross
On 11/14/2014 05:47 PM, Konrad Rzeszutek Wilk wrote: On Fri, Nov 14, 2014 at 05:53:19AM +0100, Juergen Gross wrote: On 11/13/2014 08:56 PM, Konrad Rzeszutek Wilk wrote: + mfn_save = virt_to_mfn(buf); + + while (xen_remap_mfn != INVALID_P2M_ENTRY) { So the 'list' is constructed by

Re: [Xen-devel] RFC: Configuring rumprun-xen application stacks from Xenstore

2014-11-14 Thread Martin Lucina
ian.jack...@eu.citrix.com said: > I wonder if this mechanism could be used for some or all of the things > that you're currently using xenstore for. Specifying which virtual > block devices to mount where, or what network configuration to use, > are things that other rump kernel runners would want

Re: [Xen-devel] [OSSTEST PATCH 8/9] ts-hosts-allocate-Executive: Redo variation_bonus scoring

2014-11-14 Thread Ian Campbell
On Tue, 2014-11-11 at 19:41 +, Ian Jackson wrote: > Use a logarithmic scale. Cap the bonus at 12h rather than 5d/30 = 4h. > When we have previously failed, make sure we apply a reverse bonus, > rather than a penalty. > > Signed-off-by: Ian Jackson > --- > ts-hosts-allocate-Executive | 12

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 11:19 AM, Ian Jackson wrote: Boris Ostrovsky writes ("[PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): When a device is hot-unplugged libxl sends QEMU a "device-del" message (via QMP). This call returns after QEMU has initiated device removal by send

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 05:59:23PM +0100, Sander Eikelenboom wrote: > > Friday, November 14, 2014, 4:43:58 PM, you wrote: > > On 14.11.14 at 16:20, wrote: > >> If it still helps i could try Andrews suggestion and try out with only > >> commit aeeea485 .. > > > Yes, even if it's pretty cer

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 4:43:58 PM, you wrote: On 14.11.14 at 16:20, wrote: >> If it still helps i could try Andrews suggestion and try out with only >> commit aeeea485 .. > Yes, even if it's pretty certain it's the second of the commits, verifying > this would be helpful (or if the as

Re: [Xen-devel] [OSSTEST PATCH 7/9] ts-hosts-allocate-Executive: Score for equivalent previous failures

2014-11-14 Thread Ian Campbell
On Tue, 2014-11-11 at 19:41 +, Ian Jackson wrote: > Look to see whether the last run on any hosts which are equivalent to > the ones we're looking at, failed. This means that when host X is > failing and we are considering host Y which is equivalent to X, we > give Y a selection bonus. > > Th

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 11:36 AM, Ian Jackson wrote: Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): On 11/14/2014 11:31 AM, Ian Jackson wrote: `goto skip1' only appears in the PV path AFAICT. Right, this is all about PV code path. So now I

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > On 11/14/2014 11:31 AM, Ian Jackson wrote: > > `goto skip1' only appears in the PV path AFAICT. > > Right, this is all about PV code path. So now I am confused. Why is qemu involved ?

Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 05:53:19AM +0100, Juergen Gross wrote: > On 11/13/2014 08:56 PM, Konrad Rzeszutek Wilk wrote: > + mfn_save = virt_to_mfn(buf); > + > + while (xen_remap_mfn != INVALID_P2M_ENTRY) { > >>> > >>>So the 'list' is constructed by going forward - that is from low-numbere

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
Hi Julien, > I would be surprised that the next GIC series impact this code as the > next driver is only compiled for arm64 (GICv3 doesn't exist on arm32). > Though, there was some refactoring. I meant that code was divided for generic GIC and GICv2 together with refactoring. Also in mails I saw

Re: [Xen-devel] [OSSTEST PATCH 0/9] Host allocation scoring improvements

2014-11-14 Thread Ian Campbell
On Thu, 2014-11-13 at 16:16 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST PATCH 0/9] Host allocation scoring > improvements"): > > On Tue, 2014-11-11 at 19:41 +, Ian Jackson wrote: > > > Here, I'm trying to fix the way that osstest gets far too obsessed > > > about particular

Re: [Xen-devel] [PATCH v10 for-xen-4.5 2/2] dpci: Replace tasklet with an softirq

2014-11-14 Thread Jan Beulich
>>> On 14.11.14 at 17:11, wrote: > On Fri, Nov 14, 2014 at 03:13:42PM +, Jan Beulich wrote: >> >>> On 12.11.14 at 03:23, wrote: >> > +static void pt_pirq_softirq_reset(struct hvm_pirq_dpci *pirq_dpci) >> > +{ >> > +struct domain *d = pirq_dpci->dom; >> > + >> > +ASSERT(spin_is_locked(

Re: [Xen-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 14, 2014 at 01:57:21PM +, Stefano Stabellini wrote: > > Konrad, > > this is another bug fix for QEMU: pci hotplug doesn't work when > > xen_platform_pci=0 without this. > > Yes. > > > > I think we should have it in 4.5. What do y

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Julien Grall
On 11/14/2014 04:22 PM, Andrii Tseglytskyi wrote: > On Fri, Nov 14, 2014 at 6:15 PM, Stefano Stabellini > wrote: >> On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >>> On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini >>> wrote: On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > On Fri, N

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 11:31 AM, Ian Jackson wrote: Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): On 11/14/2014 11:01 AM, Ian Jackson wrote: What call to xc_physdev_unmap_pirq ? I see one in the PV path. At the skip1 label. `goto skip1'

Re: [Xen-devel] [edk2] [PATCH 1/4] OvmfPkg/XenBusDxe: In XenStore, replace type of Len from UINTN to UINT32.

2014-11-14 Thread Laszlo Ersek
On 11/13/14 18:27, Anthony PERARD wrote: > Since a message to XenStore have a lenght of type UINT32, have > XenStore.c deal only with UINT32 instead of a mixmatch with UINTN. > > This patch replaces the type of Len in WRITE_REQUEST and the type of the > argument Len of XenStoreWriteStore and XenSt

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > (Now with Reply-all, sorry) Likewise. > On 11/14/2014 11:01 AM, Ian Jackson wrote: > > What call to xc_physdev_unmap_pirq ? I see one in the PV path. > > At the skip1 label. `goto sk

[Xen-devel] [linux-3.10 test] 31544: regressions - FAIL

2014-11-14 Thread xen . org
flight 31544 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 7 windows-install fail REGR. vs. 26303 Tests which are failin

Re: [Xen-devel] [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes

2014-11-14 Thread Ian Campbell
On Fri, 2014-11-14 at 16:27 +, Ian Jackson wrote: > With -v, runvar-perlop would unconditionally print a message about the > changed variable. Instead, only call runvar_set if the value is to > change. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell > --- > cs-adjust-flight |3

[Xen-devel] [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes

2014-11-14 Thread Ian Jackson
With -v, runvar-perlop would unconditionally print a message about the changed variable. Instead, only call runvar_set if the value is to change. Signed-off-by: Ian Jackson --- cs-adjust-flight |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cs-adjust-flight b/cs-adjust

Re: [Xen-devel] [OSSTEST PATCH 1/2] target_editfile: Improve doc comment

2014-11-14 Thread Ian Campbell
On Fri, 2014-11-14 at 16:27 +, Ian Jackson wrote: > More clearly state which arguments are optional. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell > --- > Osstest/TestSupport.pm |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Osstest/TestSupport.pm b

Re: [Xen-devel] [PATCH RFC] EFI: allow retry of ExitBootServices() call

2014-11-14 Thread Jan Beulich
>>> On 14.11.14 at 16:32, wrote: > On Fri, Nov 14, 2014 at 12:37:30PM +, Jan Beulich wrote: >> @@ -1051,17 +1051,23 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY >> if ( !efi_memmap ) >> blexit(L"Unable to allocate memory for EFI memory map"); >> >> -status = efi_bs->GetMemor

[Xen-devel] [OSSTEST PATCH 1/2] target_editfile: Improve doc comment

2014-11-14 Thread Ian Jackson
More clearly state which arguments are optional. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 45ceee9..46b6720 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
On Fri, Nov 14, 2014 at 6:15 PM, Stefano Stabellini wrote: > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >> On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini >> wrote: >> > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >> >> On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini >> >> wrote:

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 11:01 AM, Ian Jackson wrote: Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): And I believe we still need part of the second patch --- the one that removes call to xc_domain_irq_permission() for PV guests (after your pa

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("[PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > When a device is hot-unplugged libxl sends QEMU a "device-del" message > (via QMP). This call returns after QEMU has initiated device removal by > sending an interrupt to the guest. At some p

Re: [Xen-devel] [PATCH v10 for-xen-4.5 2/2] dpci: Replace tasklet with an softirq

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 03:13:42PM +, Jan Beulich wrote: > >>> On 12.11.14 at 03:23, wrote: > > +static void pt_pirq_softirq_reset(struct hvm_pirq_dpci *pirq_dpci) > > +{ > > +struct domain *d = pirq_dpci->dom; > > + > > +ASSERT(spin_is_locked(&d->event_lock)); > > + > > +switch (

Re: [Xen-devel] [PATCH RFC] EFI: allow retry of ExitBootServices() call

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 12:37:30PM +, Jan Beulich wrote: > The specification is kind of vague under what conditions > ExitBootServices() may legitimately fail, requiring the OS loader to > retry: > > "If MapKey value is incorrect, ExitBootServices() returns > EFI_INVALID_PARAMETER and GetMemo

Re: [Xen-devel] kexec-ed kernel possibly needing low memory

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 11:02:54AM +, David Vrabel wrote: > On 14/11/14 10:00, Jan Beulich wrote: > > David, > > > > we're being approached with the situation where a disk driver in the > > kexec-ed kernel needs memory below 4G in order to perform DMA > > (e.g. for the swiotlb to be set up). L

Re: [Xen-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-14 Thread Konrad Rzeszutek Wilk
On Fri, Nov 14, 2014 at 01:57:21PM +, Stefano Stabellini wrote: > Konrad, > this is another bug fix for QEMU: pci hotplug doesn't work when > xen_platform_pci=0 without this. Yes. > > I think we should have it in 4.5. What do you think? Do you believe we should first get an Tested-by from th

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini > wrote: > > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > >> On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini > >> wrote: > >> > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > >> >> Hi, >

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Andrew Cooper
On 14/11/14 15:32, Juergen Gross wrote: > On 11/14/2014 03:59 PM, Andrew Cooper wrote: >> On 14/11/14 14:14, Jürgen Groß wrote: >>> On 11/14/2014 02:56 PM, Andrew Cooper wrote: On 14/11/14 12:53, Juergen Gross wrote: > On 11/14/2014 12:41 PM, Andrew Cooper wrote: >> On 14/11/14 09:37,

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
Hi Julien, On Fri, Nov 14, 2014 at 5:49 PM, Julien Grall wrote: > Hi Andrii, > > On 11/14/2014 03:39 PM, Andrii Tseglytskyi wrote: >> Also note - freeze depends on system load. It reproduces more >> frequently if I start Android + QNX + all frontends/backends drivers. >> Starting Android only wit

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > But it doesn't help with the second part (the one that shows Linux > WARNING), because we still may try to reset the device before guest > kernel is done unloading the driver. Reproduci

Re: [Xen-devel] RFC: Configuring rumprun-xen application stacks from Xenstore

2014-11-14 Thread Ian Jackson
Antti Kantee writes ("Re: RFC: Configuring rumprun-xen application stacks from Xenstore"): > user-visible != internally visible. We can for example build /etc into > the image as data and mount it as a memory file system at runtime or > symlink /etc/resolv.conf to /resolv.conf. I'd completely

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Julien Grall
Hi Andrii, On 11/14/2014 03:39 PM, Andrii Tseglytskyi wrote: > Also note - freeze depends on system load. It reproduces more > frequently if I start Android + QNX + all frontends/backends drivers. > Starting Android only without any addition drivers works more less > stable. It looks like issue is

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Jan Beulich
>>> On 14.11.14 at 16:20, wrote: > If it still helps i could try Andrews suggestion and try out with only > commit aeeea485 .. Yes, even if it's pretty certain it's the second of the commits, verifying this would be helpful (or if the assumption is wrong, the pattern it's dying with would change

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini wrote: > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >> On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini >> wrote: >> > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >> >> Hi, >> >> >> >> I observe system freeze on latest xen/master branc

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Juergen Gross
On 11/14/2014 03:59 PM, Andrew Cooper wrote: On 14/11/14 14:14, Jürgen Groß wrote: On 11/14/2014 02:56 PM, Andrew Cooper wrote: On 14/11/14 12:53, Juergen Gross wrote: On 11/14/2014 12:41 PM, Andrew Cooper wrote: On 14/11/14 09:37, Juergen Gross wrote: The x86 struct arch_shared_info field p

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Boris Ostrovsky
On 11/14/2014 09:41 AM, Ian Jackson wrote: Boris Ostrovsky writes ("[PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): When a device is hot-unplugged libxl sends QEMU a "device-del" message (via QMP). This call returns after QEMU has initiated device removal by send

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini > wrote: > > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > >> Hi, > >> > >> I observe system freeze on latest xen/master branch. > >> > >> My setup is: > >> > >> - Jacinto 6 evm board (OMAP5) >

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 4:09:53 PM, you wrote: On 14.11.14 at 15:34, wrote: >> # addr2line -e ./xen-syms 82d080148f14 >> /usr/src/new/xen-unstable/xen/include/xen/list.h:175 >> >> Which turns out to be this assert: >> /** >> * list_del - deletes entry from list. >> * @entry: the e

Re: [Xen-devel] [PATCH 2/3] x86: allow dma_get_required_mask() to be overridden

2014-11-14 Thread Stefano Stabellini
On Wed, 12 Nov 2014, David Vrabel wrote: > Use dma_ops->get_required_mask() if provided, defaulting to > dma_get_requried_mask_from_max_pfn(). > > This is needed on systems (such as Xen PV guests) where the DMA > address and the physical address are not equal. > > Signed-off-by: David Vrabel Re

Re: [Xen-devel] [PATCH v10 for-xen-4.5 2/2] dpci: Replace tasklet with an softirq

2014-11-14 Thread Jan Beulich
>>> On 12.11.14 at 03:23, wrote: > +static void pt_pirq_softirq_reset(struct hvm_pirq_dpci *pirq_dpci) > +{ > +struct domain *d = pirq_dpci->dom; > + > +ASSERT(spin_is_locked(&d->event_lock)); > + > +switch ( cmpxchg(&pirq_dpci->state, 1 << STATE_SCHED, 0) ) > +{ > +case (1 <<

Re: [Xen-devel] [PATCH 1/3] dma, ia64: add dma_get_required_mask_from_max_pfn()

2014-11-14 Thread Stefano Stabellini
On Wed, 12 Nov 2014, David Vrabel wrote: > ia64 provides a duplicate of the generic dma_get_required_mask() > because it has ARCH_HAS_GET_REQUIRED_MASK. Provide a common > dma_get_require_mask_max_pfn() instead. > > Signed-off-by: David Vrabel > Cc: Tony Luck > Cc: Fenghua Yu > Cc: linux-i...@

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Jan Beulich
>>> On 14.11.14 at 15:34, wrote: > # addr2line -e ./xen-syms 82d080148f14 > /usr/src/new/xen-unstable/xen/include/xen/list.h:175 > > Which turns out to be this assert: > /** > * list_del - deletes entry from list. > * @entry: the element to delete from the list. > * Note: list_empty on ent

Re: [Xen-devel] [Patch v2 2/3] correct xc_domain_save()'s return value

2014-11-14 Thread Ian Jackson
Ian Campbell writes ("Re: [Patch v2 2/3] correct xc_domain_save()'s return value"): > On Fri, 2014-11-14 at 14:57 +, Ian Jackson wrote: > > +errno = EIO; > > +ERROR("Suspend request failed (without errno, using EINVAL)"); > > You mean EIO in the error message, I think.

Re: [Xen-devel] [Patch v2 3/3] update libxl__device_disk_from_xs_be() to support blktap device

2014-11-14 Thread Ian Jackson
Wen Congyang writes ("[Patch v2 3/3] update libxl__device_disk_from_xs_be() to support blktap device"): > [stuff] Thanks for your attention to the details of this rather neglected area. This patch seems related to [RFC Patch v4 8/9] store correct format into tapdisk-params/params from Mon, 22

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Andrew Cooper
On 14/11/14 14:14, Jürgen Groß wrote: > On 11/14/2014 02:56 PM, Andrew Cooper wrote: >> On 14/11/14 12:53, Juergen Gross wrote: >>> On 11/14/2014 12:41 PM, Andrew Cooper wrote: On 14/11/14 09:37, Juergen Gross wrote: > The x86 struct arch_shared_info field pfn_to_mfn_frame_list_list >

Re: [Xen-devel] [Patch v2 2/3] correct xc_domain_save()'s return value

2014-11-14 Thread Ian Campbell
On Fri, 2014-11-14 at 14:57 +, Ian Jackson wrote: > +errno = EIO; > +ERROR("Suspend request failed (without errno, using EINVAL)"); You mean EIO in the error message, I think. Ian. ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [Patch v2 2/3] correct xc_domain_save()'s return value

2014-11-14 Thread Ian Jackson
Wen Congyang writes ("[Patch v2 2/3] correct xc_domain_save()'s return value"): > If suspend_and_state() fails, the errno may be 0. But we assume > that the errno is not 0. So remove assert(). Thanks for spotting this. I think this is going in the wrong direction. Perhaps we could instead do som

Re: [Xen-devel] [PATCH] x86: (allow to) override LIST_POISON*

2014-11-14 Thread Andrew Cooper
On 14/11/14 14:52, Jan Beulich wrote: > Having these point into space not controlled by the hypervisor provides > an unnecessary attack surface. Allow architectures to override them and > utilize that override to make them non-canonical addresses (thus > causing #GP rather than #PF when dereference

[Xen-devel] [PATCH] x86: (allow to) override LIST_POISON*

2014-11-14 Thread Jan Beulich
Having these point into space not controlled by the hypervisor provides an unnecessary attack surface. Allow architectures to override them and utilize that override to make them non-canonical addresses (thus causing #GP rather than #PF when dereferenced). Suggested-by: Andrew Cooper Signed-off-b

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini wrote: > On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: >> Hi, >> >> I observe system freeze on latest xen/master branch. >> >> My setup is: >> >> - Jacinto 6 evm board (OMAP5) >> - Latest Xen 4.5.0-rc2 as hypervisor >> - Linux 3.8 as dom0, runni

Re: [Xen-devel] [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down

2014-11-14 Thread Ian Jackson
Boris Ostrovsky writes ("[PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > When a device is hot-unplugged libxl sends QEMU a "device-del" message > (via QMP). This call returns after QEMU has initiated device removal by > sending an interrupt to the guest. At some p

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: > Hi, > > I observe system freeze on latest xen/master branch. > > My setup is: > > - Jacinto 6 evm board (OMAP5) > - Latest Xen 4.5.0-rc2 as hypervisor > - Linux 3.8 as dom0, running on 2 vcpus > - Android 4.3 as domU (running on Linux kernel 3.8,

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Friday, November 14, 2014, 2:57:38 PM, you wrote: On 14.11.14 at 14:11, wrote: >> (XEN) [2014-11-14 13:00:06.810] [ Xen-4.5.0-rc x86_64 debug=y Not >> tainted ] >> (XEN) [2014-11-14 13:00:06.810] CPU:3 >> (XEN) [2014-11-14 13:00:06.810] RIP:e008:[] >> dpci_softirq+0x9c/

[Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
Hi, I observe system freeze on latest xen/master branch. My setup is: - Jacinto 6 evm board (OMAP5) - Latest Xen 4.5.0-rc2 as hypervisor - Linux 3.8 as dom0, running on 2 vcpus - Android 4.3 as domU (running on Linux kernel 3.8, 2 vcpus) - XSM feature is disabled - gcc version 4.7.3 20130328 (pr

Re: [Xen-devel] vtpmmgr bug: fails to start if locality!=0

2014-11-14 Thread Emil Condrea
I modified linux kernel tpm_tis driver to try to start with locality 2. I did some logging and after taking a look with dmesg it seems that the IO pages for other localities are full with 1. in tpm_tis_init: for(i=0;i<5;i++){ release_locality(chip,i,1); } ... wait_startup(chip,2); request_local

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Jürgen Groß
On 11/14/2014 02:56 PM, Andrew Cooper wrote: On 14/11/14 12:53, Juergen Gross wrote: On 11/14/2014 12:41 PM, Andrew Cooper wrote: On 14/11/14 09:37, Juergen Gross wrote: The x86 struct arch_shared_info field pfn_to_mfn_frame_list_list currently contains the mfn of the top level page frame of t

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Jan Beulich
>>> On 14.11.14 at 14:11, wrote: > (XEN) [2014-11-14 13:00:06.810] [ Xen-4.5.0-rc x86_64 debug=y Not > tainted ] > (XEN) [2014-11-14 13:00:06.810] CPU:3 > (XEN) [2014-11-14 13:00:06.810] RIP:e008:[] > dpci_softirq+0x9c/0x231 > (XEN) [2014-11-14 13:00:06.810] RFLAGS: 00

Re: [Xen-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-14 Thread Stefano Stabellini
Konrad, this is another bug fix for QEMU: pci hotplug doesn't work when xen_platform_pci=0 without this. I think we should have it in 4.5. What do you think? - Stefano On Thu, 13 Nov 2014, Paolo Bonzini wrote: > On 13/11/2014 03:30, Li Liang wrote: > > If user starts QEMU with "-machine pc,accel

Re: [Xen-devel] [PATCH 1/4] expand x86 arch_shared_info to support linear p2m list

2014-11-14 Thread Andrew Cooper
On 14/11/14 12:53, Juergen Gross wrote: > On 11/14/2014 12:41 PM, Andrew Cooper wrote: >> On 14/11/14 09:37, Juergen Gross wrote: >>> The x86 struct arch_shared_info field pfn_to_mfn_frame_list_list >>> currently contains the mfn of the top level page frame of the 3 level >>> p2m tree, which is use

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Andrew Cooper
On 14/11/14 13:32, Andrew Cooper wrote: > On 14/11/14 13:11, Sander Eikelenboom wrote: >> Hi Konrad / Jan, >> >> One of these commits: >> - aeeea485bcfe2a517ed9bcb3ba1c3be0f6824e07 dpci: move from an hvm_irq_dpci >> (and struct domain) to an hvm_dirq_dpci model >> - f6dd295381f4b6a66acddacf46bca89

Re: [Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Andrew Cooper
On 14/11/14 13:11, Sander Eikelenboom wrote: > Hi Konrad / Jan, > > One of these commits: > - aeeea485bcfe2a517ed9bcb3ba1c3be0f6824e07 dpci: move from an hvm_irq_dpci > (and struct domain) to an hvm_dirq_dpci model > - f6dd295381f4b6a66acddacf46bca8940586c8d8 pci: replace tasklet with softirq > >

Re: [Xen-devel] [PULL for-2.2 0/2] Xen tree 2014-11-14

2014-11-14 Thread Peter Maydell
On 14 November 2014 11:29, Stefano Stabellini wrote: > The following changes since commit c52e67924fbdadfa00668248f5c075542943c54c: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-11-13 15:44:16 +) > > are available in the git repository at: > > >

[Xen-devel] Xen-unstable: xen panic RIP: dpci_softirq

2014-11-14 Thread Sander Eikelenboom
Hi Konrad / Jan, One of these commits: - aeeea485bcfe2a517ed9bcb3ba1c3be0f6824e07 dpci: move from an hvm_irq_dpci (and struct domain) to an hvm_dirq_dpci model - f6dd295381f4b6a66acddacf46bca8940586c8d8 pci: replace tasklet with softirq gives (running under 5 minutes of host boot, on AMD hardwar

[Xen-devel] [qemu-mainline test] 31542: regressions - FAIL

2014-11-14 Thread xen . org
flight 31542 qemu-mainline real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31542/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 9 guest-start fail REGR. vs. 30603 test-amd64-i386-pai

  1   2   >