Florian Köberle a écrit :
>> I am also thinking of adding a Action::Push(bool), and Action::PopBool()
>> but this is another story ;)
>>
>>
> Please wait with this a little while. I have an idea of how to improve the
> action framework so that you can't make Pust/Pop mistakes anymore and
> whi
Thanks Matt for so a fast and positive review!
My thanks go also to Jika who helped me testing.
Without having someone like him to play with I don't know if I would have
the motivation to write those patches.
Best regards,
Florian (iflo)
___
Wormux-d
> I think you have changed the behaviour here.
>
> Only the current player can normally press space to make the fall of
> bonus box fastest. It have to be discussed I guess.
No, you could drop a box with space even as non turn master. That's why
this patch was necessary.
>
> Florian Köberle a écrit
>> - const int max_nodes_per_turn = 100; // safe value to avoid network
>> congestion
>> + const int max_nodes_per_turn = 100; // safe value, was used to avoid
>> network congestion
>>
>
> is this value still useful ? maybe it should be increased ? (or removed
> if it is useless)
>
No idea, but I
> I am also thinking of adding a Action::Push(bool), and Action::PopBool()
> but this is another story ;)
>
Please wait with this a little while. I have an idea of how to improve the
action framework so that you can't make Pust/Pop mistakes anymore and
which would make it simple to add method to lo
> Hm, I would have seen this patch at the end of the series, otherwise it
> is ok.
There was always a good reason to apply it early. For example I remember
trying to move the wind patch forward, but it turned out that it didn't
work correctly without this patch beeing applied. I didn't want to comm
> Have you tested the whole series between 2 wormux instances, one at
> 50fps and another one at 10fps ?
Yes, when I played with Jika I had frame rates ranging from 10 to 30
(using a slow netbook), while he had constant 50.
___
Wormux-dev mailing list
Wo
