[Wireshark-dev] Gitlab missing feature compared to Github

2021-10-30 Thread Joerg Mayer
Hello, there is one very valuable feature of github that was lost in the transition to giblab: The commit message does no longer reference the merge request, making it way harder to look at the discussion leading to a merge. Can this feature please be readded? Thanks! Jörg -- Joerg Mayer

Re: [Wireshark-dev] Gitlab missing feature compared to Github

2021-10-30 Thread Ivan Nardi
> there is one very valuable feature of github that was lost in the transition > to giblab: > The commit message does no longer reference the merge request, making it way > harder to > look at the discussion leading to a merge. +1. I really miss this feature (of Gerrit)! Incredibly useful Ivan

Re: [Wireshark-dev] Gitlab missing feature compared to Github

2021-10-30 Thread Jaap Keuter
Hi, What about just entering the commit in the GitLab search box? There you get the commit, parent commit, the merge request, the pipeline, etc. all just one click away. Basically the same thing. Thanks, Jaap > On 30 Oct 2021, at 11:02, Joerg Mayer wrote: > > Hello, > > there is one very v

[Wireshark-dev] How to generate epan/dissectors/packet-skinny.c?

2021-10-30 Thread Jirka Novak
Hi, based on notice of Jörg Mayer (thank you), I tried to generate epan/dissectors/packet-skinny.c from epan/dissectors/packet-skinny.c.in. The command line should be: cog.py -D xmlfile=tools/SkinnyProtocolOptimized.xml -d -c -o epan/dissectors/packet-skinny.c epan/dissectors/packet-skinny.c.

Re: [Wireshark-dev] How to generate epan/dissectors/packet-skinny.c?

2021-10-30 Thread Alexis La Goutte
Hi Jirka, from packet-skinny.c.in # Dependencies: # - python2.x # - cog.py: (pip install cogapp / http://nedbatchelder.com/code/cog/) # - python.xml # - python.xml.sax # Tested on Ubuntu 18.04 (TLS) (with python2) and work for me.. On Sat, Oct 30, 2021 at 4:39 PM Jirka Novak wrote: > Hi, > >

Re: [Wireshark-dev] How to generate epan/dissectors/packet-skinny.c?

2021-10-30 Thread Jirka Novak
Hi ALexis, > from packet-skinny.c.in > # Dependencies: > # - python2.x > # - cog.py: (pip install cogapp / http://nedbatchelder.com/code/cog/ > ) > # - python.xml > # - python.xml.sax > # > > Tested on Ubuntu 18.04 (TLS) (with python