[Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Ivan Nardi
Hi If I am not wrong, the "Windows Build" job is triggered only after a maintainer picks up the MR and assigns it to the "Wireshark GitLab Utility". Is there any way I can trigger it myself? Some background. I don't have a Windows machine to build Wireshark myself. My last MR (https://gitlab.com/

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Roland Knall
Hi Ivan We have a limited number of machines for our build-jobs. Therefore only when we set the merge-request to a semi-done level, buildjobs are triggered. What you can do though, is run your own pipeline, and use our .gitlab-ci.yml file as a template. At this point we do not plan on making the

Re: [Wireshark-dev] Byte view mouse hover behaviour

2021-09-13 Thread Roland Knall
Looks to me that we actually have an inconsistency in behavior. If you click on a byte, the underlying field gets selected in the byteview as well as packetdetail pane and stays selected, until you click someplace else. If you do the same the other way around, it does not work, as the selection is

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Ivan Nardi
Hi Roland I thought that the present configuration was a trade-off between flexibility and resource constraints. Thank you very much for the suggestions, very appreciated! I will definitely compile Wireshark with both gcc and clang from now on. Thanks for your reply Kind regards Ivan On Mon, 13

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Dario Lombardo
You can also leverage github actions: it has a windows build. Just push on a github fork of yours and you'll trigger a windows build. https://github.com/wireshark/wireshark/actions/workflows/windows.yml On Mon, Sep 13, 2021 at 2:48 PM Ivan Nardi wrote: > Hi Roland > I thought that the present c

Re: [Wireshark-dev] Edit resolved name stopped working?

2021-09-13 Thread chuck c
(for future reference - MR for a specific case of name resolution greyed out) https://gitlab.com/wireshark/wireshark/-/merge_requests/4177 Qt: Enable Edit Name Resolution for EXPORTED_PDU On Fri, Sep 10, 2021 at 2:17 PM Anders Broman wrote: > Hi, > I think it was exported pdu with ips as tags. T

Re: [Wireshark-dev] Byte view mouse hover behaviour

2021-09-13 Thread Roland Knall
See https://gitlab.com/wireshark/wireshark/-/merge_requests/4178 for the functionality change Am Mo., 13. Sept. 2021 um 11:37 Uhr schrieb Roland Knall : > Looks to me that we actually have an inconsistency in behavior. If you > click on a byte, the underlying field gets selected in the byteview a

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Gerald Combs
How long does the GitHub action take to run? The "Windows Build" job currently uses a dedicated runner, which is why it only gets run if a maintainer submits, rebases or otherwise "lays hands" the MR. We use a dedicated runner because installing all of our prerequisites, building Wireshark, and

Re: [Wireshark-dev] Byte view mouse hover behaviour

2021-09-13 Thread Jaap Keuter
Great, I’ll have a look when time permits... ;) > On 13 Sep 2021, at 17:03, Roland Knall wrote: > > See https://gitlab.com/wireshark/wireshark/-/merge_requests/4178 > for the > functionality change > > Am Mo., 13. Sept. 2021 um 11

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Dario Lombardo
On Mon, Sep 13, 2021 at 7:39 PM Gerald Combs wrote: > How long does the GitHub action take to run? According to the jobs history, it takes 25 to 30 minutes, which looks comparable to the wireshark's builds for windows on gitlab. It usually gets scheduled very quickly, which does not happen in a