Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-02 Thread Joerg Mayer
On Mon, Dec 02, 2013 at 03:34:33AM +, Christopher Maynard wrote: > For example, if a user wants to set a maximum file size, then I think it's > more intuitive to the user to specify and expect SI, powers of 10, units to > apply rather than the IEC, powers of 2, units. This might end up being a

Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-02 Thread Graham Bloice
On 2 December 2013 10:01, Joerg Mayer wrote: > On Mon, Dec 02, 2013 at 03:34:33AM +, Christopher Maynard wrote: > > For example, if a user wants to set a maximum file size, then I think > it's > > more intuitive to the user to specify and expect SI, powers of 10, units > to > > apply rather t

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Joerg Mayer
On Sun, Dec 01, 2013 at 10:35:50PM +, Graham Bloice wrote: > On 30 November 2013 23:18, Joerg Mayer wrote: > > I have no idea why/how this is supposed to work: Is Qt5 supposed to > > automagically > > add the right msvc version back into the path? > > After applying and testing this it didn't

[Wireshark-dev] Compilation failure in gtk/stats_tree_stat.c

2013-12-02 Thread Joerg Mayer
[ 83%] Building C object ui/gtk/CMakeFiles/gtkui.dir/stats_tree_stat.c.o /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c: In function ‘save_as_dialog’: /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c:296:3: error: enum conversion when passing argument 2 of ‘stats_tre

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Graham Bloice
On 2 December 2013 10:54, Joerg Mayer wrote: > On Sun, Dec 01, 2013 at 10:35:50PM +, Graham Bloice wrote: > > On 30 November 2013 23:18, Joerg Mayer wrote: > > > I still have the issue with GTK3, in that I have to comment out the path > > "corrections" in FindGTK3.cmake. > > Hmm, can you ple

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Joerg Mayer
On Mon, Dec 02, 2013 at 11:34:21AM +, Graham Bloice wrote: > On 2 December 2013 10:54, Joerg Mayer wrote: > > On Sun, Dec 01, 2013 at 10:35:50PM +, Graham Bloice wrote: > > > On 30 November 2013 23:18, Joerg Mayer wrote: > > > > > I still have the issue with GTK3, in that I have to commen

Re: [Wireshark-dev] Compilation failure in gtk/stats_tree_stat.c

2013-12-02 Thread Alexis La Goutte
checkAPI script are no happy... Error: Found prohibited APIs in stats_tree_stat.c: fopen Error: Found prohibited APIs in stats_tree_stat.c: fopen On Mon, Dec 2, 2013 at 11:55 AM, Joerg Mayer wrote: > [ 83%] Building C object ui/gtk/CMakeFiles/gtkui.dir/stats_tree_stat.c.o > /home/jmayer/wor

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Graham Bloice
On 2 December 2013 13:49, Joerg Mayer wrote: > On Mon, Dec 02, 2013 at 11:34:21AM +, Graham Bloice wrote: > > On 2 December 2013 10:54, Joerg Mayer wrote: > > > On Sun, Dec 01, 2013 at 10:35:50PM +, Graham Bloice wrote: > > > > On 30 November 2013 23:18, Joerg Mayer wrote: > > > > > > >

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Joerg Mayer
On Mon, Dec 02, 2013 at 02:28:43PM +, Graham Bloice wrote: > On 2 December 2013 13:49, Joerg Mayer wrote: > > > On Mon, Dec 02, 2013 at 11:34:21AM +, Graham Bloice wrote: > > > On 2 December 2013 10:54, Joerg Mayer wrote: > > > > On Sun, Dec 01, 2013 at 10:35:50PM +, Graham Bloice wr

Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-02 Thread Christopher Maynard
Joerg Mayer writes: > > What do others think before I make any changes to SI units? > > Please change to SI in these cases. So you're recommending moving to SI prefixes for both the file size autostop condition and the capture buffer size, or just the file size? I just wanted to confirm becaus

Re: [Wireshark-dev] Compilation failure in gtk/stats_tree_stat.c

2013-12-02 Thread Guy Harris
On Dec 2, 2013, at 5:52 AM, Alexis La Goutte wrote: > checkAPI script are no happy... > Error: Found prohibited APIs in stats_tree_stat.c: fopen > Error: Found prohibited APIs in stats_tree_stat.c: fopen Calls changed to ws_fopen() to handle UTF-8 file names on Windows (that's why it's prohibi

Re: [Wireshark-dev] Compilation failure in gtk/stats_tree_stat.c

2013-12-02 Thread Guy Harris
On Dec 2, 2013, at 2:55 AM, Joerg Mayer wrote: > [ 83%] Building C object ui/gtk/CMakeFiles/gtkui.dir/stats_tree_stat.c.o > /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c: In function > ‘save_as_dialog’: > /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c:296:3: err

Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-02 Thread Christopher Maynard
Christopher Maynard writes: > Joerg Mayer ...> writes: > > > > What do others think before I make any changes to SI units? > > > > Please change to SI in these cases. > > So you're recommending moving to SI prefixes for both the file size autostop > condition and the capture buffer size, or j

Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-02 Thread Guy Harris
On Dec 2, 2013, at 11:59 AM, Christopher Maynard wrote: > And for now I just documented the capture > buffer size as "MiB" since that's the correct units. I have no problem > changing the implementation of the capture buffer size to SI units though, > if anyone thinks it makes more sense to do

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-02 Thread Guy Harris
On Dec 2, 2013, at 8:14 AM, Joerg Mayer wrote: > On Mon, Dec 02, 2013 at 02:28:43PM +, Graham Bloice wrote: >> >> In the main CMakeLists.txt: >> >> W:\Wireshark\trunk>c:\cygwin\bin\grep.exe -ni WTAP_PLUGIN_SOURCES *.txt >> CMakeLists.txt:751:set(WTAP_PLUGIN_SOURCES >> CMakeLists.txt:1061: