Re: [Wireshark-dev] [Wireshark-commits] rev 53683: /trunk/tools/ /trunk/tools/: make-dissector-reg.py

2013-12-01 Thread Joerg Mayer
On Sun, Dec 01, 2013 at 01:35:14AM +, ger...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53683 > > User: gerald > Date: 2013/12/01 01:35 AM > > Log: > Fix compatibility with Python 2.5. Tested with 2.5, 2.6, 2.7, and 3.3. Many Thanks! I was torn b

Re: [Wireshark-dev] [Wireshark-commits] rev 53681: /trunk/codecs/SBC/ /trunk/codecs/SBC/: sbc.c

2013-12-01 Thread mmann78
Including config.h for the "conditional" codecs (sbc/G722/G726) breaks the build on Windows. I originally had removed it (because it wasn't present on the existing codecs), but I guess the "right" fix is adding an include directory to the makefile.___

Re: [Wireshark-dev] [Wireshark-commits] rev 53683: /trunk/tools/ /trunk/tools/: make-dissector-reg.py

2013-12-01 Thread Graham Bloice
On 1 December 2013 09:45, Joerg Mayer wrote: > On Sun, Dec 01, 2013 at 01:35:14AM +, ger...@wireshark.org wrote: > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53683 > > > > User: gerald > > Date: 2013/12/01 01:35 AM > > > > Log: > > Fix compatibility with Python 2.5. T

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-01 Thread Graham Bloice
On 30 November 2013 23:18, Joerg Mayer wrote: > It took some preparational time before I could test your patches: > - I needed to get a working Windows build first > - I've finally managed to be able to compile via cygwin-ssh, so no more > remote desktop sessions :-) > - Finish some other small

Re: [Wireshark-dev] [Wireshark-commits] rev 53683: /trunk/tools/ /trunk/tools/: make-dissector-reg.py

2013-12-01 Thread Guy Harris
On Dec 1, 2013, at 9:21 AM, Graham Bloice wrote: > BTW, why is OSX using such an ancient version of Python. Why is an ancient version of OS X (10.6) using such an ancient version of Python? :-) > I believe only 2.7 and 3.3 are supported by the Python folks. $ sw_vers ProductN

Re: [Wireshark-dev] Status Cmake Win32 support

2013-12-01 Thread Graham Bloice
On 30 November 2013 23:18, Joerg Mayer wrote: > > >1. I had to add some MSC version definitions to CMakeLists.txt > > There are two independent parts to this patch: > > 1) I applied the MSC_VER_REQUIRED part (after I understood the cmake > specific >part of it). > > 2) > -

[Wireshark-dev] SI vs. IEC prefixes

2013-12-01 Thread Christopher Maynard
Not too long ago, I committed a change in r51576[1] that, besides resolving a bug reported on ask.wireshark.org, also properly documented the max filesize autostop values to match the code. Previously, they were documented in SI units: kilobyte(s), megabyte(s), gigabyte(s); however, that did not m

Re: [Wireshark-dev] SI vs. IEC prefixes

2013-12-01 Thread Evan Huus
As a point of reference on this, Ubuntu recommends different formats depending on the context [1]. They suggest base 2 for RAM sizes (such as our capture buffer) and base 10 for almost everything else, including file sizes and network bandwidth. Without thinking about it too hard this seems relati