On 11/21/2013 8:05 PM, Guy Harris wrote:
On Nov 21, 2013, at 4:37 PM, Michael Lum
wrote:
Can someone tell me why code like this:
i++;
would have been changed to this:
i += 1;
?
If the code in question is stepping through a packet, and "i" is
actually "offset" or some such variable holdi
Thanks Bill.
I was concerned there was something I was missing.
I understand its a lot of work to go through other peoples varying styles of
code.
Keep up the good work.
Thanks again.
--
Michael Lum (michael@starsolutions.com) | STAR SOLUTIONS | Principal
Software Engineer
4600 Jacombs Ro
Back onto this.
Still attempting to build tshark via a Visual studio 2010 solution.
First failure, the regex stuff in FindGTK3.cmake around line 44 fails
if when I set WIRESHARK_BASE_DIR to E:\Wireshark for my build env. It
breaks on the "\W" part. Setting WIRESHARK_BASE_DIR to "E:/Wireshark"
f
I ran the checkAPIs.pl script against the files I have modified and it
complains about a lot of proto_tree_add_text() calls.
I would like to fix them but after looking at the README.dissector document I'm
left wondering if there is an easier way
than using proto_tree_add_item.
The places in the
On Nov 22, 2013, at 2:10 PM, Michael Lum wrote:
> I ran the checkAPIs.pl script against the files I have modified and it
> complains about a lot of proto_tree_add_text() calls.
>
> I would like to fix them but after looking at the README.dissector document
> I'm left wondering if there is an
I developed convert_proto_tree_add_text.pl (in tools dir) for just this reason.
See http://www.wireshark.org/lists/wireshark-dev/201307/msg00073.html for
brief explanation.
If you're looking specifically at packet-ansi_a.c, I'm not sure how
straightforward the conversion will be. Without an
