[Wireshark-dev] Taps should not use fd->flags.passed_dfilter (rtp, iax2, flow_analysis)

2013-08-15 Thread Jakub Zawadzki
Hi, Few GTK taps are using fd->flags.passed_dfilter as information whether given packet is displayed, this is little broken and might not work as intended. >From grep: ./ui/gtk/rtp_analysis.c ./ui/gtk/iax2_analysis.c ./ui/gtk/flow_graph.c flow_graph requres clicking OK to trigger graph_ana

[Wireshark-dev] Decompress problem if data is over multiple frame

2013-08-15 Thread Hardik Patel
Hello, I am creating dissector plugin. Trace which i have capture is compressed by zlib. I have two option 1)write own decompress function using zlib 2) to use tvb_uncompress() function of wireshark Both have issue if compress packet is over multiple frame. wireshark tvb_uncompress() function

Re: [Wireshark-dev] Decompress problem if data is over multiple frame

2013-08-15 Thread Jakub Zawadzki
Hi, On Thu, Aug 15, 2013 at 03:57:07PM +0200, Hardik Patel wrote: > I am creating dissector plugin. Trace which i have capture is compressed by > zlib. > > I have two option > 1)write own decompress function using zlib > 2) to use tvb_uncompress() function of wireshark > > Both have issue if com

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Clang-Code-Analysis

2013-08-15 Thread Evan Huus
./tools/fuzz-test.sh: line 201: /home/wireshark/builders/trunk-clang-ca/clangcodeanalysis/install/bin/tools/valgrind-wireshark.sh: No such file or directory This is why the valgrind fuzzing has been ineffective. I will take a look at fixing, though we may run into libtool issues as well (I'm not s

Re: [Wireshark-dev] Taps should not use fd->flags.passed_dfilter (rtp, iax2, flow_analysis)

2013-08-15 Thread Anders Broman
Jakub Zawadzki skrev 2013-08-15 14:04: Hi, Few GTK taps are using fd->flags.passed_dfilter as information whether given packet is displayed, this is little broken and might not work as intended. >From grep: ./ui/gtk/rtp_analysis.c ./ui/gtk/iax2_analysis.c ./ui/gtk/flow_graph.c flow_gr

Re: [Wireshark-dev] Taps should not use fd->flags.passed_dfilter (rtp, iax2, flow_analysis)

2013-08-15 Thread Jakub Zawadzki
On Fri, Aug 16, 2013 at 07:29:17AM +0200, Anders Broman wrote: > Jakub Zawadzki skrev 2013-08-15 14:04: > > Few GTK taps are using fd->flags.passed_dfilter as information whether > > given packet is displayed, this is little broken and might not work as > > intended. > > > > [cut] > > > > but if y