[Wireshark-dev] dissect_sip_tcp_heur()

2013-08-10 Thread Martin Kaiser
I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c index fa317c8..c04a0c8 100644 --- a/epan/disse

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX-10.5-x86

2013-08-10 Thread Martin Mathieson
Sorry, I don't understand these warning messages... On Sat, Aug 10, 2013 at 10:06 PM, wrote: > The Buildbot has detected a new failure on builder OSX-10.5-x86 while > building Wireshark (development). > Full details are available at: > http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/

Re: [Wireshark-dev] [Wireshark-commits] rev 51289: /trunk/wiretap/ /trunk/wiretap/: vwr.c

2013-08-10 Thread Martin Mathieson
Thanks Guy. On Sat, Aug 10, 2013 at 10:34 PM, wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51289 > > User: guy > Date: 2013/08/10 02:34 PM > > Log: > Initialize float variables with float constants, not double constants, > and assign float constants, not double co

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX-10.5-x86

2013-08-10 Thread Guy Harris
On Aug 10, 2013, at 2:32 PM, Martin Mathieson wrote: > Sorry, I don't understand these warning messages... Those are the ones I fixed. As per my comment: In C, a floating-point constant is a double, unless explicitly made float by an "f" suffix; to quote the C90 spec: An unsuffixed