[Wireshark-dev] Developing a dissector for MODBUS-based protocol

2008-06-23 Thread Barnes, Pat
Hi, I'm looking to write a dissector for a protocol we're using. It uses the MODBUS protocol - specifically the 'read-and-write multiple registers' message type (0x17) - to implement an RPC-ish method. (The write address represents the function, the written data represents its parameters, and the

[Wireshark-dev] (no subject)

2008-06-23 Thread Martin Corraine (mcorrain)
Hello all, In the readme.developer, it states you shouldn't use "tvb_get_ntohl(tvb, offset);" I tried using tvb_get_letohl (tvb, offset);" However, it retrieves the data backwards thus retrieving the wrong value. Any suggestions? For instance, "00 00 00 06 " should be 6 in base 10 (I'm sur

Re: [Wireshark-dev] (no subject)

2008-06-23 Thread Guy Harris
Martin Corraine (mcorrain) wrote: > In the readme.developer, it states you shouldn't use "tvb_get_ntohl(tvb, > offset);" No, it doesn't. It does say > Don't fetch a little-endian value using "tvb_get_ntohs() or > "tvb_get_ntohl()" and then using "g_ntohs()", "g_htons()", "g_ntohl()", > or "g_h

Re: [Wireshark-dev] (no subject)

2008-06-23 Thread John Sullivan
On Monday, June 23, 2008, 6:38:16 PM, Martin Corraine (mcorrain) wrote: > In the readme.developer, it states you shouldn't use "tvb_get_ntohl(tvb, > offset);" I tried using tvb_get_letohl (tvb, offset);" However, it > retrieves the data backwards thus retrieving the wrong value. Any > suggestions

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread Guy Harris
John Smith wrote: > Ive just compiled wireshark, and when adding the CFLAGS '-Wshadow > -Wpointer-arith -Wcast-qual -W -Wall' What version of Wireshark are you building? With GCC, -Wall, -W, and -Wpointer-arith are by default added if the compiler supports them; -Wcast-qual is added with --ena

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread John Smith
On Mon, Jun 23, 2008 at 10:01 PM, Guy Harris <[EMAIL PROTECTED]> wrote: > > What version of Wireshark are you building? > Wireshark 1.0.0 > > -Wshadow wasn't there; I've checked in a change to add it by default if > the compiler supports it. > Thanks. > > Some probably should. > Alright. But who

[Wireshark-dev] (no subject)

2008-06-23 Thread Martin Corraine (mcorrain)
Hello, Does anyone know how to deal with fields that are floating. For instance, "ANI" is an optional field name(it may or may not be in the packet) AND it's size can be 0-40 bytes. I need to be able to determine the data type and its length so I can dissect that field. Or I could just output as

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2008-06-23 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/249 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Buil

Re: [Wireshark-dev] (no subject)

2008-06-23 Thread Martin Corraine (mcorrain)
I got my hands on additional specs. Problem solved! From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Martin Corraine (mcorrain) Sent: Monday, June 23, 2008 4:35 PM To: Developer support list for Wireshark Subject: [Wireshark-dev] (no subject) Hel

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread Guy Harris
John Smith wrote: > On Mon, Jun 23, 2008 at 10:01 PM, Guy Harris <[EMAIL PROTECTED]> wrote: >> What version of Wireshark are you building? >> > Wireshark 1.0.0 And you had to add -Wpointer-arith, -Wcast-qual, -W, and -Wall? >> Some probably should. >> > Alright. But who ? Developers taking an in

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread Anders Broman
>Most of those come from the ASN.1 dissector generator, which, for some >reason, seems to generate a lot of unused routines (is that an error in the >ASN.1, or an error in asn2wrs?). Most come from unused routines in ASN.1 I believe - perhaps left in from earlier (draft)versions. Others need to be

Re: [Wireshark-dev] Developing a dissector for MODBUS-based protocol

2008-06-23 Thread Stephen Fisher
On Mon, Jun 23, 2008 at 06:12:59PM +1000, Barnes, Pat wrote: > The current modbus dissector is not suitable - it does not show the > data anywhere but in the raw output. I need to provide for example, > the name of the function in the packet summary, and the value of each > parameter by name in

Re: [Wireshark-dev] Developing a dissector for MODBUS-based protocol

2008-06-23 Thread Barnes, Pat
Thanks for your advice - I hadn't seen the doc/ folder in the source tree. I've managed to get the dev environment up and running in windows (VC2005) ... Although the 1.0.0 release wouldn't build due to a flex bug (2493), r25469 is working fine thus far. I don't think modifying the existing modbu

[Wireshark-dev] buildbot failure in Wireshark (development) on Ubuntu-7.10-x86-64

2008-06-23 Thread buildbot-no-reply
The Buildbot has detected a new failure of Ubuntu-7.10-x86-64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Ubuntu-7.10-x86-64/builds/29 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: ubuntu-7.10-x86 Build

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2008-06-23 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/4486 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build Reason

[Wireshark-dev] ATM Dissector Enhancements

2008-06-23 Thread McAtee, Kip
Greetings- We'd like to enhance packet-atm to call the ppp, eth, or IP dissectors as appropriate. Is anybody already working on that or is there any objection with this change? Thanks- Kip E-mail confidentiality. This e-mail contains confidential and

Re: [Wireshark-dev] ATM Dissector Enhancements

2008-06-23 Thread Guy Harris
McAtee, Kip wrote: > We’d like to enhance packet-atm to call the ppp, eth, or IP dissectors > as appropriate. Presumably you mean "we'd like to enhance some of the dissectors packet-atm.c to call the PPP dissector in case X, the Ethernet dissector in case Y in addition to LANE (where we alread

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread Guy Harris
On Jun 23, 2008, at 3:22 PM, Anders Broman wrote: >> Most of those come from the ASN.1 dissector generator, which, for >> some >> reason, seems to generate a lot of unused routines (is that an >> error in the >> ASN.1, or an error in asn2wrs?). > > Most come from unused routines in ASN.1 I be

Re: [Wireshark-dev] Compile warnings using CFLAGS '-Wshadow -Wpointer-arith -Wcast-qual -W -Wall'

2008-06-23 Thread John Smith
On Mon, Jun 23, 2008 at 10:53 PM, Guy Harris <[EMAIL PROTECTED]> wrote: >> Wireshark 1.0.0 > > And you had to add -Wpointer-arith, -Wcast-qual, -W, and -Wall? > Well I didn't know if any of those were already added or not, so I just did 'export CFLAGS=' before I ran the configure script. Regards,