Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-21 Thread Luis EG Ontanon
On Thu, Aug 21, 2008 at 10:50 PM, Ulf Lamping <[EMAIL PROTECTED]> wrote: > Anyway, I would try to avoid using commercial products for open source > development where reasonably possible ... It's already We. -- This information is top security. When you have read it, destroy yourself. -- Marsha

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-21 Thread Ulf Lamping
Maynard, Chris schrieb: > I've been using Gimpel's PC-Lint for a long time and really like it a > lot. It's a commercial product but it's pretty cheap for a single seat > license at $239: http://www.gimpel.com/. PC-Lint runs on Windows, but > their Flexelint product runs on *nix's. > > Splint is

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-21 Thread Maynard, Chris
tp://www.gimpel.com/html/pub80/msg.txt. It's located on their "Lint 8.00 Patches" page.) > -Original Message- > From: [EMAIL PROTECTED] [mailto:wireshark-dev- > [EMAIL PROTECTED] On Behalf Of Guy Harris > Sent: Thursday, August 21, 2008 3:30 PM > To: Develope

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-21 Thread Guy Harris
On Aug 13, 2008, at 8:00 AM, Maynard, Chris wrote: > Some time ago when Wireshark was still Ethereal, I had run lint > against > one or more of the dissectors and provided some results to the mailing > list and offered to provide lint output for more dissectors if there > was > interest, but

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-15 Thread Sébastien Tandel
On Fri, Aug 15, 2008 at 11:57 AM, didier <[EMAIL PROTECTED]> wrote: > Hi, > Le vendredi 15 août 2008 à 10:46 -0300, Sébastien Tandel a écrit : > > > > > it is already not a so simple inspection path to check that if > > ipfd_head != NULL, it implies that msp != NULL ... even for a > > human! :-p

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-15 Thread didier
Hi, Le vendredi 15 août 2008 à 10:46 -0300, Sébastien Tandel a écrit : > > it is already not a so simple inspection path to check that if > ipfd_head != NULL, it implies that msp != NULL ... even for a > human! :-p > I don't think it costs a lot to have something like the following for > the las

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-15 Thread Maynard, Chris
nt: Friday, August 15, 2008 9:47 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Lint of packet-tcp.c On Fri, Aug 15, 2008 at 2:30 AM, Jaap Keuter <[EMAIL PROTECTED]> wrote: Hi Chris, Thanks for taking a look. I looked at your new log also, and still wonder ho

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-15 Thread Sébastien Tandel
t; pointer > > 'msp' in left argument to operator '->' [Reference: file > > epan\dissectors\packet-tcp.c: lines 1482, 1504] > > > > Thanks, > > Chris > > > >> -Original Message----- > >> From: [EMAIL PROTECTED] [mailto:wireshark-dev-

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-14 Thread Jaap Keuter
e > epan\dissectors\packet-tcp.c: lines 1482, 1504] > > Thanks, > Chris > >> -Original Message- >> From: [EMAIL PROTECTED] [mailto:wireshark-dev- >> [EMAIL PROTECTED] On Behalf Of Jaap Keuter >> Sent: Wednesday, August 13, 2008 5:50 PM &g

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-14 Thread Maynard, Chris
Thanks, Chris > -Original Message- > From: [EMAIL PROTECTED] [mailto:wireshark-dev- > [EMAIL PROTECTED] On Behalf Of Jaap Keuter > Sent: Wednesday, August 13, 2008 5:50 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Lint of packet-tcp.c > >

Re: [Wireshark-dev] Lint of packet-tcp.c

2008-08-13 Thread Jaap Keuter
Hi, I've committed revision 26010 with some fixes for the really obvious cases. Please review the changes, found here: http://anonsvn.wireshark.org/viewvc/index.py?view=rev&revision=26010 Most of the lint output is caused by: - signed / unsigned differences - TRY / CATCH / RETHROW macro which co