Re: [Wireshark-dev] pinfo->private_data usage

2009-06-25 Thread yin sun
Isn't it depend on the agreement between caller that setup the data and the called dissector that uses the data.If the caller wants to enforce it, that is fine. But I don't see a general rule here. What if the case that sub-dissector wants to pass back some value. private_data is also the only way

[Wireshark-dev] pinfo->private_data usage

2009-04-23 Thread Tamazov, Artem
Hello, Am I correct that it is OK to use pinfo->private_data to pass information to sub-dissectors? Should dissector save pinfo->private_data and restore it after calling all sub-dissectors it needs? I've seen plenty of dissectors which do not follow this rule and going to fix them. To Wiresha