Re: [Wireshark-dev] packet_win.c still broken

2013-08-14 Thread Alexis La Goutte
Hi, On Thu, Jun 27, 2013 at 8:53 AM, Michal Labedzki wrote: > > > > On 26 June 2013 18:19, Jakub Zawadzki wrote: > >> >> (Wow, someone was using it! awesome) >> >> Cheers, >> Jakub. >> > > > Hey, I use it too.I really like it option to modify and save that to file. > It can be used to check an

Re: [Wireshark-dev] packet_win.c still broken

2013-06-26 Thread Michal Labedzki
On 26 June 2013 18:19, Jakub Zawadzki wrote: > > (Wow, someone was using it! awesome) > > Cheers, > Jakub. > Hey, I use it too.I really like it option to modify and save that to file. It can be used to check another protocol value while writing new dissector. http://wiki.wireshark.org/GSoC2013

Re: [Wireshark-dev] packet_win.c still broken

2013-06-26 Thread Christopher Maynard
Jakub Zawadzki writes: > On Tue, Jun 25, 2013 at 10:17:49PM +, Christopher Maynard wrote: > > I used this before and thought it was possible to edit the hex bytes within > > the popup dialog, but I just tried it and can confirm that it doesn't work. > > can you try r50172? OK, that works.

Re: [Wireshark-dev] packet_win.c still broken

2013-06-26 Thread Jakub Zawadzki
Hi, On Tue, Jun 25, 2013 at 10:17:49PM +, Christopher Maynard wrote: > I used this before and thought it was possible to edit the hex bytes within > the popup dialog, but I just tried it and can confirm that it doesn't work. can you try r50172? (Wow, someone was using it! awesome) Cheers,

Re: [Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Christopher Maynard
Guy Harris writes: > (I tried building it with a 1.10 tree, but haven't yet figured out how I can actually edit a field; I can get it > to pop up the edit dialog, but it doesn't seem to let me type anywhere) I used this before and thought it was possible to edit the hex bytes within the popu

Re: [Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 12:57 PM, Guy Harris wrote: > Once I file my next clang bug, I'll look at fixing that one. OK, it now builds. (I tried building it with a 1.10 tree, but haven't yet figured out how I can actually edit a field; I can get it to pop up the edit dialog, but it doesn't seem to

Re: [Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 12:27 PM, Joerg Mayer wrote: > your change to the buffer handling broke packet_win.c when being built > with WANT_PACKET_EDITOR. > As I asked about this problem before, maybe this bug isn't worth fixing, > but then we should remove WANT_PACKET_EDITOR. It's not part of the st

[Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Joerg Mayer
Hello Guy, your change to the buffer handling broke packet_win.c when being built with WANT_PACKET_EDITOR. As I asked about this problem before, maybe this bug isn't worth fixing, but then we should remove WANT_PACKET_EDITOR. Ciao Jörg [ 82%] Building C object ui/gtk/CMakeFiles/gtkui.dir/