Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-17 Thread Edwin Groothuis
Gisle Vanem writes: > > This: > #ifdef _MSC_VER > #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm)); > #endif > > doesn't look so safe. We should maybe use the localtime_r() in > wsutil/strptime.c? It is time to make localtime_r in wsutil/strptime.c non-static and

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Guy Harris
On Aug 16, 2011, at 11:05 AM, Gisle Vanem wrote: > PS. Notice that my 1st email came from and took > approx. 6 hours to get on this list. Waiting for what? > Received: from gurgle.wireshark.org (localhost [127.0.0.1]) > by mail.wireshark.org (Postfix) with ESMTP id 7567C2304A; > Tue

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Gerald Combs
On 8/16/11 11:05 AM, Gisle Vanem wrote: > PS. Notice that my 1st email came from and took > approx. 6 hours to get on this list. Waiting for what? Waiting for the list moderator to crawl out of bed and approve your message while quietly muttering "time to make the donuts"[1] to himself. > My n

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Gisle Vanem
On Tue, Aug 16, 2011 at 08:05:29PM +0200, Gisle Vanem wrote: > So it seems Mailman doesn't care so much about the address, but rather my > name. > Anyone can subscribe and claim to be me. Doesn't sound correct. And anyone can change his name to 'Gisle Vanem', welcome to reality. That's why if you

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Jakub Zawadzki
On Tue, Aug 16, 2011 at 08:05:29PM +0200, Gisle Vanem wrote: > PS. Notice that my 1st email came from and took > approx. 6 hours to get on this list. Waiting for what? Waiting for approval, look at headers: #v+ From: Gisle Vanem To: "wireshark-dev" Date: Tue, 16 Aug 2011 00:17:10 +0200 X-M

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Gisle Vanem
"Stig Bjørlykke" wrote: On Tue, Aug 16, 2011 at 12:17 AM, Gisle Vanem wrote: This: #ifdef _MSC_VER #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm)); #endif doesn't look so safe. We should maybe use the localtime_r() in wsutil/strptime.c? Or simply just use localtime

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Stig Bjørlykke
On Tue, Aug 16, 2011 at 12:17 AM, Gisle Vanem wrote: > This: >  #ifdef _MSC_VER >  #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm)); >  #endif > > doesn't look so safe. We should maybe use the localtime_r() in > wsutil/strptime.c? Or simply just use localtime, check the re

[Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Gisle Vanem
This: #ifdef _MSC_VER #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm)); #endif doesn't look so safe. We should maybe use the localtime_r() in wsutil/strptime.c? --gv ___ Sent via:Wireshark-dev