Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-06 Thread Stig Bjørlykke
On Tue, Apr 7, 2015 at 2:52 AM, wrote: > So are you thinking along the lines of prefs_register_dissector_preference > that would create a dropdown list (like an enum preference) based on > dissector table entries? Yes. Nothing controlled by the dissector, only available for convenience. -- S

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-06 Thread mmann78
[Wireshark-dev] enum preferences vs Go Fish On Apr 4, 2015, at 1:55 AM, Stig Bjørlykke wrote: > On Sat, Apr 4, 2015 at 3:30 AM, wrote: >> I may have gone a little overboard, but I tried to remove all enumerated >> preferences that really should be Decode As. There were enough nuan

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread Guy Harris
On Apr 4, 2015, at 1:55 AM, Stig Bjørlykke wrote: > On Sat, Apr 4, 2015 at 3:30 AM, wrote: >> I may have gone a little overboard, but I tried to remove all enumerated >> preferences that really should be Decode As. There were enough nuances to >> each situation, that I made them all separate

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread Stig Bjørlykke
On Sat, Apr 4, 2015 at 1:31 PM, wrote: > Right now there is no way to include a "Decode As" protocol list as a > specific preference of a dissector. If we add this I'm happy with a global Decode As functionality. And it may be an added feature to have this in the preferences for TCP and UDP too.

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread mmann78
erence. I also thought I had a better chance of doing such "GUI things" with the 2.0 release where it can be more understandable. -Original Message- From: Stig Bjørlykke To: Developer support list for Wireshark Sent: Sat, Apr 4, 2015 4:55 am Subject: Re: [Wireshark-dev] enu

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread Stig Bjørlykke
On Sat, Apr 4, 2015 at 3:30 AM, wrote: > I may have gone a little overboard, but I tried to remove all enumerated > preferences that really should be Decode As. There were enough nuances to > each situation, that I made them all separate patches. > > https://code.wireshark.org/review/7901 (P_MUL

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-03 Thread mmann78
I may have gone a little overboard, but I tried to remove all enumerated preferences that really should be Decode As. There were enough nuances to each situation, that I made them all separate patches. https://code.wireshark.org/review/7894 (ATM) https://code.wireshark.org/review/7895 (EtherN

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-03-16 Thread Evan Huus
On Mon, Mar 16, 2015 at 4:19 PM, wrote: > The SocketCan dissector has an enumerated preference to pick its > subdissector, manually finding all enumerated options through > find_dissector(). This doesn't work well for plugins and they are not going > to modify enum preference source as the whole

[Wireshark-dev] enum preferences vs Go Fish

2015-03-16 Thread mmann78
The SocketCan dissector has an enumerated preference to pick its subdissector, manually finding all enumerated options through find_dissector(). This doesn't work well for plugins and they are not going to modify enum preference source as the whole point is to not have to modify Wireshark sour