pm
Subject: Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook
Ugh, forgot the "defined". So this:
for my $k (sort keys %{$href}) {
my $h = defined($href->{$k}) ? $href->{$k} : "undef";
printf "%-40.40s %5.5s %s\n", $title, $h, $k;
Ugh, forgot the "defined". So this:
for my $k (sort keys %{$href}) {
my $h = defined($href->{$k}) ? $href->{$k} : "undef";
printf "%-40.40s %5.5s %s\n", $title, $h, $k;
}
On Apr 4, 2014, at 11:49 PM, Hadriel Kaplan wrote:
>
> Change this at line 563 in checkhf.pl:
>
Change this at line 563 in checkhf.pl:
for my $k (sort keys %{$href}) {
printf "%-40.40s %5.5s %s\n", $title, $href->{$k} // "undef", $k;
}
to this:
for my $k (sort keys %{$href}) {
my $h = ($href->{$k}) ? $href->{$k} : "undef";
printf "%-40.40s %5.5s %s\n",
What version of Perl do you have? I think that line 564's logical-or only
became available in Perl 5.10.
(it's not a regex search, but a ternary conditional-or apparently, because, ya
know... Perl can't possibly have only 20 ways of doing something when it could
instead have 21 ways... and at
On Apr 4, 2014, at 11:26 PM, Hadriel Kaplan wrote:
> I barely know perl, but checkhf.pl line 564 does indeed look bogus to me.
> (the double slashes are what it thinks is starting a regex search pattern
> that's not terminated I believe)
Actually, no it's fine. I don't know why your computer'
On Apr 4, 2014, at 10:36 PM, mman...@netscape.net wrote:
> I've taken the pre-commit hook file provided in \tools and put it in my git
> hooks folder. However, whenever I commit something (I've focused mostly on
> dissector patches and they all fail this way), it fails with "Search pattern
>
I've taken the pre-commit hook file provided in \tools and put it in my git
hooks folder. However, whenever I commit something (I've focused mostly on
dissector patches and they all fail this way), it fails with "Search pattern
not terminated at ./tools/checkhf.pl line 564."
When I run checkh